Clover General discussion

[Matgen84]

47 minutes ago, MifJpn said:

@LAbyOneThank you.

I was just having trouble with @D-an-W, so I just searched for a verbose but kind way.
If the same thing is done twice, but it's in place in the first place, it's virtually non-functional.
So it's an aesthetic.
If you don't forgive me aesthetically, I think from the beginning you should have asked slice to make a commit when you fixed the wrong make order.
Can you forgive me for this?

buildme.zip 4.75 kB · 0 downloads

 

@LAbyOne @MifJpn

@Slica

Without redundancy, it's better indeed, I think.

@LAbyOne

Maybe there is a problem of typo at the end of Buildme script: 'BuildCVP' instead of 'BuildCCPV'

 

Spoiler

 

Edited May 15, 2021 by Matgen84

[LAbyOne]

2 minutes ago, Matgen84 said:

 

@LAbyOne @MifJpn

@Slica

Without redundancy, it's better indeed, I think.

 

  Reveal hidden contents

 

ofc it is

 

2 minutes ago, Matgen84 said:

@LAbyOne

Maybe there is a problem of typo at the end of Buildme script: 'BuildCVP' instead of 'BuildCCPV'

No problems at all they are 2 different versions

[Slice]

On 5/7/2021 at 9:23 PM, Slice said:

Hi @Jief_Machak,

something wrong when I change one theme to another (cesium to metal)

Blue buttons are not updated to metal. It is "night" in the Clover now, may be related.

This bug is one year old!

I bisecting it. The first wrong commit was 22f9adcbc97e1291bc2361d69b66f96a29af0d05

between revision 5117 (good) and 5118 (bad). 

I have to revise the codes.

 

[Guest 5T33Z0]

@Slice Can you add  CloverV2-5135.zip to the assets of the current release?

[naiclub]

Uploaded instead Newly created, use your Clover_Builder LAbyOne too.

CloverV2-5135.zip

[SavageAUS]

Will 5135 fix the black screen I was getting with 5134 on AMD or is it simply adding the new tools? 5133 boots and works fine.


Sent from my iPhone using Tapatalk

I’ll answer my own question and say that clover is once again working on my AMD rig. No more black screen after choosing disk. So what ever happened in 5134 seems fixed for me.


Sent from my iPhone using Tapatalk

[Slice]

32 minutes ago, 5T33Z0 said:

@Slice Can you add  CloverV2-5135.zip to the assets of the current release?

Let it be.

[chris1111]

2 hours ago, naiclub said:

  Reveal hidden contents

Thank you very much

Well Done! 

[D-an-W]

Option 7 of Buildme now works straight off with the latest commit, thanks folks.

[chris1111]

New theme CloverLight  available in the repos Github Clover theme also in my signature Clover Themes

 

The theme are really nice  

Enjoy 

[Slice]

4 hours ago, Slice said:

This bug is one year old!

I bisecting it. The first wrong commit was 22f9adcbc97e1291bc2361d69b66f96a29af0d05

between revision 5117 (good) and 5118 (bad). 

I have to revise the codes.

 

Resolved!

@Jief_Machak

Look commit a9cb692f6

+      MenuEntryOptions.Image.ImageNight.setEmpty();
       MenuEntryOptions.Image = ThemeX.GetIcon(BUILTIN_ICON_FUNC_OPTIONS);

Strange that setEmpty() is needed to close the bug. Assignment must be enough but no.

[MacKonsti]

Hi @Slice thanks for releasing r5135 please if you have time, don't forget to update the other thread here on InsanelyMac where you update the release notes and/or major fixes/changes in the configuration too.

[Allan]

Clover updated and my Catalina booted successfully!

 

Thank you Clove team

 

[Slice]

@LAbyOne

My congratulations!

[SavageAUS]

Is there a way to make this work with clover?

https://forum.amd-osx.com/index.php?threads/fix-cpu-name-with-restrictevents.1736/

 

Edit: Nevermind - Working

Edited May 16, 2021 by SavageAUS

[Guest 5T33Z0]

INFO: I've added an english translation of the Clover Manual for all the available options, patches and fixes in the ACPI Section  of my Clover Update Guide. So, if you ever wondered what all these checkboses, fields and drop down menus do, this might be interesting to you.

[Matgen84]

17 minutes ago, 5T33Z0 said:

INFO: I've added an english translation of the Clover Manual for all the available options, patches and fixes in the ACPI Section  of my Clover Update Guide. So, if you ever wondered what all these checkboses, fields and drop down menus do, this might be interesting to you.

 

Thanks for spending time translating 

[AntarcticP]

Hi @Slice

Using legacy boot (LegacyBIOSDefault) on my AMD 8350fx.

Clover is working until version 5130 but every newer version gives me the 'purple screen of death' --> purple error messages when normally Clover should give its boot options.

So I still see the version number flash on my screen, but then nothing.

 

I have a cleaned up Plist, so this should be OK.

Any idea what is causing this? Any changes to Legacy boot >5130 ?

On my Intel laptop latest Clover is working.

 

Thanks!

Edited May 16, 2021 by AntarcticP

[Slice]

9 hours ago, AntarcticP said:

Hi @Slice

Using legacy boot (LegacyBIOSDefault) on my AMD 8350fx.

Clover is working until version 5130 but every newer version gives me the 'purple screen of death' --> purple error messages when normally Clover should give its boot options.

So I still see the version number flash on my screen, but then nothing.

 

I have a cleaned up Plist, so this should be OK.

Any idea what is causing this? Any changes to Legacy boot >5130 ?

On my Intel laptop latest Clover is working.

 

Thanks!

Produce, please, debug.log with 5135.

	<key>Boot</key>
	<dict>
		<key>Debug</key>
		<true/>

After unsuccessful boot you can found ***.log file in the folder /EFI/CLOVER/misc

[Jief_Machak]

On 5/15/2021 at 5:57 PM, Slice said:

Resolved!

@Jief_Machak

Look commit a9cb692f6

+      MenuEntryOptions.Image.ImageNight.setEmpty();
       MenuEntryOptions.Image = ThemeX.GetIcon(BUILTIN_ICON_FUNC_OPTIONS);

Strange that setEmpty() is needed to close the bug. Assignment must be enough but no.

Yes, operator = should be enough. Operator = assign and therefore totally replace the old value, like operator = for integers does. But instead of working around by adding a setEmpty(), it's better to fix the operator = implementation in XIcon.cpp.

[LAbyOne]

3 hours ago, MifJpn said:

@LAbyOne

I'm an unforgivable demon, so tranquilizers don't work anymore.

I'm going to see my psychiatrist tomorrow.

Alpha999 will do the rest.

sorry.

 

 

Don't be mate,

take good care of yourself and be back soon.

 

[Slice]

9 hours ago, Jief_Machak said:

Yes, operator = should be enough. Operator = assign and therefore totally replace the old value, like operator = for integers does. But instead of working around by adding a setEmpty(), it's better to fix the operator = implementation in XIcon.cpp.

Thanks, will do.

[Jief_Machak]

21 minutes ago, Slice said:

Thanks, will do.

Oups, no offense, I just did it...

 

I have another question : @MacKonsti pointed that FixHeaders exists in 2 places : ACPI and AXPI/DSDT/Fixes. Which is the more logical/obvious place ? Then, I'll put a warning in Validator asking to move it, and also a warning if both are defined.

[LockDown]

where can i find @MacKonsti's writeup about clover's config?

[Jief_Machak]

You can't, sorry.

 

CI failed, but it's compiling fine here. Anyone knows about that ? I didn't setup the CI...