Jump to content

Clover General discussion

ErmaC

By ErmaC,
in Clover

 Share
29,866 posts in this topic

Recommended Posts

Matgen84
Matgen84
Posted
Posted
20 minutes ago, Slice said:

Thanks, committed!

 

Hi @Slice

Is possible to replace Clover r5135 Release by new one including the commit "repair permissions for post install". Please. :)

  • Like 1
Link to comment
Share on other sites
Slice
Slice
Posted
Posted
38 minutes ago, Matgen84 said:

 

Hi @Slice

Is possible to replace Clover r5135 Release by new one including the commit "repair permissions for post install". Please. :)

One moment...

  • Thanks 1
Link to comment
Share on other sites
LAbyOne
LAbyOne
Posted
Posted
5 hours ago, MifJpn said:

 

Hello.

I am checking for the problem of the installer(pkg) error.

The "pkg" shows an error, but the ccpv was copied to "/usr/local/bin".
Seems like an error handling issue.

Thank you.

 

well, so much for having told you about that already some days ago 

and in pm also :)

  • Like 3
Link to comment
Share on other sites
LAbyOne
LAbyOne
Posted
Posted
1 minute ago, MifJpn said:

When I use Clover_r5135.pkg,and check-box BLC & CCPV,

1513358794_2021-05-120_02_44.png.65ea6fe3021710049ae4a68e4170546b.png

The package told "Can not install" as above.:cry:

But It's fixed !!:lol:

That problem NEVER existed, the files despite the error were always installed!!!

omg, man, I already told you that.

This is the third time now, the error is given by something else, already fixed but not yet available

  • Like 1
Link to comment
Share on other sites
LAbyOne
LAbyOne
Posted
Posted
26 minutes ago, MifJpn said:

 

Oh！Wait!

The first time we git cloned, I fixed the buildme so that buildall (and other make) wouldn't have any problems. Did All patterns have been confirmed. Please use it.:)

buildme.zip 4.76 kB · 1 download

 

No can do sir! your changes make no sense at all

you added a command to all executions already having that in their processes and took off to the one who really needed?

c'mon

@Slice using this will make any command execute twice the same command for each execution

 its already present in most of the build processes, so having it again makes no sense. please revert

  • Thanks 1
Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted
27 minutes ago, LAbyOne said:

No can do sir! your changes make no sense at all

you added a command to all executions already having that in their processes and took off to the one who really needed?

c'mon

@Slice using this will make any command execute twice the same command for each execution

 its already present in most of the build processes, so having it again makes no sense. please revert

 

11 minutes ago, MifJpn said:

Thank you for your advice.
Yes, it's verbose and it can be said that it doesn't make sense.
But when slice first changed the attributes, you didn't do anything at all.
If you need to set up the environment the first time we run it, don't you think you should create a new item and explain it in ”buildme”? You were the one who must do it, and you must have had the time.
Please forgive me.

 

Hi @LAbyOne @MifJpn @Slice

Checktools command is already included in 'BuildClover'. Effectively with the new menu in BuildMe, checktools is executed twice.


BuildClover section in Previous BuildMe and new BuildMe 

buildClover() {
checkTools

# to force recreation of the Conf folder. You can still use a custom CONF_PATH if you don't want recreation.
rm -rf "$CLOVERROOT"/Conf
mkdir "$CLOVERROOT"/Conf

cd "${CLOVERROOT}"
if [[ -z "$WORKSPACE" ]]; then
  export EDK_TOOLS_PATH="${PWD}"/BaseTools
  set +u
  source ./edksetup.sh BaseTools
  set -u
  cd "$CLOVERROOT"
  WORKSPACE="${PWD}"
fi

echo "[BUILD CLOVER]"
# Run a custom build script if exist (~/src/tools/Scripts/build.sh)
# This allow the user to run ebuild.sh with own parameters
if [[ -x "${DIR_TOOLS}"/Scripts/build.sh ]]; then
  echo "Running custom build script"
  "${DIR_TOOLS}"/Scripts/build.sh "${CLOVERROOT}" $MYTOOLCHAIN
else
  local parameter=${1:-none}
  if [[ "${parameter}" == HFSPlus ]]; then
    #./ebuild.sh -fr -mc --no-usb -D NO_GRUB_DRIVERS_EMBEDDED -D USE_APPLE_HFSPLUS_DRIVER -t $MYTOOLCHAIN
    ./ebuild.sh -fr -D NO_GRUB_DRIVERS_EMBEDDED -D USE_APPLE_HFSPLUS_DRIVER -t $MYTOOLCHAIN
  else
    #./ebuild.sh -fr -mc --no-usb -D NO_GRUB_DRIVERS_EMBEDDED -t $MYTOOLCHAIN
    ./ebuild.sh -fr -D NO_GRUB_DRIVERS_EMBEDDED -D LESS_DEBUG -t $MYTOOLCHAIN
  fi
fi

 

Link to comment
Share on other sites
LAbyOne
LAbyOne
Posted
Posted (edited)

 

9 minutes ago, Matgen84 said:

 

 

Hi @LAbyOne @MifJpn @Slice

Checktools command is already included in 'BuildClover'. Effectively with the new menu in BuildMe, checktools is executed twice.

 

the builme also calls for precesses not directly executed by the command itself but executed by the process it links to,

so become utterly unneeded it just makes it redundant

those are just a few examples

472745249_ScreenShot3.thumb.png.44e585c9141708bcc257264d3689d022.png149346689_ScreenShot2.png.6e0adaead7af25a00bcfb1305f2b3327.png

1557111019_ScreenShot1.png.0740b19d406f2e8d1263fd657b5919a2.png

1069650014_ScreenShot.png.35d5efa16d9cfdd489962148bafbd382.png

Edited by LAbyOne
  • Like 3
Link to comment
Share on other sites
naiclub
naiclub
Posted
Posted (edited)

 26 files changed, 1069 insertions(+), 233 deletions(-)
 mode change 100644 => 100755 CloverPackage/package/Scripts.templates/BootLoaderChooser/postinstall
 mode change 100644 => 100755 CloverPackage/package/Scripts.templates/CloverConfigPlistValidator/postinstall

 

I think this allows you to install both of them smoothly.

ภาพถ่ายหน้าจอ 2564-05-15 เวลา 15.59.44.png

Edited by naiclub
  • Like 2
Link to comment
Share on other sites
LAbyOne
LAbyOne
Posted
Posted
20 minutes ago, MifJpn said:

@LAbyOneThank you.

I was just having trouble with @D-an-W, so I just searched for a verbose but kind way.

Sorry but I think you should read more carefully the thread, no offense intended, 

The fix for @D-an-W, you are talking about, was the file i posted for him here, the same file (fixed) you re-edited for nothing,

 

25 minutes ago, MifJpn said:

If you don't forgive me aesthetically, I think from the beginning you should have asked slice to make a commit when you fixed the wrong make order.
Can you forgive me for this?

i'm speechless

  • Like 1
  • Thanks 1
Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted (edited)
47 minutes ago, MifJpn said:

@LAbyOneThank you.

I was just having trouble with @D-an-W, so I just searched for a verbose but kind way.
If the same thing is done twice, but it's in place in the first place, it's virtually non-functional.
So it's an aesthetic.
If you don't forgive me aesthetically, I think from the beginning you should have asked slice to make a commit when you fixed the wrong make order.
Can you forgive me for this?

buildme.zip 4.75 kB · 0 downloads

 

@LAbyOne @MifJpn

@Slica

Without redundancy, it's better indeed, I think.

@LAbyOne

Maybe there is a problem of typo at the end of Buildme script: 'BuildCVP' instead of 'BuildCCPV'

 

Spoiler

1979241532_Capturedcran2021-05-1511_41_05.png.0bdee073c5a6dc6f9b5a868d6be2091f.png

 

Edited by Matgen84
  • Like 2
Link to comment
Share on other sites
Slice
Slice
Posted
Posted
On 5/7/2021 at 9:23 PM, Slice said:

Hi @Jief_Machak,

something wrong when I change one theme to another (cesium to metal)

Снимок экрана 2021-05-07 в 21.18.02.png

Blue buttons are not updated to metal. It is "night" in the Clover now, may be related.

This bug is one year old! :(

I bisecting it. The first wrong commit was 22f9adcbc97e1291bc2361d69b66f96a29af0d05

between revision 5117 (good) and 5118 (bad). 

I have to revise the codes.

 

Link to comment
Share on other sites
SavageAUS
SavageAUS
Posted
Posted
Will 5135 fix the black screen I was getting with 5134 on AMD or is it simply adding the new tools? 5133 boots and works fine.


Sent from my iPhone using Tapatalk

I’ll answer my own question and say that clover is once again working on my AMD rig. No more black screen after choosing disk. So what ever happened in 5134 seems fixed for me.


Sent from my iPhone using Tapatalk
  • Like 1
Link to comment
Share on other sites
Slice
Slice
Posted
Posted
4 hours ago, Slice said:

This bug is one year old! :(

I bisecting it. The first wrong commit was 22f9adcbc97e1291bc2361d69b66f96a29af0d05

between revision 5117 (good) and 5118 (bad). 

I have to revise the codes.

 

Resolved!

@Jief_Machak

Look commit a9cb692f6 

+      MenuEntryOptions.Image.ImageNight.setEmpty();
       MenuEntryOptions.Image = ThemeX.GetIcon(BUILTIN_ICON_FUNC_OPTIONS);

Strange that setEmpty() is needed to close the bug. Assignment must be enough but no.

Link to comment
Share on other sites
 Share
Go to topic listing
×
×
  • Create New...