Slice Posted May 11, 2021 Share Posted May 11, 2021 Hey mode change 100755 => 100644 buildme iMac2017:CloverBootloader sergey$ ./buildme -bash: ./buildme: Permission denied OK, committed. Something else? Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757693 Share on other sites More sharing options...
Matgen84 Posted May 11, 2021 Share Posted May 11, 2021 (edited) 12 minutes ago, Slice said: Hey mode change 100755 => 100644 buildme iMac2017:CloverBootloader sergey$ ./buildme -bash: ./buildme: Permission denied OK, committed. Something else? Can you have a look to my post 2 hours ago: I can't build CloverPKG from an existing local Cloverbootloader Repo : ===================== RC Scripts ======================= [BUILD] rc.scripts.on.target [BUILD] rc.scripts.on.all.volumes [BUILD] rc.scripts.core ================= Optional RC Scripts ================== [BUILD] disable_sleep_proxy_client ======================== Themes ======================== [BUILD] Catalina [BUILD] Mojave [BUILD] MyMaterialBox [BUILD] Clovy [BUILD] BigSur [BUILD] One2 Error can't add choice 'disable_sleep_proxy_client': a choice with same name already exists. Edited May 11, 2021 by Matgen84 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757694 Share on other sites More sharing options...
tluck Posted May 11, 2021 Share Posted May 11, 2021 +1 on Error can't add choice 'disable_sleep_proxy_client': a choice with same name already exists. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757705 Share on other sites More sharing options...
Slice Posted May 11, 2021 Share Posted May 11, 2021 1 hour ago, Matgen84 said: Can you have a look to my post 2 hours ago: I can't build CloverPKG from an existing local Cloverbootloader Repo : ===================== RC Scripts ======================= [BUILD] rc.scripts.on.target [BUILD] rc.scripts.on.all.volumes [BUILD] rc.scripts.core ================= Optional RC Scripts ================== [BUILD] disable_sleep_proxy_client ======================== Themes ======================== [BUILD] Catalina [BUILD] Mojave [BUILD] MyMaterialBox [BUILD] Clovy [BUILD] BigSur [BUILD] One2 Error can't add choice 'disable_sleep_proxy_client': a choice with same name already exists. Build process looks different. See ===================== RC Scripts ======================= [BUILD] rc.scripts.on.target [BUILD] rc.scripts.on.all.volumes [BUILD] rc.scripts.core ================= Optional RC Scripts ================== [BUILD] disable_sleep_proxy_client ======================== Themes ======================== [BUILD] Purple_Swirl [BUILD] Clovy [BUILD] BGM [BUILD] cesium ===================== BootLoaderChooser ===================== [BUILD] BootLoaderChooser =============== CloverConfigPlistValidator =============== [BUILD] CloverConfigPlistValidator ==================== Clover Prefpane =================== [BUILD] CloverPrefpane ================= Post ================= [BUILD] Post -------------------------- Building process complete! -------------------------- Build info. =========== I have to propose your Clover repo is different from official so why you can't compile. 1 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757706 Share on other sites More sharing options...
Matgen84 Posted May 11, 2021 Share Posted May 11, 2021 47 minutes ago, Slice said: Build process looks different. See ===================== RC Scripts ======================= [BUILD] rc.scripts.on.target [BUILD] rc.scripts.on.all.volumes [BUILD] rc.scripts.core ================= Optional RC Scripts ================== [BUILD] disable_sleep_proxy_client ======================== Themes ======================== [BUILD] Purple_Swirl [BUILD] Clovy [BUILD] BGM [BUILD] cesium ===================== BootLoaderChooser ===================== [BUILD] BootLoaderChooser =============== CloverConfigPlistValidator =============== [BUILD] CloverConfigPlistValidator ==================== Clover Prefpane =================== [BUILD] CloverPrefpane ================= Post ================= [BUILD] Post -------------------------- Building process complete! -------------------------- Build info. =========== I have to propose your Clover repo is different from official so why you can't compile. I can compile with no problem until commit 2eb35b7 (08/05/2021). I recheck again 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757709 Share on other sites More sharing options...
naiclub Posted May 11, 2021 Share Posted May 11, 2021 (edited) Spoiler Spoiler Edited May 12, 2021 by naiclub 2 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757710 Share on other sites More sharing options...
Jief_Machak Posted May 12, 2021 Share Posted May 12, 2021 Not sure to have followed everything about the package, and integration of ccpv in the pkg. About people who use buildme and people who don't Let's keep things simple : - buildme is when you cloned the repo (obviously). It builds thing in CloverPackage. - the package is self-contained and must be able to install options without even internet. I didn't check thoroughly but I think it's the case. Can you confirm @LAbyOne ? 4 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757732 Share on other sites More sharing options...
SavageAUS Posted May 12, 2021 Share Posted May 12, 2021 These are the current errors i get on my configWarning: Expect a string of 4 chars for tag '/ACPI/DropTables[0]/Signature:27'.Warning: Expect a string of 4 chars for tag '/ACPI/DropTables[1]/Signature:31'.Warning: Expect a boolean, an int8 or a string starting with 'n' or '-' for '/Boot/XMPDetection:113'.Warning: Unknown key '/GUI/Custom/Entries[0]/Ignore:154'. Skipped.Warning: Unknown key '/GUI/Custom/Entries[1]/Ignore:174'. Skipped.Warning: Unknown key '/GUI/Custom/Entries[2]/Ignore:186'. Skipped.Warning: Unknown key '/GUI/Custom/Entries[3]/Ignore:204'. Skipped.Warning: Boolean value contained in a string. Please use instead of yes for tag '/SystemParameters/InjectKexts:1342'Warning: Unknown key '/Quirks/ProvideConsoleGopEnable:1403'. Skipped. I’ve gotten it down to just the ProvideConsoleGopEnable quirk and it’s still booting just fine on 5133When and why was this quirk removed?I see nothing in OpenCores changelog to reflect the removal of this quirk.As soon as I update to 5134 even with this quirk in place after clover GUI I get black screen. Anyone else on AMD updated to 5134?Bump for assistance Sent from my iPhone using Tapatalk Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757744 Share on other sites More sharing options...
Jief_Machak Posted May 12, 2021 Share Posted May 12, 2021 18 minutes ago, SavageAUS said: Bump for assistance Sent from my iPhone using Tapatalk Hi, good to see you back. You disappeared for a while. I hope everything's fine for you. 19 minutes ago, SavageAUS said: /ACPI/DropTables[0]/Signature:27 Take things one by one: - line 27, you have a signature which is more than 4 chars long. Could be space before or after. Or an invisible char. You might need to have a look with hexfiend to be sure. - Same line 31. - XMPDetection should be <true/> or <false/> or <integer>{integer}</integer>. If it's currently working, just remove that key or put the default value : <true/> - /GUI/Custom/Entries[x]/Ignore : that key never existed. Remove. - /SystemParameters/InjectKexts:1342 : you have <string>yes<string>, it's stricter to put <true/> instead although both currently work. - /Quirks/ProvideConsoleGopEnable : that key doesn't exist here anymore. It's in GUI and it's called ProvideConsoleGop (no "Enable" at the end). Default is true so you can just remove this one. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757747 Share on other sites More sharing options...
SavageAUS Posted May 12, 2021 Share Posted May 12, 2021 Take things one by one: - line 27, you have a signature which is more than 4 chars long. Could be space before or after. Or an invisible char. You might need to have a look with hexfiend to be sure. - Same line 31. - XMPDetection should be or or {integer}. If it's currently working, just remove that key or put the default value : - /GUI/Custom/Entries[x]/Ignore : that key never existed. Remove. - /SystemParameters/InjectKexts:1342 : you have yes, it's stricter to put instead although both currently work. - /Quirks/ProvideConsoleGopEnable : that key doesn't exist here anymore. It's in GUI and it's called ProvideConsoleGop (no "Enable" at the end). Default is true so you can just remove this one. Yeah my monitor was broken. Plus other dramas but back now. Oh I can easily fix the issues with the config.plist but when I update clover to 5134 I get a black screen. Exact config works with 5133. This is on my AMD rig. Sent from my iPhone using Tapatalk Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757750 Share on other sites More sharing options...
chris1111 Posted May 12, 2021 Share Posted May 12, 2021 (edited) @Jief_Machak Buildme Like the Old command (CloverCommand) and the first one create by @JrCsCloverGrower is not suppose to create stuff in the package, it only calls Makepkg for the package to be created cd ~/src/CloverBootloader/CloverPackage/ makepkg that's why it should stick to that, to create things in the package it goes through the source and buildpkg.sh and all the makefiles Edit *** This is how Clover has always functioned since its existence Edited May 12, 2021 by chris1111 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757752 Share on other sites More sharing options...
Jief_Machak Posted May 12, 2021 Share Posted May 12, 2021 3 minutes ago, chris1111 said: @Jief_Machak Buildme Like the Old command (CloverCommand) and the first one create by @JrCsCloverGrower is not suppose to create stuff in the package, it only calls Makepkg for the package to be created cd ~/src/CloverBootloader/CloverPackage/ makepkg that's why it should stick to that, to create things in the package it goes through the source and buildpkg.sh and all the makefiles Edit *** This is how Clover has always functioned since its existence I really don't know how all that works. But if there is a script "makepkg" ALL the package should be done in it. But packaging things doesn't always imply compiling things. Indeed, in the spirit of layer separation that I cherish in my programming, "makepkg" should first check that everything that needs to be packaged (clover efi, drivers, validator, boot sectors, etc.) is there and then only do package... So for me, if "makepkg" does compilation, I'd remove that step from it and create a "build4pkg". Also, CloverPackage contains some original files and some generated files. It's also not very good as generated should be 100% separated from original files, like in the Build folder. You just have to delete Build to recompile from scratch. In the end, if it's working like it is now, maybe there is no need to be so strict about it... But if someone want to clean and rethink the build process from scratch, he's welcome... 3 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757755 Share on other sites More sharing options...
chris1111 Posted May 12, 2021 Share Posted May 12, 2021 (edited) 17 minutes ago, Jief_Machak said: I really don't know how all that works. But if there is a script "makepkg" ALL the package should be done in it. But packaging things doesn't always imply compiling things. Indeed, in the spirit of layer separation that I cherish in my programming, "makepkg" should first check that everything that needs to be packaged (clover efi, drivers, validator, boot sectors, etc.) is there and then only do package... So for me, if "makepkg" does compilation, I'd remove that step from it and create a "build4pkg". Also, CloverPackage contains some original files and some generated files. It's also not very good as generated should be 100% separated from original files, like in the Build folder. You just have to delete Build to recompile from scratch. In the end, if it's working like it is now, maybe there is no need to be so strict about it... But if someone want to clean and rethink the build process from scratch, he's welcome... It is certain that there could be a cleaning and a restructuring I agree EDIT** keep in mind that buildme was integrated into Clover in 2019 and that before that the scripts to build clover were external Edited May 12, 2021 by chris1111 2 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757756 Share on other sites More sharing options...
PG7 Posted May 12, 2021 Share Posted May 12, 2021 (edited) Top Merci équipe Divulgacher Edited May 12, 2021 by PG7 2 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757758 Share on other sites More sharing options...
Jief_Machak Posted May 12, 2021 Share Posted May 12, 2021 3 hours ago, chris1111 said: It is certain that there could be a cleaning and a restructuring I agree EDIT** keep in mind that buildme was integrated into Clover in 2019 and that before that the scripts to build clover were external Maybe it can sound like negative comments, I don't know, but rest assured that I know what the history is in computer dev. I'm cleaning my printf project and there was quite some mess. And I'm the only one to have done that. So when I'll ever say : this need cleaning and/or re-design, it's just the way it works over history and not a critics of who has done it. 6 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757777 Share on other sites More sharing options...
Jief_Machak Posted May 12, 2021 Share Posted May 12, 2021 Hi everyone, I've commented out the double compilation made by buildme. I tried here and the package build successfully. If something is wrong, please tell me so I can reproduce or at least understand what this double compilation was for. It maybe just a historic leftover... Have a good weekend... when the weekend will come for you. 2 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757825 Share on other sites More sharing options...
naiclub Posted May 12, 2021 Share Posted May 12, 2021 (edited) 37 minutes ago, Jief_Machak said: Hi everyone, I've commented out the double compilation made by buildme. I tried here and the package build successfully. If something is wrong, please tell me so I can reproduce or at least understand what this double compilation was for. It maybe just a historic leftover... Have a good weekend... when the weekend will come for you. The collection has been successful. But stuck, add the file BootLoadCooser. There will be problems immediately. In summary, the newly added section must not be clicked. So it will be successful as well Spoiler Spoiler Spoiler Edited May 12, 2021 by naiclub Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757826 Share on other sites More sharing options...
chris1111 Posted May 12, 2021 Share Posted May 12, 2021 (edited) I share my Desktop background Clover Its a 5K image PNG DesktopClover.zip 1 hour ago, naiclub said: But stuck, add the file BootLoadCooser. There will be problems immediately. Reveal hidden contents Edited May 12, 2021 by chris1111 3 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757833 Share on other sites More sharing options...
LAbyOne Posted May 13, 2021 Share Posted May 13, 2021 3 hours ago, naiclub said: The collection has been successful. But stuck, add the file BootLoadCooser. There will be problems immediately. In summary, the newly added section must not be clicked. So it will be successful as well In reality you'r not stuck at all Despite the failure warning all your files have been installed correctly in the right places. you can verify that warning is given by a little oversight i made when re-editing a file. annoying but not crucial to the installation process. i'm currently modifing also other things, and I will pull everything once finished and verified (this time trice). Very sorry for these annoyances. 2 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757858 Share on other sites More sharing options...
makk Posted May 13, 2021 Share Posted May 13, 2021 Sorry apologies for chiming in, when upgraded to 5134 ( from 5133 ) had some error messages in the log that were minor which did not prevent booting. After changing to Boolean on these few issues, the log is cleared of the original messages. from String to Boolean then no messy error message. (for Quirks) Intel Chip. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757884 Share on other sites More sharing options...
tluck Posted May 13, 2021 Share Posted May 13, 2021 (edited) On 5/11/2021 at 10:59 AM, Slice said: Build process looks different. See ===================== RC Scripts ======================= [BUILD] rc.scripts.on.target [BUILD] rc.scripts.on.all.volumes [BUILD] rc.scripts.core ================= Optional RC Scripts ================== [BUILD] disable_sleep_proxy_client ======================== Themes ======================== [BUILD] Purple_Swirl [BUILD] Clovy [BUILD] BGM [BUILD] cesium ===================== BootLoaderChooser ===================== [BUILD] BootLoaderChooser =============== CloverConfigPlistValidator =============== [BUILD] CloverConfigPlistValidator ==================== Clover Prefpane =================== [BUILD] CloverPrefpane ================= Post ================= [BUILD] Post -------------------------- Building process complete! -------------------------- Build info. =========== I have to propose your Clover repo is different from official so why you can't compile. [BUILD] OsxFatBinaryDrv.UEFI [BUILD] PartitionDxe.UEFI ===================== RC Scripts ======================= [BUILD] rc.scripts.on.target [BUILD] rc.scripts.on.all.volumes [BUILD] rc.scripts.core ================= Optional RC Scripts ================== [BUILD] disable_sleep_proxy_client ======================== Themes ======================== [BUILD] ThinkPad [BUILD] Clovy ==================== Clover Prefpane =================== [BUILD] CloverPrefpane ================= Post ================= [BUILD] Post -------------------------- Building process complete! -------------------------- this fixes buildpkg.sh which has problem with logic when not including BootLoaderchooser - this else branch is not needed -- and if it was needed it should have its vars redefined for the else branch. diff buildpkg.orig.sh buildpkg.sh 1432,1434c1432,1434 < else < addChoice --start-visible="true" --start-selected="false" \ < --pkg-refs="$packageRefId" "${choiceId}" --- > ## else > ## addChoice --start-visible="true" --start-selected="false" \ > ## --pkg-refs="$packageRefId" "${choiceId}" Edited May 13, 2021 by tluck 1 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757945 Share on other sites More sharing options...
Slice Posted May 13, 2021 Share Posted May 13, 2021 21 hours ago, Jief_Machak said: I've commented out the double compilation made by buildme. I tried here and the package build successfully. If something is wrong, please tell me so I can reproduce or at least understand what this double compilation was for. It maybe just a historic leftover... Have a good weekend... when the weekend will come for you. This is not strictly double compilation. We should split compilation of Efildr (boot file) and CloverX64.efi itself. This double compilations makes two different files boot6 and boot7 while CloverX64 will be the same. boot7 is produced when we compile with option -mc. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757957 Share on other sites More sharing options...
chris1111 Posted May 13, 2021 Share Posted May 13, 2021 Ok simple Utility to sanity check config.plist Clover Config Validator View Full Video 15 seconds Credit Clover team and @Jief_Machak 3 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757964 Share on other sites More sharing options...
D-an-W Posted May 13, 2021 Share Posted May 13, 2021 Having trouble building here too... Clover r5134 (SHA: 5731ed0a8) TOOLCHAIN: GCC53 (override example: './buildme XCODE8') ----------------------------------------------------------- 1) build Clover 2) build Clover with HFSPlus 3) make pkg 4) make app 5) make app (with Clover) 6) make iso 7) build all 8) test build (no autogen, no boot files) 9) status 10) update Clover 11) show diff 12) open CloverV2/EFI/CLOVER directory 13) update Clover (reset changes) 14) clean BaseTools 15) Utilities 16) quit Please enter your choice: 7 /Users/dan/src/CloverBootloader/rEFIt_UEFI/Platform/CloverVersion.cpp:9:10: fatal error: '../../Version.h' file not found #include "../../Version.h" ^~~~~~~~~~~~~~~~~ 1 error generated. note: Using new build system note: Planning build note: Constructing build description ** BUILD FAILED ** Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757966 Share on other sites More sharing options...
chris1111 Posted May 14, 2021 Share Posted May 14, 2021 Another theme add on GitHub see my signature for Download CoolClover theme 6 background inside the theme 3 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1074/#findComment-2757982 Share on other sites More sharing options...
Recommended Posts