blackosx Posted April 5, 2021 Author Share Posted April 5, 2021 @Download-Fritz Forgive me for not understanding why sizes would be mismatched. I don't see it. My only knowledge of disk labels comes from you guys' disklabel.c and the linked explanation to rEFIt's vollabel where it explains these are pre-rendered image files created by bless which Apple uses to display the volume names when showing its boot picker. You have built OpenCanopy (amazing job BTW) to follow Apple's method of using these labels but you also already have the functionality of not using them and drawing the names directly using a font file. As you have this option, then why not just ignore disk label images completely all the time? Just because Apple uses them, doesn't mean you have to. Unless I'm missing something more important here And I don't notice any difference in time presenting the UI with the labels enabled or not. Link to comment Share on other sites More sharing options...
mhaeuser Posted April 5, 2021 Share Posted April 5, 2021 1 minute ago, blackosx said: As you have this option, then why not just ignore disk label images completely all the time? As I have explained, the textual representation we use may not exist (iirc Recovery and sometimes installer?), and all else we have to get the proper name is heuristics. This is simply supporting Apple bless to its fullest. Link to comment Share on other sites More sharing options...
blackosx Posted April 5, 2021 Author Share Posted April 5, 2021 (edited) Okay. You are right. EDIT: So as I understand it now, the mismatched issue would come from any instance where the text representation didn't exist. In these cases the disklabel image would be used, instead of the rendered text drawn using the font in the theme. 3 hours ago, Download-Fritz said: One way would be to force all label heights to be equal I suppose. So could your earlier suggestion be the way forward? Edited April 5, 2021 by blackosx Link to comment Share on other sites More sharing options...
blackosx Posted April 5, 2021 Author Share Posted April 5, 2021 (edited) 1 hour ago, Download-Fritz said: I think we may just omit Apple disklabel images that are not the same size as the inbuilt font, if it is enabled, Mismatched fonts would also look terrible, but that's the price of flexibility. Or maybe it can somehow be controlled by the proposed theme plist... idk I'm now up to speed with your thoughts here. So yes. Mismatched fonts would not look the best but that would have to be a caveat that comes with the users choice to installing a theme with larger fonts. EDIT: A theme plist could have a key for the user to choose between showing: 1 - the mismatched size disklabel (if they are indeed different sizes to the theme font) 2- nothing (just blank space) 3 - a custom string? Edited April 5, 2021 by blackosx Link to comment Share on other sites More sharing options...
mhaeuser Posted April 5, 2021 Share Posted April 5, 2021 4 hours ago, blackosx said: 1 - the mismatched size disklabel (if they are indeed different sizes to the theme font) 2- nothing (just blank space 3 - a custom string? Sorry, no, who wants to see any of that? The theme plist could maybe have an option to force drawing all labels with the theme font unless fonts are disabled by PickerAttributes, I think that is about it. 1 Link to comment Share on other sites More sharing options...
blackosx Posted April 5, 2021 Author Share Posted April 5, 2021 Okay. That’s why you develop amazing stuff and I don’t. But, seriously. Thanks for OpenCanopy. It’s really great. I hope you can get a break before the next round of updates. 3 Link to comment Share on other sites More sharing options...
BuXb Posted April 5, 2021 Share Posted April 5, 2021 Great conversation. Very curious now about 0.6.8 OpenCanopy. Might find some time to delve in tomorrow. Thumbs up in advance. Link to comment Share on other sites More sharing options...
BuXb Posted April 8, 2021 Share Posted April 8, 2021 (edited) @Download-Fritz I'll keep it short and simple: above all, thanks a ton for all the mighty-fine improvements. Still, I hope that soon the font size issue where Apple clearly failed can be improved, in whichever technical way. Because what counts most even after 100s of lines of code is what's seen, and read. That the versatile better readable framd had to be downgraded back to Helvetica is a visual regression, totally regardless of technicalities in the background. Sorry but I'm simply being honest. Yet again, I am aware that this is just a temporary state of 0.6.8 beta for now - a state at which I do not at all expect perfection yet. Just keep in mind that the average hackintosher aka the vast majority DOES love to tinker/ tweak and have as much as possible THEIR personal and NOT necessarily Apple's way. That's why blackosx's thread here hsa 21 pages: people love to adapt the UI to their very own interpretation of "beauty". Edited April 8, 2021 by BuXb 1 Link to comment Share on other sites More sharing options...
mhaeuser Posted April 9, 2021 Share Posted April 9, 2021 @BuXb I have already said the implementation details are in discussion? That people want to tinker will not make it faster. I won't promise either it will be in 0.6.9. 2 Link to comment Share on other sites More sharing options...
polkaholga Posted April 9, 2021 Share Posted April 9, 2021 Hi guys, to be honest I can't remember exactly when it started but I noticed again as I updated within OC 0.6.8 updates ( not from 0.6.7 or previous revs ), that picker switches to text mode though I never changed any settings at Misc/Boot... Anyone with same experiences. I looked through the configuration.pdf but could not find any hint that I was dioing sth wrong.... Attached a screenshot from the relevant config.plist Link to comment Share on other sites More sharing options...
Anto65 Posted April 9, 2021 Share Posted April 9, 2021 7 minutes ago, polkaholga said: Hi guys, to be honest I can't remember exactly when it started but I noticed again as I updated within OC 0.6.8 updates ( not from 0.6.7 or previous revs ), that picker switches to text mode though I never changed any settings at Misc/Boot... Anyone with same experiences. I looked through the configuration.pdf but could not find any hint that I was dioing sth wrong.... Attached a screenshot from the relevant config.plist you need maybe to Resources folder with all required elements from acidanthera or others users theme BsxDarkFence Default-StarWars by @chris1111 and @blackosx 1 1 Link to comment Share on other sites More sharing options...
polkaholga Posted April 9, 2021 Share Posted April 9, 2021 5 hours ago, antuneddu said: you need maybe to Resources folder with all required elements from acidanthera or others users theme BsxDarkFence Default-StarWars by @chris1111 and @blackosx I compared mentioned resources folder with the one on my EFI, but could not find any obvious differences... Nevertheless I downloaded it again and copied it over the existing one. On next boot graphic's been back. Weird... 2 Link to comment Share on other sites More sharing options...
Fory360 Posted April 10, 2021 Share Posted April 10, 2021 On 4/2/2021 at 9:51 PM, blackosx said: Hey BuXb Everything here is planned to be up to date for when 0.6.8 is released. For ref: New mandatory icons for 0.6.8 are: - Restart, Shutdown, BtnFocus, Dot, Entry, Lock, Password and SetDefault. 1. Yes 2. I have a current WIP theme available here: https://github.com/blackosx/BsxOc1_ And also some simpler, cleaner themes based on the above but with different icon colours. https://github.com/blackosx/BsxDarkFenceBlue1_ https://github.com/blackosx/BsxDarkFenceDarkGray1_ https://github.com/blackosx/BsxDarkFenceLight1_ https://github.com/blackosx/BsxDarkFenceLightGrey1_ https://github.com/blackosx/BsxDarkFenceOrangeRed1_ https://github.com/blackosx/BsxDarkFencePinkPurple1_ https://github.com/blackosx/BsxDarkFenceYellowGold1_ https://github.com/blackosx/BsxDarkFenceYellowOrange1_ https://github.com/blackosx/BsxDarkFenceGreen1_ These are still work in progress and may change in the next few days. Hello and Thanks for the work, you have to add in the config.plist so that the background is full screen, I added the 1080p background but it looks small, or is it? Link to comment Share on other sites More sharing options...
blackosx Posted April 10, 2021 Author Share Posted April 10, 2021 I don't know. Please supply a screenshot of what you see. What screen resolution does OpenCanopy use on your system? Link to comment Share on other sites More sharing options...
blackosx Posted April 10, 2021 Author Share Posted April 10, 2021 (edited) Set3 icons on the OpenCanopyIcons repository is now up to date for OpenCore/OpenCanopy 0.6.8. Sorry for any delay. I've also updated the OpenCanopyIconsSetBuilder_v0.1.9 script on the first post of this thread. Edited April 10, 2021 by blackosx 2 1 Link to comment Share on other sites More sharing options...
miliuco Posted April 10, 2021 Share Posted April 10, 2021 @Fory360 I have a 29" 4K display and @blackosx BsDarkFence themes work very well. If your monitor is 4K, have you tried to write 02 in NVRAM > 4D1EDE05-38C7-4A6A-9CC6-4BCCA8B38C14 > UIScale? 1 Link to comment Share on other sites More sharing options...
eSaF Posted April 10, 2021 Share Posted April 10, 2021 1 minute ago, blackosx said: Set3 icons on the OpenCanopyIcons repository is now up to date for OpenCore/OpenCanopy 0.6.8. Sorry for any delay. I've also updated the OpenCanopyIconsSetBuilder_v0.1.9 script on the first post of this thread. Bro I am getting a broken link???!!! 1 Link to comment Share on other sites More sharing options...
miliuco Posted April 10, 2021 Share Posted April 10, 2021 1 minute ago, blackosx said: Set3 icons on the OpenCanopyIcons repository is now up to date for OpenCore/OpenCanopy 0.6.8. Sorry for any delay. I've also updated the OpenCanopyIconsSetBuilder_v0.1.9 script on the first post of this thread. Thanks, it's time to download and try them. Link to comment Share on other sites More sharing options...
blackosx Posted April 10, 2021 Author Share Posted April 10, 2021 1 minute ago, eSaF said: Bro I am getting a broken link???!!! Updated. Thanks. Link to comment Share on other sites More sharing options...
eSaF Posted April 10, 2021 Share Posted April 10, 2021 No worries - Got it. 1 Link to comment Share on other sites More sharing options...
blackosx Posted April 10, 2021 Author Share Posted April 10, 2021 Just now, miliuco said: Thanks, it's time to download and try them. I think I've covered all bases. Please let me know if anything is missing etc. Link to comment Share on other sites More sharing options...
miliuco Posted April 10, 2021 Share Posted April 10, 2021 (edited) 2 minutes ago, eSaF said: Bro I am getting a broken link???!!! Me too. Broken link is https://github.com/blackosx/OpenCanopyIcons/tree/master/Set3 But this link is working: https://github.com/blackosx/OpenCanopyIcons/archive/refs/heads/master.zip Corrected by @blackosx Edited April 10, 2021 by miliuco Link to comment Share on other sites More sharing options...
Fory360 Posted April 10, 2021 Share Posted April 10, 2021 (edited) 11 minutes ago, blackosx said: I don't know. Please supply a screenshot of what you see. What screen resolution does OpenCanopy use on your system? 32 " 3840x2160 Edited April 10, 2021 by Fory360 Link to comment Share on other sites More sharing options...
blackosx Posted April 10, 2021 Author Share Posted April 10, 2021 (edited) Cool. Then you will need to edit your config plist as mentioned by @miliuco above But essentially, all the .icns files contain 2 sizes. One for x1 Scale and a second for x2 Scale. If you do not change the UIScale setting in config plist to 02 then you will only see the x1 Scale icon image. EDIT: For ref: https://github.com/acidanthera/OpenCorePkg/blob/master/Docs/Sample.plist#L981 Edited April 10, 2021 by blackosx 2 Link to comment Share on other sites More sharing options...
Fory360 Posted April 10, 2021 Share Posted April 10, 2021 5 minutes ago, miliuco said: @Fory360 I have a 29" 4K display and @blackosx BsDarkFence themes work very well. If your monitor is 4K, have you tried to write 02 in NVRAM > 4D1EDE05-38C7-4A6A-9CC6-4BCCA8B38C14 > UIScale? 1 Link to comment Share on other sites More sharing options...
Recommended Posts