OpenCanopy Icons

[mhaeuser]

@blackosx I looked into it further, and our label height calculation code was wrong, hence your font image was not rejected as it should have been. Code to disallow it may land for 0.6.8. Flexible label heights may not as I do not know how to support it well with Apple disklabel images. If you have suggestions, feel free to comment on the bugtracker.

[blackosx]

Thanks for the update @Download-Fritz

Disallowing incorrect fonts makes sense. I will look more in to these other font files the tool creates when I can.

 

With regard to supporting larger fonts in OpenCanopy while understanding that Apple disk labels must only be 12 pixels high, I think one way could be to have another PickerAttribute for example OC_ATTR_USE_CUSTOM_FONT which would override/disable OC_ATTR_USE_DISK_LABEL_FILE forcing rendering the volume name from a theme font file which is the larger size. Of course, the original OCBinaryData font would be retained as a fallback.

That’s just my first thought and may not be a good suggestion. I’ll give it more thought and maybe comment on the bugtracker if I think it could work.

 

 

Edited April 4, 2021 by blackosx

[BuXb]

On 4/3/2021 at 1:53 PM, blackosx said:

@BuXb See here 

great, sounds promising!

 

6 hours ago, Download-Fritz said:

Code to disallow it may land for 0.6.8. Flexible label heights may not as I do not know how to support it well with Apple disklabel images.

From my understanding, hackintosh boot-land philosophy has always been to adapt/ copy/ emulate Apple where they've achieved perfection, and to do better where they have not (yet). In terms of disk label font size, there sure is room for improvement even on real Macs. In that regard, blackosx's suggestion with OC_ATTR_USE_CUSTOM_FONT or alike sounds sensible, and promising.

[BuXb]

On 4/2/2021 at 11:55 PM, miliuco said:

I have multiple folders out of order and can't find the Monaco font from @blackosx. It may be this that I attach but I'm not sure.

ah, blackosx originally shared the Monaco font? Anyways - no, the one you attached is stock OC Helvetica - all 4 files same byte counts ..

[mhaeuser]

@blackosx @BuXb This behaviour is already possible with current OC. The point is that bless label images is something Apple guarantees to be present and valid, while the text files we use are more or less temporary files for generation and have been absent in the past. One way would be to force all label heights to be equal I suppose.

[blackosx]

Morning @Download-Fritz

 

Apologies for not elaborating more yesterday. Yes, I know OC can currently skip using labels and render the volume name directly but what I was thinking with a new picker attribute was a way for the user to indicate that they are happy to step away from the proper way of doing it using Apple’s rules as OC currently does. So more of a hack switch.

 

Enabling this attribute would then use adjusted values in OpenCanopy to draw the UI based on the size of the theme font, within a set tolerance of maybe +4px?

 

if the user chooses not to enable the attribute then OpenCanopy will always use the existing rules as it currently does.

 

This may not fit in with the OpenCore methodology of doing things correctly but it was the only way I could think of trying to achieve using larger fonts

[blackosx]

1 hour ago, Download-Fritz said:

One way would be to force all label heights to be equal I suppose.

If I understand correctly what you suggest then yes, that should work. Good thinking. 
 

So I presume you’re thinking along the lines of placing the existing labels on a larger canvas? To put it simply..

[mhaeuser]

@blackosx No, mismatched sizes will look like ****. I think we may just omit Apple disklabel images that are not the same size as the inbuilt font, if it is enabled, Mismatched fonts would also look terrible, but that's the price of flexibility.  Or maybe it can somehow be controlled by the proposed theme plist... idk

[blackosx]

 

@Download-Fritz Forgive me for not understanding why sizes would be mismatched. I don't see it.

 

My only knowledge of disk labels comes from you guys' disklabel.c and the linked explanation to rEFIt's vollabel where it explains these are pre-rendered image files created by bless which Apple uses to display the volume names when showing its boot picker.

 

You have built OpenCanopy (amazing job BTW) to follow Apple's method of using these labels but you also already have the functionality of not using them and drawing the names directly using a font file. As you have this option, then why not just ignore disk label images completely all the time? Just because Apple uses them, doesn't mean you have to. Unless I'm missing something more important here 

 

And I don't notice any difference in time presenting the UI with the labels enabled or not.
 

[mhaeuser]

1 minute ago, blackosx said:

As you have this option, then why not just ignore disk label images completely all the time?

As I have explained, the textual representation we use may not exist (iirc Recovery and sometimes installer?), and all else we have to get the proper name is heuristics. This is simply supporting Apple bless to its fullest.

[blackosx]

Okay. You are right. 

 

EDIT: So as I understand it now, the mismatched issue would come from any instance where the text representation didn't exist. In these cases the disklabel image would be used, instead of the rendered text drawn using the font in the theme.

 

3 hours ago, Download-Fritz said:

One way would be to force all label heights to be equal I suppose.

 

So could your earlier suggestion be the way forward?

 

Edited April 5, 2021 by blackosx

[blackosx]

1 hour ago, Download-Fritz said:

I think we may just omit Apple disklabel images that are not the same size as the inbuilt font, if it is enabled, Mismatched fonts would also look terrible, but that's the price of flexibility.  Or maybe it can somehow be controlled by the proposed theme plist... idk

I'm now up to speed with your thoughts here. 

 

So yes. Mismatched fonts would not look the best but that would have to be a caveat that comes with the users choice to installing a theme with larger fonts.

 

EDIT:

A theme plist could have a key for the user to choose between showing:

1 - the mismatched size disklabel (if they are indeed different sizes to the theme font)

2- nothing (just blank space)

3 - a custom string?

 

Edited April 5, 2021 by blackosx

[mhaeuser]

4 hours ago, blackosx said:

1 - the mismatched size disklabel (if they are indeed different sizes to the theme font)

2- nothing (just blank space

3 - a custom string?

Sorry, no, who wants to see any of that?

The theme plist could maybe have an option to force drawing all labels with the theme font unless fonts are disabled by PickerAttributes, I think that is about it.

[blackosx]

Okay. That’s why you develop amazing stuff and I don’t.   
But, seriously. Thanks for OpenCanopy. It’s really great. I hope you can get a break before the next round of updates. 

[BuXb]

Great conversation. Very curious now about 0.6.8 OpenCanopy. Might find some time to delve in tomorrow. Thumbs up in advance.

[BuXb]

@Download-Fritz I'll keep it short and simple: above all, thanks a ton for all the mighty-fine improvements.

Still, I hope that soon the font size issue where Apple clearly failed can be improved, in whichever technical way. Because what counts most even after 100s of lines of code is what's seen, and read. That the versatile better readable framd had to be downgraded back to Helvetica is a visual regression, totally regardless of technicalities in the background.

 

Sorry but I'm simply being honest. Yet again, I am aware that this is just a temporary state of 0.6.8 beta for now - a state at which I do not at all expect perfection yet. Just keep in mind that the average hackintosher aka the vast majority DOES love to tinker/ tweak and have as much as possible THEIR personal and NOT necessarily Apple's way. That's why blackosx's thread here hsa 21 pages: people love to adapt the UI to their very own interpretation of "beauty".

Edited April 8, 2021 by BuXb

[mhaeuser]

@BuXb I have already said the implementation details are in discussion? That people want to tinker will not make it faster. I won't promise either it will be in 0.6.9.

 

[polkaholga]

Hi guys,

 

to be honest I can't remember exactly when it started but I noticed again as I updated

within OC 0.6.8 updates ( not from 0.6.7 or previous revs ), that picker switches to text mode though I never changed any settings at Misc/Boot...

Anyone with same experiences.

I looked through the configuration.pdf but could not find any hint that I was dioing sth wrong....

 

Attached a screenshot from the relevant config.plist

 

[Anto65]

7 minutes ago, polkaholga said:

Hi guys,

 

to be honest I can't remember exactly when it started but I noticed again as I updated

within OC 0.6.8 updates ( not from 0.6.7 or previous revs ), that picker switches to text mode though I never changed any settings at Misc/Boot...

Anyone with same experiences.

I looked through the configuration.pdf but could not find any hint that I was dioing sth wrong....

 

Attached a screenshot from the relevant config.plist

 

you need maybe to Resources folder with all required elements from acidanthera  or others users theme  BsxDarkFence    Default-StarWars by  @chris1111  and   @blackosx

[polkaholga]

5 hours ago, antuneddu said:

you need maybe to Resources folder with all required elements from acidanthera  or others users theme  BsxDarkFence    Default-StarWars by  @chris1111  and   @blackosx

 

I compared mentioned resources folder with the one on my EFI, but could not find any obvious differences...

Nevertheless I downloaded it again and copied it over the existing one. On next boot graphic's been back.

Weird...

[Fory360]

On 4/2/2021 at 9:51 PM, blackosx said:

Hey BuXb

 

Everything here is planned to be up to date for when 0.6.8 is released.

For ref:

New mandatory icons for 0.6.8 are:

- Restart, Shutdown, BtnFocus, Dot, Entry, Lock, Password and SetDefault.

 

1. Yes

 

2. I have a current WIP theme available here:

https://github.com/blackosx/BsxOc1_

 

And also some simpler, cleaner themes based on the above but with different icon colours. 
https://github.com/blackosx/BsxDarkFenceBlue1_

 

https://github.com/blackosx/BsxDarkFenceDarkGray1_

 

https://github.com/blackosx/BsxDarkFenceLight1_

 

https://github.com/blackosx/BsxDarkFenceLightGrey1_

 

https://github.com/blackosx/BsxDarkFenceOrangeRed1_

 

https://github.com/blackosx/BsxDarkFencePinkPurple1_

 

https://github.com/blackosx/BsxDarkFenceYellowGold1_

 

https://github.com/blackosx/BsxDarkFenceYellowOrange1_

 

https://github.com/blackosx/BsxDarkFenceGreen1_

 

These are still work in progress and may change in the next few days.

 

 

 

 

Hello and Thanks for the work, you have to add in the config.plist so that the background is full screen, I added the 1080p background but it looks small, or is it?

[blackosx]

I don't know.

Please supply a screenshot of what you see.

What screen resolution does OpenCanopy use on your system?

[blackosx]

Set3 icons on the OpenCanopyIcons repository is now up to date for OpenCore/OpenCanopy 0.6.8. Sorry for any delay.

I've also updated the OpenCanopyIconsSetBuilder_v0.1.9 script on the first post of this thread.

 

Edited April 10, 2021 by blackosx

[miliuco]

@Fory360

 

I have a 29" 4K display and @blackosx BsDarkFence themes work very well. If your monitor is 4K, have you tried to write 02 in NVRAM > 4D1EDE05-38C7-4A6A-9CC6-4BCCA8B38C14 > UIScale?

[miliuco]

1 minute ago, blackosx said:

Set3 icons on the OpenCanopyIcons repository is now up to date for OpenCore/OpenCanopy 0.6.8. Sorry for any delay.

I've also updated the OpenCanopyIconsSetBuilder_v0.1.9 script on the first post of this thread.

 Thanks, it's time to download and try them.