Jump to content
27,332 posts in this topic

Recommended Posts

Hi @Jief_Machak One question: I edited my personal Clover script, to build CloverConfigPlistValidator release to a specific destination: ~/src/tools (along side Cloverbootloader). When I update Clover, is the CloverConfigPlistValidator project also updated ? Because I don't use git pull for CloverConfigPlistValidator.

Thanks.

Posted (edited)

Hi @Jief_Machak @Slice

I don't understand why, there is a difference between commit number for OpencorePKG when I build this morning.

CloverHackycolor/CloverBootloader repo
 

Spoiler

1112721748_Capturedcran2021-05-0508_09_41.png.2c4549dba1e0e456cc6b144dc9cfd037.png


CloverHackycolor/OpencorePKG
 

Spoiler

1190313861_Capturedcran2021-05-0508_14_19.thumb.png.9791172b6bcb769c4b7506e67af9d8fc.png

 

 

I can't build CloverConfigPlistValidator

 

note: Using new build system
note: Planning build
note: Constructing build description
error: unable to find sdk 'macosx10.11' (in target 'CloverConfigPlistValidator' from project 'CloverConfigPlistValidator')

But I can using: -sdk macosx (on Mojave, Xcode 11.3.1). 
 

Spoiler

1970562495_Capturedcran2021-05-0510_08_50.png.c6f9a625f679dd88ec59c9540115c3a4.png

 

Spoiler

1826756467_Capturedcran2021-05-0510_10_59.png.cae6341e97f4ce335b8bba601715d1e9.png

 

Edited by Matgen84
Posted (edited)
1 hour ago, Jief_Machak said:

@kushwavez Did you see that post ?

I'd like to debug your crash that seems to happen in ACPI patching.

Yes I did, just needed to revert my config.plist to the old state where it won't boot (but could boot with v5133).

Now I woke up ealry so had time for that.

So here a new log with your efi:

 

I compared the new and the old config.plist
 

The only thing changed in new:

ACPI/DSDT/Fixes: FixAirport=False, FixHPET=True, FixIPIC= True, FixRTC=True, FixTMR=True

The above Fixes didn't cause the lockup.

 

Moving on to ACPI/DSDT/Patches:

  • Deleted "Change _DSM to XDSM" rename patch
  • Disabled HECI to IMEI rename patch
  • Deleted HPET _CRS to XCRS, RTC IRQ8, TIMR IRQ8, TIMR IRQ 0 (enabled ACPI/DSDT/Fixes for them instead)

After that, it started (with release v5134 and your efi too). So something was in the ACPI/DSDT/Patches

 

EDIT: also with your new efi, iGPU HW acceleration failed to load (UHD 620 loaded with 7 MB VRAM). tried two times (once with NVRAM reset). On v5134 it's okay. Don't know why, will test more later.

2021-05-05_06-06_CloverX64-2021-05-04-13-36-24-ee78cb9-dirty-jief.efi.log

Edited by kushwavez
2 hours ago, Jief_Machak said:

@kushwavez Did you see that post ?

I'd like to debug your crash that seems to happen in ACPI patching.

 

i am block with ACPI/DSDT/Fixes i could find to find where.

i will send Three reports with:

1-boot too slowly and ACPI is totally wrong (value are different from previous r5133)? time to boot 33 s

2-boot complet too slowly and ACPI is totally wrong (all section  !!!!!!!!!) (values are different from previous r5133). time to boot 33 s

3-not boot, value are from previous with black screen.

 

Posted (edited)
2 hours ago, kushwavez said:

I compared the new and the old config.plist

 

The only thing changed in new:

ACPI/DSDT/Fixes: FixAirport=False, FixHPET=True, FixIPIC= True, FixRTC=True, FixTMR=True

The above Fixes didn't cause the lockup.

 

Moving on to ACPI/DSDT/Patches:

  • Deleted "Change _DSM to XDSM" rename patch
  • Disabled HECI to IMEI rename patch
  • Deleted HPET _CRS to XCRS, RTC IRQ8, TIMR IRQ8, TIMR IRQ 0 (enabled ACPI/DSDT/Fixes for them instead)

 

Could developer clover confirm whole  modifications list to to do or not , because i am not sur that is compatible with clover configurator ?

 

thanks

 

i agree in this case, if options are set to TRUE, no boot

Edited by maclinuxG4
2 hours ago, Matgen84 said:

unable to find sdk 'macosx10.11'

I'm currently working on cleaning the validator project.

This problem is fixed, soon to be committed.

3 hours ago, Matgen84 said:

When I update Clover, is the CloverConfigPlistValidator project also updated ? Because I don't use git pull for CloverConfigPlistValidator.

Yes, you pull everything. It's not separate project, they are in the same tree.

Hi @Jief_Machak thanks from me too for posting the CloverConfigPlistValidator officially in Clover's GitHub Releases page.

For us that don't know or don't have time to build binaries etc. now that you fixed both bugs, can we ask you to either share an updated r5134-1 or r5134.1 binary in the Releases Page or at least, kindly offer it here?

This way we know everyone is using the latest fixed one. Thank you in advance!

Posted (edited)
54 minutes ago, Jief_Machak said:

I'm currently working on cleaning the validator project.

This problem is fixed, soon to be committed.

 

@Jief_Machak Thanks. 
I can build the validator with macosx only ( in my script: -sdk macosx ) instead of 'macosx10.11' in the xcodeproject GitHub repo: the project find itself the macOS SDK installed on my system (Mojave, Xcode 11.3.1) and use it to build the tool.

Edited by Matgen84

@kushwavez Sorry, made a mistake and the log are not there.

Please keep that configuration that can reproduce this crash !

Try it with CloverX64-2021-05-05-12-57-57-6266377-dirty-jief.zip

Thanks.

10 minutes ago, Matgen84 said:

 

@Jief_Machak Thanks. 
I can build the validator with macosx only ( in my script: -sdk macosx ) instead of 'macosx10.11' in the xcodeproject GitHub repo: the project find itself the macOS SDK installed on my system (Mojave, Xcode 11.3.1) and use it to build the tool.

yes, I already put back macosx instead of macosx10.11.

Posted (edited)
4 hours ago, Jief_Machak said:

@kushwavez Sorry, made a mistake and the log are not there.

Please keep that configuration that can reproduce this crash !

Try it with CloverX64-2021-05-05-12-57-57-6266377-dirty-jief.zip

Thanks.

Here you go

 

EDIT: @Jief_Machak I saw in the log that it hangs after FixAirport. So I disabled it (only that, no other changes in the old cfg), and it booted.

Still no iGPU accel with this efi, gonna look into that in a half hour


EDIT2: tried 4 times with the same config:

- With your efi: No iGPU acceleration. Kexts are loaded. Maybe DeviceProperties aren't injected?

- With Clover v5134 release: Everything's OK

 

2021-05-05_14-41_CloverX64-2021-05-05-12-57-57-6266377-dirty-jief.efi.log

Edited by kushwavez

Ok, let's take them down one by one ! :P

The reason I can't reproduce is because I don't have the same DSDT.

Execute this with FixAirport to true CloverX64-2021-05-05-20-36-44-d52803e-dirty-jief.zip

After the crash, reboot and you'll find a file "DSDT_before_AIRPORT.bin" in misc folder. Send it to me. With this, I have the DSDT in the exact state it is when FixAirport is called.

I hope to reproduce with that, which will save you a loooot of reboot ! :wallbash:

11 minutes ago, Jief_Machak said:

Ok, let's take them down one by one ! :P

The reason I can't reproduce is because I don't have the same DSDT.

Execute this with FixAirport to true CloverX64-2021-05-05-20-36-44-d52803e-dirty-jief.zip

After the crash, reboot and you'll find a file "DSDT_before_AIRPORT.bin" in misc folder. Send it to me. With this, I have the DSDT in the exact state it is when FixAirport is called.

I hope to reproduce with that, which will save you a loooot of reboot ! :wallbash:

Thanks, man, if there were more devs like you... 

Here you are

DSDT_and_log.zip

7 hours ago, Jief_Machak said:

Fixed.

@Slice : remember that when you commit in OpenCorePkg, you have to commit in Clover that the sunmodule changed.

How shall I do this?

iMac2017:CloverBootloader sergey$ git commit -a -s -m "submodule changed"
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
	modified:   OpenCorePkg (untracked content)

 

7 hours ago, Jief_Machak said:

 

 

yes, I already put back macosx instead of macosx10.11.

My mistake.

Anyway my version of CloverConfigPlistValidator compiled with sdk10.11 works everywhere!

Can we please have Scanpolicy in Config.plist, as seen in OpenCore? It is a very powerful and simple way to select what filesystems, drives etc. should be scanned for by the bootloader, and what gets to show up in the boot menu. Since we use OC runtime I think that option should be readily available? Nothing wrong with picking the good stuff that could benefit Clover users :) Just my 2cents.

 

Excellent work with Clover, integrating XML validation at boot and having a command line tool for validating and making sure that the config.plist is properly formatted and uses the correct options and values. Makes it so much easier to find faults when you get stuck and just cannot find what is wrong with the file.

New theme MacSteel available on Github  

screenshot0.thumb.png.8a9866c41e8cc6e9a32d7d90edaffe3e.png

5 background included

 

Background-1080p.png

Background-1366x768.png

Background-1024x768.png

Background-2560x1440.png

Background-1600x900.png

 

Included MacOS Icons from Tiger to macOS Big Sur

 

 

 

2 hours ago, kushwavez said:

Thanks, man, if there were more devs like you... 

Here you are

DSDT_and_log.zip 61.27 kB · 0 downloads

@kushwavez Did you have an error message on the screen finishing with "A fatal error happened. System halted" ?

Try this, with fix airport enabled CloverX64-2021-05-05-23-30-57-d52803e-dirty-jief.zip

 

2 hours ago, Slice said:

How shall I do this?


iMac2017:CloverBootloader sergey$ git commit -a -s -m "submodule changed"
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
	modified:   OpenCorePkg (untracked content)

 

You have to add that "change" like you any other. It's a submodule instead of a file, but that the same idea.

Probably "git add OpenCorePkg". I have to admit I never did on command line.

Posted (edited)

ok finally able to boot 5134... FWIW,  here are my diffs from 5133 to 5134. it takes 2 seconds longer ...  but i think that is pause from showing the parsing logs issues?
 

$ diff 5133.log 5134.log 
2c2
< -05 TIME: 12:48:03
---
> -05 TIME: 12:30:15
4c4
<  MemLog inited, TSC freq: 2491905600
---
>  MemLog inited, TSC freq: 2491906440
6c6,7
<  CloverX64 : Image base = 0xD6E34000
---
>  CloverX64 : Image base = 0xD6E08000
>  Clover ImageHandle = d8157c98
8,10c9,11
<  Now is 05.05.2021,  19:47:31 (GMT)
<  Starting Clover revision: 5133 (master, commit 51d5d4a14) on Lenovo EFI
<  Build id: 20210428210028-51d5d4a
---
>  Now is 05.05.2021,  19:29:41 (GMT)
>  Starting Clover revision: 5134 (master, commit d52803e7c) on Lenovo EFI
>  Build id: 20210505201010-d52803e
13d13
<  === [ GetDefaultSettings ] ======================
56d55
<  === [ GetDefaultCpuSettings ] ===================
57a57
>  Found more than one GOP protocol ??? Using the first one
63c63,64
<   - LAN: 0 Vendor=Intel
---
>   - LAN: 1 Vendor=Intel
>  Legacy MAC address of LAN #0= 00:21:CC:5D:55:05:
81,82c82
<  Clover load options size = 0 bytes
<  _checkOEMPath Look for oem dir at path '\EFI\CLOVER\OEM\4236ED7--00-00-00-00-00-00'. Dir doesn't exist.
---
>  _checkOEMPath Look for oem dir at path '\EFI\CLOVER\OEM\4236ED7--00-21-CC-5D-55-05'. Dir doesn't exist.
84a85
>  === [ GetUserSettings ] =========================
86c87,110
<  \EFI\CLOVER\OEM\4236ED7\config.plist  loaded: Success
---
>  There is problems in plist '\EFI\CLOVER\OEM\4236ED7\config.plist'
>  Warning: Unknown key '/ACPI/DSDT/Fixes/NewWay_80000000:15'. Skipped.
>  Warning: Unknown key '/Boot/IgnoreNVRAMBoot:75'. Skipped.
>  Warning: Unknown key '/Boot/UseAlternateLogo:83'. Skipped.
>  Warning: Unknown key '/GUI/Mouse/DoubleClick:285'. Skipped.
>  Warning: Unknown key '/Graphics/EDID/Comment:318'. Skipped.
>  Warning: Unknown key '/Quirks/AppleCpuPmCfgLock:472'. Skipped.
>  Warning: Unknown key '/Quirks/AppleXcpmCfgLock:474'. Skipped.
>  Warning: Unknown key '/Quirks/CustomSMBIOSGuid:482'. Skipped.
>  Warning: Unknown key '/Quirks/DisableRtcChecksum:490'. Skipped.
>  Warning: Unknown key '/Quirks/LapicKernelPanic:514'. Skipped.
>  Warning: Unknown key '/Quirks/PanicNoKextDump:516'. Skipped.
>  Warning: Unknown key '/Quirks/ProvideConsoleGopEnable:526'. Skipped.
>  Use CloverConfigPlistValidator or look in the log
>  Cannot find smbios.plist at path '\EFI\CLOVER' : Not Found
>  '\EFI\CLOVER\smbios.plist' not loaded. Efi error Not Found
>  BiosVersion: not set, Using BiosVersion from clover
>  BiosVersion: MBP81.88Z.F000.B00.1906132217
>  BiosReleaseDate: not set, Using BiosReleaseDate from clover
>  BiosReleaseDate: 06/13/19
>  
>  Using EfiVersion from clover: 87.0.0.0.0
>  Calibrated TSC Frequency = 2491906440 = 2491MHz
>  GOP found at: 
93,104d116
<  === [ GetEarlyUserSettings ] ====================
<  timeout set to 5
<  KextsToPatch: 7 requested
<   - [00]: com.apple.driver.AppleIntelSNBGraphicsFB (Patch Framebuffer to Replace 4th port with VGA) :: BinPatch :: data len: 60
<   - [01]: com.apple.iokit.IOAHCIBlockStorage (TRIM for SSD) :: BinPatch :: data len: 9
<   - [02]: com.apple.driver.AppleAHCIPort (fix IO error ICH10 for 10.15, credit vit9696) :: MatchOS: 10.15.x :: BinPatch :: data len: 4
<   - [03]: com.apple.driver.AppleAHCIPort (fix IO error ICH10 for 10.13, credit SunKi) :: MatchOS: 10.13.x :: BinPatch :: data len: 20
<   - [04]: com.apple.driver.AppleAHCIPort (fix hotplug ICH10 for 10.13, credit SunKi) :: MatchOS: 10.13.x :: BinPatch :: data len: 26
<   - [05]: com.apple.driver.AppleIntelSNBGraphicsFB (1024MB memory) :: MatchOS: 10.13.x,10.14.x,10.15.x :: BinPatch :: data len: 7
<   - [06]: com.apple.driver.AppleIntelSNBGraphicsFB (Sierra 1024MB memory) :: MatchOS: 10.12.x :: BinPatch :: data len: 7
<  Hiding entries with string Preboot
<   Custom EDID is ok
106c118,119
<  Loading ApfsDriverLoader.efi  status=Success
---
>  Loading ApfsDriverLoader.efi status=Success
>  ChildImaheHandle=d77fc818
108,109c121,124
<  Loading SMCHelper.efi  status=Success
<  Loading AudioDxe.efi  status=Success
---
>  Loading SMCHelper.efi status=Success
>  ChildImaheHandle=d862c418
>  Loading AudioDxe.efi status=Success
>  ChildImaheHandle=d862c898
111c126,127
<  Loading HfsPlusLegacy.efi  status=Success
---
>  Loading HfsPlusLegacy.efi status=Success
>  ChildImaheHandle=d862cd98
130d145
<  === [ GetMacAddress ] ===========================
156,183d170
<  Calibrated TSC Frequency = 2491905600 = 2491MHz
<  === [ GetUserSettings ] =========================
<   Custom EDID is ok
<  Add 1 properties:
<   - [00]: IntelGFX Key: AAPL00,DualLink, len: 4
<  USB FixOwnership: yes
<   - final DSDT Fix mask=10000000
<  C3Latency: 0
<  MinMultiplier: 0
<  MaxMultiplier: 0
<  PluginType: 0
<  ResetAddr: 0xCF9
<  Calc ResetVal: 0x6
<  ResetVal: 0x6
<  ProductName SETTINGS_DATA=MacBookPro8,1
<  ProductName setting=MacBookPro8,1
<  ProductName new SETTINGS_DATA=MacBookPro8,1
<  SetDMISettingsForModel=25
<  Using ProductName : MacBookPro8,1
<  BiosVersion: not set, Using BiosVersion from clover
<  BiosVersion: MBP81.88Z.F000.B00.1906132217
<  BiosReleaseDate: 06/13/19
<  Using EfiVersion from clover: 87.0.0.0.0
<  Using FirmwareFeatures from clover: 0xC00DE137
<  Using FirmwareFeaturesMask from clover: 0xFF1FFF3F
<  PlatformFeature will not set in SMBIOS
<  gSettings.Smbios.SerialNr: C02FKGR8DH2G
<  void ParseSMBIOSSettings(SETTINGS_DATA &, const TagDict *) : BoardVersion: MacBookPro8,1
190d176
<  Cannot find smbios.plist at path '\EFI\CLOVER' : Not Found
448c434
<   OC: OpenCore DBG-061-2021-04-28 is loading in Optional mode (0/0)...
---
>   OC: OpenCore DBG-061-2021-05-05 is loading in Optional mode (0/0)...
450c436
<   OC: Current version is DBG-061-2021-04-28
---
>   OC: Current version is DBG-061-2021-05-05
482c468
<   OCC: Install console control (D6F78EF0/0/0), current - Success
---
>   OCC: Install console control (D6F750B0/0/0), current - Success
492c478
<   OCB: Arch filtering D56D3018(617016)->D56D3018(617016) caps 4 - Success
---
>   OCB: Arch filtering D56AC018(617016)->D56AC018(617016) caps 4 - Success
510,512c496,498
<   void PatchTableType1() : UpdateSmbiosString ProductName=MacBookPro8,1
<   void PatchTableType2() : UpdateSmbiosString ProductName=BoardNumber=Mac-94245B3640C91C81
<   void PatchTableType2() : UpdateSmbiosString Version=BoardVersion=MacBookPro8,1
---
>   void PatchTableType1(const SmbiosInjectedSettings &) : UpdateSmbiosString ProductName=MacBookPro8,1
>   void PatchTableType2(const SmbiosInjectedSettings &) : UpdateSmbiosString ProductName=BoardNumber=Mac-94245B3640C91C81
>   void PatchTableType2(const SmbiosInjectedSettings &) : UpdateSmbiosString Version=BoardVersion=MacBookPro8,1
612,613c598,599
<   SetNvramVariable (UIScale, guid, 0x7, 1): -> writing new (Success)
<   SetNvramVariable (EFILoginHiDPI, guid, 0x7, 4): -> writing new (Success)
---
>   DeleteNvramVariable (UIScale, guid = Not Found):
>   DeleteNvramVariable (EFILoginHiDPI, guid = Not Found):

 

Edited by tluck
2 hours ago, Slice said:

My mistake.

Anyway my version of CloverConfigPlistValidator compiled with sdk10.11 works everywhere!

No problem. I imagine that using macosx instead of macosx10.11 allows people to compile on different configuration as xcode will take any sdk available.

Personally, I have sdk 10.14 if I compile on command line and 10.15 if I compile with xcode

In the end, the validator doesn't use at all the macos sdk !

5 minutes ago, tluck said:

it takes 2 seconds longer

Could just the fact that there is a bit more log. Each log line open a file, write, and close (to flush). Not the quickest operation.

What you can do to compare is to start with boot/debug set to false and save preboot.log with F2.

Do that with both version and send me these logs. The last time I made something inefficient, it added 12 seconds to the boot !

1 hour ago, Common_Sense said:

Since we use OC runtime

Almost only for the kernel patching part and the Quirks part.

The discovery of bootable volumes and what's in the menu is done like before and way before OC is initialised.

 

I never really understood why I would like to see my APFS volume but not my HFS ones (or the other way around). If a volume shows up and you don't like, there is a possibility to hide it.

 

That said, we're open to feature request discussions. What do you find interesting in ScanPolicy from OC, exactly ?

Posted (edited)
48 minutes ago, Jief_Machak said:

@kushwavez Did you have an error message on the screen finishing with "A fatal error happened. System halted" ?

No I didn't, just a black screen after selecting Preboot.

 

48 minutes ago, Jief_Machak said:

Try this, with fix airport enabled CloverX64-2021-05-05-23-30-57-d52803e-dirty-jief.zip

It boots with this. What was the cause?

Now the only thing remains is the non-working iGPU.:whistle:

 

Here is the log from that efi

2021-05-05_21-10_CloverX64-2021-05-05-23-30-57-d52803e-dirty-jief.efi.log

Edited by kushwavez
Posted (edited)

Please help everyone.
I'm testing CloverConfigPlistValidator to Build with Xcode 12.4. (Successful with Xcode 11.3.1)
The following error will occur.

 

% pwd
/Users/alpha/CloverBootloader/Xcode/CloverConfigPlistValidator
% xcodebuild -version
Xcode 12.4
Build version 12D4e
% mkdir $HOME/Desktop/CloverConfigPlistValidator
% xcodebuild ARCHS=x86_64 ONLY_ACTIVE_ARCH=YES -scheme CloverConfigPlistValidator clean build CONFIGURATION_BUILD_DIR=$HOME/Desktop/CloverConfigPlistValidator >error.txt                    
** BUILD FAILED **


The following build commands failed:
    CompileC /Users/alpha/Library/Developer/Xcode/DerivedData/CloverConfigPlistValidator-bkzmbgpcdtudzeebllzdkxobhvun/Build/Intermediates.noindex/CloverConfigPlistValidator.build/Release/CloverConfigPlistValidator.build/Objects-normal/x86_64/Platform.o /Users/alpha/CloverBootloader/Xcode/CloverConfigPlistValidator/src/Platform.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
    CompileC /Users/alpha/Library/Developer/Xcode/DerivedData/CloverConfigPlistValidator-bkzmbgpcdtudzeebllzdkxobhvun/Build/Intermediates.noindex/CloverConfigPlistValidator.build/Release/CloverConfigPlistValidator.build/Objects-normal/x86_64/BootLog.o /Users/alpha/CloverBootloader/rEFIt_UEFI/PlatformPOSIX/BootLog.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(2 failures)

error.txt

I'm currently studying Build in Xcode.
Thank you in advance.

(I can build CloverBootloder with Xcode12.4, ./bulidme and select 7 )

 

Edited by MifJpn
6 hours ago, Jief_Machak said:

 

You have to add that "change" like you any other. It's a submodule instead of a file, but that the same idea.

Probably "git add OpenCorePkg". I have to admit I never did on command line.

There are problems

https://stackoverflow.com/questions/50167969/how-to-fix-modified-content-untracked-content-in-git

The solution #8.

×
×
  • Create New...