Clover General discussion

[Slice]

15 hours ago, Qwels said:

it's not loading ,there's a screenshot upstairs Linia 1164

 

 

And where is the config.plist? Where is the screenshot?

[Slice]

Hi @Jief_Machak,

one user encounter this technical bug https://www.applelife.ru/threads/clover.42089/page-1413#post-957201

    MACHINE_TYPES getModel() const
    {
      if ( !ProductName.isDefined() ) {
        log_technical_bug("%s : !ProductName.isDefined()", __PRETTY_FUNCTION__);
        return iMac132;
      }
      return GetModelFromString(ProductName.value()); // ProductName has been validated, so Model CANNOT be MaxMachineType
    }

If it is malformed config.plist then the calculated ProductName should be from GetDefaultModel() which is not always 13,2.

[Jief_Machak]

If I logged a "technical bug", it's because I consider that the code must not get there unless a bug before. A malformed entry is not a technical bug.

I don't have the computer to check (in few hours I will) but it must something like reading the plist, rejecting bad values must be done before (probably in the plist reading object which contains validate methods).

 

It's planned that log_technical_bug do not panic and give the chance to run anyway, but I never had the time to implement this. So for now, log_technical_bug still panic. Which is not what seems to happen here.

Of course, it's probably possible and make more sense to return GetDefaultModel(). GetDefaultModel() depends on gCPUStructure or will return iMac132 if gCPUStructure is not initialised. That may be why I did that. I don't know. Depends if gCPUStructure is filled before or after getModel() is called.

 

Here, it looks like he got a warning and a crash (not a panic, nor a log_technical_bug).

@Qwels send me your whole CLOVER folder. I'll have a look with a debugger.

 

[Qwels]

 

 

and added the Ephie folder on your page

On 9/12/2021 at 5:07 PM, Slice said:

And where is the config.plist? Where is the screenshot?

I don't make F2 ( preboot.plist )

Edited September 25, 2021 by Qwels

[Jief_Machak]

I tried your EFI and this

On 9/11/2021 at 3:12 PM, Qwels said:

is not happening. Maybe you already fixed it ?

 

Activate debug in your config.plist, so we have a log.

[Qwels]

On 9/13/2021 at 12:45 PM, Jief_Machak said:

I tried your EFI and this

is not happening. Maybe you already fixed it ?

 

Activate debug in your config.plist, so we have a log.

unfortunately, I don't know how to work with Clover

i've always worked with a hamelion

 

 

 

 

 

 

Edited September 25, 2021 by Qwels

[chris1111]

Maybe its time to create a Manuel for Clover  Clover.pdf 

[Qwels]

5 hours ago, chris1111 said:

Maybe its time to create a Manuel for Clover  Clover.pdf 

Chris

   The main thing to create is that everything else is not important.

Edited September 17, 2021 by Qwels

[MacKonsti]

Hello everyone, hope you are all well !  @Slice please, two questions:

 

a) My hack Intel NUC8 has been running stable r5136 with latest Catalina as my primary computer. Does it make sense or is there a real need to update to Clover r5139 while still on Catalina ? Is this version having improvements impacting Catalina or just Monterey stuff ? (perhaps Big Sur too?) Thank you...

 

b) I managed to reproduce the non-automatic-selection of boot drive (only 1 SSD on my hack, macOS -- no Windows) when I tried to update to Catalina new Security Updates. First reboot auto-selected "data" partition/container OK; second reboot did not auto-select "data" container and had to do this manually; third reboot had no "data" drive anymore and booted automatically to main partition/container.

 

I added debug=yes in my config and here is the logs for you from "misc" folder. I hope they will give you an idea of what happened. Thanks again

r5136_boot_log_no_auto_selected.zip

[Slice]

1 hour ago, MacKonsti said:

Hello everyone, hope you are all well !  @Slice please, two questions:

 

a) My hack Intel NUC8 has been running stable r5136 with latest Catalina as my primary computer. Does it make sense or is there a real need to update to Clover r5139 while still on Catalina ? Is this version having improvements impacting Catalina or just Monterey stuff ? (perhaps Big Sur too?) Thank you...

 

b) I managed to reproduce the non-automatic-selection of boot drive (only 1 SSD on my hack, macOS -- no Windows) when I tried to update to Catalina new Security Updates. First reboot auto-selected "data" partition/container OK; second reboot did not auto-select "data" container and had to do this manually; third reboot had no "data" drive anymore and booted automatically to main partition/container.

 

I added debug=yes in my config and here is the logs for you from "misc" folder. I hope they will give you an idea of what happened. Thanks again

r5136_boot_log_no_auto_selected.zip 37.56 kB · 0 downloads

Hello!

a) If it works then you need no to update Clover even for Monterey. But each release we did some bugs elimination including your problem b)

So yes, you'd better to make this update.

Then make the similar log and we will compare them.

With Clover 5138 I made full automatic updates Mojave and Monterey with several betas. From pressing "OK" up to final entering desktop I didn't have to interfere to update process.

[Jief_Machak]

I canceled the 0.6.5 integration in master branch and make it a branch.

 

That means you have to issue

- "git reset --hard b0aac62accc46de3297b2fa3b50e34f0d03460bd" in OpenCorePkg

- "git reset --hard 2e387406cdd3e9de08b2e1375af2750217458ace" in Clover folder

if you want to be able to fetch, pull ( @Slice and push).

 

Possible to re-clone instead.

[Matgen84]

On 9/21/2021 at 12:27 PM, Jief_Machak said:

I canceled the 0.6.5 integration in master branch and make it a branch.

 

That means you have to issue

- "git reset --hard b0aac62accc46de3297b2fa3b50e34f0d03460bd" in OpenCorePkg

- "git reset --hard 2e387406cdd3e9de08b2e1375af2750217458ace" in Clover folder

if you want to be able to fetch, pull ( @Slice and push).

 

Possible to re-clone instead.

 

Thanks. After git reset in OpencorePKG, I've this issue in my script:

 

Entering 'OpenCorePkg'
HEAD is now at 046e209c Merge pull request #8 from serdeliuk/master

2021-09-21T13:43:18CEST Building Clover, this may take a while..
2021-09-21T13:46:27CEST Build failed!

And this:

Spoiler

[CPP] main
/Users/mathieu/src/Cloverbootloader/rEFIt_UEFI/refit/main.cpp:633:12: error: no matching function for call to 'OcStorageInitFromFs'
  Status = OcStorageInitFromFs(&mOpenCoreStorage, FileSystem, self.getCloverDirFullPath().wc_str(), NULL);
           ^~~~~~~~~~~~~~~~~~~
/Users/mathieu/src/Cloverbootloader/OpenCorePkg/Include/Acidanthera/Library/OcStorageLib.h:118:1: note: candidate function not viable: requires 6 arguments, but 4 were provided
OcStorageInitFromFs (
^
/Users/mathieu/src/Cloverbootloader/rEFIt_UEFI/refit/main.cpp:865:14: error: no matching function for call to 'OcStorageInitFromFs'
    Status = OcStorageInitFromFs(&mOpenCoreStorage, FileSystem, self.getCloverDirFullPath().wc_str(), NULL);
             ^~~~~~~~~~~~~~~~~~~
/Users/mathieu/src/Cloverbootloader/OpenCorePkg/Include/Acidanthera/Library/OcStorageLib.h:118:1: note: candidate function not viable: requires 6 arguments, but 4 were provided
OcStorageInitFromFs (
^
2 errors generated.
make: *** [/Users/mathieu/src/Cloverbootloader/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit/OUTPUT/refit/main.obj] Error 1

build.py...
 : error 7000: Failed to execute command
    make tbuild [/Users/mathieu/src/Cloverbootloader/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit]

build.py...
 : error F002: Failed to build module
    /Users/mathieu/src/Cloverbootloader/rEFIt_UEFI/refit.inf [X64, XCODE8, RELEASE]

- Failed -
 

 

In CloverHackyColor/OpencorePKG

 

 

 

Same problem after a fresh cloning of Clover:

 

HEAD is now at 046e209c Merge pull request #8 from serdeliuk/master
HEAD is now at 2e387406c Merge branch 'master' of https://github.com/CloverHackyColor/CloverBootloader

 

Edited September 21, 2021 by Matgen84

[Jief_Machak]

On 9/21/2021 at 2:47 PM, Matgen84 said:

 

Thanks. After git reset in OpencorePKG, I've this issue in my script:

 

Entering 'OpenCorePkg'
HEAD is now at 046e209c Merge pull request #8 from serdeliuk/master

2021-09-21T13:43:18CEST Building Clover, this may take a while..
2021-09-21T13:46:27CEST Build failed!

And this:

  Hide contents

[CPP] main
/Users/mathieu/src/Cloverbootloader/rEFIt_UEFI/refit/main.cpp:633:12: error: no matching function for call to 'OcStorageInitFromFs'
  Status = OcStorageInitFromFs(&mOpenCoreStorage, FileSystem, self.getCloverDirFullPath().wc_str(), NULL);
           ^~~~~~~~~~~~~~~~~~~
/Users/mathieu/src/Cloverbootloader/OpenCorePkg/Include/Acidanthera/Library/OcStorageLib.h:118:1: note: candidate function not viable: requires 6 arguments, but 4 were provided
OcStorageInitFromFs (
^
/Users/mathieu/src/Cloverbootloader/rEFIt_UEFI/refit/main.cpp:865:14: error: no matching function for call to 'OcStorageInitFromFs'
    Status = OcStorageInitFromFs(&mOpenCoreStorage, FileSystem, self.getCloverDirFullPath().wc_str(), NULL);
             ^~~~~~~~~~~~~~~~~~~
/Users/mathieu/src/Cloverbootloader/OpenCorePkg/Include/Acidanthera/Library/OcStorageLib.h:118:1: note: candidate function not viable: requires 6 arguments, but 4 were provided
OcStorageInitFromFs (
^
2 errors generated.
make: *** [/Users/mathieu/src/Cloverbootloader/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit/OUTPUT/refit/main.obj] Error 1

build.py...
 : error 7000: Failed to execute command
    make tbuild [/Users/mathieu/src/Cloverbootloader/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit]

build.py...
 : error F002: Failed to build module
    /Users/mathieu/src/Cloverbootloader/rEFIt_UEFI/refit.inf [X64, XCODE8, RELEASE]

- Failed -
 

 

In CloverHackyColor/OpencorePKG

 

 

 

Same problem after a fresh cloning of Clover:

 

HEAD is now at 046e209c Merge pull request #8 from serdeliuk/master
HEAD is now at 2e387406c Merge branch 'master' of https://github.com/CloverHackyColor/CloverBootloader

 

Did you do "git reset --hard b0aac62accc46de3297b2fa3b50e34f0d03460bd" from inside OpenCorePkg folder ?

Head of OpenCorePkg must be b0aac62

 

[Matgen84]

On 9/21/2021 at 2:53 PM, Jief_Machak said:

Did you do "git reset --hard b0aac62accc46de3297b2fa3b50e34f0d03460bd" from inside OpenCorePkg folder ?

Head of OpenCorePkg must be b0aac62

 

 

Right. I git reset --hard from inside OpencorePKG. Even with a new git clone, the HEAD is not correct.
 

But take a look in CloverHackycolor/OpencorePkg repo, the serdeluik's commits are always present. So when I use Update option, with BuildMe. There is a wrong HEAD for OpencorePKG

https://github.com/CloverHackyColor/OpenCorePkg

Edited September 21, 2021 by Matgen84

[Cyberdevs]

Guys as @Hervé has mentioned above please post your Monterey related problems in the related topic because these issues are not related to the clover and most likely they are related to your security setting in config.plist and other people are testing and posting their findings here:

Thanks

[Matgen84]

5 minutes ago, Cyberdevs said:

Guys as @Hervé has mentioned above please post your Monterey related problems in the related topic because these issues are not related to the clover and most likely they are related to your security setting in config.plist

 

 

You're right @Cyberdevs, you're right @Hervé But most comments on Monterey Thread, are posted by Opencore's users. So the solutions for one bootloader is not the same for other bootloader. Specially for SecureModel option, for example.

[SavageAUS]

So if I’m using Clover and the update isn’t showing it’s a Monterey problem not a Clover problem? Laptop using MacBookPro16,4 and AMD desktop using iMacPro1,1 both using clover boot loader.
The fixes in Monterey thread are for OpenCore users not Clover, clover does not have securebootmodel etc… unless I’m wrong? If so please show me.


Sent from my iPhone using Tapatalk

[Matgen84]

1 hour ago, Hervé said:

if the update isn't showing, in all likelihood it's because your settings are incorrect (SIP related possibly...). This has been extensively discussed in the past. I experienced no issue receiving the update offer on my Hackintosh laptop (MBP13,1 SMBIOS) booting with Clover r5133. Your issue of the offer not being offered is not related to a development being required in Clover. Let's not further confuse the matter by adding stuff related to the actual installation of beta7 which bears no relation to the update offering. Anyway, let's close this discussion here, it's a matter for the Monterey beta thread.

 

 

Thanks, you're right 🙂 Few month ago, in Clover general discussion thread, @Slice told to me to use: 0x285.

 

Concerning Beta 7, maybe Apple has changed a few things. Clover developers should take this into account. They therefore need a lift. "It needs to be improved to extend to FirmwareFeatures, FirmwareFeaturesMask" as suggested by @MifJpnAlphaPlus. It is well linked to Clover in order to improve it.

Have a nice day.

[Slice]

18 minutes ago, Matgen84 said:

 

Thanks, you're right 🙂 Few month ago, in Clover general discussion thread, @Slice told to me to use: 0x285.

 

Concerning Beta 7, maybe Apple has changed a few things. Clover developers should take this into account. They therefore need a lift. "It needs to be improved to extend to FirmwareFeatures, FirmwareFeaturesMask" as suggested by @MifJpnAlphaPlus. It is well linked to Clover in order to improve it.

Have a nice day.

I know the problem and the solution. Wait please when I'll commit it.

[Matgen84]

13 minutes ago, Slice said:

I know the problem and the solution. Wait please when I'll commit it.

 

Thanks a lot 😊 Can you have a look to OpencorePKG submodule synchro, please. Clover can't be build with the correct HEAD for OpencorePKG. Even recloning.

The good one in CloverHackyColcor/Cloverbootloader: b0aac62

Spoiler

 

CloverHackycolor/OpencorePKG: commits stays in Master instead of 0.6.5 branch

 

Spoiler

 

[Guest 5T33Z0]

Just in case somebody wonders which flags are set by "0x285". It's these:

 

[Slice]

10 minutes ago, 5T33Z0 said:

Just in case somebody wonders which flags are set by "0x285". It's these:

 

Clover shows this in its GUI.

[SavageAUS]

I know the problem and the solution. Wait please when I'll commit it.

Waiting patiently, I do not wish to switch to OpenCore just to update. I have downloaded the full installer while I wait for clover solution.


Sent from my iPhone using Tapatalk

[Guest 5T33Z0]

1 hour ago, Slice said:

Clover shows this in its GUI.

 

You mean in the Boot Menu? If so, I didn't know this.

40 minutes ago, SavageAUS said:

Waiting patiently, I do not wish to switch to OpenCore just to update. I have downloaded the full installer while I wait for clover solution.


Sent from my iPhone using Tapatalk

 

The full installer is broken. After "compiling" the Installer app, the whole "Shared Content" Folder is missing and the thing is 34 MB in size. I'd wait a little longer

[Jief_Machak]

Here is my first version with an update of the OpenCore component to 0.7.3.

 

Could you try ?CloverX64-2021-09-23-15-42-13-d8755c9-jief.zip