Clover General discussion

[smolderas]

Could someone please help me build clover? I like to test filevault2, but ebuild.sh fails with following error:

[CC] AutoGen
/Users/<redacted>/edk2/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c:4020:29: error: implicit declaration of function 'ARRAY_SIZE' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    for (Index = 0; Index < ARRAY_SIZE (mVariableEntryProperty); Index++) {
                            ^
1 error generated

[Slice]

Read

PlatformSupport.plist.zip

macOS 10.12.1

 

Could someone please help me build clover? I like to test filevault2, but ebuild.sh fails with following error:

[CC] AutoGen
/Users/<redacted>/edk2/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c:4020:29: error: implicit declaration of function 'ARRAY_SIZE' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    for (Index = 0; Index < ARRAY_SIZE (mVariableEntryProperty); Index++) {
                            ^
1 error generated

 

#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))

 

Looks like you updated EDK2? My version 22865 contains correct line 4020

[smolderas]

Read

PlatformSupport.plist.zip

macOS 10.12.1

 

#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))

Thanks Slice, so I should define that function in every file, which uses ARRAY_SIZE?

 

Edit:

I'm sorry to bother you, I reverted to previous edk2 and it is good to go. I forget the comment out the svn up edk2 line

[Slice]

Thanks Slice, so I should define that function in every file, which uses ARRAY_SIZE?

 

Edit:

I'm sorry to bother you, I reverted to previous edk2 and it is good to go. I forget the comment out the svn up edk2 line

It is EDK2 developers problem. I thing they resolve it in nearest commit.

Yes, in every file. As I see in the whole EDK2 tree it is defined multiple times.

[phi777]

@smolderas

I did the trick 3 times in MdeModulePkg/Universal/EbcDxe/EbcExecute.c, MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c and MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c

and now it works with newest ed2k!

It's fast, if you use "vim +LineNumber file" like "vim +4020 MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c"!

[smolderas]

@smolderas

I did the trick 3 times in MdeModulePkg/Universal/EbcDxe/EbcExecute.c, MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c and MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c

and now it works with newest ed2k!

It's fast, if you use "vim +LineNumber file" like "vim +4020 MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c"!

Thanks for the tip. I'm trying to hold my diff from the repository to a minimum, so I've just reversed the EDK2 version and it's working again.

[tluck]

@slice - what are these new "mandatory" UEFI drivers all about that came in r3882/3883? 

 

$ ls -1
AppleImageCodec-64.efi
AppleKeyAggregator-64.efi
AppleUITheme-64.efi
DataHubDxe-64.efi
EmuVariableUefi-64.efi
FSInject-64.efi
FirmwareVolume-64.efi
OsxAptioFix2Drv-64.efi
OsxFatBinaryDrv-64.efi
SMCHelper-64.efi
UsbKbDxe-64.efi
VBoxHfs-64.efi

[Mirone]

@tluck, look here: http://www.insanelymac.com/forum/topic/317290-filevault-2/

[Sherlocks]

Read

PlatformSupport.plist.zip

macOS 10.12.1

 

#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))

 

Looks like you updated EDK2? My version 22865 contains correct line 4020

 

thank you

serial invaild(generated random)

 

replace plist and test for other users

 

skylake users have bug

glitch on menubar

touchpad blank

capslock

PlatformSupport.plist.zip

[idaima]

thank you

serial invaild(generated random)

 

replace plist and test for other users

 

skylake users have bug

glitch on menubar

touchpad blank

capslock

when you use the plist file on 10.12.1,glitch on menubar still exists?

[LockDown]

what does this platform differs in vanilla?

[Sherlocks]

when you use the plist file on 10.12.1,glitch on menubar still exists?

Yes. I think we have to use FakeID "Iris HD540 or HD550" or find hex code to fix glitch on menubar.

 

I see Macbook pro 13,1 geekbench.

They use other MacOS build number.

 

It use more number than10.12.1 official xxx555.

 

We need time to clear this issue.

 

나의 LG-F410S 의 Tapatalk에서 보냄

what does this platform differs in vanilla?

I just added platform id for macbookpro13,1

 

나의 LG-F410S 의 Tapatalk에서 보냄

[Slice]

 

skylake users have bug

glitch on menubar

touchpad blank

capslock

See commit 3879

 #41 

[Sherlocks]

See commit 3879

 #41 

 

Thank Slice.

 

report one

r3882 still have bug about "return main gui with don't any touch option in submenu that i said"

 

have a good day

[pkdesign]

No, this EDID is not custom, it is native.

1:484  0:000  EdidOverrideFound!
1:484  0:000   found Detail Timing 2560x1440
1:548  0:064     0 640x480 attr=3BF - ok, edid+, 640x480, working, highest, pref=0
1:550  0:002     1 800x600 attr=3BF - ok, edid+, 800x600, working, highest, pref=1
1:553  0:002     2 1024x768 attr=3BF - ok, edid+, 1024x768, working, highest, pref=2
1:555  0:002     3 1280x1024 attr=3BF - ok, edid+, working, highest, pref=3
1:565  0:009  BV new mode: 3 1280x1024

You have to modify it with some EDID_Editor to have 1920x1080 in this list.

 

Well i guess I'm out since I have no clue how to do this.

 

I've also tried to find a way to edit the VBIOS of my card but can't seem to find a way to do that. I have followed several guides but can't find the hex code they tell you to.

 

It's only a few seconds at boot time so I guess I will just live with it.

[Micky1979]

Hi, may be this what you are looking for?

[Micky1979]

My version 22865 contains correct line 4020

run to update my script with this version than..

[wastez]

@ Clover Developers

Since 10.12 it´s not possible to use a custom hibernate file path. (Clover will not load it)

I saw in the Clover log that it took the hibernate preferences from /Library/Preferences/com.apple.PowerManagement.plist, what could be the reason why it can´t find the setting for "hibernatefile".

hibernatefile is stored in /Library/Preferences/com.apple.PowerManagement.XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX.plist since 10.12.

 

Would be great if somebody can have a look on it.

[Balamut]

Does anybody else have issues with sleep on the latest Clover?

 

Before used to sleep perfectly, now just hard reset

[iRipper]

Do I need FakeSMC.kext when we now have SMCHelper.efi? 

 

Or do they work together? 

[mhaeuser]

Do I need FakeSMC.kext when we now have SMCHelper.efi? 

 

Or do they work together? 

 

They work together.

[dgsga]

The Clover installer when run on an encrypted FV2 volume installs to the root partition and not the EFI partition...I have absolutely no idea why, I shall do some digging.

[Micky1979]

a pkg cannot install directly to the ESP, is not allowed, plus if the fv disk is a logical volume and have no ESP (is on the physical disk) ... he cannot be found. ... and Clover package only have the target volume to be used..  

[dgsga]

This change needs to be made in line 8 of the MountESP installer script but I don't know how to submit a diff to the repo on Sourceforge:

-sed -n 's/.*Part [oO]f Whole: *//p')
+sed -n 's/.*PV UUID (disk): .*(//p' | \
+sed -n 's/s[0-9])//p')
+
+if [[ "$ESPDevice" == "" ]]; then
+ESPDevice=$(LC_ALL=C diskutil info / 2>/dev/null | \
+sed -n 's/.*Part [Oo]f Whole: *//p')
+fi

[Slice]

 

This change needs to be made in line 8 of the MountESP installer script but I don't know how to submit a diff to the repo on Sourceforge:

-sed -n 's/.*Part [oO]f Whole: *//p')
+sed -n 's/.*PV UUID (disk): .*(//p' | \
+sed -n 's/s[0-9])//p')
+
+if [[ "$ESPDevice" == "" ]]; then
+ESPDevice=$(LC_ALL=C diskutil info / 2>/dev/null | \
+sed -n 's/.*Part [Oo]f Whole: *//p')
+fi

I will commit tomorrow.

And I want too see some confirmations.