Clover General discussion

[Matgen84]

10 hours ago, vector sigma said:

Tadan: Clover_v2.4k_r4974.pkg

 

after one year, as soon I understood that you wanted a dark background image and not the logo Lol, here is it:

 

To all,

before committing changes I want to know if the package can work in old OSes, e.g. 10.10 or maybe 10.7? Please report!

 

Thanks a lot  I look forward to the new commit. It's possible that Clover Logo keeps Green color (in Dark Mode) instead of Gray. I've a dream...

 

I hope this new background would be compatible with old OSes e.g. 10.10 or 10.10.7

 

Edited June 26, 2019 by Matgen84

[PMheart]

Hi,

 

Sorry, I was too hurried yesterday, better to polish logging as follows:

Index: rEFIt_UEFI/Platform/kernel_patcher.c
===================================================================
--- rEFIt_UEFI/Platform/kernel_patcher.c	(revision 4974)
+++ rEFIt_UEFI/Platform/kernel_patcher.c	(working copy)
@@ -1048,7 +1048,7 @@
 
   // check OS version suit for patches
   if (!IsXCPMOSVersionCompat(os_version)) {
-    DBG("Unsupported macOS.\n");
+    DBG("HaswellLowEndXCPM(): Unsupported macOS.\n");
     DBG("HaswellLowEndXCPM() <===FALSE\n");
     return FALSE;
   }
@@ -1121,7 +1121,7 @@
 
   // check whether Ivy Bridge
   if (gCPUStructure.Model != CPU_MODEL_IVY_BRIDGE) {
-    DBG("Unsupported platform.\nRequires Ivy Bridge, aborted\n");
+    DBG("KernelIvyBridgeXCPM(): Unsupported platform.\nRequires Ivy Bridge, aborted\n");
     DBG("KernelIvyBridgeXCPM() <===FALSE\n");
     return FALSE;
   }
@@ -1129,7 +1129,7 @@
   // check OS version suit for patches
   // PMheart: attempt to add 10.14 compatibility
   if (!IsXCPMOSVersionCompat(os_version)) {
-    DBG("Unsupported macOS.\n");
+    DBG("KernelIvyBridgeXCPM(): Unsupported macOS.\n");
     DBG("KernelIvyBridgeXCPM() <===FALSE\n");
     return FALSE;
   } else if (os_version >= AsciiOSVersionToUint64("10.8.5") && os_version < AsciiOSVersionToUint64("10.12")) {
@@ -1205,7 +1205,7 @@
   
   // check whether Ivy Bridge-E5
   if (gCPUStructure.Model != CPU_MODEL_IVY_BRIDGE_E5) {
-    DBG("Unsupported platform.\nRequires Ivy Bridge-E, aborted\n");
+    DBG("KernelIvyE5XCPM(): Unsupported platform.\nRequires Ivy Bridge-E, aborted\n");
     DBG("KernelIvyE5XCPM() <===FALSE\n");
     return FALSE;
   }
@@ -1213,7 +1213,7 @@
   // check OS version suit for patches
   // PMheart: attempt to add 10.15 compatibility
   if (!IsXCPMOSVersionCompat(os_version)) {
-    DBG("Unsupported macOS.\n");
+    DBG("KernelIvyE5XCPM(): Unsupported macOS.\n");
     DBG("KernelIvyE5XCPM() <===FALSE\n");
     return FALSE;
   }

Thanks a lot!

[Slice]

3 hours ago, PMheart said:

Hi,

 

Sorry, I was too hurried yesterday, better to polish logging as follows:

Index: rEFIt_UEFI/Platform/kernel_patcher.c
===================================================================
--- rEFIt_UEFI/Platform/kernel_patcher.c	(revision 4974)
+++ rEFIt_UEFI/Platform/kernel_patcher.c	(working copy)
@@ -1048,7 +1048,7 @@
 
   // check OS version suit for patches
   if (!IsXCPMOSVersionCompat(os_version)) {
-    DBG("Unsupported macOS.\n");
+    DBG("HaswellLowEndXCPM(): Unsupported macOS.\n");
     DBG("HaswellLowEndXCPM() <===FALSE\n");
     return FALSE;
   }
@@ -1121,7 +1121,7 @@
 
   // check whether Ivy Bridge
   if (gCPUStructure.Model != CPU_MODEL_IVY_BRIDGE) {
-    DBG("Unsupported platform.\nRequires Ivy Bridge, aborted\n");
+    DBG("KernelIvyBridgeXCPM(): Unsupported platform.\nRequires Ivy Bridge, aborted\n");
     DBG("KernelIvyBridgeXCPM() <===FALSE\n");
     return FALSE;
   }
@@ -1129,7 +1129,7 @@
   // check OS version suit for patches
   // PMheart: attempt to add 10.14 compatibility
   if (!IsXCPMOSVersionCompat(os_version)) {
-    DBG("Unsupported macOS.\n");
+    DBG("KernelIvyBridgeXCPM(): Unsupported macOS.\n");
     DBG("KernelIvyBridgeXCPM() <===FALSE\n");
     return FALSE;
   } else if (os_version >= AsciiOSVersionToUint64("10.8.5") && os_version < AsciiOSVersionToUint64("10.12")) {
@@ -1205,7 +1205,7 @@
   
   // check whether Ivy Bridge-E5
   if (gCPUStructure.Model != CPU_MODEL_IVY_BRIDGE_E5) {
-    DBG("Unsupported platform.\nRequires Ivy Bridge-E, aborted\n");
+    DBG("KernelIvyE5XCPM(): Unsupported platform.\nRequires Ivy Bridge-E, aborted\n");
     DBG("KernelIvyE5XCPM() <===FALSE\n");
     return FALSE;
   }
@@ -1213,7 +1213,7 @@
   // check OS version suit for patches
   // PMheart: attempt to add 10.15 compatibility
   if (!IsXCPMOSVersionCompat(os_version)) {
-    DBG("Unsupported macOS.\n");
+    DBG("KernelIvyE5XCPM(): Unsupported macOS.\n");
     DBG("KernelIvyE5XCPM() <===FALSE\n");
     return FALSE;
   }

Thanks a lot!

Not a big deal! Committed.

[fusion71au]

16 hours ago, vector sigma said:

Tadan: Clover_v2.4k_r4974.pkg

 

after one year, as soon I understood that you wanted a dark background image and not the logo Lol, here is it:

 

To all,

before committing changes I want to know if the package can work in old OSes, e.g. 10.10 or maybe 10.7? Please report!

 

Install also succeeds in Lion and boots it as well ...

 

Spoiler

 

[vector sigma]

13 hours ago, Matgen84 said:

Thanks a lot  I look forward to the new commit. It's possible that Clover Logo keeps Green color (in Dark Mode) instead of Gray. I've a dream.

I made it dark with Photoshop Lol, but ok will be green 

6 hours ago, fusion71au said:

Install also succeeds in Lion and boots it as well ...

Thanks you so much! I'll commit this as soon as possible.

Edited June 26, 2019 by vector sigma
typo

[Badruzeus]

16 minutes ago, vector sigma said:

I made it dark with Photoshop Lol, but ok will be green 

Thanks you so mutch! I'll commit this as soon as possible.

I think gray is also cool, so Clover logo is also transformed into another color when UI goes Dark lol 

[Sherlocks]

@Slice

the most of people uses disable kernel panic patch to get exact panic kext part.

https://github.com/RehabMan/OS-X-Clover-Laptop-Config/pull/60

 

like this. can we include this patch default like SIP and EXT? if we need, i will consider

Edited June 26, 2019 by Sherlocks

[Slice]

41 minutes ago, Sherlocks said:

@Slice

the most of people uses disable kernel panic patch to get exact panic kext part.

https://github.com/RehabMan/OS-X-Clover-Laptop-Config/pull/60

 

like this. can we include this patch default like SIP and EXT? if we need, i will consider

May be conditional, like DisablePanic?

[vector sigma]

9 minutes ago, Slice said:

May be conditional, like DisablePanic?

Why not automatic if "Reboot On Panic" is turned off?

[Slice]

21 minutes ago, vector sigma said:

Why not automatic if "Reboot On Panic" is turned off?

In this case it will be good.

On 6/25/2019 at 5:56 PM, cecekpawon said:

@Slice Please ignore if you already have similar results like imac dump below.

 

https://sourceforge.net/p/cloverefiboot/code/HEAD/tree/rEFIt_UEFI/Platform/smbios.c#l1083

 

 

 

My result with Clover

 

[vector sigma]

2 hours ago, Badruzeus said:

I think gray is also cool, so Clover logo is also transformed into another color when UI goes Dark lol 

Yes,  I've only followed a popular policy lately in Apple, but green is default for a clover lol, so I think it's ok for most.. 

Anway I need to test it to ensure this method isn't applied in dark mode, that usually require an image to be greyscaled... otherwise the result will be unpleasant.

 

EDIT

committed

Edited June 26, 2019 by vector sigma

[pkdesign]

Quick question, do you still have to format the EFI partition as FAT32? I am about to update to Mojave and want o be sure I get it right,

 

I apologize if this has been asked before but I can’t find a definitive answer.

[Sherlocks]

9 hours ago, Slice said:

In this case it will be good.

My result with Clover

 

 

can we turn off cosmetic of apple rom info in system profiler from config.plist?

 

also what is better name for disabled kernel panic logging?

 

can i determine name?

[PMheart]

Regarding "disabled kernel panic logging", should you mean something like this in OpenCore?

 

12 hours ago, Sherlocks said:

@Slice

the most of people uses disable kernel panic patch to get exact panic kext part.

https://github.com/RehabMan/OS-X-Clover-Laptop-Config/pull/60

 

like this. can we include this patch default like SIP and EXT? if we need, i will consider

By the way, this is not the best approach, a better one can be found at https://github.com/acidanthera/OcSupportPkg/blob/master/Library/OcAppleKernelLib/CommonPatches.c#L948-L958, where the bytes are kind of stabler.

 

As for the name itself, not so bad to copy/paste it from OC I guess. =)

[Badruzeus]

Thanks @Slice now I see diff between my iMac vs Hackintosh laptop #LoL, I mean.. I feel good.

[Slice]

1 hour ago, Sherlocks said:

 

can we turn off cosmetic of apple rom info in system profiler from config.plist?

 

also what is better name for disabled kernel panic logging?

 

can i determine name?

Apple ROM Info depends on macModel or FeatureMask. I don't know exactly.

As well we set smbis version as 2.4 while in newest Mac it is 3.0. May be it also should be adustable.

[Badruzeus]

Hmmb, I just realized that "Boot ROM Version" and "EFI Version" give a same result. (256.0.0.0.0 on my case)

Can EFI version replaced with Clover revision, or.. BiosReleaseDate? Thanks.

[Slice]

17 minutes ago, Badruzeus said:

Hmmb, I just realized that "Boot ROM Version" and "EFI Version" give a same result. (256.0.0.0.0 on my case)

Can EFI version replaced with Clover revision, or.. BiosReleaseDate? Thanks.

We may include different information. Discussable. Do you really want to see BiosReleaseDate? Is it influence on something?

[Matgen84]

Hi

 

thanks a lot  @vector sigma Clover Team for Clover PKG in Dark Mode.

 

 

[Badruzeus]

1 hour ago, Slice said:

Do you really want to see BiosReleaseDate? Is it influence on something

It doesn't, but I usually bdmesg grep it to compare my custom PlatformData on SMBios with Clover provided to see whether BiosReleaseDate is current or not, or you could consider another one like Board-id maybe..

Edited June 27, 2019 by Badruzeus

[Sherlocks]

4 hours ago, Slice said:

We may include different information. Discussable. Do you really want to see BiosReleaseDate? Is it influence on something?

 

i want to keep vanilla system profiler like realmac without cosmetic. so i ask you to turn off cosmetics option

[Badruzeus]

@Slice Or EFI Version could be unified with BiosReleaseDate in single line like screenshot below, probably..

plus Board-ID as addition.

 

15 minutes ago, Sherlocks said:

i want to keep vanilla system profiler like realmac without cosmetic. so i ask you to turn off cosmetics option

Uhmmb, if there's such option on config.plist I think it'll be better for user to choose.

 

Edited June 27, 2019 by Badruzeus

[Slice]

1 hour ago, Sherlocks said:

 

i want to keep vanilla system profiler like realmac without cosmetic. so i ask you to turn off cosmetics option

I just added SMBIOS table 11. It does present in real Macs.

There is a question why System Profiler not always shows the information. May be because of FeatureMask? Or because of MacModel? Or because of SMBIOS version?

[Matgen84]

Hi Clover Team

 

I don't know if I'm Off-Topic

 

Under catalina Developer Beta 2, Clover stuck at prepare stage so I can't update

 

 

 

[arsradu]

1 hour ago, Matgen84 said:

Hi Clover Team

 

I don't know if I'm Off-Topic

 

Under catalina Developer Beta 2, Clover stuck at prepare stage so I can't update

 

 

 

 

Hi Matt,

 

Uhm...no such issues on my side.

 

However, I'm still getting this weird warning. Maybe because Clover was built on Mojave...? No idea. Clicking Install Anyway does seem to install it properly though.

 

 

How are you building Clover? Maybe you're selecting something else in Drivers....? I only chose the mandatory (automatically checked) drivers + OSXAptioFix3Drv. That's all.

 

Also, we were previously talking about the post install script, which should prevent user from getting AptioMemoryFix and OSxAptioFix drivers, both at the same time.

There seems to be a case where this does not happen.

 

Because this is what I'm getting after installing Clover, while previously I had AptioMemoryFix in drivers64UEFI.

 

 

My guess is that since the previous Clover installer did have AptioMemoryFix (and it was checked for installation) and this one doesn't (since I've switched to the default OsXAptioFix3Drv instead, and did not include AptioMemoryFix in the build anymore), the installer doesn't know AptioMemoryFix is already present, and it doesn't do anything based on that. Doesn't skip the installation of OsXAptioFix3Drv, and it doesn't remove AptioMemoryFix either to avoid conflicts.

 

I'm looking forward to your opinions though. In my opinion this could be a real life scenario. If one day we ship Clover with AptioMemoryFix, and the other day we don't or we use something else instead, I see this as a potential problem on the long run, if people will end up with two (or more) Aptio fixes. And I've actually seen people with all 3 OsXAptioFixes in their drivers folders. Probably added manually, not through the installer. In which case there's not much we can do. But if that was through the installer...maybe we should think of a better solution to this other than relying on the post-install script to fix everything in the background.

 

I think a bit more transparency wouldn't hurt anyone. Meaning let the user know in the UI that what they're trying to do is not ok. I don't know, it's just my opinion. If we just allow the user to choose whatever he wants and then "fix it" in the background, it will create confusion, they'll think it's a bug the fact that they didn't get their drivers installed as they selected, and they will never learn anything from that. They'll think it's Clover's fault for not installing everything they wanted, not their fault, for selecting (stupid) incompatible things in the installer UI.

Edited June 28, 2019 by arsradu