Jump to content

PMheart

Coders
  • Content Count

    1,011
  • Joined

  • Last visited

  • Days Won

    26

PMheart last won the day on June 4 2019

PMheart had the most liked content!

About PMheart

  • Rank
    InsanelyMac Legend

Recent Profile Visitors

The recent visitors block is disabled and is not being shown to other users.

  1. PMheart

    [Pre-Release] macOS Catalina 10.15.1

    Hi, Sorry, I am afraid not. Apple has restricted the writing permission as of 10.15. `sudo mount -uw /` stopped working starting at certain beta as well... Ref: https://developer.apple.com/videos/play/wwdc2019/710/ PMheart By the way, just a quick tip, I got Safari Preferences and Messages hang after downgrading to 10.15 (19A583) from 10.15.1 b1 (19B68f) on my real MacBook9,1. For this good please do not go back and currently I do not see any solutions other than upgrading to the upcoming b2. Furthermore, it is impossible to update to 10.15.1 b1 from 10.15 supplemental update (19A602).
  2. PMheart

    OpenCore Discussion

    Sorry for the late reply! Finally I got the point, thanks a lot! Oh, 0 vs 9 is not of vital significance as it stands for stepping, which is rather ignored by macOS.
  3. PMheart

    OpenCore Discussion

    Sorry for my stupidness. I still didn't get it. Might you want to make this patch a quirk or?
  4. PMheart

    OpenCore Discussion

    Hello, Sorry, I didn't quite catch that. Could you please point out the changes that I am supposed to handle? Thanks!
  5. PMheart

    [pre-release] macOS Catalina

    Interesting. 8u211 never works for me. 8u221, released on 16 Jul 2019, triggers an error that reads "XPC connection error" on either installation or uninstallation. Still erroneous anyway...
  6. PMheart

    Clover General discussion

    function abort() { echo "ERROR: ${1}" 1>&2 exit 1 } # # Get the latest release tag on GitHub. # # @param author Name of user/organization on GitHub # @param repo Repository belonging to the author # # @return latest tag of author/repo # function getGitHubLatestReleaseTag() { local author="$1" local repo="$2" if [ -z "${author}" ] || [ -z "${repo}" ]; then echo 'Author or repository is null!' 1>&2 exit 1 fi local url="https://api.github.com/repos/${author}/${repo}/releases" local tag="$(curl --silent "${url}" | grep 'tag_name' | head -n 1 | awk -F ":" '{print $2}' | tr -d '"' | tr -d ',' | tr -d ' ')" if [ -z "${tag}" ]; then abort "WARNING: Failed to retrieve latest tag of release from ${author}/${repo}." 1>&2 fi echo "${tag}" } # # Download a file from release page of author/repo. # # @param author Name of user/organization on GitHub # @param repo Repository belonging to the given author # @param tag Tag to search for, or null for latest # @param fileName Asset of the tag # function downloadGitHubRelease() { local author="$1" local repo="$2" local tag="$3" local fileName="$4" if [ -z "${author}" ] || [ -z "${repo}" ] || [ -z "${fileName}" ]; then abort 'Author/repository/file name is null!' fi if [ -z "${tag}" ]; then tag="$(getGitHubLatestReleaseTag "${author}" "${repo}")" fi local url="https://github.com/${author}/${repo}/releases/download/${tag}/${fileName}" curl --silent -L "${url}" -o "${fileName}" || abort "Failed to download ${fileName}!" } Tiny functions extracted from one of my scripts for download from GitHub release page. For this specific case, let's abstract it based on tag and fileName: - tag is Rxx, which can be retrieved by getGitHubLatestReleaseTag() - fileName, generally RELEASE is grabbed, then it would be "AptioFix-${tag}-RELEASE.zip"
  7. PMheart

    [pre-release] macOS Catalina

    Is that a fresh installation or upgrade from Mojave?
  8. PMheart

    [pre-release] macOS Catalina

    I don't have Java installed (i.e no panel in System Preferences for sure) and was trying to install it, yet what I got is just the infinite installation as mentioned by @URBANsUNITED. Anyway, let's wait for the next update.
  9. PMheart

    [pre-release] macOS Catalina

    Reproduced here, macOS 10.15 b3 (19A501i) Unfortunately this does not work for me.
  10. PMheart

    OpenCore Discussion

    That's totally another story I guess. Currently we are having a tremendous number of new features to implement, which makes us too exhausted to investigate a specific platform. I suppose it would be sensible for users tending to build a new hack to avoid it. As for theming, well, I guess one of the biggest reasons to use OpenCore is to enjoy the fun macOS brings us, instead of themes one might only see for several seconds, which are too fleeting to be enjoyed. Either way, we wish somebody who were willing to and capable to participate in the problem, and finally we would have a solution. We are sorry for lack of time to do it compared to other TODOs that may appear more worthwhile. Best Regards, PMheart
  11. PMheart

    OpenCore Discussion

    Hmm, that looks weird as you seem to be applying the patch correctly... Better to ask developers instead.
  12. PMheart

    OpenCore Discussion

    Maybe you applied it as a "kernel patch"? I don't know much either to be honest, it's not me who wrote this code. The reason why you managed to patch it anyway is that a "kernel patch" applies to the whole kernel cache, which contains your AMD9500Controller. CORRECT ME IF WRONG!
  13. PMheart

    OpenCore Discussion

    That can be taken into account WITH LOWEST PRIORITY.
  14. PMheart

    Clover General discussion

    Hi, Sorry, I was too hurried yesterday, better to polish logging as follows: Index: rEFIt_UEFI/Platform/kernel_patcher.c =================================================================== --- rEFIt_UEFI/Platform/kernel_patcher.c (revision 4974) +++ rEFIt_UEFI/Platform/kernel_patcher.c (working copy) @@ -1048,7 +1048,7 @@ // check OS version suit for patches if (!IsXCPMOSVersionCompat(os_version)) { - DBG("Unsupported macOS.\n"); + DBG("HaswellLowEndXCPM(): Unsupported macOS.\n"); DBG("HaswellLowEndXCPM() <===FALSE\n"); return FALSE; } @@ -1121,7 +1121,7 @@ // check whether Ivy Bridge if (gCPUStructure.Model != CPU_MODEL_IVY_BRIDGE) { - DBG("Unsupported platform.\nRequires Ivy Bridge, aborted\n"); + DBG("KernelIvyBridgeXCPM(): Unsupported platform.\nRequires Ivy Bridge, aborted\n"); DBG("KernelIvyBridgeXCPM() <===FALSE\n"); return FALSE; } @@ -1129,7 +1129,7 @@ // check OS version suit for patches // PMheart: attempt to add 10.14 compatibility if (!IsXCPMOSVersionCompat(os_version)) { - DBG("Unsupported macOS.\n"); + DBG("KernelIvyBridgeXCPM(): Unsupported macOS.\n"); DBG("KernelIvyBridgeXCPM() <===FALSE\n"); return FALSE; } else if (os_version >= AsciiOSVersionToUint64("10.8.5") && os_version < AsciiOSVersionToUint64("10.12")) { @@ -1205,7 +1205,7 @@ // check whether Ivy Bridge-E5 if (gCPUStructure.Model != CPU_MODEL_IVY_BRIDGE_E5) { - DBG("Unsupported platform.\nRequires Ivy Bridge-E, aborted\n"); + DBG("KernelIvyE5XCPM(): Unsupported platform.\nRequires Ivy Bridge-E, aborted\n"); DBG("KernelIvyE5XCPM() <===FALSE\n"); return FALSE; } @@ -1213,7 +1213,7 @@ // check OS version suit for patches // PMheart: attempt to add 10.15 compatibility if (!IsXCPMOSVersionCompat(os_version)) { - DBG("Unsupported macOS.\n"); + DBG("KernelIvyE5XCPM(): Unsupported macOS.\n"); DBG("KernelIvyE5XCPM() <===FALSE\n"); return FALSE; } Thanks a lot!
  15. PMheart

    Clover General discussion

    Nope. It's not like the bytes are stable, so better to leave as is. Yet I came up with a tiny function for compatibility check, see the diff please: (@vector sigma) Index: rEFIt_UEFI/Platform/kernel_patcher.c =================================================================== --- rEFIt_UEFI/Platform/kernel_patcher.c (revision 4973) +++ rEFIt_UEFI/Platform/kernel_patcher.c (working copy) @@ -822,6 +822,15 @@ } // +// Global XCPM patches compatibility +// Currently 10.8.5 - 10.15 +// +static inline BOOLEAN IsXCPMOSVersionCompat(UINT64 os_version) +{ + return (os_version >= AsciiOSVersionToUint64("10.8.5")) && (os_version < AsciiOSVersionToUint64("10.16")); +} + +// // Enable Unsupported CPU PowerManagement // // syscl - SandyBridgeEPM(): enable PowerManagement on SandyBridge-E @@ -846,8 +855,8 @@ UINT64 os_version = AsciiOSVersionToUint64(Entry->OSVersion); // check OS version suit for patches - if (os_version < AsciiOSVersionToUint64("10.8.5") || os_version >= AsciiOSVersionToUint64("10.14")) { - DBG("Unsupported macOS.\nHaswell-E requires macOS 10.8.5 - 10.13.x, aborted\n"); + if (!IsXCPMOSVersionCompat(os_version)) { + DBG("HaswellEXCPM(): Unsupported macOS.\n"); DBG("HaswellEXCPM() <===FALSE\n"); return FALSE; } @@ -988,8 +997,8 @@ UINT64 os_version = AsciiOSVersionToUint64(Entry->OSVersion); // check OS version suit for patches - if (os_version < AsciiOSVersionToUint64("10.8.5")) { - DBG("Unsupported macOS.\nBroadwell-E/EP requires macOS at least 10.8.5, aborted\n"); + if (!IsXCPMOSVersionCompat(os_version)) { + DBG("BroadwellEPM(): Unsupported macOS.\n"); DBG("BroadwellEPM() <===FALSE\n"); return FALSE; } @@ -1038,8 +1047,8 @@ CHAR8 *comment; // check OS version suit for patches - if (os_version < AsciiOSVersionToUint64("10.8.5") || os_version >= AsciiOSVersionToUint64("10.14")) { - DBG("Unsupported macOS.\nHaswell Celeron/Pentium requires macOS 10.8.5 - 10.13.x, aborted\n"); + if (!IsXCPMOSVersionCompat(os_version)) { + DBG("Unsupported macOS.\n"); DBG("HaswellLowEndXCPM() <===FALSE\n"); return FALSE; } @@ -1118,9 +1127,8 @@ } // check OS version suit for patches - // PMheart: attempt to add 10.14 compatibility - if (os_version < AsciiOSVersionToUint64("10.8.5") || os_version >= AsciiOSVersionToUint64("10.15")) { - DBG("Unsupported macOS.\nIvy Bridge XCPM requires macOS 10.8.5 - 10.13.x, aborted\n"); + if (!IsXCPMOSVersionCompat(os_version)) { + DBG("Unsupported macOS.\n"); DBG("KernelIvyBridgeXCPM() <===FALSE\n"); return FALSE; } else if (os_version >= AsciiOSVersionToUint64("10.8.5") && os_version < AsciiOSVersionToUint64("10.12")) { @@ -1203,8 +1211,8 @@ // check OS version suit for patches // PMheart: attempt to add 10.14 compatibility - if (os_version < AsciiOSVersionToUint64("10.8.5") || os_version >= AsciiOSVersionToUint64("10.15")) { - DBG("Unsupported macOS.\nIvy Bridge-E XCPM requires macOS 10.8.5 - 10.13.x, aborted\n"); + if (!IsXCPMOSVersionCompat(os_version)) { + DBG("Unsupported macOS.\n"); DBG("KernelIvyE5XCPM() <===FALSE\n"); return FALSE; } Thanks!
×