Jump to content
30960 posts in this topic

Recommended Posts

4 minutes ago, Jief_Machak said:

You can set the max time between 2 clicks to be recognised as a double click. It was forced to 500. Now it's default to 500 and you can change with DoubleClickTime key in config.plist


Ok, I understand now. You mean the config-sample.plist  is going to be updated as well as CloverConfigPlistValidator. ASAP :)

  • Like 1
4 minutes ago, chris1111 said:

Fix Visual Studio compilation broken CloverConfigPlistValidator macOS Build

Oups, forgot to check that.

On my way...

12 minutes ago, Matgen84 said:

config-sample.plist  is going to be updated

DoubleClickTime is not in config-sample.plist, but Clover and the validator is aware of it.

  • Like 4
4 hours ago, Jief_Machak said:

Good.

 

When typing into console, you have completion. So for me a long name isn't a problem.

But I like ccpv too. I don't we'll ever confuse with "Club Canin du Périgord Vert" :D, so it's ok by me. Does everyone prefer ccpv ?

Sure, yes.

image.png.ab7e82e0ea9a8e8443615742c267be00.pngimage.png.e35322f231c335f92fe8f7ad47dad4ab.png

  • Like 2
  • Thanks 1
1 hour ago, chris1111 said:

Fix Visual Studio compilation broken CloverConfigPlistValidator macOS Build :frantics:

It was just that I deleted that need to be removed from the project...

I'm surprised thought about open the project with xcode and try to compile...

Hi all.

 

Compilation Pbm with "Club Canin du Périgord Vert"

 

 

meunier@MACBOOKPRO CloverConfigPlistValidator % xcodebuild -target CloverConfigPlistValidator

Command line invocation:

    /Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -target CloverConfigPlistValidator

 

User defaults from command line:

    IDEPackageSupportUseBuiltinSCM = YES

 

note: Using new build system

note: Planning build

note: Analyzing workspace

note: Constructing build description

note: Build preparation complete

CreateBuildDirectory /Users/meunier/CloverBootloader/Xcode/CloverConfigPlistValidator/build

    cd /Users/meunier/CloverBootloader/Xcode/CloverConfigPlistValidator/CloverConfigPlistValidator.xcodeproj

    builtin-create-build-directory /Users/meunier/CloverBootloader/Xcode/CloverConfigPlistValidator/build

...

error: Build input file cannot be found: '/Users/meunier/CloverBootloader/rEFIt_UEFI/Settings/ConfigPlist/Config_ACPI.cpp' (in target 'CloverConfigPlistValidator' from project 'CloverConfigPlistValidator')

 

** BUILD FAILED **

 

 

The following build commands failed:

CompileC /Users/meunier/CloverBootloader/Xcode/CloverConfigPlistValidator/build/CloverConfigPlistValidator.build/Release/CloverConfigPlistValidator.build/Objects-normal/x86_64/Config_ACPI.o /Users/meunier/CloverBootloader/rEFIt_UEFI/Settings/ConfigPlist/Config_ACPI.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler

(1 failure)

 

Greetings

 

 

Capture d’écran 2021-05-08 à 18.06.29.png

51 minutes ago, Jief_Machak said:

It was just that I deleted that need to be removed from the project...

I'm surprised thought about open the project with xcode and try to compile...

Build failed from command line Xcode 12.5 (12E262)

792764219_Capturedcranle2021-05-0812_34_21.png.bf4c3fef617c84d5b1a9e8d150336a3d.png

Edited by chris1111

With 2eb35b70

 

meunier@MACBOOKPRO CloverConfigPlistValidator % xcodebuild -target CloverConfigPlistValidator

Command line invocation:

    /Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -target CloverConfigPlistValidator

...

RegisterExecutionPolicyException /Users/meunier/CloverBootloader/Xcode/CloverConfigPlistValidator/build/Release/CloverConfigPlistValidator (in target 'CloverConfigPlistValidator' from project 'CloverConfigPlistValidator')

    cd /Users/meunier/CloverBootloader/Xcode/CloverConfigPlistValidator

    builtin-RegisterExecutionPolicyException /Users/meunier/CloverBootloader/Xcode/CloverConfigPlistValidator/build/Release/CloverConfigPlistValidator

 

** BUILD SUCCEEDED **

  • Like 2
On 5/5/2021 at 1:53 PM, Jief_Machak said:

Could just the fact that there is a bit more log. Each log line open a file, write, and close (to flush). Not the quickest operation.

What you can do to compare is to start with boot/debug set to false and save preboot.log with F2.

Do that with both version and send me these logs. The last time I made something inefficient, it added 12 seconds to the boot !

once the parser warnings were eliminated/commented out, boot time was consistent with previous versions. all good now.

4 hours ago, Jief_Machak said:

If this app is still alive, I could work with the guy so his app integrate the source code of the validator in Clover Configurator app. That'll ensure that the generated XML is 100% correct.

Do you know if the app is still alive and who make this app ?

He did a similar app Open Core Configurator that has Opencore validator tool integrated, so i think could easily fix all the issues and add validator as well in the Clover Configurator app.

Thanks a lot for your work Jief.

15 hours ago, Jief_Machak said:

If this app is still alive, I could work with the guy so his app integrate the source code of the validator in Clover Configurator app. That'll ensure that the generated XML is 100% correct.

Do you know if the app is still alive and who make this app ?

He is mackie100. Ten years ago he decided to make private project and may be commercial and rejected our requests for cooperation.

The project is still popular in the net despite on our opinion.

For example

https://www.applelife.ru/threads/rekomenduemye-redaktory-plist-fajlov-xml-i-pochemu-ne-konfigurator.41550/ 

About CCPV I don't think it should has "_5134". It is the user affair to keep and rename version.

The installer will just replace old version to new. Let it be only new version.

May be add a functionality to it to check Clover version currently installed and say something like

"... you are booted with Clover 5119 while using club canin for 5134...". :D

  • Like 3
2 hours ago, Slice said:

About CCPV I don't think it should has "_5134". It is the user affair to keep and rename version.

The installer will just replace old version to new. Let it be only new version.

May be add a functionality to it to check Clover version currently installed and say something like

"... you are booted with Clover 5119 while using club canin for 5134...". :D

Ideally, we should have a version number for the plist that is independent of Clover version number. Because many release shared the same plist definition. If that version would be in the config plist itself, it means we could maintain a backward compatibility while evolving. The validator could know all the different version and validate accordingly.

If you look inside the code, it'll be quite easy with this new parser. For example, if a config-v1.2.plist that has a slightly modified GUI section but all the reset is identical, only the Config_GUI.h would be modified ( or subclassed if it's an addition).

In that case, there would only one validator that can validate all.

 

Ok, that would be amazing, but do we really need it ? The config.plist doesn't change much. And now the validator is there, if we make a non-compatible change, the user who is trying to update an old config.plist will know quickly.

And I kind of want to reduce my Clover todo list instead of increasing it.

 

If we stay like this, we can't automatically know the corresponding clover version. Except if you run the validator on one configplist located in a Clover folder that does not contains multiple version of a clover efi file. If I have few version (including intermediary commits) , let's say, from 5132 to 5134, the validator cannot know if what it is validating will work in 5132 as well as 5134.

In the other hand, the installer pkg is probably more for people who don't play with multiple efi file in one clover folder, and who don't have hundreds of config.plist from a lot of people (that's me :lol:).

 

There's pros and cons... I personally always rename ALL the apps I used (including big apps like Firefox, Chrome, etc.) with a version number in the name. Very handy when you have multiple version of an app because you see the version number in the "Open with..." menu for example.

In the case you install the new version, probably upgrade and never downgrade, and ccpv is installed somewhere with a fixed name, it could make it easier for regular user..

 

Story short, what am I saying ? Version number in the name or not ?

Hum, I think I realise, writing this, that I don't know...:hysterical:

 

3 hours ago, Slice said:

rejected our requests for cooperation

Too bad for him. He would have had more donation if there weren't this bugs and if we support it.

Whatever, my todo list's long enough.

  • Like 4
4 hours ago, Slice said:

About CCPV I don't think it should has "_5134". It is the user affair to keep and rename version.

The installer will just replace old version to new. Let it be only new version.

May be add a functionality to it to check Clover version currently installed and say something like

"... you are booted with Clover 5119 while using club canin for 5134...". :D

No worries, ccpv will have no versioning in it,

it will have that reference only if you build it manually

 

Btw, should i remove the preference pane and updater from installer, before committing?

Edited by LAbyOne
11 hours ago, matxpa said:

(??? in French in the text ?)

:lol: No, not in French in the text :hysterical:

11 hours ago, matxpa said:

There's pros and cons...

That's proper english, if I'm not mistaken. Yes, yes, they say that.

 

8 hours ago, naiclub said:

Sorry, no idea. Is that a new thing ? Which version of Clover works, if any ?

  • Like 3
×
×
  • Create New...