maclinuxG4 Posted May 3, 2021 Share Posted May 3, 2021 still too with r5134 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757037 Share on other sites More sharing options...
Slice Posted May 3, 2021 Share Posted May 3, 2021 5 hours ago, Matgen84 said: Hi @MacKonsti CloverConfigPlistValidator is not a part of Clover Binaries (Releease r5134). The project is independent. The mention "dirty", maybe because it's a @Jief_Machak project Beta (ongoing development) and he do not put it to Release in GitHub repo. It is in Release 5134 3 hours ago, Cyberdevs said: @Allan I'm doing fine thanks, I hope you're doing great as well. You're welcome bro To be honest I don't know if we can disable these messages or how to disable them, I guess it's a part of the new Clover like OpenCore and it's a very useful addition to Clover IMHO, but maybe @Slice or @Jief_Machak can explain wether we can disable these messages or not. These release we will see the messages to fix all errors in your config-plists. Next release I'll hide these messages. 2 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757042 Share on other sites More sharing options...
Cyberdevs Posted May 3, 2021 Share Posted May 3, 2021 34 minutes ago, Slice said: It is in Release 5134 These release we will see the messages to fix all errors in your config-plists. Next release I'll hide these messages. I think if we have the option to toggle between showing/hiding these messages would be a nice addition so is it possible to have it as an option? 1 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757044 Share on other sites More sharing options...
Matgen84 Posted May 3, 2021 Share Posted May 3, 2021 47 minutes ago, Slice said: It is in Release 5134 These release we will see the messages to fix all errors in your config-plists. Next release I'll hide these messages. 11 minutes ago, Cyberdevs said: I think if we have the option to toggle between showing/hiding these messages would be a nice addition so is it possible to have it as an option? I think too. A addition with Debug (in config.plist) for example. but currently anyway, if the config.plist is correct, there are no messages. 3 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757045 Share on other sites More sharing options...
Jief_Machak Posted May 3, 2021 Share Posted May 3, 2021 I don't understand why you want to hide warnings. Why would you want to keep problems in your config.plist ??? It's not a lot of work to clean. It's usually because of unknown keys, like "Ignore" in custom entries that never existed that I saw a lot. I called them warnings because Clover will "correct" and "ignore" this problems, but it is still problems. Just take 5 minutes and correct, and you won't need an ignore option. The day you'll immediately realise that your config plist modification doesn't work because of a misspelling, you'll be happy to get warning at Clover start. I'm a democratic guy. If a majority of people can convince that it is good to keep wrong keys in config.plist, I'll do the option... 9 2 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757046 Share on other sites More sharing options...
Cyberdevs Posted May 3, 2021 Share Posted May 3, 2021 @Jief_Machak +1 I vote for keeping it as an option for debugging the config.plist, but as I mentioned earlier it's nice to be able to turn it on and off Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757048 Share on other sites More sharing options...
kushwavez Posted May 3, 2021 Share Posted May 3, 2021 I don't think it is necessary. Just fix it, and that's it. It is a good thing. If there is an update for Clover that changes or add something, then you won't see it if you disable the option. Let's just keep it "enabled". 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757049 Share on other sites More sharing options...
Matgen84 Posted May 3, 2021 Share Posted May 3, 2021 @Jief_Machak I'm agree with you and @kushwavez: Let's just keep it "enabled", now and for next Clover Release. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757051 Share on other sites More sharing options...
chris1111 Posted May 3, 2021 Share Posted May 3, 2021 2 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757066 Share on other sites More sharing options...
Jief_Machak Posted May 3, 2021 Share Posted May 3, 2021 2 hours ago, Cyberdevs said: I vote for keeping it as an option for debugging the config.plist, but as I mentioned earlier it's nice to be able to turn it on and off What I'd like to understand is why it is nice to turn it off instead of fixing your config.plist. 7 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757072 Share on other sites More sharing options...
Guest 5T33Z0 Posted May 3, 2021 Share Posted May 3, 2021 Just leave it enabled with an ignore option. It's a good feature for finding and fixing possible config errors. And as long as there are no config issues you won't notice it anyway. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757076 Share on other sites More sharing options...
LockDown Posted May 3, 2021 Share Posted May 3, 2021 Like in cars, do you want to disable all sensors? Just leave clover enabled by default so it can detect faults. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757089 Share on other sites More sharing options...
Cyberdevs Posted May 4, 2021 Share Posted May 4, 2021 10 hours ago, Jief_Machak said: What I'd like to understand is why it is nice to turn it off instead of fixing your config.plist. When Slice said he'll turn it off in the next release I thought it will be disabled for good and what I meant was to have the option to turn it on back again if someone wanted it to be enabled, but now that I understand the concept that it will show the messages when there is an issue with the config I'd say just leave it enabled. 2 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757092 Share on other sites More sharing options...
Jief_Machak Posted May 4, 2021 Share Posted May 4, 2021 2 minutes ago, Cyberdevs said: When Slice said he'll turn it off Oh, I didn't see that. Sorry, my bad. There was quite a few pages of this forum I missed. I think it should stay on, because we know that we will use the validator, most of the time only after we know there is a problem. Knowing that Clover will notify if there is one is a good thing. Looks like we mainly agree on this. That said, a notification at Clover GUI instead of text messages before the GUI would be nicer... But my days has only 24 hours... 3 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757093 Share on other sites More sharing options...
Slice Posted May 4, 2021 Share Posted May 4, 2021 Enable/Disable the feature is problematic because it can be written in config.plist which we have to check. Сhicken or egg? 3 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757094 Share on other sites More sharing options...
Jief_Machak Posted May 4, 2021 Share Posted May 4, 2021 On 4/29/2021 at 9:32 PM, Slice said: Validator was built successfully. I got such messages Error: Unexpected tag 'true' at line 103 col 47. Was expecting <key>. Warning: Unknown key '/ACPI/_SB.PCI0.RP03.PXSX:153'. Skipped. Warning: Unknown key '/SSDT:156'. Skipped. I don't understand config.plist 2.zip 3.66 kB · 7 downloads I've just reproduced that. What happen si that DEBUG version do it right and RELEASE version is wrong ! Having a look. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757095 Share on other sites More sharing options...
Slice Posted May 4, 2021 Share Posted May 4, 2021 5 minutes ago, Jief_Machak said: I've just reproduced that. What happen si that DEBUG version do it right and RELEASE version is wrong ! Having a look. Yes, I uploaded DEBUG version compiled without JIEF_DEBUG , because RELEASE is wrong. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757096 Share on other sites More sharing options...
Cyberdevs Posted May 4, 2021 Share Posted May 4, 2021 @Jief_Machak It's ok man, maybe I should have explained it better to avoid any confusions. lol @Slice I don't want to cause any troubles for you guys you are already doing more than enough on this project so let's just leave it enabled and if so there is no need to make it optional. And thanks as always for your input and your support guys 2 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757097 Share on other sites More sharing options...
Slice Posted May 4, 2021 Share Posted May 4, 2021 There is also a small bug with line numeration: 122 instead of 123 and so on. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757098 Share on other sites More sharing options...
Jief_Machak Posted May 4, 2021 Share Posted May 4, 2021 14 minutes ago, Slice said: Yes, I uploaded DEBUG version compiled without JIEF_DEBUG , because RELEASE is wrong. If I compile without optimization, Release works fine... Wondering how is that possible, considering it's simple with no "tricks" or anything that's supposed to generate optimization errors... 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757100 Share on other sites More sharing options...
maclinuxG4 Posted May 4, 2021 Share Posted May 4, 2021 hello i am still with R5133, i make each time compile ,and install . https://github.com/CloverHackyColor/CloverBootloader/commit/f28e98fb3330990e357476dc6bf784453e3c67df https://github.com/CloverHackyColor/CloverBootloader/commit/51d5d4a141e92dfa8337b82d06bd41be686b5082 @Jief_Machak could you generate a version to test ? thanks Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757102 Share on other sites More sharing options...
kushwavez Posted May 4, 2021 Share Posted May 4, 2021 (edited) @maclinuxG4 I don't really understand your question but if you want the latest, Clover v5134 is the latest, with the latest commits available. Validator also included on the git release page Edited May 4, 2021 by kushwavez 2 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757105 Share on other sites More sharing options...
kushwavez Posted May 4, 2021 Share Posted May 4, 2021 (edited) @Jief_Machak Just an idea. What if a new key or some new features added in Clover? Could the Validator notify us that there is such key, but not defined in config.plist? For example: Key "IsCloverTheBest" is undefined, Type Boolean, using default value "True" or something like that. That would also good for another, existing keys too to see that they're existing, but unused OR used with default values. Edited May 4, 2021 by kushwavez Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757106 Share on other sites More sharing options...
maclinuxG4 Posted May 4, 2021 Share Posted May 4, 2021 it is simply: before a new change, and many of us have to modify config.plist, it would be nice to have a tag to take before this evolution the previous version was tag 23 days before. it is suitable to reduce the frontier of the investigation. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757109 Share on other sites More sharing options...
Jief_Machak Posted May 4, 2021 Share Posted May 4, 2021 On 4/29/2021 at 1:56 PM, kushwavez said: Yes of course. Here you are: X1C6_config_and_logs.zip Looks like a crash is DSDT pacthing... surprising. Please try this efi : CloverX64-2021-05-04-13-36-24-ee78cb9-dirty-jief.zip and send me the log. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1068/#findComment-2757118 Share on other sites More sharing options...
Recommended Posts