Clover General discussion

[Jief_Machak]

2 hours ago, kushwavez said:

Thanks, man, if there were more devs like you... 

Here you are

DSDT_and_log.zip 61.27 kB · 0 downloads

@kushwavez Did you have an error message on the screen finishing with "A fatal error happened. System halted" ?

Try this, with fix airport enabled : CloverX64-2021-05-05-23-30-57-d52803e-dirty-jief.zip

 

2 hours ago, Slice said:

How shall I do this?

iMac2017:CloverBootloader sergey$ git commit -a -s -m "submodule changed"
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
	modified:   OpenCorePkg (untracked content)

 

You have to add that "change" like you any other. It's a submodule instead of a file, but that the same idea.

Probably "git add OpenCorePkg". I have to admit I never did on command line.

[tluck]

ok finally able to boot 5134... FWIW,  here are my diffs from 5133 to 5134. it takes 2 seconds longer ...  but i think that is pause from showing the parsing logs issues?
 

$ diff 5133.log 5134.log 
2c2
< -05 TIME: 12:48:03
---
> -05 TIME: 12:30:15
4c4
<  MemLog inited, TSC freq: 2491905600
---
>  MemLog inited, TSC freq: 2491906440
6c6,7
<  CloverX64 : Image base = 0xD6E34000
---
>  CloverX64 : Image base = 0xD6E08000
>  Clover ImageHandle = d8157c98
8,10c9,11
<  Now is 05.05.2021,  19:47:31 (GMT)
<  Starting Clover revision: 5133 (master, commit 51d5d4a14) on Lenovo EFI
<  Build id: 20210428210028-51d5d4a
---
>  Now is 05.05.2021,  19:29:41 (GMT)
>  Starting Clover revision: 5134 (master, commit d52803e7c) on Lenovo EFI
>  Build id: 20210505201010-d52803e
13d13
<  === [ GetDefaultSettings ] ======================
56d55
<  === [ GetDefaultCpuSettings ] ===================
57a57
>  Found more than one GOP protocol ??? Using the first one
63c63,64
<   - LAN: 0 Vendor=Intel
---
>   - LAN: 1 Vendor=Intel
>  Legacy MAC address of LAN #0= 00:21:CC:5D:55:05:
81,82c82
<  Clover load options size = 0 bytes
<  _checkOEMPath Look for oem dir at path '\EFI\CLOVER\OEM\4236ED7--00-00-00-00-00-00'. Dir doesn't exist.
---
>  _checkOEMPath Look for oem dir at path '\EFI\CLOVER\OEM\4236ED7--00-21-CC-5D-55-05'. Dir doesn't exist.
84a85
>  === [ GetUserSettings ] =========================
86c87,110
<  \EFI\CLOVER\OEM\4236ED7\config.plist  loaded: Success
---
>  There is problems in plist '\EFI\CLOVER\OEM\4236ED7\config.plist'
>  Warning: Unknown key '/ACPI/DSDT/Fixes/NewWay_80000000:15'. Skipped.
>  Warning: Unknown key '/Boot/IgnoreNVRAMBoot:75'. Skipped.
>  Warning: Unknown key '/Boot/UseAlternateLogo:83'. Skipped.
>  Warning: Unknown key '/GUI/Mouse/DoubleClick:285'. Skipped.
>  Warning: Unknown key '/Graphics/EDID/Comment:318'. Skipped.
>  Warning: Unknown key '/Quirks/AppleCpuPmCfgLock:472'. Skipped.
>  Warning: Unknown key '/Quirks/AppleXcpmCfgLock:474'. Skipped.
>  Warning: Unknown key '/Quirks/CustomSMBIOSGuid:482'. Skipped.
>  Warning: Unknown key '/Quirks/DisableRtcChecksum:490'. Skipped.
>  Warning: Unknown key '/Quirks/LapicKernelPanic:514'. Skipped.
>  Warning: Unknown key '/Quirks/PanicNoKextDump:516'. Skipped.
>  Warning: Unknown key '/Quirks/ProvideConsoleGopEnable:526'. Skipped.
>  Use CloverConfigPlistValidator or look in the log
>  Cannot find smbios.plist at path '\EFI\CLOVER' : Not Found
>  '\EFI\CLOVER\smbios.plist' not loaded. Efi error Not Found
>  BiosVersion: not set, Using BiosVersion from clover
>  BiosVersion: MBP81.88Z.F000.B00.1906132217
>  BiosReleaseDate: not set, Using BiosReleaseDate from clover
>  BiosReleaseDate: 06/13/19
>  
>  Using EfiVersion from clover: 87.0.0.0.0
>  Calibrated TSC Frequency = 2491906440 = 2491MHz
>  GOP found at: 
93,104d116
<  === [ GetEarlyUserSettings ] ====================
<  timeout set to 5
<  KextsToPatch: 7 requested
<   - [00]: com.apple.driver.AppleIntelSNBGraphicsFB (Patch Framebuffer to Replace 4th port with VGA) :: BinPatch :: data len: 60
<   - [01]: com.apple.iokit.IOAHCIBlockStorage (TRIM for SSD) :: BinPatch :: data len: 9
<   - [02]: com.apple.driver.AppleAHCIPort (fix IO error ICH10 for 10.15, credit vit9696) :: MatchOS: 10.15.x :: BinPatch :: data len: 4
<   - [03]: com.apple.driver.AppleAHCIPort (fix IO error ICH10 for 10.13, credit SunKi) :: MatchOS: 10.13.x :: BinPatch :: data len: 20
<   - [04]: com.apple.driver.AppleAHCIPort (fix hotplug ICH10 for 10.13, credit SunKi) :: MatchOS: 10.13.x :: BinPatch :: data len: 26
<   - [05]: com.apple.driver.AppleIntelSNBGraphicsFB (1024MB memory) :: MatchOS: 10.13.x,10.14.x,10.15.x :: BinPatch :: data len: 7
<   - [06]: com.apple.driver.AppleIntelSNBGraphicsFB (Sierra 1024MB memory) :: MatchOS: 10.12.x :: BinPatch :: data len: 7
<  Hiding entries with string Preboot
<   Custom EDID is ok
106c118,119
<  Loading ApfsDriverLoader.efi  status=Success
---
>  Loading ApfsDriverLoader.efi status=Success
>  ChildImaheHandle=d77fc818
108,109c121,124
<  Loading SMCHelper.efi  status=Success
<  Loading AudioDxe.efi  status=Success
---
>  Loading SMCHelper.efi status=Success
>  ChildImaheHandle=d862c418
>  Loading AudioDxe.efi status=Success
>  ChildImaheHandle=d862c898
111c126,127
<  Loading HfsPlusLegacy.efi  status=Success
---
>  Loading HfsPlusLegacy.efi status=Success
>  ChildImaheHandle=d862cd98
130d145
<  === [ GetMacAddress ] ===========================
156,183d170
<  Calibrated TSC Frequency = 2491905600 = 2491MHz
<  === [ GetUserSettings ] =========================
<   Custom EDID is ok
<  Add 1 properties:
<   - [00]: IntelGFX Key: AAPL00,DualLink, len: 4
<  USB FixOwnership: yes
<   - final DSDT Fix mask=10000000
<  C3Latency: 0
<  MinMultiplier: 0
<  MaxMultiplier: 0
<  PluginType: 0
<  ResetAddr: 0xCF9
<  Calc ResetVal: 0x6
<  ResetVal: 0x6
<  ProductName SETTINGS_DATA=MacBookPro8,1
<  ProductName setting=MacBookPro8,1
<  ProductName new SETTINGS_DATA=MacBookPro8,1
<  SetDMISettingsForModel=25
<  Using ProductName : MacBookPro8,1
<  BiosVersion: not set, Using BiosVersion from clover
<  BiosVersion: MBP81.88Z.F000.B00.1906132217
<  BiosReleaseDate: 06/13/19
<  Using EfiVersion from clover: 87.0.0.0.0
<  Using FirmwareFeatures from clover: 0xC00DE137
<  Using FirmwareFeaturesMask from clover: 0xFF1FFF3F
<  PlatformFeature will not set in SMBIOS
<  gSettings.Smbios.SerialNr: C02FKGR8DH2G
<  void ParseSMBIOSSettings(SETTINGS_DATA &, const TagDict *) : BoardVersion: MacBookPro8,1
190d176
<  Cannot find smbios.plist at path '\EFI\CLOVER' : Not Found
448c434
<   OC: OpenCore DBG-061-2021-04-28 is loading in Optional mode (0/0)...
---
>   OC: OpenCore DBG-061-2021-05-05 is loading in Optional mode (0/0)...
450c436
<   OC: Current version is DBG-061-2021-04-28
---
>   OC: Current version is DBG-061-2021-05-05
482c468
<   OCC: Install console control (D6F78EF0/0/0), current - Success
---
>   OCC: Install console control (D6F750B0/0/0), current - Success
492c478
<   OCB: Arch filtering D56D3018(617016)->D56D3018(617016) caps 4 - Success
---
>   OCB: Arch filtering D56AC018(617016)->D56AC018(617016) caps 4 - Success
510,512c496,498
<   void PatchTableType1() : UpdateSmbiosString ProductName=MacBookPro8,1
<   void PatchTableType2() : UpdateSmbiosString ProductName=BoardNumber=Mac-94245B3640C91C81
<   void PatchTableType2() : UpdateSmbiosString Version=BoardVersion=MacBookPro8,1
---
>   void PatchTableType1(const SmbiosInjectedSettings &) : UpdateSmbiosString ProductName=MacBookPro8,1
>   void PatchTableType2(const SmbiosInjectedSettings &) : UpdateSmbiosString ProductName=BoardNumber=Mac-94245B3640C91C81
>   void PatchTableType2(const SmbiosInjectedSettings &) : UpdateSmbiosString Version=BoardVersion=MacBookPro8,1
612,613c598,599
<   SetNvramVariable (UIScale, guid, 0x7, 1): -> writing new (Success)
<   SetNvramVariable (EFILoginHiDPI, guid, 0x7, 4): -> writing new (Success)
---
>   DeleteNvramVariable (UIScale, guid = Not Found):
>   DeleteNvramVariable (EFILoginHiDPI, guid = Not Found):

 

Edited May 5, 2021 by tluck

[Jief_Machak]

2 hours ago, Slice said:

My mistake.

Anyway my version of CloverConfigPlistValidator compiled with sdk10.11 works everywhere!

No problem. I imagine that using macosx instead of macosx10.11 allows people to compile on different configuration as xcode will take any sdk available.

Personally, I have sdk 10.14 if I compile on command line and 10.15 if I compile with xcode

In the end, the validator doesn't use at all the macos sdk !

[Jief_Machak]

5 minutes ago, tluck said:

it takes 2 seconds longer

Could just the fact that there is a bit more log. Each log line open a file, write, and close (to flush). Not the quickest operation.

What you can do to compare is to start with boot/debug set to false and save preboot.log with F2.

Do that with both version and send me these logs. The last time I made something inefficient, it added 12 seconds to the boot !

[Jief_Machak]

1 hour ago, Common_Sense said:

Since we use OC runtime

Almost only for the kernel patching part and the Quirks part.

The discovery of bootable volumes and what's in the menu is done like before and way before OC is initialised.

 

I never really understood why I would like to see my APFS volume but not my HFS ones (or the other way around). If a volume shows up and you don't like, there is a possibility to hide it.

 

That said, we're open to feature request discussions. What do you find interesting in ScanPolicy from OC, exactly ?

[kushwavez]

48 minutes ago, Jief_Machak said:

@kushwavez Did you have an error message on the screen finishing with "A fatal error happened. System halted" ?

No I didn't, just a black screen after selecting Preboot.

 

48 minutes ago, Jief_Machak said:

Try this, with fix airport enabled : CloverX64-2021-05-05-23-30-57-d52803e-dirty-jief.zip

It boots with this. What was the cause?

Now the only thing remains is the non-working iGPU.

 

Here is the log from that efi

2021-05-05_21-10_CloverX64-2021-05-05-23-30-57-d52803e-dirty-jief.efi.log

Edited May 5, 2021 by kushwavez

[Slice]

6 hours ago, Jief_Machak said:

 

You have to add that "change" like you any other. It's a submodule instead of a file, but that the same idea.

Probably "git add OpenCorePkg". I have to admit I never did on command line.

There are problems

https://stackoverflow.com/questions/50167969/how-to-fix-modified-content-untracked-content-in-git

The solution #8.

[Jief_Machak]

3 hours ago, Slice said:

There are problems

https://stackoverflow.com/questions/50167969/how-to-fix-modified-content-untracked-content-in-git

The solution #8.

NOOOOO !

You've just removed OpenCorePkg as a submodule and committed as an ordinary submodule. That means we lost all history.

There wasn't any problems. When I told you, I had done the commit and everything was fine.

Updating OC code while preserving our modification will now be a nightmare.

 

Sorry, but I had to cancel (not revert) that commit. You'll get something like your repo has diverged if you try to commit. You have to go back to commit d52803e7cd7481346b0c6a28f328aa5243e9658d (with git reset --hard {sha}) to be able to fetch and pull.

Or maybe just re-clone from scratch.

On 5/5/2021 at 7:50 AM, Jief_Machak said:

"I lost time" : I think I understand now.

But you have to send at least some logs if you want us to look.

 

 

Wouldn't it be handy if you create a pull request ?

@LAbyOne Hi, are you still there ?

Tell me when you'll have some time so we can agree on how to finish the integration of the build of the validator.

Thanks for the work.

[Jief_Machak]

5 hours ago, MifJpn said:

Please help everyone.
I'm testing CloverConfigPlistValidator to Build with Xcode 12.4. (Successful with Xcode 11.3.1)
The following error will occur.

 

% pwd
/Users/alpha/CloverBootloader/Xcode/CloverConfigPlistValidator
% xcodebuild -version
Xcode 12.4
Build version 12D4e
% mkdir $HOME/Desktop/CloverConfigPlistValidator
% xcodebuild ARCHS=x86_64 ONLY_ACTIVE_ARCH=YES -scheme CloverConfigPlistValidator clean build CONFIGURATION_BUILD_DIR=$HOME/Desktop/CloverConfigPlistValidator >error.txt                    
** BUILD FAILED **

The following build commands failed:
    CompileC /Users/alpha/Library/Developer/Xcode/DerivedData/CloverConfigPlistValidator-bkzmbgpcdtudzeebllzdkxobhvun/Build/Intermediates.noindex/CloverConfigPlistValidator.build/Release/CloverConfigPlistValidator.build/Objects-normal/x86_64/Platform.o /Users/alpha/CloverBootloader/Xcode/CloverConfigPlistValidator/src/Platform.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
    CompileC /Users/alpha/Library/Developer/Xcode/DerivedData/CloverConfigPlistValidator-bkzmbgpcdtudzeebllzdkxobhvun/Build/Intermediates.noindex/CloverConfigPlistValidator.build/Release/CloverConfigPlistValidator.build/Objects-normal/x86_64/BootLog.o /Users/alpha/CloverBootloader/rEFIt_UEFI/PlatformPOSIX/BootLog.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(2 failures)

error.txt 154.07 kB · 2 downloads

I'm currently studying Build in Xcode.
Thank you in advance.

(I can build CloverBootloder with Xcode12.4, ./bulidme and select 7 )

 

Fixed.

Please use "xcodebuild -target CloverConfigPlistValidator" instead of using the option "-scheme" to compile. Compiling through a scheme doesn't really make sense as schemes are made for running into xcode and don't contains any build settings.

[Jief_Machak]

11 hours ago, kushwavez said:

No I didn't, just a black screen after selecting Preboot.

Strange! Because I fixed a panic, not a crash. And I had the message when I tried with your DSDT...

I've added the panic in the log (it was only screen before) so I can have it.

 

11 hours ago, kushwavez said:

What was the cause?

Before, there was an array of devices that has 16 slots even if less than 16 was needed. Empty slots were just initialised to 0. Accessing an empty slots was valid.

Now, I store only the valid one. Empty slots doesn't exists, therefore trying to access one of them is invalid and generate a panic (panic is a proper message saying that there was something wrong and the program cannot recover).

I added a method that return an empty slots (initialised to 0) when the asked slots doesn't exist.

 

11 hours ago, kushwavez said:

Here is the log from that efi

In this log, there is :

add device: PciRoot(0x0)/Pci(0x2,0x0)
   Add key=@d�N valuelen=4
   Add key=@d�N valuelen=4
   Add key=@d�N valuelen=8
   Add key=@d�N valuelen=4
   Add key=@d�N valuelen=4
   Add key=@d�N valuelen=4
   Add key=@d�N valuelen=4
   Add key=@d�N valuelen=4
   Add key=@d�N valuelen=4

Try this version : CloverX64-2021-05-06-11-45-56-243f6d7-dirty-jief.zip and you should see instead :

add device: PciRoot(0x0)/Pci(0x2,0x0)
   Add key=framebuffer-stolenmem valuelen=4
   Add key=framebuffer-con1-type valuelen=4
   Add key=complete-modeset-framebuffers valuelen=8
   Add key=AAPL,ig-platform-id valuelen=4
   Add key=framebuffer-con1-enable valuelen=4
   Add key=framebuffer-fbmem valuelen=4
   Add key=device-id valuelen=4
   Add key=framebuffer-patch-enable valuelen=4
   Add key=complete-modeset valuelen=4

Looks better, right ?

 

I hope it also works better ! (if it works, just tell me so I can commit. No need for log).

[kushwavez]

@Jief_Machak yep, it's good now.

Thanks!

[LAbyOne]

3 hours ago, Jief_Machak said:

@LAbyOne Hi, are you still there ?

Tell me when you'll have some time so we can agree on how to finish the integration of the build of the validator.

Thanks for the work.

Whenever you'r ready, btw thanks to you for fixing the 12.5 issue

Edited May 6, 2021 by LAbyOne

[maclinuxG4]

strange i use the last debug version proposed by jief.

Without any change of config.plist , i boot finally, it s take time.

 

 

Edited May 6, 2021 by maclinuxG4

[Jief_Machak]

59 minutes ago, LAbyOne said:

Whenever you'r ready, btw thanks to you for fixing the 12.5 issue

You're welcome.

Could you submit a pull request, maybe ? So you'll keep the credits and it'll be easy for future adjustment if needed.

 

[matxpa]

2 hours ago, Jief_Machak said:

Fixed.

Please use "xcodebuild -target CloverConfigPlistValidator" instead of using the option "-scheme" to compile. Compiling through a scheme doesn't really make sense as schemes are made for running into xcode and don't contains any build settings.

Hi @Jief_Machak

 

CloverConfigPlistValidator compiled on BS 11.3.1 (20E241) with commit 243f6d7b3 Fix validator xcode 12.5 compilation problem.

 

Spoiler

On a

Laptop Ivy Bridge i5-3340M with 
    Big Sur 11.3.1 (20E241)
    Xcode Version 12.5 (12E262)
    Apple clang version 12.0.5 (clang-1205.0.22.9)

meunier@MACBOOKPRO CloverConfigPlistValidator % pwd
/Users/meunier/CloverBootloader/Xcode/CloverConfigPlistValidator

 

meunier@MACBOOKPRO CloverConfigPlistValidator % xcodebuild -quiet -target CloverConfigPlistValidator

 

meunier@MACBOOKPRO CloverConfigPlistValidator % cd build/Release
meunier@MACBOOKPRO Release % ls -ltr
total 2360
drwxr-xr-x  3 meunier  staff       96  6 mai 11:01 CloverConfigPlistValidator.dSYM
-rwxr-xr-x  1 meunier  staff  1204688  6 mai 11:53 CloverConfigPlistValidator

 

meunier@MACBOOKPRO Release % ./CloverConfigPlistValidator /Volumes/EFI/EFI/CLOVER/config.plist 
Your plist looks so wonderful. Well done!
 

 

Edited May 6, 2021 by matxpa

[Slice]

4 hours ago, Jief_Machak said:

NOOOOO !

You've just removed OpenCorePkg as a submodule and committed as an ordinary submodule. That means we lost all history.

There wasn't any problems. When I told you, I had done the commit and everything was fine.

Updating OC code while preserving our modification will now be a nightmare.

 

Sorry, but I had to cancel (not revert) that commit. You'll get something like your repo has diverged if you try to commit. You have to go back to commit d52803e7cd7481346b0c6a28f328aa5243e9658d (with git reset --hard {sha}) to be able to fetch and pull.

Or maybe just re-clone from scratch.

@LAbyOne Hi, are you still there ?

Tell me when you'll have some time so we can agree on how to finish the integration of the build of the validator.

Thanks for the work.

I will re-clone the whole project.

[LAbyOne]

1 hour ago, Jief_Machak said:

You're welcome.

Could you submit a pull request, maybe ? So you'll keep the credits and it'll be easy for future adjustment if needed.

 

yes, but before that i've a stupid question to ask.. about the buildme

 

1) this is how just integrates CloverConfigPlistValidator (8)

 

2) or would be better have a  Clover Utilities menu (15)  

( I added the newparser here just to give the idea...)

for future additions?

what do you think?

[Jief_Machak]

@LAbyOne I like the utilities menu, but please remove "by jief". Who knows, we may attract some developer one day 

Will it be built in the option "build all" ?

[LAbyOne]

44 minutes ago, Jief_Machak said:

@LAbyOne I like the utilities menu, but please remove "by jief". Who knows, we may attract some developer one day 

Will it be built in the option "build all" ?

Jief removed ...

 

it will be built as standalone (from utilities) , into build  pkg, and build all

P.S.

All Utilities, will be built into /Applications/CloverUtilities as i had really no idea where to move the files, as per my own use i would hap placed them into $HOME/src you will see and manage the way you think most appropriated

PP.SS

pull done

PPP.SSS

I forgot to modify 2 files to reflect the last modifications to buildme, i will pull it again in a few minutes. Sorry.

Edited May 6, 2021 by LAbyOne

[chris1111]

 

Build CloverConfigPlistValidator

 

xcodebuild -project $HOME/src/CloverBootloader/Xcode/CloverConfigPlistValidator/CloverConfigPlistValidator.xcodeproj -alltargets -configuration Release

Open $HOME/src/CloverBootloader/Xcode/CloverConfigPlistValidator/build/Release

 

Edited May 6, 2021 by chris1111

[matxpa]

@Jief_Machak

 

XCODE8 RELEASE Clover 541182fcd commit compilation on

Laptop Ivy Bridge i5-3340M

Spoiler

XCODE8 RELEASE Clover 541182fcd commit compilation OK and boot(able) on
        Laptop Ivy Bridge i5-3340M with
                Big Sur 11.3.1 (20E241)
                Xcode Version 12.5 (12E262)
                Apple clang version 12.0.5 (clang-1205.0.22.9)

0:148  0:048  === [ Starting Clover ] =========================
0:148  0:000  Now is 06.05.2021,  13:33:42 (GMT)
0:148  0:000  Starting Clover revision: 5134 (master, commit 541182fcd) on American Megatrends EFI
0:148  0:000  Build id: 20210506123544-541182f-dirty
0:148  0:000  Build with: [Args: -D NO_GRUB_DRIVERS_EMBEDDED -D LESS_DEBUG -t XCODE8 | --cmd-len=50000 -D NO_GRUB_DRIVERS_EMBEDDED -D LESS_DEBUG --conf=/Users/meunier/CloverBootloader/Conf -D USE_LOW_EBDA -a X64 -b RELEASE -t XCODE8 -n 5 | OS: 11.3.1]
...
0:148  0:000  Boot status=0
0:148  0:000  Running on: 'X75VB' with board 'X75VB'
0:148  0:000  === [ GetCPUProperties ] ========================
0:148  0:000  CPU Vendor = 756E6547 Model=306A9
0:148  0:000   The CPU supported SSE4.1
0:148  0:000  BrandString = Intel(R) Core(TM) i5-3340M CPU @ 2.70GHz
...

 

 

[Matgen84]

41 minutes ago, LAbyOne said:

Jief removed ...

 

it will be built as standalone (from utilities) , into build  pkg, and build all

P.S.

All Utilities, will be built into /Applications/CloverUtilities as i had really no idea where to move the files, as per my own use i would hap placed them into $HOME/src you will see and manage the way you think most appropriated

PP.SS

pull done

PPP.SSS

I forgot to modify 2 files to reflect the last modifications to buildme, i will pull it again in a few minutes. Sorry.

Great. Thanks  Personally, I build CloverConfigPlistValidator to $HOME/src/tools

[LAbyOne]

2 minutes ago, Matgen84 said:

Great. Thanks  Personally, I build CloverConfigPlistValidator to $HOME/src/tools

I know, but as you can remember,

a quite similar discussion took place when Chris1111 made the default directory for EFI backup $HOME.

So since not everybody build Clover itself, we have to find some "universal" directories for all users...

[Matgen84]

6 minutes ago, LAbyOne said:

I know, but as you can remember,

a quite similar discussion took place when Chris1111 made the default directory for EFI backup $HOME.

So since not everybody build Clover itself, we have to find some "universal" directories for all users...

I remember the discussion for EFI Backup, but the directory is created by the cloverpkg. Will CloverConfigPlistValidator be included in the package? or Build by the Buildme ? I don't understand.

[Jief_Machak]

1 hour ago, LAbyOne said:

Jief removed ...

 

it will be built as standalone (from utilities) , into build  pkg, and build all

P.S.

All Utilities, will be built into /Applications/CloverUtilities as i had really no idea where to move the files, as per my own use i would hap placed them into $HOME/src you will see and manage the way you think most appropriated

PP.SS

pull done

PPP.SSS

I forgot to modify 2 files to reflect the last modifications to buildme, i will pull it again in a few minutes. Sorry.

I thought you would fork the repo to make the pull request. That way it's easy for you to work on your contribution... I can explain if you're not familiar.

1) About putting things in /Applications/CloverUtilities, why don't we build in a clover subfolder (probably CloverPackage) and not put anything outside ? In a general way, I think nothing should be written outside Clover, or maybe in a clear menu item that says "Install in /Applications/CloverUtils" for example.

2) TestNewParser is not a valid tool. It was just a transition test. It's already not working anymore. I shouldn't have committed that.

 

3) I also think that the validator executable file should be renamed with the version at the end. Like CloverConfigPlistValidator-v5135, or it's a build in between release something like CloverConfigPlistValidator-{7 chars sha}