Jump to content

Clover General discussion

ErmaC

By ErmaC,
in Clover

 Share
29,869 posts in this topic

Recommended Posts

Jief_Machak
Jief_Machak
Posted
Posted
10 hours ago, tluck said:

FWIW: had a compile issue with Xcode 12.5 (12.4 is ok)

[CPP] Settings

In file included from /opt/Source/edk2/Clover/rEFIt_UEFI/Platform/Settings.cpp:6:

In file included from /opt/Source/edk2/Clover/rEFIt_UEFI/gui/../Platform/Settings.h:5:

In file included from /opt/Source/edk2/Clover/rEFIt_UEFI/entry_scan/../gui/menu_items/menu_items.h:39:

In file included from /opt/Source/edk2/Clover/rEFIt_UEFI/Platform/KERNEL_AND_KEXT_PATCHES.h:12:

In file included from /opt/Source/edk2/Clover/rEFIt_UEFI/refit/../libeg/libeg.h:43:

  XStringArray_(const XStringArray_& other) : array() {

  ^

/opt/Source/edk2/Clover/rEFIt_UEFI/gui/../cpp_foundation/XStringArray.h:322:7: note: in implicit copy assignment operator for 'XStringArray_<XStringW, XStringWArray>' first required here

class XStringWArray : public XStringArray_<XStringW, XStringWArray>

      ^

/opt/Source/edk2/Clover/rEFIt_UEFI/Platform/KERNEL_AND_KEXT_PATCHES.h:143:7: note: in implicit copy assignment operator for 'XStringWArray' first required here

class KERNEL_AND_KEXT_PATCHES

      ^

/opt/Source/edk2/Clover/rEFIt_UEFI/Platform/Settings.cpp:227:24: note: in implicit copy assignment operator for 'KERNEL_AND_KEXT_PATCHES' first required here

  KernelAndKextPatches = gSettings.KernelAndKextPatches; // Jief : why do we have a duplicated KernelAndKextPatches var inside CUSTOM_LOADER_ENTRY ?

                       ^

1 error generated.

make: *** [/opt/Source/edk2/Clover/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit/OUTPUT/Platform/Settings.obj] Error 1

I think that is only the end of the message (from where the error comes from), not the error message.

Compile with only one job so the message won't get splitted, or send the whole log.

Link to comment
Share on other sites
kushwavez
kushwavez
Posted
Posted
1 hour ago, Jief_Machak said:

Definitely strange !

I have a computer that sometimes, and I haven't figured it out under what circumstances, reboot at Clover loading, and then it's fine for a while. Not the same as you, though.

Maybe, because of the changes between different Clover versions the nvram mixed up, and that's why? Some pc will react like that, some will not, idk.

Just like on routers, if you do a firmware update or downgrade you NEED an nvram reset, otherwise it won't boot, or some modul will be broken because of the differences between the older and newer configuration. It isn't needed on some models, but needed on others.

 

Also, sometimes if I start my X1C6 notebook it is restarting at ealry boot. I can't catch the verbose msg even once, and it's happening very rarely (like once in a week or so), now I'm always booting with "-v debug=0x100" so hopefully I can catch what is causing the early panic.

  • Like 1
Link to comment
Share on other sites
matxpa
matxpa
Posted
Posted
1 hour ago, Jief_Machak said:

I think that is only the end of the message (from where the error comes from), not the error message.

Compile with only one job so the message won't get splitted, or send the whole log.

 

Hi Jief.

 

XCODE8 commit f28e98fb3 compilation errors (Big Sur 11.3 and Xcode Version 12.5 (12E262) on Laptop Asus )

 

 

------------------------------------------------------------------------
buildme, Clover r5133 (SHA: f28e98fb3)
TOOLCHAIN: XCODE8 (override example: './buildme XCODE8')

 1) build Clover
...
[CPP] Settings
In file included from /Users/meunier/CloverBootloader/rEFIt_UEFI/Platform/Settings.cpp:6:
In file included from /Users/meunier/CloverBootloader/rEFIt_UEFI/gui/../Platform/Settings.h:5:
In file included from /Users/meunier/CloverBootloader/rEFIt_UEFI/entry_scan/../gui/menu_items/menu_items.h:39:
In file included from /Users/meunier/CloverBootloader/rEFIt_UEFI/Platform/KERNEL_AND_KEXT_PATCHES.h:12:
In file included from /Users/meunier/CloverBootloader/rEFIt_UEFI/refit/../libeg/libeg.h:43:
/Users/meunier/CloverBootloader/rEFIt_UEFI/gui/../cpp_foundation/XStringArray.h:33:3: error: definition of implicit copy assignment operator for 'XStringArray_<XStringW, XStringWArray>' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy]
  XStringArray_(const XStringArray_& other) : array() {
  ^
/Users/meunier/CloverBootloader/rEFIt_UEFI/gui/../cpp_foundation/XStringArray.h:322:7: note: in implicit copy assignment operator for 'XStringArray_<XStringW, XStringWArray>' first required here
class XStringWArray : public XStringArray_<XStringW, XStringWArray>
      ^
/Users/meunier/CloverBootloader/rEFIt_UEFI/Platform/KERNEL_AND_KEXT_PATCHES.h:143:7: note: in implicit copy assignment operator for 'XStringWArray' first required here
class KERNEL_AND_KEXT_PATCHES
      ^
/Users/meunier/CloverBootloader/rEFIt_UEFI/Platform/Settings.cpp:227:24: note: in implicit copy assignment operator for 'KERNEL_AND_KEXT_PATCHES' first required here
  KernelAndKextPatches = gSettings.KernelAndKextPatches; // Jief : why do we have a duplicated KernelAndKextPatches var inside CUSTOM_LOADER_ENTRY ?
                       ^
1 error generated.
make: *** [/Users/meunier/CloverBootloader/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit/OUTPUT/Platform/Settings.obj] Error 1


build.py...
 : error 7000: Failed to execute command
    make tbuild [/Users/meunier/CloverBootloader/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit]


build.py...
 : error F002: Failed to build module
    /Users/meunier/CloverBootloader/rEFIt_UEFI/refit.inf [X64, XCODE8, RELEASE]

- Failed -


Build end time: 12:32:54, Apr.27 2021
Build total time: 00:04:02

 

Greetings 

  • Sad 1
Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted
49 minutes ago, matxpa said:

XStringArray.h:33:3: error: definition of implicit copy assignment operator for 'XStringArray_<XStringW, XStringWArray>' is deprecated because it has a user-declared copy constructor

Yep, this is the message. And it's a deprecation, that's confirm it was working before.

Ok, I'll create an explicit copy assignment !

 

Try to replace this file (folder rEFIt_UEFI/cpp_foundation) and tell me if it compiles with 12.5, please. If yes, I'll commit.

XStringArray.h

1 hour ago, kushwavez said:

it's happening very rarely (like once in a week or so)

Looks like same as me...

  • Like 1
Link to comment
Share on other sites
matxpa
matxpa
Posted
Posted (edited)
1 hour ago, Jief_Machak said:

Yep, this is the message. And it's a deprecation, that's confirm it was working before.

Ok, I'll create an explicit copy assignment !

 

Try to replace this file (folder rEFIt_UEFI/cpp_foundation) and tell me if it compiles with 12.5, please. If yes, I'll commit.

XStringArray.h 15.36 kB · 1 download

Looks like same as me...

 

Hi Jief, thanks

 

f28e98fb3 XCODE8 compilation done with Xcode 12.5

 

Spoiler

 

------------------------------------------------------------------------

buildme, Clover r5133 (SHA: f28e98fb3)

TOOLCHAIN: XCODE8 (override example: './buildme XCODE8')

 

1) build Clover

...

- Done -

Build end time: 12:34:01, Apr.28 2021

Build total time: 00:05:20

 

  -> CloverX64-RELEASE_XCODE8-20210426210407-f28e98f-dirty.efi

  adding: Users/meunier/CloverBootloader/Build/CloverX64-RELEASE_XCODE8-20210426210407-f28e98f-dirty.efi (deflated 51%)

…

 

Done!

 

------------------------------------------------------------------------

buildme, Clover r5133 (SHA: f28e98fb3)

TOOLCHAIN: XCODE8 (override example: './buildme XCODE8')

 

 

Thanks & Greetings

Spoiler

 

BOOT ok and BootLog (part of) with f28e98f XCODE8 compilation (Big Sur 11.3 & Xcode 12.5)

…

0:148  0:000  Now is 28.04.2021,  11:54:25 (GMT)

0:148  0:000  Starting Clover revision: 5133 (master, commit f28e98fb3) on American Megatrends EFI

0:148  0:000  Build id: 20210426210407-f28e98f-dirty

0:148  0:000  Build with: [Args: -D NO_GRUB_DRIVERS_EMBEDDED -D LESS_DEBUG -t XCODE8 | --cmd-len=50000 -D NO_GRUB_DRIVERS_EMBEDDED -D LESS_DEBUG --conf=/Users/meunier/CloverBootloader/Conf -D USE_LOW_EBDA -a X64 -b RELEASE -t XCODE8 -n 5 | OS: 11.3]

…

0:149  0:000  Boot status=0

0:149  0:000  Running on: 'X75VB' with board 'X75VB'

0:149  0:000  === [ GetCPUProperties ] ========================

0:149  0:000  CPU Vendor = 756E6547 Model=306A9

0:149  0:000   The CPU supported SSE4.1

0:149  0:000  BrandString = Intel(R) Core(TM) i5-3340M CPU @ 2.70GHz

…

 

image.png.0363ec2dfac689eb781eb6be03d20414.png

 

 

Edited by matxpa
  • Like 1
Link to comment
Share on other sites
Slice
Slice
Posted
Posted
Quote

// Jief : why do we have a duplicated KernelAndKextPatches var inside CUSTOM_LOADER_ENTRY ?

There is a bug caused by an incomplete idea to make different patches for each Custom Entry.

If you have an idea what to do then do it.

Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted
2 hours ago, matxpa said:

 

Hi Jief, thanks

 

f28e98fb3 XCODE8 compilation done with Xcode 12.5

 

  Hide contents

 

------------------------------------------------------------------------

buildme, Clover r5133 (SHA: f28e98fb3)

TOOLCHAIN: XCODE8 (override example: './buildme XCODE8')

 

1) build Clover

...

- Done -

Build end time: 12:34:01, Apr.28 2021

Build total time: 00:05:20

 

  -> CloverX64-RELEASE_XCODE8-20210426210407-f28e98f-dirty.efi

  adding: Users/meunier/CloverBootloader/Build/CloverX64-RELEASE_XCODE8-20210426210407-f28e98f-dirty.efi (deflated 51%)

…

 

Done!

 

------------------------------------------------------------------------

buildme, Clover r5133 (SHA: f28e98fb3)

TOOLCHAIN: XCODE8 (override example: './buildme XCODE8')

 

 

Thanks & Greetings

Clear error message = quick resolution :lol:

That's why I love panic messages ;)

2 hours ago, Slice said:

There is a bug caused by an incomplete idea to make different patches for each Custom Entry.

If you have an idea what to do then do it.

Ok, I understand now.

If there is a need, we can have a look on how to do it when my Clover todo list will be a bit shorter :(

I'm preparing the commit for this big change of parser. I moved few files, renamed few thing resulting in changes in a lot of files. So I hope you don't have anything big to commit (your 2 last commits are no problems at all) as it could result in a lot of conflicts.
I hope to commit very soon. Latest in 12/16 hours.

  • Like 1
  • Thanks 2
Link to comment
Share on other sites
tluck
tluck
Posted
Posted
5 hours ago, Jief_Machak said:

Yep, this is the message. And it's a deprecation, that's confirm it was working before.

Ok, I'll create an explicit copy assignment !

Try to replace this file (folder rEFIt_UEFI/cpp_foundation) and tell me if it compiles with 12.5, please. If yes, I'll commit.

XStringArray.h 15.36 kB · 3 downloads

 

this change allowed the compile to complete without errors

  • Like 1
Link to comment
Share on other sites
Slice
Slice
Posted
Posted
16 hours ago, Jief_Machak said:

@everyone : could test this : CloverX64-2021-04-28-02-03-18-afa09cc-dirty-jief.zip Please.

 

 

Looks fine.

 

9 hours ago, Matgen84 said:


One question: Is it normal that every time I change Cloverx64 efi, I have to do F11 several times, to be able to boot. It's the same when I update with the pkg

It is not normal.

Clear NVRAM was invented by Acidanthera because OC smudges NVRAM. Clover no.

We need no clean NVRAM with every reboot. Moreover I never do this and the key F11 on my keyboard is pristine as I never touched it.

  • Like 3
  • Thanks 1
Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted
9 minutes ago, Slice said:

It is not normal.

Clear NVRAM was invented by Acidanthera because OC smudges NVRAM. Clover no.

We need no clean NVRAM with every reboot. Moreover I never do this and the key F11 on my keyboard is pristine as I never touched it.


Thanks @Slice I have not this problem with my IvyBridge (Mojave). Only with my Z390 config (Big Sur). I don't use Reset NVRAM (F11) every reboot, only if I change or update Clover. Before OC-Integration, all works fine using OcQuirks (ReddestDream - GitHub).
Strange !

  • Like 1
Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted
1 minute ago, eng_redaesm said:

working good no issue complied with gcc  but :hysterical: again the compiled commit with xcode blank screen 

Oh yes we still have that thing.

I have to add ctor to all objects as there is a bug in Xcode. We'll see if that improves. If not I will need you help to find the problem. But I'm going away for a few days so that'll next week,

Just now, iCanaro said:

which is the latest version of CloverConfigValidator??? I had stayed at 0.7

It's 0.7 and not up to date. You'll get one tmo, promise ;)

  • Thanks 3
Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted

So you can now compile the validator yourself : just go to Xcode/CloverConfigPlistValidator and open the xcode project. Compile the scheme "CloverConfigPlistValidator_Release" and voila.

Is there someone up to integrate this in buildme and in the CloverPackage ?

  • Thanks 1
Link to comment
Share on other sites
tluck
tluck
Posted
Posted (edited)

well I got a bunch of warnings and then nothing.

cant compile validator - hit a bug - something about <size_t> (__v) - can't cast unsigned long long to unsigned long...

Edited by tluck
Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted
10 hours ago, iCanaro said:

@Jief_Machak which is the latest version of CloverConfigValidator??? I had stayed at 0.7

 

10 hours ago, Jief_Machak said:

It's 0.7 and not up to date. You'll get one tmo, promise ;)


Hi @iCanaro @Jief_Machak

On https://github.com/jief666/CloverCommits there is CloverConfigValidator 0.8. So the next one, will be CloverConfigValidator 0.9 :hysterical:

Now, Build and test latest commit efb5e87. Thanks @Jief_Machak

  • Like 4
Link to comment
Share on other sites
 Share
Go to topic listing
×
×
  • Create New...