Clover General discussion

[vector sigma]

10 minutes ago, brousseau6933 said:

Not sure if I'm off topic:

 

Clover 4988 on Sourceforge: missing AptioMemoryFix-64.efi in the package.

 

I'll wait, better safe than sorry.

 

1 minute ago, tluck said:

I was curious about the new packaging (which looks good) - but was specifically curious about the exclusion of the EXT_PACKAGES - such as the AptioMemoryFix group?

 

Are we left to figure out which one is bests or what is the thought/rationale on this aspect?

thanks

 

AptioMemoryFix.efi (external)

vs

OsxAptioFix3Drv.efi

OsxAptioFixDrv.efi

OsxLowMemFixDrv.efi

EXT_PACKAGES gives errors which we cannot control and people asked here why, unless you want to import almost all the OpenCore source code Lol. If you have AptioMemoryFix installed the package will not touch it unless you decide to install one of the *AptioFix* included in Clover. Later if I have time I want to implement back all the changes they made to the original OsxAptioFix which AptioMemoryFix is based on .

[pkdesign]

Just updated to 4988 and am confused by install. There is a drivers64UEFI folder in clover folder.

 

1) Is this left over from my original 4972 install and was not deleted by Clover?

2) Will this be a problem when I restart?

3) Do I just put the drivers in the drivers64UEFI folder into the new drivers>UEFI folder and delete the driver64UEFI folder?

4) Why do I have a BIOS folder when I have a UEFI mobo and did not select any of those during install?

 

Thanks!

 

 

[arsradu]

23 minutes ago, pkdesign said:

Just updated to 4988 and am confused by install. There is a drivers64UEFI folder in clover folder.

 

1) Is this left over from my original 4972 install and was not deleted by Clover?

2) Will this be a problem when I restart?

3) Do I just put the drivers in the drivers64UEFI folder into the new drivers>UEFI folder and delete the driver64UEFI folder?

4) Why do I have a BIOS folder when I have a UEFI mobo and did not select any of those during install?

 

Thanks!

 

 

1) it's been decided to keep both the new folder scheme, and the old one, for retro-compatibility. But I feel like this created more confusion to the users.

2) unlikely (but just in case, make a USB drive with Clover on it and double check your drivers and drivers64UEFI folders). Make sure all your necessary drivers are in there.

3) if you're not planning on going back to an old version of Clover (which still uses drivers64 and drivers64UEFI scheme), without reinstalling that version, but by simply copy-pasting the drivers to your EFI/Clover folder, then yes, you can delete. In other words, if you want to use an older version, just use the damn installer! :)) Don't just copy-paste folders from one version to the other. Unless you rename them to match the old folder naming scheme (meaning drivers64 for BIOS and drivers64UEFI for UEFI booting).

4) Did you reselect UEFI drivers, along with the corresponding UEFI drivers? If yes...that might be a bug. Nothing to worry about. It just won't use those. But yeah, could be a bug.

Edited July 11, 2019 by arsradu

[artur_pt]

hello Slice good night

 

something is wrong in clover .. that is only my opinion.. the value is zero

 

many people now is changing the source code .. clover is beginning slow to boot the OS, and not always boot the OS first time when u are doing a new update to the system.

what I want to say about this , u must begin to work the files in clover.. and do a cleanup in the source code .. I'm sure many lines are now deprecated.. I know is a hard job ... but I'm sure u are the right person to do this ... another point something is wrong in inject kext in Mojave and in Catalina..

 

sorry to disturb u , in all work u do for booting macOS 

 

all the best

 

[LockDown]

is it more correct to use the name "firmware" instead of drivers?

 

[Slice]

2 minutes ago, ellaosx said:

is it more correct to use the name "firmware" instead of drivers?

 

No, there are drivers sorted by firmwares.

[arsradu]

@fusion71au Many thanks for the detailed post above.  

 

Problem is...nothing worked so far. :)) Probably in part due to the fact that I have almost 0 experience with booting Legacy (I didn't really need it), but also in part due to the fact that I'm probably doing something wrong (probably not related to the actual ISO, but we can't know for sure until I'm able to boot in Legacy mode).

I created an iso with everything ok in terms of config (thanks for the script), themes, all of that. Aaand...even with the embedded theme set up and the same config as the one I use for booting on a daily basis, I still get exactly the same result. Which makes me think maybe the problem is somewhere else.

 

Now, in terms of trying to load those drivers manually from EFI Shell...that didn't go too well either.

First of all, the DVD ROM is USB based (external). Not sure if this is relevant in any way. But I'm just mentioning it in case it is.

Second of all, it shows in Shell as blkC, with Alias (null).

So, while I can do blkC:, it doesn't seem to have anything inside (I tried a simple ls and I got some error, I don't remember which one exactly off the top of my head). I can't see the contents of the CD. And none of the other "fs" entries is linking to this CD-ROM. All of them are my hard disks/SSD. So not what I needed.

 

However, if I'm not mistaken, I've got the exact same issue when booting off of an USB drive, with Clover in Legacy mode. Booting in Legacy mode doesn't seem to work for me, for some reason. Never bothered to find out why, since my motherboard has an UEFI firmware. So I never needed to boot Legacy. 

But I was thinking, maybe I should focus on booting in Legacy mode first, then trying to understand (and debug) why booting off of the DVD doesn't work. Cause the reason might be the same. And it would take a lot less time to edit the files on a USB drive, than erasing and rewriting a CD every time I want to test a new scenario.

Also, I couldn't find an option in the UEFI menu to boot CDs in UEFI mode or something like that... So I don't think my motherboard has this feature.

 

I'll try to play with the Legacy mode a bit more, on a USB drive. See if I can get it to boot. We'll see what the results tell us after that. Since nobody else complained about booting in Legacy mode, I'm guessing it's probably something specific to my system.

Edited July 12, 2019 by arsradu

[vector sigma]

@Sherlocks and all, r4994 should install in 10.15 by automatically change the root fs as rw (of course this is only done in 10.15+). There's a dialog anyone can translate in any language.

 

Clover_v2.4k_r4994.zip

 

@Slice take a look at localizable.strings and tell me if is now ok. To All, at the beginning of the localizable.strings now there are two new localization to be translated, as just said for the dialogs the package now show you in Catalina.

[chris1111]

@vector sigma

I test the new distribution its like to be working  

Edited July 12, 2019 by chris1111

[vector sigma]

1 minute ago, chris1111 said:

@vector sigma

I test the new distribution its like to be working  

I made it all "embeded" + a check for the OS should not be  older then catalina:

  function checkFileSystemIsWritable()
  {
    var result = true;
    if (-1 == system.numericalCompare('10.14.9', system.version.ProductVersion)) {
        result = false;
        var cmd = '/usr/bin/osascript -e\''
        cmd += 'do shell script "mount -uw /" with prompt '
        cmd += '"' + system.localizedString('MakingRootRW') + '"'
        cmd += ' with administrator privileges\''
        try
        {
           cmd = system.runOnce('/bin/sh', '-c', cmd);
           result = (cmd == 0);
           } catch (e) {
            system.log('mount -uw / returned with error: ' + e);
            result = false;
         }
         
         if (result == false) {
          my.result.message = system.localizedString('GoToFailRootRW');
          my.result.type = 'Fatal';
         }
     }
	system.log("checkFileSystemIsWritable() returned: " + result);
    return result;
  }

 

[chris1111]

1 minute ago, vector sigma said:

I made it all "embeded" + a check for the OS should not be  older then catalina:

  function checkFileSystemIsWritable()
  {
    var result = true;
    if (-1 == system.numericalCompare('10.14.9', system.version.ProductVersion)) {
        result = false;
        var cmd = '/usr/bin/osascript -e\''
        cmd += 'do shell script "mount -uw /" with prompt '
        cmd += '"' + system.localizedString('MakingRootRW') + '"'
        cmd += ' with administrator privileges\''
        try
        {
           cmd = system.runOnce('/bin/sh', '-c', cmd);
           result = (cmd == 0);
           } catch (e) {
            system.log('mount -uw / returned with error: ' + e);
            result = false;
         }
         
         if (result == false) {
          my.result.message = system.localizedString('GoToFailRootRW');
          my.result.type = 'Fatal';
         }
     }
	system.log("checkFileSystemIsWritable() returned: " + result);
    return result;
  }

 

Yea I see

did you find info from NPM site 

[vector sigma]

22 minutes ago, chris1111 said:

did you find info from NPM site 

No on the Apple developer portal

Anyway this I guess cannot be killed by Apple because all this is done before even the target volume is selected. Which is also a downside if you want to install else where.

Edited July 12, 2019 by vector sigma

[Matgen84]

Hi 

 

Sorry if is off-topic. I try to build r4994 and I got this issue...

 

[vector sigma]

2 minutes ago, Matgen84 said:

I try to build r4994 and I got this issue...

Make:

Status = ReadDisk (
      DiskIo,
      DiskIo2,
      MediaId,
      EfiFileCurrentExtentOffset,
      EfiFileCurrentExtentSize,
      (CHAR8*)EfiFileBuffer + CurPos
      );

to be:

Status = ReadDisk (
      DiskIo,
      DiskIo2,
      MediaId,
      EfiFileCurrentExtentOffset,
      EfiFileCurrentExtentSize,
      EfiFileBuffer + CurPos
      );

in ApfsDriverLoader.c

[Matgen84]

14 minutes ago, vector sigma said:

Make:

Status = ReadDisk (
      DiskIo,
      DiskIo2,
      MediaId,
      EfiFileCurrentExtentOffset,
      EfiFileCurrentExtentSize,
      (CHAR8*)EfiFileBuffer + CurPos
      );

to be:

Status = ReadDisk (
      DiskIo,
      DiskIo2,
      MediaId,
      EfiFileCurrentExtentOffset,
      EfiFileCurrentExtentSize,
      EfiFileBuffer + CurPos
      );

in ApfsDriverLoader.c

 

I do make a mistake because no more directories 

 

EDIT: I try to compile in Mojave 10.14.5 / Xcode 10.2.1

 

Edited July 12, 2019 by Matgen84

[vector sigma]

Did you use a script or did you do that manually? Any way something should appear in terminal...

[Matgen84]

3 minutes ago, vector sigma said:

Did you use a script or did you do that manually? Any way something should appear in terminal...

 

I use manual makepkg in Terminal

 

========= Translating Resources ========
/Users/mathieu/src/udk2018/clover/cloverpackage/package/../../../../opt/local
Updating 'en' strings file for CloverUpdater... done
Updating 'en' strings file for Clover Preference Panel... done
Updating strings file for Clover Preference Panel... done
 (204 entries)

Updating 'en' strings file for CloverUpdater... done
Generating de interface... done
Generating es interface... done
Generating fr interface... done
Generating hr interface... done
Generating id interface... done
Generating it interface... done
Generating ja interface... done
Generating ko interface... done
Generating lv interface... done
Generating nl interface... done
Generating pl interface... done
Generating pt-BR interface... done
Generating pt interface... done
Generating ro interface... done
Generating ru interface... done
Generating tr interface... done
Generating uk interface... done
Generating vi interface... done
Generating zh_CN interface... done
Generating zh_TW interface... done
Building CloverUpdater application...
[XCODE]
Updating 'en' strings file for Clover Preference Panel... done
Generating de interface... done
Generating es interface... done
Generating fr interface... done
Generating hr interface... done
Generating id interface... done
Generating it interface... done
Generating ja interface... done
Generating ko interface... done
Generating lv interface... done
Generating nl interface... done
Generating pl interface... done
Generating pt-BR interface... done
Generating pt interface... done
Generating ro interface... done
Generating ru interface... done
Generating tr interface... done
Generating uk interface... done
Generating vi interface... done
Generating zh_CN interface... done
Generating zh_TW interface... done
Updating strings file for Clover Preference Panel... done
Check de strings... done
Check en strings... done
Check es strings... done
Check fr strings... done
Check hr strings... done
Check id strings... done
Check it strings... done
Check ja strings... done
Check ko strings... done
Check lv strings... done
Check nl strings... done
Check pl strings... done
Check pt-BR strings... done
Check pt strings... done
Check ro strings... done
Check ru strings... done
Check tr strings... done
Check uk strings... done
Check vi strings... done
Check zh_CN strings... done
Check zh_TW strings... done
Building CloverPrefpane preference...
[XCODE]
================= Making all in boot1-install =================
	[XCODE] boot1-install
================= Making all in partutil =================
	[XCODE] partutil
================= Making all in bdmesg =================
	[XCODE] bdmesg
================= Making all in clover-genconfig =================
	[XCODE] clover-genconfig

  -------------------------------
  Building Clover Install Package
  -------------------------------

====================== Preinstall ======================
	[BUILD] Pre
===================== Installation =====================
	[BUILD] UEFI.only
================== Target ESP ==========================
	[BUILD] Target.ESP
=================== BiosBoot ===========================
	[BUILD] BiosBoot
===================== Utils ============================
	[BUILD] Utils
===================== EFI folder =======================
	[BUILD] EFIFolder
===================== off drivers ======================
find: /Users/mathieu/src/udk2018/clover/cloverpackage/CloverV2/EFI/CLOVER/drivers: No such file or directory
	[BUILD] off
===================== BootLoaders ======================
	[BUILD] AltBoot
	[BUILD] bootNo
	[BUILD] boot0af
	[BUILD] boot0ss
====================== CloverEFI =======================
	[BUILD] cloverEFI.64.sata
===================== RC Scripts =======================
	[BUILD] rc.scripts.on.target
	[BUILD] rc.scripts.on.all.volumes
	[BUILD] rc.scripts.core
================= Optional RC Scripts ==================
	[BUILD] disable_sleep_proxy_client
======================== Themes ========================
	[BUILD] Clovy
	[BUILD] BGM
	[BUILD] cesium
	[BUILD] CloverThemeManager
==================== Clover Prefpane ===================
	[BUILD] CloverPrefpane
================= Post =================
	[BUILD] Post

 --------------------------
 Building process complete!
 --------------------------

 Build info.
 ===========
  Package name: Clover_v2.4k_r4994.pkg
  MD5:          91def03c5481e636a48ab21c1e213d12
  Version:      v2.4k
  Stage:        v2.4k
  Date/Time:    2019-07-12 18:33:46
  Built by:     mathieu
  Copyright     2012-2019

  adding: Clover_v2.4k_r4994.pkg (deflated 0%)
  adding: Clover_v2.4k_r4994.pkg.md5 (stored 0%)
total 35064
drwxr-xr-x   9 mathieu  staff      288 Jul 12 18:43 .
drwxr-xr-x  15 mathieu  staff      480 Jul 12 18:43 ..
-rw-r--r--@  1 mathieu  staff  8754566 Jul 12 18:43 Clover_v2.4k_r4994.pkg
-rw-r--r--   1 mathieu  staff       68 Jul 12 18:43 Clover_v2.4k_r4994.pkg.md5
-rw-r--r--   1 mathieu  staff  8733421 Jul 12 18:43 Clover_v2.4k_r4994.zip
drwxr-xr-x   3 mathieu  staff       96 Jul 12 18:43 Resources
drwxr-xr-x   6 mathieu  staff      192 Jul 12 18:43 build
drwxr-xr-x   3 mathieu  staff       96 Jul 12 18:43 package
drwxr-xr-x   6 mathieu  staff      192 Jul 12 18:43 utils

 

[vector sigma]

Drivers directories are created by ebuild.sh. Run it before ..otherwise. And please post what's on your terminal entirely please.

[Matgen84]

3 minutes ago, vector sigma said:

Drivers directories are created by ebuild.sh. Run it before ..otherwise. And please post what's on your terminal entirely please.

 

All works fine under Mojave. Thanks 

 

Please commit your new ApfsDriverLoader.c

[Slice]

2 hours ago, vector sigma said:

Make:

Status = ReadDisk (
      DiskIo,
      DiskIo2,
      MediaId,
      EfiFileCurrentExtentOffset,
      EfiFileCurrentExtentSize,
      (CHAR8*)EfiFileBuffer + CurPos
      );

to be:

Status = ReadDisk (
      DiskIo,
      DiskIo2,
      MediaId,
      EfiFileCurrentExtentOffset,
      EfiFileCurrentExtentSize,
      EfiFileBuffer + CurPos
      );

in ApfsDriverLoader.c

It rather should be (UINT8*)

[vector sigma]

6 minutes ago, Slice said:

It rather should be (UINT8*)

is inited as VOID*, I guess it is compatible with the smallest size of UInt8. But yes.

[arsradu]

Hi @fusion71au !

 

So, after a long day of testing, I managed to find the cause for the red text screen with x64 Exception Type 06. And it seems to have something to do with Clover itself.

 

Older versions like 3911 work fine. But only if I select BiosBlockIO. With SATA, I get the exact same behavior (blinking cursor for a while, then "not found" then red screen). With BiosBlockIO it goes straight into Clover GUI (with a few icon issues for the embedded theme)...but it gets there. 

 

 

Also, 3911 had its own issues (mouse and keyboard not working in Clover GUI). Fixed it by removing AppleKeyAggregator. Newer versions don't seem to have it, so I guess that's ok.

 

Another problem with 3911 is, of course, the fact that it can't boot Mojave (and not because of APFS, since I've got ApfsDriverLoader already in place, it's most likely the kext injection). :)) So...while I did get to the Clover GUI and I did manage to get my keyboard working so I can select the boot drive, I got stuck on my way to Desktop.

 

So, to sum up:

1. newer versions of Clover (such as 4993) don't have BiosBlockIO anymore, so I will get that red screen if I select the SATA option and try to boot in Legacy mode (and yes, it looks like I remembered correctly, I DO get the exact same issue booting off of the USB as I did booting from the DVD, and now we know why).

2. older versions (such as 3911) can boot ok in Legacy mode, but only if BiosBlockIO is selected. Same issue if SATA is selected. Problem here is that those versions can't boot newer MacOS versions, such as Mojave.

So...yeah, not sure why BiosBlockIO was removed for Legacy booting...but I can't seem to be able to boot otherwise.

 

So, in a nutshell, older Clover can boot to Clover GUI, but can't get any further, due to OS issues, newer Clover can't boot even into the GUI, due to SATA issues (red screen with "x64 Exception Type 06" error) but, in theory, it should be able to boot Mojave.

 

Maybe there's something in BIOS that should be checked in order for this to work with SATA, as well...? No idea. But so far, these are the results.

[Slice]

3 hours ago, vector sigma said:

is inited as VOID*, I guess it is compatible with the smallest size of UInt8. But yes.

I made this change because of what? 

It was initially VOID*, but it is not compatible with VS2013 (error C2036).

[fusion71au]

1 hour ago, arsradu said:

Hi @fusion71au !

 

So, to sum up:

1. newer versions of Clover (such as 4993) don't have BiosBlockIO anymore, so I will get that red screen if I select the SATA option and try to boot in Legacy mode (and yes, it looks like I remembered correctly, I DO get the exact same issue booting off of the USB as I did booting from the DVD, and now we know why).

2. older versions (such as 3911) can boot ok in Legacy mode, but only if BiosBlockIO is selected. Same issue if SATA is selected. Problem here is that those versions can't boot newer MacOS versions, such as Mojave.

So...yeah, not sure why BiosBlockIO was removed for Legacy booting...but I can't seem to be able to boot otherwise.

 

So, in a nutshell, older Clover can boot to Clover GUI, but can't get any further, due to OS issues, newer Clover can't boot even into the GUI, due to SATA issues (red screen with "x64 Exception Type 06" error) but, in theory, it should be able to boot Mojave.

 

Maybe there's something in BIOS that should be checked in order for this to work with SATA, as well...? No idea. But so far, these are the results.

 

@arsradu,

 

I noticed the makeiso script formats the iso with -eltorito-boot, to allow for legacy BIOS booting, and it also uses boot6 instead of boot7 (BiosBlockIO) which works on your system.  I'm guessing the presence of the legacy BIOS code is what makes the CD-DVD-ROM "invisible" to your firmware when it is set to boot to "UEFI only".

 

Try the following modified makeiso files (place in ~/src/edk2/Clover/CloverPackage) to generate the Clover ISO instead of the default one...

makeiso_boot7.zip ---> uses boot 7 instead of boot 6 for legacy boot

makeiso_uefi_only.zip ---> removed -eltorito-boot formatting so only UEFI booting possible

 

PS BiosBlockIO is still available in the latest Clover Pkg installer r4995.  If the boot7/BosBlockIO installed by r4995 doesn't work, then simply replace it with the boot7 "boot" file from Clover r3911 (keep the rest of the files from Clover r4995, including CLOVERX64.efi, BOOTX64.efi and the new drivers folder file structure)...

 

 

Good Luck!

Clover_v2.4k_r4995.pkg.zip

Edited July 12, 2019 by fusion71au
typo

[Matgen84]

9 hours ago, Slice said:

It rather should be (UINT8*)

 

 

9 hours ago, vector sigma said:

is inited as VOID*, I guess it is compatible with the smallest size of UInt8. But yes.

 

exrpression (UNIT8*) don't work in Mojave / Xcode 10.2.1: can't compile. Please commit previous vector sigma diff or else.

 

make: Nothing to be done for `tbuild'.
make: Nothing to be done for `tbuild'.
make: Nothing to be done for `tbuild'.
make: Nothing to be done for `tbuild'.
make: Nothing to be done for `tbuild'.
/Users/mathieu/src/UDK2018/Clover/FileSystems/ApfsDriverLoader/ApfsDriverLoader.c:953:20: error: expected expression
            (UNIT8*)EfiFileBuffer + CurPos
                   ^
/Users/mathieu/src/UDK2018/Clover/FileSystems/ApfsDriverLoader/ApfsDriverLoader.c:953:14: error: use of undeclared identifier 'UNIT8'
            (UNIT8*)EfiFileBuffer + CurPos
             ^
2 errors generated.
make: *** [/Users/mathieu/src/UDK2018/Build/Clover/RELEASE_XCODE8/X64/Clover/FileSystems/ApfsDriverLoader/ApfsDriverLoader/OUTPUT/ApfsDriverLoader.obj] Error 1


build.py...
 : error 7000: Failed to execute command
	make tbuild [/Users/mathieu/src/udk2018/Build/Clover/RELEASE_XCODE8/X64/Clover/FileSystems/ApfsDriverLoader/ApfsDriverLoader]


build.py...
 : error F002: Failed to build module
	/Users/mathieu/src/udk2018/Clover/FileSystems/ApfsDriverLoader/ApfsDriverLoader.inf [X64, XCODE8, RELEASE]

- Failed -