Clover General discussion

[cecekpawon]

I have a diff, but it based on revision 4853.  I never blame Slice, since he was always faster than me.

This patches contain some fixes for audio volume, port and also device to work with/from GUI and BootChimeCfg.

Please do check -or- take some -or- improve as usual and sync it with latest revision.

 

*update attachment

 

diff.diff.zip

Edited January 21, 2019 by cecekpawon

[Slice]

Appreciated your work but I have to look carefully because I already made other patches.

Nontheless thanks for point the bugs.

[cecekpawon]

Please take whatever it needs Slice _/|\_

[Emanuele-1998]

@Slice audio does not work on the bootloader and there is no option to change the volume to the clover GUI

[arsradu]

[mention=112217]Slice[/mention] audio does not work on the bootloader and there is no option to change the volume to the clover GUI

You mean the volume of the startup sound?

 

Does it work from Shell? Can you test the sound from there?

 

Cause there is an option in Clover’s GUI for that. You can see it in one of my screenshots above. But last time I tried it, it didn’t work very well (reset itself to 0000 when trying to change the volume). So I used BootChimeCfg.efi, accessed from Shell to adjust the volume. It’s a workaround.

 

You have to make sure you’re using the latest build. 4851 had some issues. But 4853 worked perfectly fine for me (aside from the GUI issues I mentioned above).

[Slice]

12 minutes ago, Emanuele-1998 said:

@Slice audio does not work on the bootloader and there is no option to change the volume to the clover GUI

 

Can you give me preboot.log?

And wait for next Clover revision with some bugs corrected.

27 minutes ago, cecekpawon said:

Please take whatever it needs Slice _/|\_

Some notes.

1. I don't like ReallocatePool when we deal with 20*sizeof(HDA_OUTPUTS) bytes. May be 30 but not more.

2. F7 souldn't play sound file because it may absent. It's better to test hardware on a sound we sure to be playable.

3. About gSettings I am not decided finally. Keep only AudioVolume? What about other audio settings?

4. Currently we using gBootChimeVendorVariableGuid as Goldfish64 do. But it is not good for legacy Clover. May be remake to gAppleBootGuid? In this case we got saving audio parameters even with legacy Clover but we will loose original project compatibility.

 

PS. I need some ideas why PlayAsync is not working.

[Emanuele-1998]

22 minutes ago, Slice said:

Can you give me preboot.log?

And wait for next Clover revision with some bugs corrected.

Some notes.

1. I don't like ReallocatePool when we deal with 20*sizeof(HDA_OUTPUTS) bytes. May be 30 but not more.

2. F7 souldn't play sound file because it may absent. It's better to test hardware on a sound we sure to be playable.

3. About gSettings I am not decided finally. Keep only AudioVolume? What about other audio settings?

4. Currently we using gBootChimeVendorVariableGuid as Goldfish64 do. But it is not good for legacy Clover. May be remake to gAppleBootGuid? In this case we got saving audio parameters even with legacy Clover but we will loose original project compatibility.

 

@Slice I switched to 4855 and it works but the audio output does not remain fixed and when restarting it disappears remaining unchecked, then I can not boot via the HDMI because they are still in the process of being true?

 

I send you an example video, also as you can see the start of the clover gui is very slow even in the latest stable version, and pressing U that would be the button to shut down causes a bug.

Edited January 21, 2019 by Emanuele-1998

[MakAsrock]

I switched to Clover r4855 without BootChimeCfg.efi and, as it turned out, Clover immediately writes the wrong value to NVRAM (got index=-1003609600, which cannot be changed without BootChimeCfg.efi). At the same time, it records the correct volume value (volume 90 received). It does not matter whether the audio output settings menu was used or not. In my configuration, hardware NVRAM is running. Therefore, I do not use EmuVariableUefi-64.efi and not nravam.plist  If I boot from the flash drive which BootChimeCfg.efi and fix the output, then the value (got index = -1003609600) changes to the correct one, and the sound appears before loading Clover.

Edited January 21, 2019 by MakAsus

[Sherlocks]

@Slice

latest clover r4856, everything is good. thank you for update.

can we have chance to reset nvram(F11) lnclude BootChime GUID(initialized like factory)?

is BootChime GUID unique guid for only audiodxe.efi? not common?

 

also can we have chance for boot sound when showing apple log like BootChimeDxe.efi?

 

thanks in advance

 

EDIT1.

in r4856, sound.wav quality is bad. i listened original sound with electronic. i used sound.wav file from clovy theme folder

3:810  0:000  === [ InitTheme ] =========================================
3:810  0:000  use daylight theme
3:812  0:001  Using theme 'bootcamp' (EFI\CLOVER\themes\bootcamp)
3:812  0:000  Warning! Character width 9 should be even!
3:812  0:000    Channels: 2  Sample rate: 8000 Hz  Bits: 16
3:812  0:000  output to channel -780514048 with volume 80, len=75200
3:812  0:000   sound channels=2 bits=16 freq=8000
3:812  0:000  sound converted to 48kHz
6:448  2:635  Loading font from ThemeDir: Error
6:449  0:000  theme inited
6:449  0:000  Chosen theme bootcamp

Edited January 21, 2019 by Sherlocks

[arsradu]

Personally, I feel like having the startup sound before the UI is more realistic. But...an option to select to play it before or after, yeah, that would be interesting to have. I personally prefer it just the way it is now, meaning before the UI. I feel like it's closer to what real Macs do. But as I said, an option to choose which one you want, that would be interesting.

Edited January 21, 2019 by arsradu

[Badruzeus]

3 hours ago, arsradu said:

Personally, I feel like having the startup sound before the UI is more realistic. But...an option to select to play it before or after, yeah, that would be interesting to have. I personally prefer it just the way it is now, meaning before the UI. I feel like it's closer to what real Macs do. But as I said, an option to choose which one you want, that would be interesting.

Honestly, using AudioDxe, BootChimeDxe & BootChimeCfg from @Goldfish64 repo I can hear sound before - after Clover GUI since r4843 w/o issue, except my nvram is going crazy (sometimes).

[Matgen84]

Hi

 

Sorry for questions for dummies:

• I can't find internal speakers output in clover audio setting and rear output
• Clover GUI seems to be slower at startup
• I can't keep settings after reboot (I only use AptioMemoryFix): I must use emuvariable, Right.

Thanks

[cecekpawon]

19 hours ago, Slice said:

3. About gSettings I am not decided finally. Keep only AudioVolume? What about other audio settings?

4. Currently we using gBootChimeVendorVariableGuid as Goldfish64 do. But it is not good for legacy Clover. May be remake to gAppleBootGuid? In this case we got saving audio parameters even with legacy Clover but we will loose original project compatibility.

 

3. It would be nice if Clover have own config (plist) including audio device, portindex, and also volumelevel. You may take this as example. User can grab device & port_index values from log and store it to config plist (I have log those values on my prev diff).

4. For nvram values, Clover can read values from gBootChimeVendorVariableGuid (if any) as 1st attempt, read from gAppleBootGuid as 2nd attempt, and fallback to user config plist values as last attempt, then save it to from gBootChimeVendorVariableGuid (+ gAppleBootGuid, meh!).

 

19 hours ago, Slice said:

PS. I need some ideas why PlayAsync is not working.

 

Have not tried it with Clover yet, will do. (already discussed with dev days ago about async playback here).

 

18 hours ago, MakAsus said:

value (got index = -1003609600)

 

17 hours ago, Sherlocks said:

output to channel -780514048

 

@MakAsus @Sherlocks seems you have bad values stored to nvram.

 

17 hours ago, Sherlocks said:

also can we have chance for boot sound when showing apple log like BootChimeDxe.efi?

 

Having those option in Clover is also great. But why you dont just install BootChimeDxe.efi for that purpose?

* AudioDxe will should much more useful to enhanced the GUI like this instead of just greeting sound

 

 

* link removed

Edited January 22, 2019 by cecekpawon

[arsradu]

39 minutes ago, Matgen84 said:

Hi

 

Sorry for questions for dummies:

• I can't find internal speakers output in clover audio setting and rear output
• Clover GUI seems to be slower at startup
• I can't keep settings after reboot (I only use AptioMemoryFix): I must use emuvariable, Right.

Thanks

 

1. Well, I think your Realtek ALC892_Headphones should also be your "internal speakers". They're usually paired in switch mode. 

Rear output should probably be Realtek ALC892_LineOut (the first one). Actually, they're most likely all Rear Outs... Just...different ports for different speakers. But the first one is probably mapped as the Green one. So that's why I said the first one.

 

2. Yeah, it's been reported before. It might be intended though... Not sure.

 

3. Mmm...which system are you trying this on? Isn't your system using native NVRAM? If not, I think AptioMemoryFix should be enough. But I'm not sure Clover is working in cooperation with it...yet. If your other NVRAM related settings are saved, I'd say this is probably a Clover issue and it doesn't work with AptioMemoryFix quite yet. I don't know. I might be talking stupid. So don't take my word for it.

 

Thing is, depending on your system, you might or might not need AptioMemoryFix for NVRAM. I do not think you need EmuVariable. And especially you shouldn't be using both at the same time.

Edited January 21, 2019 by arsradu

[Matgen84]

10 minutes ago, arsradu said:

 

1. Well, I think your Realtek ALC892_Headphones should also be your "internal speakers". They're usually paired in switch mode. 

Rear output should probably be Realtek ALC892_LineOut (the first one). Actually, they're most likely all Rear Outs... Just...different ports for different speakers. But the first one is probably mapped as the Green one. So that's why I said the first one.

 

2. Yeah, it's been reported before. It might be intended though... Not sure.

 

3. Mmm...which system are you trying this on? Isn't your system using native NVRAM? If not, I think AptioMemoryFix should be enough. But I'm not sure Clover is working in cooperation with it...yet. If your other NVRAM related settings are saved, I'd say this is probably a Clover issue and it doesn't work with AptioMemoryFix quite yet. I don't know. I might be talking stupid. So don't take my word for it.

 

Thing is, depending on your system, you might or might not need AptioMemoryFix for NVRAM. I do not think you need EmuVariable. And especially you shouldn't be using both at the same time.

 

Thanks for reply 

 

1. I don't think Realtek ALC892_Headphones is Internal speakers and Rear output is not Realtek ALC892_LineOut (the first one). Both don't work in Clover options. Bootchimecfg.efi show Internal speakers in list output, mapped with rear green one.
2. OK
3. I don't know if my mobo 'Asus p8z77-v Pro' support native NVRAM. My other settings are saved.

Wait and see others commits 

[arsradu]

2 minutes ago, Matgen84 said:

 

Thanks for reply 

 

1. I don't think Realtek ALC892_Headphones is Internal speakers and Rear output is not Realtek ALC892_LineOut (the first one). Both don't work in Clover options. Bootchimecfg.efi show Internal speakers in list output, mapped with rear green one.
2. OK
3. I don't know if my mobo 'Asus p8z77-v Pro' support native NVRAM. My other settings are saved.

Wait and see others commits 

 

None of them will work in Clover options.  That's a bug. If you wanna test them and set your boot chime, you need to use BootChimeCfg from Shell for now. As for your motherboard, I think all motherboards until Skylake (series 100) should have native NVRAM. So the issue might be somewhere else in your case.

[Slice]

46 minutes ago, Matgen84 said:

 

Thanks for reply 

 

1. I don't think Realtek ALC892_Headphones is Internal speakers and Rear output is not Realtek ALC892_LineOut (the first one). Both don't work in Clover options. Bootchimecfg.efi show Internal speakers in list output, mapped with rear green one.
2. OK
3. I don't know if my mobo 'Asus p8z77-v Pro' support native NVRAM. My other settings are saved.

Wait and see others commits 

Show me, please, voodoohda dump. I want to see if a problem with output configuration can be resolved by some patch like voodoohda do.

[MakAsrock]

Cod work. It seems that it began to work correctly. The startup sound now plays on my computer with rev. 4857. Without using BootChimeCfg then clearing NVMRAM, I can set the volume and device output variable with Clover. The volume and device output are saved to NVRAM. Respect! 

7:841  0:000  found 3 handles with audio

7:841  0:000  got index=2

7:841  0:000  got volume 90

——————————————————————————————————

8:451  0:000  Using vector theme 'Clovy' (EFI\CLOVER\themes\Clovy)

8:468  0:017    Channels: 2  Sample rate: 44100 Hz  Bits: 16

8:468  0:000  output to channel 2 with volume 90, len=451584

8:468  0:000   sound channels=2 bits=16 freq=44100

11:364  2:895  theme inited

[arsradu]

13 hours ago, MakAsus said:

Cod work. It seems that it began to work correctly. The startup sound now plays on my computer with rev. 4857. Without using BootChimeCfg then clearing NVMRAM, I can set the volume and device output variable with Clover. The volume and device output are saved to NVRAM. Respect! 

 

7:841  0:000  found 3 handles with audio

7:841  0:000  got index=2

7:841  0:000  got volume 90

——————————————————————————————————

8:451  0:000  Using vector theme 'Clovy' (EFI\CLOVER\themes\Clovy)

8:468  0:017    Channels: 2  Sample rate: 44100 Hz  Bits: 16

8:468  0:000  output to channel 2 with volume 90, len=451584

8:468  0:000   sound channels=2 bits=16 freq=44100

11:364  2:895  theme inited

 

I was just finishing compiling Clover when I saw your message. :)) Yeah, Clover 4857's UI seems to work a little better now. I was able to change the volume, without resetting itself, and select different outputs.

 

Things left to fix, for what I could see:

 

1. update the UI according to the previously saved configuration, when entering that menu.

 

Meaning: even though the settings are correctly saved, and the output you select is the one which will be used on the next reboot, it's still not correctly read when coming back to that menu. For example, although I'm using Device Output #8 in that list, when I enter that menu, it still displays the first one in the list as selected.

 

It looks like it's writing correctly to NVRAM, but it's not reading correctly from it. At least when it comes to the selected device output. It does display the volume correctly though. But not the device.

 

2. F7 still doesn't work yet. I understand it might be trickier to fix than it seems. 

 

So...if you already know which device to choose from that list, yes, you can set it up from that UI and be done with it in a second. But if you don't...you might have to set each one of them individually and see which one works and also, which one suits your needs the best. Similar to what you would currently do using BootChimeCfg actually.

 

Other than that, just like you said: respect! Nice job!

 

Update:

 

Ok, it looks like it's more complicated than it seems in regards to bug nr 1. It DOES display them correctly when coming back to that menu, but for some reason, not all of them... Also, selecting some of them will freeze the UI. More details below.

 

So, these the options I've got. I selected option #8 just because that's what I'm using, not because that's what it was displaying when I opened this menu.

 

Now, all AMD options (options 1-6 in the list) are selectable, though no sound is coming out for this case. I understand this is a limitation of BootChime's implementation..? I could be wrong. Or at least it's not implemented yet. Point is, I'm not gonna say anything about it being functional or not if I'm not sure it should be.

 

Anwyay, selecting any of them will be actually saved and displayed correctly when coming back here. These are the only ones that are displayed. Anything else you select from the list below will be applied (correctly set), but not correctly displayed. Meaning they won't be displayed as selected when coming back to this menu.

 

Option 7 (Intel Haswell HDMI_HDMI) is not correctly displayed. I haven't tested the sound itself, since I'm not using the HDMI port on my motherboard. So it might work, but it probably doesn't, since it's still HDMI and it's not supported yet.

 

Now begins the interesting part:

 

Options 8 and 10 (Realtek ALC892_LineOut) work fine in terms of actual sound, but they're not displayed as selected.

Options 9, 11 and 12 (Realtek ALC892_LineOut and Realtek ALC892_Headphones) will freeze the UI if selected.

 

Edited January 22, 2019 by arsradu

[Tobiko]

1 hour ago, MakAsus said:

Cod work. It seems that it began to work correctly. The startup sound now plays on my computer with rev. 4857. Without using BootChimeCfg then clearing NVMRAM, I can set the volume and device output variable with Clover. The volume and device output are saved to NVRAM. Respect! 

 

Same. 

 

Awesome!

 

Is there a way to get rid of the metallic sound of the wav? It played clearly testing with BootChimeCfg but when hitting F7 in the Clover options and when it plays automatically it is buzzy.  My desktop it plays fine. Stupid laptop. 

Edited January 21, 2019 by Tobiko

[Emanuele-1998]

@Slice

 

[LockDown]

Hi @Slice

Regarding the timezone feature, mine is +8. Should i write +8 or only 8?

[SavageAUS]

Hi [mention=112217]Slice[/mention]
Regarding the timezone feature, mine is +8. Should i write +8 or only 8?

Just 8 should be fine. I’m +9.5 and I do just 9 or 10 I can’t remember which.


Sent from my iPhone using Tapatalk

[Matgen84]

13 hours ago, Slice said:

Show me, please, voodoohda dump. I want to see if a problem with output configuration can be resolved by some patch like voodoohda do.

I don't use voodoohda, only AppleALC.

 

Also, I disabled AppleALC and use Voodoohda for dump. Files attached

VoodooHDAGetdump.txt.zip

AudioCodecID.txt.zip

Edited January 22, 2019 by Matgen84

[Slice]

7 hours ago, ellaosx said:

Hi @Slice

Regarding the timezone feature, mine is +8. Should i write +8 or only 8?

Both possible.

2 hours ago, Matgen84 said:

I don't use voodoohda, only AppleALC.

 

Also, I disabled AppleALC and use Voodoohda for dump. Files attached

VoodooHDAGetdump.txt.zip

AudioCodecID.txt.zip

Well, your Realtek codec is not different from many others and configs are good.

You have

First group

 nid 20 0x01014010 as  1 seq  0 Line-out      Jack  1/8     Rear    External Green   misc 0
 nid 21 0x01011012 as  1 seq  2 Line-out      Jack  1/8     Rear    External Black   misc 0
 nid 22 0x01016011 as  1 seq  1 Line-out      Jack  1/8     Rear    External Orange  misc 0
 nid 23 0x01012014 as  1 seq  4 Line-out      Jack  1/8     Rear    External Grey    misc 0
There is first output Rear Green

 

Second group

 nid 27 0x02214c20 as  2 seq  0 Headphones    Jack  1/8     Front   External Green   misc 6

It is headphone jack at Front Green

 

Third group

nid 30 0x01456130 as  3 seq  0 SPDIF-out     Jack  Optic   Rear    External Orange  misc 0 NoPresenceDetect

 also you have HDMI output from Nvidia card.

 

Which one are you expected to use for startup sound?