Jief_Machak Posted May 19, 2021 Share Posted May 19, 2021 On 5/17/2021 at 9:59 PM, AntarcticP said: Deleted my NVRAM.plist and now getting the following message in the log. Clover still crashes. 29:055 0:002 Searching volumes for latest nvram.plist ... 29:059 0:004 - [0] no nvram.plist - skipping! I found a bug. Not sure if it applies to you. Could you test ? CloverX64-2021-05-19-10-01-12-82ba60a-dirty-jief.zip Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2758615 Share on other sites More sharing options...
Matgen84 Posted May 19, 2021 Share Posted May 19, 2021 11 hours ago, matxpa said: @Slice The two screenshots come from my Laptop Asus. "EFI\CLOVER" useful ? may be no more but ... There's two distinct versions : 1) Only with the short SHA (7 chars) added 2) with BUILDTARGET + TOOLCHAIN + short SHA (7 chars) added @matxpa Clover revision with only the short SHA (7 chars) at bottom right. I think it would be useful enough for end users. 10 hours ago, Jief_Machak said: I have more than one Clover folder and switch a lot between them. So yes, I think it's useful. Now, it can be only when Boot/Debug in true, for example... Or just in my own builds if no one likes it. @Jief_Machak @Slice Few month, I suggest to activate /EFI/CLOVER (bottom right) as possibility with Boot/Debug in true. I think that would be a good compromise. Especially for those who have installed and use BootLoaderChooser. 2 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2758616 Share on other sites More sharing options...
AntarcticP Posted May 19, 2021 Share Posted May 19, 2021 (edited) 3 hours ago, Jief_Machak said: I found a bug. Not sure if it applies to you. Could you test ? CloverX64-2021-05-19-10-01-12-82ba60a-dirty-jief.zip 821.15 kB · 1 download Hi @Jief_Machak Thanks a lot, this solved my problem! Typing this from my Hack, booted with this CloverX64.efi. Hope you can include this in the next release! Will not add this to the Github issues list, I assume. Edited May 19, 2021 by AntarcticP Added Github remark. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2758630 Share on other sites More sharing options...
Jief_Machak Posted May 19, 2021 Share Posted May 19, 2021 31 minutes ago, AntarcticP said: Hi @Jief_Machak Thanks a lot, this solved my problem! Typing this from my Hack, booted with this CloverX64.efi. Hope you can include this in the next release! Will not add this to the Github issues list, I assume. If it's fixed, no need for issue on github. I'll commit it, so yes, it'll be in the next release. 2 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2758631 Share on other sites More sharing options...
Slice Posted May 19, 2021 Share Posted May 19, 2021 3 hours ago, Jief_Machak said: If it's fixed, no need for issue on github. I'll commit it, so yes, it'll be in the next release. OK, but what is the case that RootDir = EfiLibOpenRoot(Handles[indexHandle]); can return null? It's impossible. EFI partition is bad formed? Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2758656 Share on other sites More sharing options...
matxpa Posted May 19, 2021 Share Posted May 19, 2021 7 hours ago, Matgen84 said: @matxpa Clover revision with only the short SHA (7 chars) at bottom right. I think it would be useful enough for end users. @Jief_Machak @Slice Few month, I suggest to activate /EFI/CLOVER (bottom right) as possibility with Boot/Debug in true. I think that would be a good compromise. Especially for those who have installed and use BootLoaderChooser. Couldn't this be managed by "theme.plist" ? Spoiler 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2758660 Share on other sites More sharing options...
Jief_Machak Posted May 19, 2021 Share Posted May 19, 2021 2 hours ago, Slice said: OK, but what is the case that RootDir = EfiLibOpenRoot(Handles[indexHandle]); can return null? It's impossible. EFI partition is bad formed? Well, never happened before... No idea. Bad firmware ? Doesn't hurt to check for NULL anyway. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2758664 Share on other sites More sharing options...
Matgen84 Posted May 20, 2021 Share Posted May 20, 2021 Hi @Jief_Machak @Slice I update Big Sur 11.4 RC to 11.5 Beta from my HDD. At reboot, I can boot Big Sur 11.5 Beta nor form HDD, nor from USB 5135 (master, commit 4bd343402). Only underscore at top left of the screen. Error message in Debug.log 39:405 10:054 OCB: InternalEfiExit 3361E298 - Aborted / Unsupported 39:587 0:182 StartImage failed : Aborted Any ideas, please 2021-05-20_08-55_BOOTX64.EFI.log Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2758768 Share on other sites More sharing options...
Jief_Machak Posted May 20, 2021 Share Posted May 20, 2021 Start with Clover that is NOT on a USB stick ? Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2758781 Share on other sites More sharing options...
Matgen84 Posted May 20, 2021 Share Posted May 20, 2021 2 hours ago, Jief_Machak said: Start with Clover that is NOT on a USB stick ? I tried both (HDD and USB stick). After, some reset and shutdown. I decide to boot BS 11.5 Beta from OC USB stick and shutdown. I restart again to boot from my Clover HDD: all works fine now. Strangely ! 1 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2758790 Share on other sites More sharing options...
matxpa Posted May 22, 2021 Share Posted May 22, 2021 @Slice & @Jief_Machak Hello. On r5135 release why « All checks have failed » on « Build Clover Pack » from commitID 8da3efae to 2b84ee6 and from 4bd3434 to 4c30ccd6 ? Regards 1 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2758955 Share on other sites More sharing options...
Guest 5T33Z0 Posted May 22, 2021 Share Posted May 22, 2021 (edited) On 5/18/2021 at 4:43 PM, kushwavez said: Just noticed, Clover Configurator has been updated, reflecting to changes! Nice to see it has been corrected. When I was working on the translation of the ACPI section of the russan manual into english for my Clover Update Guide, I noticed that a lot of the features that were still present in Clover Configurator have actually been removed from Clover for some time. So I just enabled every available option in a blank config file, saved it, ran it through the Config Validator the see which wouldn't pass and reported the once thae no longer worked. Edited May 22, 2021 by 5T33Z0 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2758956 Share on other sites More sharing options...
Slice Posted May 23, 2021 Share Posted May 23, 2021 8 hours ago, LIMITANT said: @Slice @Jief_Machak Thank you for all your efforts with Clover Please I would like to understand this section in Clover / ACPI / SSDT ..... please see the attached screenshot . My issue is that my CPU Turbo Boost is 3800 MHz and I want it only to be at 3400 MHz because of fan noise , in Windows I have managed to do that by " Disable Power Management " in Bios but macOs doesn't respect that and reaches 3800 MHz so I am looking now in this section as per Clover Wiki documents but any value I change doesn't reflect in macOs , Intel Power Gadget all the time is the same any idea how to do it correctly ? Thank you Reveal hidden contents May be CPU->TurboDisable=true? Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2759051 Share on other sites More sharing options...
Slice Posted May 23, 2021 Share Posted May 23, 2021 See also ACPI->SSDT->PLimitDict = 2 This number is a restriction for Max CPU speed if Clover's PState generation is used. ACPI->SSDT->Generate->PStates=true It was developed and tested for Penryn class CPU so I am not sure it is valid for recent processors. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2759053 Share on other sites More sharing options...
MacKonsti Posted May 23, 2021 Share Posted May 23, 2021 (edited) Hello @Slice thanks again for the r5135 release. However, please, can you explain the difference between releases in Git Hub? The full package ZIP (10MB) has CLOVERX64.efi that is different to the EFI-only zip release: The EFI only release is in the morning and shows Clover revision: 5135 (master, commit 5731ed0a8) The EFI binary in full-ZIP of mid-day has 916 differences (I binary-compared) and shows Clover revision: 5135 (master, commit f848a2179) Just to understand what is what and what should be used. Thank you! Edited May 23, 2021 by MacKonsti Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2759069 Share on other sites More sharing options...
Slice Posted May 23, 2021 Share Posted May 23, 2021 35 minutes ago, MacKonsti said: Hello @Slice thanks again for the r5135 release. However, please, can you explain the difference between releases in Git Hub? The full package ZIP (10MB) has CLOVERX64.efi that is different to the EFI-only zip release: The EFI only release is in the morning and shows Clover revision: 5135 (master, commit 5731ed0a8) The EFI binary in full-ZIP of mid-day has 916 differences (I binary-compared) and shows Clover revision: 5135 (master, commit f848a2179) Just to understand what is what and what should be used. Thank you! About what releases you tell? I don't know them. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2759071 Share on other sites More sharing options...
MacKonsti Posted May 23, 2021 Share Posted May 23, 2021 Hi @Slice I refer to the official releases r5135 files https://github.com/CloverHackyColor/CloverBootloader/releases/tag/5135 The EFI-only ZIP is different inside, compared to the full-ZIP (10MB) EFI binary... Thanks Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2759080 Share on other sites More sharing options...
Slice Posted May 23, 2021 Share Posted May 23, 2021 50 minutes ago, MacKonsti said: Hi @Slice I refer to the official releases r5135 files https://github.com/CloverHackyColor/CloverBootloader/releases/tag/5135 The EFI-only ZIP is different inside, compared to the full-ZIP (10MB) EFI binary... Thanks No problem, I updated the package. Anyway these files again are not final solution. If you find any bug please report we will correct it. 1 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2759086 Share on other sites More sharing options...
Slice Posted May 23, 2021 Share Posted May 23, 2021 @Jief_Machak You probably double files /Users/sergey/src/CloverBootloader/rEFIt_UEFI/refit/../gui/../libeg/../Settings/Self.h:19:7: warning: type 'struct Self' violates the C++ One Definition Rule [-Wodr] 19 | class Self | ^ /Users/sergey/src/CloverBootloader/rEFIt_UEFI/Settings/../Settings/../Settings/Self.h:19:7: note: a different type is defined in another translation unit 19 | class Self | ^ /Users/sergey/src/CloverBootloader/rEFIt_UEFI/refit/../gui/../libeg/../Settings/Self.h:33:36: note: the first difference of corresponding definitions is field 'm_SelfSimpleVolume' 33 | EFI_SIMPLE_FILE_SYSTEM_PROTOCOL* m_SelfSimpleVolume {}; // Volume containing this efi. | ^ /Users/sergey/src/CloverBootloader/rEFIt_UEFI/Settings/../Settings/../Settings/Self.h:25:21: note: a field with different name is defined in another translation unit 25 | static const EFI_FILE_PROTOCOL* getCloverDirAndEfiFileName(EFI_HANDLE ImageHandle, XStringW* efiFileName); | ^ /Users/sergey/src/CloverBootloader/rEFIt_UEFI/refit/../Settings/Self.h:55:14: warning: type of 'reInitialize' does not match original declaration [-Wlto-type-mismatch] 55 | EFI_STATUS reInitialize(); | ^ /Users/sergey/src/CloverBootloader/rEFIt_UEFI/Settings/Self.cpp:252:12: note: 'reInitialize' was previously declared here 252 | EFI_STATUS Self::reInitialize() | ^ and so on. Which one to delete? Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2759090 Share on other sites More sharing options...
eng_redaesm Posted May 23, 2021 Share Posted May 23, 2021 @Jief_Machak Can't build xcode or gcc /Users/redaismail/Documents/GitHub/CloverBootloader/rEFIt_UEFI/Settings/Self.cpp:71:13: error: unused variable 'efiFileName' [-Werror,-Wunused-variable] XStringW& efiFileName = *efiFileNamePtr; ^ /Users/redaismail/Documents/GitHub/CloverBootloader/rEFIt_UEFI/Settings/Self.cpp:98:13: error: unused variable 'CloverDir' [-Werror,-Wunused-variable] EFI_FILE* CloverDir = *CloverDirPtr; ^ 2 errors generated. make: *** [/Users/redaismail/Documents/GitHub/CloverBootloader/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit/OUTPUT/Settings/Self.obj] Error 1 build.py... : error 7000: Failed to execute command make tbuild [/Users/redaismail/Documents/GitHub/CloverBootloader/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit] build.py... : error F002: Failed to build module /Users/redaismail/Documents/GitHub/CloverBootloader/rEFIt_UEFI/refit.inf [X64, XCODE8, RELEASE] Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2759091 Share on other sites More sharing options...
Slice Posted May 23, 2021 Share Posted May 23, 2021 5 minutes ago, eng_redaesm said: @Jief_Machak Can't build xcode or gcc /Users/redaismail/Documents/GitHub/CloverBootloader/rEFIt_UEFI/Settings/Self.cpp:71:13: error: unused variable 'efiFileName' [-Werror,-Wunused-variable] XStringW& efiFileName = *efiFileNamePtr; ^ /Users/redaismail/Documents/GitHub/CloverBootloader/rEFIt_UEFI/Settings/Self.cpp:98:13: error: unused variable 'CloverDir' [-Werror,-Wunused-variable] EFI_FILE* CloverDir = *CloverDirPtr; ^ 2 errors generated. make: *** [/Users/redaismail/Documents/GitHub/CloverBootloader/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit/OUTPUT/Settings/Self.obj] Error 1 build.py... : error 7000: Failed to execute command make tbuild [/Users/redaismail/Documents/GitHub/CloverBootloader/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit] build.py... : error F002: Failed to build module /Users/redaismail/Documents/GitHub/CloverBootloader/rEFIt_UEFI/refit.inf [X64, XCODE8, RELEASE] Take sources again https://github.com/CloverHackyColor/CloverBootloader/commit/fe480f9625572a45c6aaf584b8245f9332f2d930 2 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2759092 Share on other sites More sharing options...
eng_redaesm Posted May 23, 2021 Share Posted May 23, 2021 22 minutes ago, Slice said: Take sources again https://github.com/CloverHackyColor/CloverBootloader/commit/fe480f9625572a45c6aaf584b8245f9332f2d930 DONE WORKING NOW Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2759093 Share on other sites More sharing options...
Jief_Machak Posted May 23, 2021 Share Posted May 23, 2021 Sorry, for the unused variables. Forgot to compile Release before commit. /Users/sergey/src/CloverBootloader/rEFIt_UEFI/refit/../gui/../libeg/../Settings/Self.h:19:7: warning: type 'struct Self' violates the C++ One Definition Rule [-Wodr] 19 | class Self | ^ /Users/sergey/src/CloverBootloader/rEFIt_UEFI/Settings/../Settings/../Settings/Self.h:19:7: note: a different type is defined in another translation unit 19 | class Self | ^ What was the problem for that ? Never saw errors like these. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2759096 Share on other sites More sharing options...
Slice Posted May 23, 2021 Share Posted May 23, 2021 41 minutes ago, Jief_Machak said: Sorry, for the unused variables. Forgot to compile Release before commit. /Users/sergey/src/CloverBootloader/rEFIt_UEFI/refit/../gui/../libeg/../Settings/Self.h:19:7: warning: type 'struct Self' violates the C++ One Definition Rule [-Wodr] 19 | class Self | ^ /Users/sergey/src/CloverBootloader/rEFIt_UEFI/Settings/../Settings/../Settings/Self.h:19:7: note: a different type is defined in another translation unit 19 | class Self | ^ What was the problem for that ? Never saw errors like these. Same class defined twice but differently. You should use common header. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2759097 Share on other sites More sharing options...
Slice Posted May 23, 2021 Share Posted May 23, 2021 Oh no. The problem is different. The message is /Users/sergey/src/CloverBootloader/rEFIt_UEFI/refit/../gui/../libeg/../Settings/Self.h:33:36: note: the first difference of corresponding definitions is field 'm_SelfSimpleVolume' 33 | EFI_SIMPLE_FILE_SYSTEM_PROTOCOL* m_SelfSimpleVolume {}; // Volume containing this efi. | ^ The symbols {} means realisation. And it happen every time when #include "self.h" is used. So twice include = double realisation. And this is the error. Compiler must warn about such usage. For example in the first realisation there in initialisation by 0 and second realisation will initialise by 1. But usage assumes it is the same. Common rule: .h file contains only definitions while .cpp contains realisation. cpp presents once while .h can be included many times. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/1079/#findComment-2759099 Share on other sites More sharing options...
Recommended Posts