Clover General discussion

[Slice]

21 minutes ago, LAbyOne said:

 

 

@Slice

hi, i've just installed new 5114, and effectively there's some improvement on badges size, even if far from real size it should be. (in my case)

My question is, whether this is still in progress, or its the new form/proportions clover will take

(just asking to eventually make the needed changes to the icons affected to reflect actual design/position they where meant to have originally) 

Scale from 1 to 16. I just don't remember what was default value. May be 8?

 

 

@ameris cyning

You don't need to set FakeCPUID the same as real CPUID. FakeCPUID should differ from real.

But I think you want to see some other titles in "About this Mac"? It is unpredictable. Apple may write here what he want without any logic.

Anyway it depends on Mac model and on CPU Type

You probably want to set 0x1005 or may be 0x0709. Test and report.

 

[ameris_cyning]

19 minutes ago, Slice said:

Scale from 1 to 16. I just don't remember what was default value. May be 8?

 

 

@ameris cyning

You don't need to set FakeCPUID the same as real CPUID. FakeCPUID should differ from real.

But I think you want to see some other titles in "About this Mac"? It is unpredictable. Apple may write here what he want without any logic.

Anyway it depends on Mac model and on CPU Type

You probably want to set 0x1005 or may be 0x0709. Test and report.

 

 

0x0709 shows me i7 at last. Thank you for that. Unfortunately that does not solve my issue of ig-platform-id not being injected. I am having color banding issues and I am trying to use other IDs to see if that fixes the problem. Injecting my laptop's monitor EDID did not work at all so that is why I am trying this.

[Slice]

Clover injected ig-platform-id 100%.

[vector sigma]

12 hours ago, Badruzeus said:

Good idea, but if I still remember png image would become 'glitchy' even if it was resized smaller from 256px to 128px directly. Using real image size from Graphics Editor on the contrary, it was 'smooth'. Plz explain it better. Thanks.

Well, I guess resizing from a largest image is the best one can do. I had problems resizing images mantaining right colors plus the optimizing,  but now I think I'm perfect, see by your self:

 

before (icns from 16x16 up to  1024x1024) 

vol_clover.icns.zip

 

to png 128x128

vol_clover.png.zip

 

P.S. the autodetection of the screen resolution works like a sharm. And cannot be less than 128x128. Then I set this rule:

 

   // determine the icon size
    var iconSize : Int = 128 // default
    switch screenWidth {
    case 0...2048:
      iconSize = 128
    case 2049...2560:
      iconSize = 192
    case 2561...3840:
      iconSize = 256
    case 3841...7680:
      iconSize = 400
    case 7681...12000:
      iconSize = 512
    default:
      break
    }

the rule can be changed and may be decided by the user when it knows the desired size (but for now is for bad themes).

To mantain quality, however, icons are sized at max with the smallest size found in all image (in the case not all the icons os_* and vol_* have the same size). e.g. if the smallest size is 177x177 pixels and your screen width is between 2049 and 2560 cannot be 192x192 as suggested .. but will be 177x177 anyway. 

Edited April 22, 2020 by vector sigma

[Badruzeus]

Anyway, with r5114 I get 'system halted' error immediately when a theme which contains 'anime' is in use || debug.log below is using 'Gothic' (and to make sure I've tried several animated themes as well including; BGM, Clovernity, DarkBoot*, Neon, Shield, etc. with similar result). Thanks.

 

debug.log_r5114_AOH.zip

Edited April 22, 2020 by Badruzeus

[chris1111]

I have a lots of Anim theme and all working perfect no issue

I try also BGM and black_green without any issue

 

 

[Badruzeus]

36 minutes ago, chris1111 said:

I have a lots of Anim theme and all working perfect no issue

I try also BGM and black_green without any issue

Interesting! Might be caused by different display sizes? Mine is just 800x600. Using animated theme, try with 768, 600 or even 480px resolution height and let me know (alternatively pressing 'F9' on Clover GUI).

 

Or if you have more recent prebuilt CLOVERX64.efi then plz attach it here (my test was using GitHub release). Thanks.

[chris1111]

24 minutes ago, Badruzeus said:

Interesting! Might be caused by different display sizes? Mine is just 800x600. Using animated theme, try with 768, 600 or even 480px resolution height and let me know (alternatively pressing 'F9' on Clover GUI).

 

Or if you have more recent prebuilt CLOVERX64.efi then plz attach it here (my test was using GitHub release). Thanks.

here you go

 

 

r5114 (d3da5e1a2).zip

[Pene]

17 hours ago, Badruzeus said:

Anyway, with r5114 I get 'system halted' error immediately when a theme which contains 'anime' is in use || debug.log below is using 'Gothic' (and to make sure I've tried several animated themes as well including; BGM, Clovernity, DarkBoot*, Neon, Shield, etc. with similar result). Thanks.

 

debug.log_r5114_AOH.zip

I again could not reproduce it, but I think I see why that crash could happen, so hope I fixed it: CLOVERX64.zip

Edited April 23, 2020 by Pene
Updated binary to 1ec5726

[Alpha22]

 

does not detect F1: Help

 

Edited April 23, 2020 by Alpha22

[Slice]

6 hours ago, Alpha22 said:

 

 

does not detect F1: Help

 

I still can't understand what you show me. I see

[Alpha22]

Clover_r5108

 

 

from the version of Clover_5109 to 5114 I find the double writing of the Clover version in the lower left

 

Clover_r5114

 

Edited April 23, 2020 by Alpha22

[Slice]

1 hour ago, Alpha22 said:

Clover_r5108

 

 

 

from the version of Clover_5109 to 5114 I find the double writing of the Clover version in the lower left

 

Clover_r5114

 

 

Did you see my screenshot with version 5114?

[Alpha22]

Quote

Did you see my screenshot with version 5114?

yes

where is wrong in my case

[Pene]

@Slice

Regarding your commit "detect unknown linux versions":

This has the effect for some distros, of no longer loading custom linux icons that were defined in LinuxEntryData, for example MX linux will no longer have "mx,linux", so only "linux" icon will be loaded

 

If I look at LinuxEntryData, I see some had "special" icon naming:

\EFI\LinuxMint\ -> mint

\EFI\arch_grub\ -> arch

\EFI\opensuse\ -> suse

\EFI\ORACLE\ -> solaris

\EFI\elementary\ -> eos

\EFI\pclinuxos -> pclinux

\EFI\MX19 -> mx

 

Edited April 23, 2020 by Pene

[maclinuxG4]

add at your list manjaro, i have a partition on my hack thanks (EFI/manjaro)

[Pene]

2 minutes ago, maclinuxG4 said:

add at your list manjaro, i have a partition on my hack thanks (EFI/manjaro)

manjaro has standard naming (\EFI\Manjaro\grubx64.efi and "manjaro" as icon), so nothing to add.

 

 

[Slice]

44 minutes ago, Pene said:

@Slice

Regarding your commit "detect unknown linux versions":

This has the effect for some distros, of no longer loading custom linux icons that were defined in LinuxEntryData, for example MX linux will no longer have "mx,linux", so only "linux" icon will be loaded

 

If I look at LinuxEntryData, I see some had "special" icon naming:

\EFI\LinuxMint\ -> mint

\EFI\arch_grub\ -> arch

\EFI\opensuse\ -> suse

\EFI\ORACLE\ -> solaris

\EFI\elementary\ -> eos

\EFI\pclinuxos -> pclinux

\EFI\MX19 -> mx

 

We can create an array for this substitutions in procedure 

const XImage& XTheme::LoadOSIcon(const XString& Full)

[Slice]

Or before it called, before line

XString IconXS = OSName + ",linux"_XS;

make a substitution from OSName to "special" icon names.

[Pene]

2 hours ago, Slice said:

Or before it called, before line

XString IconXS = OSName + ",linux"_XS;

make a substitution from OSName to "special" icon names.

Yes, this sounds good.

Speaking of icons, I also see a report on GitHub that undetected OS no longer has icon (I think that what's he trying to say, that for entries that are not windows/linux/Mac, no icon gets loaded).

 

And indeed, that is also true, we are setting in loader.cpp:

    case OSTYPE_OTHER:
    case OSTYPE_EFI:
      OSIconName = L"clover";
      ShortcutLetter = 'E';
      Entry->LoaderType = OSTYPE_OTHER;
      break;
    default:
      OSIconName = L"unknown";
      Entry->LoaderType = OSTYPE_OTHER;
      break;

So before there was XTheme, for OSTYPE_OTHER the icon "os_clover" was loaded (not sure why os_clover for other OS, but that's how it worked).

 

But now, after the change to XTheme, there is nothing to handle loading of os_clover and os_unknown icons.

The only icons that get loaded are the ones specified in IconsNames[] array, and we have no os_clover or os_unknown there. Maybe they should be added? Not sure how you prefer to handle this.

(The only exception to loading icons that are not specified in that array is made by LinuxScan() that specifically loads the icon specified from disk).

Edited April 23, 2020 by Pene

[Slice]

os_clover is not good idea for OSTYPE_OTHER but os_unknown can be implemented if any theme contains it.

[Pene]

12 hours ago, Slice said:

os_clover is not good idea for OSTYPE_OTHER but os_unknown can be implemented if any theme contains it.

Yes, I didn't understand why it was used for OSTYPE_OTHER also. Anyway, what was the original purpose of os_clover, is it still relevant?

By the way, I looked in some themes and I see many contain os_unkonwn, so it seems we can use that instead.

 

Edited April 24, 2020 by Pene

[Pene]

On 4/23/2020 at 9:39 AM, Alpha22 said:

The only possible explanation I can see for this is that your volume label is also named 5114. Any install scripts by any chance change the volume label?

[Slice]

tonymac? niresh? something else?

[Slice]

18 hours ago, Alpha22 said:

yes

where is wrong in my case

Check if you have invisible file on EFI partition

.VolumeLabel.txt

And tell us what is the method to install Clover you used.