Jump to content
InsanelyMac Forum

Pene

Coders
  • Content count

    114
  • Joined

  • Last visited

  • Days Won

    1

Pene last won the day on January 3 2013

Pene had the most liked content!

About Pene

  • Rank
    InsanelyMac Geek

Profile Information

  • Gender
    Male

Recent Profile Visitors

4,070 profile views
  1. Pene

    Clover General discussion

    Hi Slice, apianti, Download-Fritz, and everyone else who's still here I've updated my system (after a long pause in the osx department), so now I put also High Sierra on it, and of course came here for a visit. Yes, AptioFix2 works with High Sierra. For my board I use a mixture of AptioFix2 with LowMemFix with KERNEL_TOP_ADDRESS=0x40000000. I've seen 10.13 boot.efi allocate way up to 1GB on my system, and I have a clean memory map with the exception of 40 pages at 0x3289A000 that were causing occasional "couldn't allocate runtime area" and had to be freed.
  2. Pene

    Clover General discussion

    Resolved in r3288.
  3. Pene

    Clover General discussion

    I'm fine, thanks Yourself? Yes, I see r2381 changed "Other" dir to always load first, and then specific versions directories. So basically "Other" is now more like "Common". Confusing name, if that's the intended behaviour.
  4. Pene

    Clover General discussion

    Unfortunately, time is something we have less and less... But I recently installed El Capitan, so I came to check what's going on. Change what? I wasn't really following lately. I compiled with latest EDK2 (with only two patches, MdePkg/Include/Base.h & BaseTools/Scripts/gcc4.9-ld-script) on El Capitan and didn't see any special problems. P.S. I see with r3283 you added objc to --enable-languages= for gcc. Not sure why objc is needed, but for objc support to compile also on Xcode 7.x we need the patch I added to r3285. Or if objc is not needed, then the patch can be removed also.
  5. What do you mean - the animation is perfect if autoboot is disabled? Which autoboot? Can you reproduce the exact changes that solve the situation described in your photos? -- Many options, simplest is config.plist: (By the way, it makes sense to do it only with Inject nvidia disabled, as if it is enabled, that property is already being added... But nvidia injection doesn't seem to be really needed anymore with latest OS drivers) ... <key>Graphics</key> <dict> <key>Inject</key> <dict> <key>NVidia</key> <false/> </dict> ... <key>Devices</key> <dict> <key>AddProperties</key> <array> <dict> <key>Device</key> <string>NVidia</string> <key>Key</key> <string>@0,AAPL,boot-display</string> <key>Value</key> <data>AQAAAA==</data> </dict> </array> ...
  6. Now to some testing of the Grub HfsPlus driver: Unfortunately, for media created by 'createinstallmedia' the situation is similar to VboxHfs, so it also doesn't handle hfs hard links properly. It seems to support symlinks though (which VBoxHfs does not), but this doesn't really help us.
  7. Regarding FreeFsInstance(), I think that RootFile is being allocated by grub_file.c, GrubCreateFile(). The assert is because it tries to free it without checking it if its value is NULL, so it may end up trying to FreePool(NULL). I think we should just add checks for non-NULL values in FreeFsInstance(), for both DevicePathString and RootFile, as I see in the code cases where FreeFsInstance() may be called without any of these being allocated. Anyway, with the above checks added, and commenting out the FreePool which you mentioned (which is not being allocated, so there's no reason to free it), there seem to be no more asserts.
  8. Thanks dmazar. Indeed that is one issue. Another issue is in driver.c, FreeFsInstance(): FreePool(Instance->RootFile). That one assets also for FreePool on EFI_INVALID_PARAMETER.
  9. Hi Andy, Thanks. I tried to test this HfsPlus driver, under Qemu with OvmfClover firmware compiled with DEBUG mode ( ./ebuild.sh -D CSM_ENABLE -b DEBUG). This allows me to see debugging information printed by edk2 code. Edk2 Asserts when Grub HfsPlus loads with: InstallProtocolInterface: 5B1B31A1-9562-11D2-8E3F-00A0C969723B 7F170A40 Loading driver at 0x0007EC17000 EntryPoint=0x0007EC172AF HFSPLUS.efi InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF 7F174218 ASSERT /Users/pene/Desktop/CloverGrowerPro/edk2/MdeModulePkg/Core/Dxe/Mem/Pool.c(425): CR has Bad Signature This happens both if I use the binary you uploaded, and also if I compile it myself. Not sure what's wrong yet, but something is. If I had tried without DEBUG, it may have passed this point (with RELEASE asserts are disabled), but this issue needs to be ironed out. The assertion is at CoreFreePoolI (), so this is most probably a memory management issue. I didn't really try to look into it deeply yet to figure out why, but if you have any ideas, they are welcome
  10. Speaking of the HFS driver, did anyone test if this grub HFS driver properly supports links (aka can boot media created by 'createinstallmedia')? I'm away from home for a while, so I can't really test things. If it properly reads 'createinstallmedia' disk, I think it might be a good idea to switch the driver used in Clover to this one instead of VBoxHfs (if it is OK with Andy, of course).
  11. Slice, note that with r2819 you changed in fdf to VBoxHfs (instead of HFSPlus that was used previously). This will break in CloverEFI the possibility to boot installers created by 'createinstallmedia' (no links support in VBoxHfs). Also, just wondering, which diff file are you referring to? I did not see any diff file...
  12. Do you get black screen also if you use "-v"? I did not see any other reports with this behaviour. But anyway, there were some changes in boot.efi regarding Logo drawing, so for now, you can probably use boot.efi from DP3 instead, and you will get back old behavior.
  13. But did you try to set what I wrote? (CustomLogo=false) It should solve your problem. CustomLogo seems not needed anymore for DP4, and it should operate properly with CustomLogo=false. Beware that it defaults to true for Yosemite if you don't specifically set it to false. About the progress bar - CustomLogo (unless it is set to false) currently blocks the progress bar in latest revisions. We are waiting for apianti to address this.
×