Jump to content
30960 posts in this topic

Recommended Posts

On 3/8/2020 at 11:38 PM, Jief_Machak said:

@Slice I can see that you change "static   XPointer mPointer;" back to what is was before (non-static). Was it just a trial ? Because having an instance of XPointer in each XImage seems no right : a big memory consumming. And there will only be one pointer at a time, right ?

So for me, XPointer should only exist once. Either as a global, or as a static in a class. Same thing : only one instance exist. Am I right ?

I prefer Pointer arises at each screen and disappear after change screen.

But I afraid static pointer will have images or position from previous screen which is incorrect.

7 hours ago, Jief_Machak said:

I can switch without problems between these 2 themes.

So I can only help if you send me the img you use in Qemu and the exact procedure.

I send my Qemu.img into github  and test.sh which reproduced the problem.

Unpack img.7z.

Mount img.

cd Qemu

./test.sh

2 minutes ago, Slice said:

I send my Qemu.img into github  and test.sh which reproduced the problem.

Unpack img.7z.

Mount img.

cd Qemu

./test.sh

Use the file sharing instead for GitHub ?

7 hours ago, Slice said:

I prefer Pointer arises at each screen and disappear after change screen.

But I afraid static pointer will have images or position from previous screen which is incorrect.

 

I think I've put it back to static to try. I'm afraid I must have committed it with something else. I don't want to force it. Both options works.

The advantage of sharing is to save memory and to avoid reallocations. I would go with a "setEmpty". Remember with all the Array objects, size is 0 but memory stays allocated, which the next time you need it, it's there.

As we talk before, I always go more for "setEmpty" than destroy and recreate when possible.

 

11 minutes ago, Slice said:

If it will work then let it be.

12Mb is not so much for github. Or no? Take it and delete again.

Maybe we should setup a new repo for exchanging these kind of files...

Edited by Jief_Machak

I found the error with switch from cesium to embedded. It is my old mistake with pointers on the same place. Once I free first pointer I have not to free second one.

It seems to be better to copy memory. Not good as well. Or make handles: pointer to pointer. Once first is freed and zeroed then second will point to zero.

I committed for now just memory leak to avoid crash.

15 hours ago, exquirentibus said:

After getting 10.15.3 installed, I'm seeing a very strange icon in 5104 CloverHacky for a USB connected SSD that is 10.15.3 bootable?  Should I be concerned?

 

UEFI drivers
FSInject.efi
FwRuntimeServices.efi
OcQuirks.efi (from OcQuirks rev 17)
OcQuirks.plist
VBoxHfs.efi

from 5104 CloverHacky
UEFI\FileSystem\ApfsDriverLoader.efi

 

 

 

ApfsDriverLoader.efi must be in EFI/CLOVER/Drivers/UEFI like your others efi drivers.

7 hours ago, Matgen84 said:

 

ApfsDriverLoader.efi must be in EFI/CLOVER/Drivers/UEFI like your others efi drivers. 

Yes, it is located in EFI/CLOVER/Drivers/UEFI.

 

I had documented where I found it on another thread (getting the right set of working EFI drivers can be tricky for those who only think about them once a year), and should have removed that in this thread.

 

That strange looking icon (possibly  os_moja.icns  from a Friday post you made?)  seems to appear on different drives at different times, but I don't remember ever seeing it until I upgraded to 10.15.3.  I included the UEFI drivers in case specific ones had a side effect that might explain it?

 

It's not causing any problems - and probably something I ignorantly changed while experimenting to get 10.15.3 working.  No doubt installing a proper theme or new release will fix it.

  • Like 1
1 hour ago, LAbyOne said:

Hi @vector sigma

seems I have a little troubles building CloverApp after last update

how's that?

422606218_Screenshot2020-03-10at18_56_43.png.8b509c1b7ca9c2c170851dec3a9c3676.png

 

then just a generic question for @Slice

is it necessary to have QEmu being added to clover when updating build?

No, the build system should exclude qemu from release.

@vector sigma

  • Thanks 1
54 minutes ago, Slice said:

No, the build system should exclude qemu from release.

@vector sigma

For the moment I made a copy of SETTINGS_DATA structure in Clover.app. Should be nice to have anything after line 45 (or after 113) in a single header for the future and forgot to link to EDK2 as basic types can be redeclared there.

 

About qemu ... I'll take a look later as I still did not build Clover to see what should be excluded.. 

 

Edited by vector sigma
9 minutes ago, telepati said:

Guys I little confused. What is the difference r5105 (11.3 MB) between V2 5105 (9.39MB). Which one should I download?

CloverV2 is the zipped CloverV2 directory. The other one is the pkg + md5 which in case is compressed with the loseless compression algo decided by pkgutil... which is way better than zip... why the difference.

Edited by vector sigma
  • Thanks 1
1 hour ago, vector sigma said:

CloverV2 is the zipped CloverV2 directory. The other one is the pkg + md5 which in case is compressed with the loseless compression algo decided by pkgutil... which is way better than zip... why the difference.

I just asked what is the difference between them because of their size. But you have already done enough explanation. Thank you.

 

@vector sigma Why does clover.app work even though I didn't choose to run at login? 

 

1154065307_ScreenShot2020-03-11at00_19_35.png.7619ba291a3e99372c2fafe919034203.png

Edited by telepati

r5105 build good and boot well but only one things on UEFI booting the windows Icon is no seeing in gui clover.

I try different theme with the same result

Thanks anyway for the latest build 

PS: Legacy booting is not an issue

 

 

screenshot1.png.5a6d20f0dcce9387b9b3836c78e6e84c.png

 

Edited by chris1111
Windows Icon
  • Sad 1
1 hour ago, chris1111 said:

r5105 build good and boot well but only one things on UEFI booting the windows Icon is no seeing in gui clover.

I try different theme with the same result

Thanks anyway for the latest build 

PS: Legacy booting is not an issue

 

 

screenshot1.png.5a6d20f0dcce9387b9b3836c78e6e84c.png

 

 

I test latest r5105 build from source (2e598c0) in UEFI booting: there is no issue here for Windows icons

 

PS: I've to separate hard disk.

  • Like 1
9 hours ago, Matgen84 said:

 

I test latest r5105 build from source (2e598c0) in UEFI booting: there is no issue here for Windows icons

 

PS: I've to separate hard disk.

Windows installed UEFI or legacy ?

 

 

EDIT***

Latest commit and new build + clear nvram work here for windows icons

Edited by chris1111
new build + clear nvram
  • Like 1
8 hours ago, chris1111 said:

Windows installed UEFI or legacy ?

 

 

EDIT***

Latest commit and new build + clear nvram work here for windows icons

 

Great :thumbsup_anim: Windows installed UEFI here.

  • Like 1

Hi

 

Since several commits, there is a little mistake on my clover install log file: I don't understand why.

 


Clover EFI installer log - Wed Mar 11 10:35:36 CET 2020
Installer version: %CLOVERVERSION% r5105 EFI bootloader
======================================================

 

Hi guys! 

 

There seem to be some issues with release 5105.

 

1. themes seem to be broken. Went back to 5104 for now. Now everything ok again.

screenshot6.thumb.png.9858d9a1d336aa8f50747efbd8715179.png

 

2. CloverUpdater points to a Page not Found: https://github.com/CloverHackyColor/CloverBootloader/releases/download/5105/Clover_v2.5k_r5105.pkg

 

3. The Clover_r5105.zip option from Clover Github Releases page goes to Page not Found: https://github.com/CloverHackyColor/CloverBootloader/releases/download/5105/Clover_r5105.zip

 

The only way I managed to get 5105 in pkg version was by renaming the link above and pointing it to https://github.com/CloverHackyColor/CloverBootloader/releases/download/5105/Clover_r5105.pkg

Edited by arsradu
×
×
  • Create New...