Jump to content

Clover General discussion

ErmaC

By ErmaC,
in Clover

 Share
30960 posts in this topic

Recommended Posts

Matgen84
Matgen84
Posted
Posted

Hi @Slice

 

I can't build latest commit.

 

Spoiler

[CC] AutoGen
In file included from /Users/mathieu/src/CloverBootloader/rEFIt_UEFI/Platform/AcpiPatcher.cpp:20:
In file included from /Users/mathieu/src/CloverBootloader/rEFIt_UEFI/Platform/StateGenerator.h:9:
In file included from /Users/mathieu/src/CloverBootloader/rEFIt_UEFI/Platform/AmlGenerator.h:13:
In file included from /Users/mathieu/src/CloverBootloader/rEFIt_UEFI/Platform/Platform.h:99:
In file included from /Users/mathieu/src/CloverBootloader/rEFIt_UEFI/Platform/../refit/IO.h:28:
/Users/mathieu/src/CloverBootloader/rEFIt_UEFI/refit/../gui/menu_items/menu_items.h:427:39: error: field 'mItemID' will be initialized after field 'mPointer' [-Werror,-Wreorder]
                                                  Film(0), mAction(ActionNone), mItemID(0), mPointer() //, StyleFunc(&REFIT_MENU_SCREEN::TextMenuStyle)
                                                                                ^
/Users/mathieu/src/CloverBootloader/rEFIt_UEFI/refit/../gui/menu_items/menu_items.h:435:39: error: field 'mItemID' will be initialized after field 'mPointer' [-Werror,-Wreorder]
                                                  Film(0), mAction(ActionNone), mItemID(0), mPointer() //, StyleFunc(&REFIT_MENU_SCREEN::TextMenuStyle)
                                                                                ^
/Users/mathieu/src/CloverBootloader/rEFIt_UEFI/refit/../gui/menu_items/menu_items.h:442:39: error: field 'mItemID' will be initialized after field 'mPointer' [-Werror,-Wreorder]
                                                  Film(0), mAction(ActionNone), mItemID(0), mPointer() //, StyleFunc(&REFIT_MENU_SCREEN::TextMenuStyle)
                                                                                ^
3 errors generated.
make: *** [/Users/mathieu/src/CloverBootloader/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit/OUTPUT/Platform/AcpiPatcher.obj] Error 1


build.py...
 : error 7000: Failed to execute command
    make tbuild [/Users/mathieu/src/CloverBootloader/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit]


build.py...
 : error F002: Failed to build module
    /Users/mathieu/src/CloverBootloader/rEFIt_UEFI/refit.inf [X64, XCODE8, RELEASE]

- Failed -
Build end time: 17:57:01, Mar.06 2020
Build total time: 00:00:17

 

Matgen84
Matgen84
Posted
Posted (edited)

Hi @Slice

 

I just build and install latest r5104  (a00e14851). I've the same issues described yesterday: quick test message left top corner "all tests" + no icons. 

 

My knowledge is limited: It seems that the files with icns extension aren't display correctly.
 

screenshot0.png

Edited by Matgen84
Slice
Slice
Posted
Posted
18 minutes ago, Matgen84 said:

Hi @Slice

 

I just build and install latest r5104  (a00e14851). I've the same issues described yesterday: quick test message left top corner "all tests" + no icons. 

 

My knowledge is limited: It seems that the files with icns extension aren't display correctly.
 

screenshot0.png

I excluded icns decoder because years ago we stated that all icons must be PNG files renamed to .icns.

  • Like 1
  • Confused 1
Matgen84
Matgen84
Posted
Posted (edited)
9 minutes ago, Slice said:

I excluded icns decoder because years ago we state that all icon must be PNG files renamed to .icns.

 

Sorry for my bad english: all icons are png files rename to .icns as I describe yesterday. I use one of BadruZeus's theme for Clover that worked fine before. It works if I rollback to r5104 (8dbd938bf).

 

What about quick test message left top corner "all tests"

Edited by Matgen84
Matgen84
Matgen84
Posted
Posted

Hi again @Slice

 

I've found a new issue. When I use spacebar or arrow key: there is new message: a code line about operator or something like that, at left top corner. F10 don't work because keyboard don't work, so I can't post the screenshot.

Slice
Slice
Posted
Posted
2 hours ago, Matgen84 said:

 

Sorry for my bad english: all icons are png files rename to .icns as I describe yesterday. I use one of BadruZeus's theme for Clover that worked fine before. It works if I rollback to r5104 (8dbd938bf).

 

What about quick test message left top corner "all tests"

The message "all tests..ok" can be excluded. It will be no in release.

But about icns (PNG) I didn't test the theme. I think those png files are not standard. See Optimise PNG files

Anyway it is strange that it worked before.

  • Like 1
  • Thanks 1
Matgen84
Matgen84
Posted
Posted (edited)
1 hour ago, Slice said:

The message "all tests..ok" can be excluded. It will be no in release.

But about icns (PNG) I didn't test the theme. I think those png files are not standard. See Optimise PNG files

Anyway it is strange that it worked before.

 

@Slice The theme I'm using, is a BadruZeus's theme for Clover, included in CloverThemeManager. So, I think  icns (PNG) are already optimize. This theme works fine with the version r5104 (8dbd938bf) 
@Jief_Machak knows the problem since Friday (see previous post).

 

Now, there is another issue: When I use spacebar or arrow key to access to Menu: there is new message: a code line message about 'operator' or something like that, at left top corner. F10 don't work because keyboard don't work, so I can't post the screenshot.

Edited by Matgen84
Slice
Slice
Posted
Posted
On 3/6/2020 at 12:50 PM, Matgen84 said:

 

This theme works fine with r5104 (8dbd938bf), don't works with r5104 (bc45ded34): perhaps, the problem comes from change between these two versions and in several commits.

Unfortunately, I have no debug version because I only compile in release mode. So it is difficult to do tests to pinpoint the problem.

There are changes in lodepng.cpp. But we have more recent version and it should work better as the author said.

I may suppose bad png icons are decoded by old algo but failed with better algo. 

Matgen84
Matgen84
Posted
Posted
23 minutes ago, Slice said:

There are changes in lodepng.cpp. But we have more recent version and it should work better as the author said.

I may suppose bad png icons are decoded by old algo but failed with better algo. 

 

If it's right, There will be a lot of problems for all themes in CloverThemeManager and the great themes created by Badruzeus. :cry: 

  • Haha 1
Matgen84
Matgen84
Posted
Posted
36 minutes ago, Slice said:

May be additional button? <Optimize theme icons>

 

I try Optimize png on my current theme: icons appears again but the new message: a code line message about 'operator'  remains (no keyboard, no mouse). I can boot using timeout.

Matgen84
Matgen84
Posted
Posted
8 minutes ago, Slice said:

The message is 


12:072  2:196  XArray::ElementAt(xsize) const -> Operator [] : index > m_len

when I pressed SPACE on Mojave icon.

 

Right. :) or when I pressed ARROW key left or right.

Matgen84
Matgen84
Posted
Posted
12 hours ago, vector sigma said:

Done: Clover.app.zip

 

guys please report back.. thanks

 

Hi @vector sigma

 

I've got a problem with indexing: not all themes are in preview window. Is it possible to optimize a theme installed which is not in the GitHub theme repo! I don't know if I made a mistake but when I check "Show Installed", Clover.app close itself.

 

Thanks

Capture d’écran 2020-03-08 à 08.03.35.png

  • Like 1
vector sigma
vector sigma
Posted
Posted
7 hours ago, Matgen84 said:

repo! I don't know if I made a mistake but when I check "Show Installed", Clover.app close itself.

Simply, you have a very very slow internet connection and no patient :hysterical:. Jokes aside try the last:

 

Clover.app.zip

 

P.S. you can now optimize only installed themes.

 

@Slice, I introduced error handling optimizing themes and this is what I got at first try: 

Can't load /Volumes/EFI/EFI/CLOVER/themes/BGM/icons/pointer.icns: incorrect PNG signature, it's no PNG or corrupted

error.png.9af5c6bbdbb0abc58c9fa4f750a88088.png

 

manually checking it is true because it is really an icns instead of a png. Isn't this causing problems?

 

  • Like 1
Matgen84
Matgen84
Posted
Posted
30 minutes ago, vector sigma said:

Simply, you have a very very slow internet connection and no patient :hysterical:. Jokes aside try the last:

 

Clover.app.zip

 

P.S. you can now optimize only installed themes.

 

 

Thanks. :weight_lift:

 

I've error message 'incorrect PNG signature, it's no PNG or corrupted' on several real png file on several theme.

  • Like 2
Matgen84
Matgen84
Posted
Posted
43 minutes ago, Jief_Machak said:

I'm about to commit the fix in a minute.

 

I've this issue when I build

  

[SLINK] CLOVERX64
Undefined symbols for architecture x86_64:
  "egDecodeICNS(unsigned char*, unsigned long long, unsigned long long, unsigned char)", referenced from:
      egLoadIcon(_EFI_FILE_PROTOCOL*, wchar_t const*, unsigned long long) in CLOVERX64.lib(image.obj)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [/Users/mathieu/src/CloverBootloader/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit/DEBUG/CLOVERX64.dll] Error 1


build.py...
 : error 7000: Failed to execute command
	make tbuild [/Users/mathieu/src/CloverBootloader/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit]


build.py...
 : error F002: Failed to build module
	/Users/mathieu/src/CloverBootloader/rEFIt_UEFI/refit.inf [X64, XCODE8, RELEASE]

- Failed -
Build end time: 17:53:52, Mar.08 2020

 

 Share
Go to topic listing
×
×
  • Create New...