Jump to content

Customized OpenCore with additional features


n.d.k
1,348 posts in this topic

Recommended Posts

2 hours ago, Rocky12 said:

first of all i am really thankful to all those of you who help me to solve this issue

and yes i did the changes but i don don't know if i did the right way but the result is as usual

config.plist.zip

opencore-2020-02-20-150451.txt.zip

 

You provide log files but you do not read them first :no:

 

Your log file shows:

78:323 00:624 OC: Image Kexts\AppleMCEReporterDisabler.kext\Contents\MacOS\AppleMCEReporterDisabler is missing for kext AppleMCEReporterDisabler.kext ()

Which clearly shows that AppleMCEReporterDisabler.kext/Contents/MacOS/AppleMCEReporterDisabler is missing for kext.

I just downloaded AppleMCEReporterDisabler.kext and checked its content and indeed there is NO executable and so this kext is an Info.plist patch.

 

I did suggest to that you should check the content of that kext and if you had, you would have noticed that the kext does not have an executable. Which means that in the config.plist file, you leave the ExecutablePath string EMPTY for that kext.

  • Like 1
Link to comment
Share on other sites

Here is a simple and effective method to get your ScanPolicy value:

Let’s say your config has Windows (NTFS) & MacOS (APFS) on Sata & NVMe Drives, but you’d also like to scan your USB for OS Installation purpose. 

1- Enter your Calculator in MacOS   ( Programmer : CMD3 )

You’ll have this window.CALC.thumb.png.1cc20f7717e2fbbfa81de977374518bd.png

Without entering any numeric values, you just need to click on the desired binary value (in front of the red arrow) to switch it from 0 to 1  ( 0= False / 1=True )

By clicking on the desired values the big Hex value will appear:

747559808_ScreenShot2020-02-20at13_26_16.png.8514385182d0db6ec94ac7447ca3e820.png

 

FSL + DL+ APFS+NTFS+SATA+SAS/Mac NVMe +NVMe+USB

  0. +  1. +  8.  +   11. +  16. +     17.            +  19.  +  21.    

( Note that the ESP Value =0 so no EFI will be scanned.)

By converting that HEX value to Decimal ( Any Hex Converter )

You’ll get 0x2B0903 -> 2820355 ( Your New Scan Policy )

Done !

Edited by Ellybz
  • Like 7
  • Thanks 2
Link to comment
Share on other sites

2 hours ago, Ellybz said:

Here is a simple and effective method to get your ScanPolicy value:

Let’s say your config has Windows (NTFS) & MacOS (APFS) on Sata & NVMe Drives, but you’d also like to scan your USB for OS Installation purpose. 

1- Enter your Calculator in MacOS   ( Programmer : CMD3 )

You’ll have this window.CALC.thumb.png.1cc20f7717e2fbbfa81de977374518bd.png

Without entering any numeric values, you just need to click on the desired binary value (in front of the red arrow) to switch it from 0 to 1  ( 0= False / 1=True )

By clicking on the desired values the big Hex value will appear:

747559808_ScreenShot2020-02-20at13_26_16.png.8514385182d0db6ec94ac7447ca3e820.png

 

FSL + DL+ APFS+NTFS+SATA+SAS/Mac NVMe +NVMe+USB

  0. +  1. +  8.  +   11. +  16. +     17.            +  19.  +  21.    

( Note that the ESP Value =0 so no EFI will be scanned.)

By converting that HEX value to Decimal ( Any Hex Converter )

You’ll get 0x2B0903 -> 2820355 ( Your New Scan Policy )

Done !

It would be nice to develop a simple scan policy generation tool

  • Like 1
Link to comment
Share on other sites

1 hour ago, n.d.k said:

There's couple new changes:

* Adding faded effect to unselected icons

* Option to remove the square selector

 

ScreenShot-2020-02-20-231133.thumb.png.322216aa21196f9d6cd9c7f91510ba4e.pngScreenShot-2020-02-20-230751.thumb.png.38a150b624733379958e93296ac38315.png

Under the premise of highlighting the selected icon, the Y-axis with the selected item icon should be moved up by 2 values to make it more prominent

Link to comment
Share on other sites

5 hours ago, moozuki said:

Finally got it to work, OC 0.5.6 with external GUI.

 

ScreenShot-2020-02-21-011815.thumb.png.d2e4a3fd829a31539e09e03fc1c102f9.png

Still stack on OC 0.5.6

oc configuration requires vault but no vault provided

config.plist

Link to comment
Share on other sites

2 minutes ago, n.d.k said:

 

Vault = Optional

Thanks @n.d.k

Its work now.

1298093754_ScreenShot2020-02-21at4_06_33AM.png.a70c6e6b8481685f8b4cbae965c51f83.png

Link to comment
Share on other sites

@n.d.k 

 

Quote

*Note: For users who is using BootChimeDxe.efi, this driver seems to prevent any other drivers to load and cause system hang after BootChimeDxe.efi was loaded. To prevent a system hang, make sure that NdkBootPicker.efi (and all other EFI drivers) are loaded BEFORE BootChimeDxe.efi. This can be achieved by making sure that BootChimeDxe.efi is the last driver in the UEFI->Drivers section of the OpenCore config.plist file.

 

imo, bugs like this may not just be left living to ensure there is no unknown significant bug causing the symptoms. So, I checked your code for bugs, but it was fine. Turns out, AudioDxe has NULL deref bug: https://github.com/Goldfish64/AudioPkg/tree/09426e2c3a328db9d12d50c4fb98568d4273bb69/Platform/BootChimeDxe/BootChimeDxe.c#L61-L62

This is an issue only for drivers but not for booters because we do not propagate the driver origin: https://github.com/acidanthera/OpenCorePkg/tree/5226157d0f2ea679e6ad7a0a44cd772b404db46a/Platform/OpenCore/OpenCoreUefi.c#L111

 

CC @Goldfish64

Edited by Download-Fritz
  • Like 1
Link to comment
Share on other sites

2 hours ago, Download-Fritz said:

@n.d.k 

 

 

imo, bugs like this may not just be left living to ensure there is no unknown significant bug causing the symptoms. So, I checked your code for bugs, but it was fine. Turns out, AudioDxe has NULL deref bug: https://github.com/Goldfish64/AudioPkg/tree/09426e2c3a328db9d12d50c4fb98568d4273bb69/Platform/BootChimeDxe/BootChimeDxe.c#L61-L62

This is an issue only for drivers but not for booters because we do not propagate the driver origin: https://github.com/acidanthera/OpenCorePkg/tree/5226157d0f2ea679e6ad7a0a44cd772b404db46a/Platform/OpenCore/OpenCoreUefi.c#L111

 

CC @Goldfish64

 

I discovered this bug and reported it to @n.d.k and did some digging into the cause and concluded that it was not an issue with NdkBootPicker.efi and suggested that he add that comment you quoted in the readme.md.

 

I have also raised the issue here for @Goldfish64.

 

I agree "bugs like this may not just be left living to ensure there is no unknown significant bug causing the symptoms".

Link to comment
Share on other sites

13 hours ago, n.d.k said:

There's couple new changes:

* Adding faded effect to unselected icons

* Option to remove the square selector

 

Great job. Thx.

Has this new feature been added to the External NdkBootPicker.efi 0.0.6 ?

Link to comment
Share on other sites

16 minutes ago, MacNB said:

 

Great job. Thx.

Has this new feature been added to the External NdkBootPicker.efi 0.0.6 ?

 

Yes in the source code, but not in the Release binary yet!

 

59 minutes ago, Andrey1970 said:

In your forks OpenCorePkg and OcSupportPkg: travis-ci and coverity show the official. I think, you need to correct it or to remove

 

Sure will do!

  • Like 1
Link to comment
Share on other sites

58 minutes ago, n.d.k said:

 

Yes in the source code, but not in the Release binary yet!

 

I just built the binaries from your sources.

FYI, it almost works.

On startup, I see this screen:

ScreenShot-2020-02-21-151809.thumb.png.7b1e612656bd0cdb1bc1be8c995b4cfa.png

 

The icons are corrupt.

As I move the selector LEFT, the corruption changes:

 

ScreenShot-2020-02-21-151816.thumb.png.294364a3d88766b1eff7594d044c44d7.png

 

Move the selector RIGHT:

 

ScreenShot-2020-02-21-151823.thumb.png.fac6497a9f4a42092afb3e1052ffbb1a.png

 

Hitting the spacebar, hides the others and corrects the display :

 

ScreenShot-2020-02-21-151831.thumb.png.2251c7ca8c4af9ca514458ee475244f4.png

 

...and moving the selectors works fine in the "hidden" mode:

 

ScreenShot-2020-02-21-151840.thumb.png.6b4eb5f45ea82106ef37c192948828e0.png

 

I am sure you will know what is the problem :)

 

Keep up the good work.

 

  • Thanks 1
Link to comment
Share on other sites

Hi @n.d.k

 

Sorry for my stupid question: how to put "Autodefault:On" at startup.

 

Thanks for your great job

1 minute ago, MacNB said:

 

I just built the binaries from your sources.

FYI, it almost works.

On startup, I see this screen:

 

 

The icons are corrupt.

As I move the selector LEFT, the corruption changes:

 

 

 

Move the selector RIGHT:

 

 

 

Hitting the spacebar, hides the others and corrects the display :

 

 

 

...and moving the selectors works fine in the "hidden" mode:

 

 

 

I am sure you will know what is the problem :)

 

Keep up the good work.

 

 

Do you use No_selector.png files (tiny png file) in Icons folder as @n.d.k  says before in his post. Maybe it's a solution.

 

Link to comment
Share on other sites

14 minutes ago, MacNB said:

 

I just built the binaries from your sources.

FYI, it almost works.

On startup, I see this screen:

ScreenShot-2020-02-21-151809.thumb.png.7b1e612656bd0cdb1bc1be8c995b4cfa.png

 

The icons are corrupt.

As I move the selector LEFT, the corruption changes:

 

ScreenShot-2020-02-21-151816.thumb.png.294364a3d88766b1eff7594d044c44d7.png

 

Move the selector RIGHT:

 

ScreenShot-2020-02-21-151823.thumb.png.fac6497a9f4a42092afb3e1052ffbb1a.png

 

Hitting the spacebar, hides the others and corrects the display :

 

ScreenShot-2020-02-21-151831.thumb.png.2251c7ca8c4af9ca514458ee475244f4.png

 

...and moving the selectors works fine in the "hidden" mode:

 

ScreenShot-2020-02-21-151840.thumb.png.6b4eb5f45ea82106ef37c192948828e0.png

 

I am sure you will know what is the problem :)

 

Keep up the good work.

 

After the update, I also found this problem, in the state of show hidden items, move the left and right keys, clear the screen code will eat the original icon one by one, like a snake, do not press the space bar normal!

Just now, btwise said:

After the update, I also found this problem, in the state of show hidden items, move the left and right keys, clear the screen code will eat the original icon one by one, like a snake, do not press the space bar normal!

This problem occurs when there seem to be more than one item!

  • Sad 1
Link to comment
Share on other sites

56 minutes ago, Matgen84 said:

Do you use No_selector.png files (tiny png file) in Icons folder as @n.d.k  says before in his post. Maybe it's a solution.

 

 

No - same problem even with No-selector.png. But I like the selector - it's more obvious as to what is selected.

  • Sad 1
Link to comment
Share on other sites

There are some code differences between NDK fork and NdkBootPicker.efi,  so please state in the post when reporting the problem, which version it belong to,  Thanks!.

 

As for snake eating icons (lol) in unhidden mode on that @MacNB reported, I will provide the fix soon enough, Is there anyone with the same issue on NDK fork version?...I tested on my end, it doesn't seem to be the problem with NDK fork regarding this snake eating icons. 

  • Like 1
Link to comment
Share on other sites

There are some code differences between NDK fork and NdkBootPicker.efi,  so please state in the post when reporting the problem, which version it belong to,  Thanks!.

 

As for snake eating icons (lol) in unhidden mode on that @MacNB reported, I will provide the fix soon enough, Is there anyone with the same issue on NDK fork version?...I tested on my end, it doesn't seem to be the problem with NDK fork regarding this snake eating icons. 

 

PS.  @MacNB, May I ask what are those 2 ? Icons entries?, you have there, because I can't seem to replicate the problem on my end, my system doesn't seem to have any ? Icons entry even I set Scan policy to 0 and set HideSelf to No. I can try a blind fix..lol if you can tell me what those entries are.  Or you can try the guessing fix, Attachment and let me know if it's fixed.  Thank you! 

NdkBootPicker.efi.zip

Edited by n.d.k
Link to comment
Share on other sites

1 hour ago, n.d.k said:

PS.  @MacNB, May I ask what are those 2 ? Icons entries?, you have there, because I can't seem to replicate the problem on my end, my system doesn't seem to have any ? Icons entry even I set Scan policy to 0 and set HideSelf to No. I can try a blind fix..lol if you can tell me what those entries are.  Or you can try the guessing fix, Attachment and let me know if it's fixed.  Thank you! 

NdkBootPicker.efi.zip

 

I am using standard OC and not NDK Fork.

 

The "guess fix" does more or less the same.

 

The scan policy = 0

I have three drives: 2 x SATA (/dev/disk0 and /dev/disk1) and one NVMe (/dev/disk3).

The first two icons (Folder with ? inside) are EFI folders (containing Clover).

The Windows icon is also on the same EFI as the second EFI icon (i.e. /dev/disk2 is dual boot).

There's also an external USB disk from which I am booting with OpenCore.

Here's disk list:

/dev/disk0 (internal, physical):
   #:                       TYPE NAME                    SIZE       IDENTIFIER
   0:      GUID_partition_scheme                        *120.0 GB   disk0
   1:                        EFI EFI                     209.7 MB   disk0s1
   2:                 Apple_APFS Container disk4         85.1 GB    disk0s3
   3:                  Apple_HFS Untitled                34.6 GB    disk0s4

/dev/disk1 (internal, physical):
   #:                       TYPE NAME                    SIZE       IDENTIFIER
   0:      GUID_partition_scheme                        *750.2 GB   disk1
   1:                        EFI EFI                     209.7 MB   disk1s1
   2:         Microsoft Reserved                         16.8 MB    disk1s2
   3:       Microsoft Basic Data Win10-Pro               106.9 GB   disk1s3
   4:           Windows Recovery                         498.1 MB   disk1s4
   5:           Windows Recovery                         478.2 MB   disk1s5
   6:                 Apple_APFS Container disk3         215.4 GB   disk1s6
   7:                  Apple_HFS iMac-SR-SSD             426.0 GB   disk1s7
   8:                 Apple_Boot Recovery HD             650.0 MB   disk1s8

/dev/disk2 (internal):
   #:                       TYPE NAME                    SIZE       IDENTIFIER
   0:      GUID_partition_scheme                         1.0 TB     disk2
   1:                        EFI EFI                     209.7 MB   disk2s1
   2:                 Apple_APFS Container disk6         85.0 GB    disk2s2
   3:                 Apple_APFS Container disk5         939.0 GB   disk2s3

/dev/disk3 (synthesized):
   #:                       TYPE NAME                    SIZE       IDENTIFIER
   0:      APFS Container Scheme -                      +215.4 GB   disk3
                                 Physical Store disk1s6
   1:                APFS Volume HS-SSD                  125.9 GB   disk3s1
   2:                APFS Volume Preboot                 19.3 MB    disk3s2
   3:                APFS Volume Recovery                516.1 MB   disk3s3
   4:                APFS Volume VM                      2.1 GB     disk3s4

/dev/disk4 (synthesized):
   #:                       TYPE NAME                    SIZE       IDENTIFIER
   0:      APFS Container Scheme -                      +85.1 GB    disk4
                                 Physical Store disk0s3
   1:                APFS Volume P120GB                  58.1 GB    disk4s1
   2:                APFS Volume Preboot                 45.8 MB    disk4s2
   3:                APFS Volume Recovery                510.4 MB   disk4s3
   4:                APFS Volume VM                      20.5 KB    disk4s4

/dev/disk5 (synthesized):
   #:                       TYPE NAME                    SIZE       IDENTIFIER
   0:      APFS Container Scheme -                      +939.0 GB   disk5
                                 Physical Store disk2s3
   1:                APFS Volume NVMe-free               2.5 MB     disk5s1

/dev/disk6 (synthesized):
   #:                       TYPE NAME                    SIZE       IDENTIFIER
   0:      APFS Container Scheme -                      +85.0 GB    disk6
                                 Physical Store disk2s2
   1:                APFS Volume Catalina-HD - Data      40.2 GB    disk6s1
   2:                APFS Volume PreBoot                 81.1 MB    disk6s2
   3:                APFS Volume Recovery                526.6 MB   disk6s3
   4:                APFS Volume VM                      3.2 GB     disk6s4
   5:                APFS Volume Catalina-HD             11.0 GB    disk6s5

/dev/disk7 (external, physical):
   #:                       TYPE NAME                    SIZE       IDENTIFIER
   0:      GUID_partition_scheme                        *15.9 GB    disk7
   1:                        EFI EFI                     209.7 MB   disk7s1
   2:                  Apple_HFS OpenCore                15.6 GB    disk7s2

 

Link to comment
Share on other sites

×
×
  • Create New...