Jump to content
30960 posts in this topic

Recommended Posts

 

5 hours ago, Pene said:

Thanks for your post but I'm confused now. Didn't you say earlier that my commit Witt the fix didn't fix it?

Yes before your fix I try to change some file to rolling back for testing and one of my friend with a GeForce 710 telling me your fix work

So I recompile the Clover source from scratch and its work on HDMI and work on DVI for my friend so everything is correct

thank you

Edited by chris1111
  • Like 1

@Slice i have faced this error issue recently with 10.15.4 (fresh install) with Clover. Is this related to "Memory RANK"??

I have faced this issue with MSI MBP Z390 Gaming Pro Carbon and Dell Vostro 5468 in 10.15.4, this error is shown after second boot stage for installing,, it crash after apple loading bar in second stage.

It's fresh erase disk..

 

image.thumb.png.37527e96fc76458fe91f551946de8c09.png 

7 hours ago, Jief_Machak said:

What are the impacts if I want to change a fixed length string in SETTINGS_DATA by a XString (VendorName for example) ?

The problem is just the serialization of SETTINGS_DATA ?

We want to send the SETTINGS_DATA to device-tree and further to use by clover-genconfig or by Clover.app.

It will be impossible for classes.

3 hours ago, Slice said:

We want to send the SETTINGS_DATA to device-tree and further to use by clover-genconfig or by Clover.app.

It will be impossible for classes.

It's possible to have a serialize/deserialize mechanism, instead of a raw copy. Actually, I already have an object that doest that...

Is it worth taking the time to do that now ? I'm not sure. Just thinking.

On 3/2/2020 at 1:06 PM, Slice said:

No, Clover didn't drop support for AMD CPU as well as it did anything special for AMD CPU in Catalina.

What are the special things about Catalina on AMD? You're absolutely right, but it's not like that, maybe because here in InsanelyMac Development AMD is stopped, everyone has turned things at their convenience, before they used to adapt kernels and patches to Clover, instead now it is clover that must adapt to the Patches? mistaken!!! Here for years there has been a development and this has been a massacre and it is not a good thing

  • Like 1
7 hours ago, Jief_Machak said:

It's possible to have a serialize/deserialize mechanism, instead of a raw copy. Actually, I already have an object that doest that...

Is it worth taking the time to do that now ? I'm not sure. Just thinking.

It is not priority task and it requires to reconstruct Clover.app to deal with the new data.

23 hours ago, Slice said:

We want to send the SETTINGS_DATA to device-tree and further to use by clover-genconfig or by Clover.app.

It will be impossible for classes.

hi Slice compiling stuck with this stage 

[HDIUTIL] /Users/mohammad/src/CloverBootloader/CloverPackage/sym/Clover-5108-X64.iso

how to fix it 

45 minutes ago, anmool said:

hi Slice compiling stuck with this stage 

[HDIUTIL] /Users/mohammad/src/CloverBootloader/CloverPackage/sym/Clover-5108-X64.iso

how to fix it 

I see no mistake. How can I reproduce your issue?

====================== Creating cdboot =====================
Update cdboot with boot file size info
======================= Creating ISO =======================
[RM] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/usr/standalone/i386
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/EFI/BOOT
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/EFI/CLOVER/themes/
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/usr/bin
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/usr/local/bin
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/Library/Application Support/Clover
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/Library/PreferencePanes
[CP] cdboot
[CP] embedded
[CP] BOOTX64
[CP] CLOVERX64
[CP] drivers/BIOS
[CP] drivers/UEFI
[CP] kexts and OEM
[CP] tools
[CP] doc
[CP] drivers-off
[CP] boot
[HDIUTIL] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/Clover-5108-X64.iso
[TAR] CloverISO-5108
a .
a ./Clover-5108-X64.iso
[LZMA] CloverISO-5108
Encoding
total 77232
drwxr-xr-x  15 sergey  staff       480 Apr  2 06:43 .
drwxr-xr-x  14 sergey  staff       448 Mar 30 12:23 ..
-rw-r--r--@  1 sergey  staff      6148 Mar 30 12:32 .DS_Store
-rw-r--r--   1 sergey  staff  15079007 Mar 30 12:24 Clover.app_v1.16_r5108.pkg.zip
drwxr-xr-x   5 sergey  staff       160 Apr  2 06:43 CloverCD
drwxr-xr-x   3 sergey  staff        96 Apr  2 06:43 CloverISO-5108
-rw-r--r--   1 sergey  staff   2498975 Apr  2 06:43 CloverISO-5108.tar.lzma
-rw-r--r--   1 sergey  staff   9492856 Mar 30 12:24 CloverV2-5108.zip
-rw-r--r--@  1 sergey  staff   9895297 Mar 30 12:23 Clover_r5108.pkg
-rw-r--r--@  1 sergey  staff        62 Mar 30 12:23 Clover_r5108.pkg.md5
drwxr-xr-x   3 sergey  staff        96 Mar 30 12:20 Resources
drwxr-xr-x   6 sergey  staff       192 Mar 30 12:22 build
drwxr-xr-x   3 sergey  staff        96 Mar 30 12:23 i386
drwxr-xr-x   3 sergey  staff        96 Mar 30 12:23 package
drwxr-xr-x   6 sergey  staff       192 Mar 30 12:22 utils

------------------------------------------------------------------------

 

On 3/31/2020 at 7:51 PM, Pene said:

I am curious also, as I didn't find anything else wrong either.

Story short : it's worrying that it's working :):hysterical:

 

%c with an integral parameter is a case that slipped my mimd. And because I let Xcode do mass fixing of printf format warning, that went wrong. But there was only one !!

I'll be carefull when I'll replace UnicodeSPrintf.

 

  • Like 1
14 hours ago, Slice said:

I see no mistake. How can I reproduce your issue?


====================== Creating cdboot =====================
Update cdboot with boot file size info
======================= Creating ISO =======================
[RM] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/usr/standalone/i386
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/EFI/BOOT
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/EFI/CLOVER/themes/
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/usr/bin
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/usr/local/bin
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/Library/Application Support/Clover
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/Library/PreferencePanes
[CP] cdboot
[CP] embedded
[CP] BOOTX64
[CP] CLOVERX64
[CP] drivers/BIOS
[CP] drivers/UEFI
[CP] kexts and OEM
[CP] tools
[CP] doc
[CP] drivers-off
[CP] boot
[HDIUTIL] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/Clover-5108-X64.iso
[TAR] CloverISO-5108
a .
a ./Clover-5108-X64.iso
[LZMA] CloverISO-5108
Encoding
total 77232
drwxr-xr-x  15 sergey  staff       480 Apr  2 06:43 .
drwxr-xr-x  14 sergey  staff       448 Mar 30 12:23 ..
-rw-r--r--@  1 sergey  staff      6148 Mar 30 12:32 .DS_Store
-rw-r--r--   1 sergey  staff  15079007 Mar 30 12:24 Clover.app_v1.16_r5108.pkg.zip
drwxr-xr-x   5 sergey  staff       160 Apr  2 06:43 CloverCD
drwxr-xr-x   3 sergey  staff        96 Apr  2 06:43 CloverISO-5108
-rw-r--r--   1 sergey  staff   2498975 Apr  2 06:43 CloverISO-5108.tar.lzma
-rw-r--r--   1 sergey  staff   9492856 Mar 30 12:24 CloverV2-5108.zip
-rw-r--r--@  1 sergey  staff   9895297 Mar 30 12:23 Clover_r5108.pkg
-rw-r--r--@  1 sergey  staff        62 Mar 30 12:23 Clover_r5108.pkg.md5
drwxr-xr-x   3 sergey  staff        96 Mar 30 12:20 Resources
drwxr-xr-x   6 sergey  staff       192 Mar 30 12:22 build
drwxr-xr-x   3 sergey  staff        96 Mar 30 12:23 i386
drwxr-xr-x   3 sergey  staff        96 Mar 30 12:23 package
drwxr-xr-x   6 sergey  staff       192 Mar 30 12:22 utils

------------------------------------------------------------------------

 


This is patch for NVME Controller PM981, i can set this patch with OpenCore only,, any clue how can i apply this patch with latest Clover version???

Thank you
image.thumb.png.c1d56d34bf3b43cf49b2ed6750f256a2.png

@Slice

 

Clover v2.5k r5108 (SHA: 418b4f4cc)

 

i'm getting this in both GCC53 and XCODE8

[CPP] XString
/Users/labyone/src/Clover/rEFIt_UEFI/cpp_foundation/XStringW.cpp: In member function 'const XStringW& XStringW::takeValueFrom(const wchar_t*)':
/Users/labyone/src/Clover/rEFIt_UEFI/cpp_foundation/XStringW.cpp:116:6: error: control reaches end of non-void function [-Werror=return-type]
  116 |  Init(0);
      |  ~~~~^~~
cc1plus: all warnings being treated as errors
make: *** [/Users/labyone/src/Clover/Build/Clover/RELEASE_GCC53/X64/rEFIt_UEFI/refit/OUTPUT/cpp_foundation/XStringW.obj] Error 1


build.py...
 : error 7000: Failed to execute command
	make tbuild [/Users/labyone/src/Clover/Build/Clover/RELEASE_GCC53/X64/rEFIt_UEFI/refit]


build.py...
 : error F002: Failed to build module
	/Users/labyone/src/Clover/rEFIt_UEFI/refit.inf [X64, GCC53, RELEASE]

- Failed -
Build end time: 23:51:29, Apr.02 2020
Build total time: 00:01:25

logout
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.

[Process completed]

  
  =================   then  Trying XCODE8
  
  [CC] EfiLoader
/Users/labyone/src/Clover/rEFIt_UEFI/cpp_foundation/XStringW.cpp:117:1: error: control may reach end of non-void function [-Werror,-Wreturn-type]
}
^
[SLINK] EfiLoader
1 error generated.
make: *** [/Users/labyone/src/Clover/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit/OUTPUT/cpp_foundation/XStringW.obj] Error 1


build.py...
 : error 7000: Failed to execute command
	make tbuild [/Users/labyone/src/Clover/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit]


build.py...
 : error F002: Failed to build module
	/Users/labyone/src/Clover/rEFIt_UEFI/refit.inf [X64, XCODE8, RELEASE]

- Failed -
Build end time: 23:56:50, Apr.02 2020
Build total time: 00:00:13

logout
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.

[Process completed]

I'm actually using Xcode 10.1 on HS

Edited by LAbyOne
23 hours ago, Slice said:

I see no mistake. How can I reproduce your issue?


====================== Creating cdboot =====================
Update cdboot with boot file size info
======================= Creating ISO =======================
[RM] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/usr/standalone/i386
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/EFI/BOOT
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/EFI/CLOVER/themes/
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/usr/bin
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/usr/local/bin
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/Library/Application Support/Clover
[MKDIR] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/CloverCD/Library/PreferencePanes
[CP] cdboot
[CP] embedded
[CP] BOOTX64
[CP] CLOVERX64
[CP] drivers/BIOS
[CP] drivers/UEFI
[CP] kexts and OEM
[CP] tools
[CP] doc
[CP] drivers-off
[CP] boot
[HDIUTIL] /Users/sergey/src/CloverHackyColor/CloverPackage/sym/Clover-5108-X64.iso
[TAR] CloverISO-5108
a .
a ./Clover-5108-X64.iso
[LZMA] CloverISO-5108
Encoding
total 77232
drwxr-xr-x  15 sergey  staff       480 Apr  2 06:43 .
drwxr-xr-x  14 sergey  staff       448 Mar 30 12:23 ..
-rw-r--r--@  1 sergey  staff      6148 Mar 30 12:32 .DS_Store
-rw-r--r--   1 sergey  staff  15079007 Mar 30 12:24 Clover.app_v1.16_r5108.pkg.zip
drwxr-xr-x   5 sergey  staff       160 Apr  2 06:43 CloverCD
drwxr-xr-x   3 sergey  staff        96 Apr  2 06:43 CloverISO-5108
-rw-r--r--   1 sergey  staff   2498975 Apr  2 06:43 CloverISO-5108.tar.lzma
-rw-r--r--   1 sergey  staff   9492856 Mar 30 12:24 CloverV2-5108.zip
-rw-r--r--@  1 sergey  staff   9895297 Mar 30 12:23 Clover_r5108.pkg
-rw-r--r--@  1 sergey  staff        62 Mar 30 12:23 Clover_r5108.pkg.md5
drwxr-xr-x   3 sergey  staff        96 Mar 30 12:20 Resources
drwxr-xr-x   6 sergey  staff       192 Mar 30 12:22 build
drwxr-xr-x   3 sergey  staff        96 Mar 30 12:23 i386
drwxr-xr-x   3 sergey  staff        96 Mar 30 12:23 package
drwxr-xr-x   6 sergey  staff       192 Mar 30 12:22 utils

------------------------------------------------------------------------

 

thanks compiled successfully all done but only i can't see Clover_r5108.pkg.zip

 

On 3/31/2020 at 4:09 PM, Pene said:

Thanks for your post but I'm confused now. Didn't you say earlier that my commit Witt the fix didn't fix it?

 

Then I confuse you even more, because HDMI-DVi works perfectly for me.

Maybe because of the Smbios standards?

10.15.4 - clover 5108 -iMac 14.2

 

 

Schermata 2020-04-03 alle 09.54.48.png

 

Schermata 2020-04-03 alle 09.57.03.png

Hi Slice, coders

Tried to switch back from OpenCore to Clover 5108 om my old AMD CPU (fx8350), Catalina 10.15.4 installed.

I have updated the mask kernel patches using the correct syntax for Clover with the latest OC ones.

Unfortunately it does not work with Clover, kernel panic during boot.

Anyone else who has tested the latest Clover with mask kernel patches for AMD?

 

thanks!

  • Like 1

report

missing local header now.

 

Active Platform          = /Users/sherlocks/src/CloverBootloader/Clover.dsc

.......build: : warning: Module MetaFile [Sources] is missing local header!

    Local Header: /users/sherlocks/src/cloverbootloader/refit_uefi/platform/startupsound.h not found in /Users/sherlocks/src/CloverBootloader/rEFIt_UEFI/refit.inf

build: : warning: Module MetaFile [Sources] is missing local header!

    Local Header: /users/sherlocks/src/cloverbootloader/refit_uefi/platform/startupsound.h not found in /Users/sherlocks/src/CloverBootloader/rEFIt_UEFI/refit.inf

. done!

Building ... /Users/sherlocks/src/CloverBootloader/MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf [X64]

Building ... /Users/sherlocks/src/CloverBootloader/MdePkg/Library/UefiLib/UefiLib.inf [X64]

Building ... /Users/sherlocks/src/CloverBootloader/MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf [X64]

Building ... /Users/sherlocks/src/CloverBootloader/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf [X64]

Building ... /Users/sherlocks/src/CloverBootloader/MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf [X64]

  • Sad 1
On 4/4/2020 at 3:51 AM, AntarcticP said:

Hi Slice, coders

Tried to switch back from OpenCore to Clover 5108 om my old AMD CPU (fx8350), Catalina 10.15.4 installed.

I have updated the mask kernel patches using the correct syntax for Clover with the latest OC ones.

Unfortunately it does not work with Clover, kernel panic during boot.

Anyone else who has tested the latest Clover with mask kernel patches for AMD?

 

thanks!

I got the same issue in my FX-6300 hackintosh too, which's waiting for some expert to fix it ASAP !

Hi @Slice

 

I can't build latest r5108 commit.

 

Spoiler

[CPP] bootscreen
/Users/mathieu/src/CloverBootloader/rEFIt_UEFI/entry_scan/common.cpp:158:5: error: variable 'IconX' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
    default:
    ^~~~~~~
/Users/mathieu/src/CloverBootloader/rEFIt_UEFI/entry_scan/common.cpp:161:11: note: uninitialized use occurs here
  return *IconX;
          ^~~~~
/Users/mathieu/src/CloverBootloader/rEFIt_UEFI/entry_scan/common.cpp:105:22: note: initialize the variable 'IconX' to silence this warning
  const XImage* IconX;
                     ^
                      = nullptr
1 error generated.
make: *** [/Users/mathieu/src/CloverBootloader/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit/OUTPUT/entry_scan/common.obj] Error 1


build.py...
 : error 7000: Failed to execute command
    make tbuild [/Users/mathieu/src/CloverBootloader/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit]


build.py...
 : error F002: Failed to build module
    /Users/mathieu/src/CloverBootloader/rEFIt_UEFI/refit.inf [X64, XCODE8, RELEASE]

- Failed -
 

 

  • Thanks 1
35 minutes ago, Matgen84 said:

Hi @Slice

 

I can't build latest r5108 commit.

No build issue here, on Ubuntu 20.04 Beta and Debian 10 Buster; both with GCC53.

 

 

...
[SLINK] CLOVERX64
[DLINK1] CLOVERX64
cp -f /home/Badruzeus/src/CloverBootloader/Build/Clover/RELEASE_GCC53/X64/rEFIt_UEFI/refit/DEBUG/CLOVERX64.debug /home/Badruzeus/src/CloverBootloader/Build/Clover/RELEASE_GCC53/X64/CLOVERX64.debug
[OBJCOPY] CLOVERX64
Section 1 .text mCoffOffset=576(0x240) mCoffOffsetNew=576(0x240) diff=0(0x0)
Section 5 .eh_frame mCoffOffset=748320(0xb6b20) mCoffOffsetNew=894336(0xda580) diff=146016(0x23a60)
Section 3 .data mCoffOffset=894336(0xda580) mCoffOffsetNew=748352(0xb6b40) diff=-145984(0xfffdc5c0)
[GENFW] CLOVERX64

Generating DUETEFIMAINFVX64 FV
###
GUID cross reference file can be found at /home/Badruzeus/src/CloverBootloader/Build/Clover/RELEASE_GCC53/FV/Guid.xref

FV Space Information
DUETEFIMAINFVX64 [35%Full] 2752512 total, 981336 used, 1771176 free

- Done -
Build end time: 21:15:23, Apr.06 2020
Build total time: 00:12:57

Compressing DUETEFIMainFv.FV ...
Encoding
Compressing DxeCore.efi ...
Encoding
Compressing DxeIpl.efi ...
Encoding
Generate Loader Image ...
Created /home/Badruzeus/src/CloverBootloader/Build/Clover/RELEASE_GCC53/FV/Efildr64
879+0 records in
879+0 records out
450048 bytes (450 kB, 440 KiB) copied, 0.0165606 s, 27.2 MB/s
Copy CloverEFI:
  -> boot6
Changing byte at 0xa9 of boot6 to show 6 as init message:
1+0 records in
1+0 records out
1 byte copied, 0.00022845 s, 4.4 kB/s
  -> BOOTX64.efi
  -> CLOVERX64.efi
Copy Mandatory drivers:
  -> FSInject.efi
  -> XhciDxe.efi
  -> SMCHelper.efi
  -> AudioDxe.efi
  -> AppleImageCodec.efi
  -> AppleKeyAggregator.efi
  -> AppleUITheme.efi
  -> FirmwareVolume.efi
  -> ApfsDriverLoader.efi
  -> FSInject.efi
  -> DataHubDxe.efi
  -> SMCHelper.efi
  -> AudioDxe.efi
  -> AppleImageCodec.efi
  -> AppleUITheme.efi
  -> AppleKeyAggregator.efi
  -> FirmwareVolume.efi
  -> GrubEXFAT.efi
  -> GrubISO9660.efi
  -> GrubNTFS.efi
  -> GrubUDF.efi
  -> CsmVideoDxe.efi
  -> EnglishDxe.efi
  -> EmuVariableUefi.efi
  -> NvmExpressDxe.efi
  -> OsxFatBinaryDrv.efi
  -> PartitionDxe.efi
  -> Ps2MouseDxe.efi
  -> UsbKbDxe.efi
  -> UsbMouseDxe.efi
  -> AptioInputFix.efi
  -> ApfsDriverLoader.efi
  -> Fat.efi
  -> VBoxExt2.efi
  -> VBoxExt4.efi
  -> VBoxIso9600.efi
  -> VBoxHfs.efi
  -> AppleKeyFeeder.efi
  -> HashServiceFix.efi
  -> OsxAptioFixDrv.efi
  -> OsxLowMemFixDrv.efi
  -> OsxAptioFix3Drv.efi
  -> AptioMemoryFix.efi
Copy Applications:
  -> bdmesg.efi
  -> Shell64U.efi
Done!

Generating BootSectors
make: Entering directory '/home/Badruzeus/src/CloverBootloader/BootHFS'
make: Nothing to be done for 'all'.
make: Leaving directory '/home/Badruzeus/src/CloverBootloader/BootHFS'
Done!
Badruzeus@AOHAPPY:~/src/CloverBootloader

 

 

My only problem is when I'm trying to boot it under Legacy-BIOS soon after boot6 (or 7) loaded.. it seems when showing GUI I get Red Screen of Death immediately.

 

(Sorry, I've no idea with Xcode test build since I broke my Hackintosh laptop's BIOS last year by accident. Also [replying your old comments on this thread related to Clover Themes] I'm afraid I can't fix them if any changes are needed. Though.. yeah, the last r5108 (github release) shows my Themes properly except it's bit stretched on my netbook with 1024x600 px Display hah haa.. Sure, it's not related to Clover but hw limitation. Thanks to all of devs and Coders whom have fixed the GUI issue and made better progresses anyway).

Edited by Badruzeus
×
×
  • Create New...