Jump to content

Clover General discussion

ErmaC

By ErmaC,
in Clover

 Share
30960 posts in this topic

Recommended Posts

Matgen84
Matgen84
Posted
Posted (edited)
19 minutes ago, Jief_Machak said:

Good luck suggesting that to OC team.

 

When we build Clover, we build Openruntime too. So It can be rename OpenRuntime-vXX.efi in CloverPackage. It's tha what I want to say. Openruntime for Clover(8Ko)  is not the Openruntime for OC (20ko), or I'm wrong, sorry.

Can't build Clover despite good HEAD:

  


In file included from /Users/mathieu/src/CloverBootloader/rEFIt_UEFI/Settings/ConfigPlist/Config_GUI.cpp:14:
In file included from /Users/mathieu/src/CloverBootloader/rEFIt_UEFI/Settings/ConfigPlist/ConfigPlistClass.h:27:
In file included from /Users/mathieu/src/CloverBootloader/rEFIt_UEFI/Settings/ConfigPlist/../../Platform/cpu.h:15:
In file included from /Users/mathieu/src/CloverBootloader/MdePkg/Include/Register/Intel/../../../../rEFIt_UEFI/Platform/../include/OC.h:25:
/Users/mathieu/src/CloverBootloader/OpenCorePkg/Include/Acidanthera/Library/OcMainLib.h:46:2: error: "Unknown target definition"
#error "Unknown target definition"
 ^
1 error generated.
note: Using new build system
note: Planning build
note: Using build description from disk
** BUILD FAILED **

 

Edited by Matgen84
Matgen84
Matgen84
Posted
Posted (edited)

@Jief_Machak

I re-clone. Unfortunately, can't build again:
  

enerating BootSectors
make: Nothing to be done for `all'.
Done!
In file included from /Users/mathieu/src/Cloverbootloader/rEFIt_UEFI/Platform/platformdata.cpp:7:
In file included from /Users/mathieu/src/Cloverbootloader/rEFIt_UEFI/Platform/smbios.h:15:
In file included from /Users/mathieu/src/Cloverbootloader/rEFIt_UEFI/Platform/../Platform/cpu.h:15:
In file included from /Users/mathieu/src/Cloverbootloader/rEFIt_UEFI/Platform/../include/OC.h:25:
/Users/mathieu/src/Cloverbootloader/OpenCorePkg/Include/Acidanthera/Library/OcMainLib.h:46:2: error: "Unknown target definition"
#error "Unknown target definition"
 ^
1 error generated.
note: Using new build system
note: Planning build
note: Constructing build description
** BUILD FAILED **

  

HEAD is now at c8e7ee0a Disable reading config.plist.
HEAD is now at 0bca61ad3 Handle multiple OpenRuntime version.

 

Edited by Matgen84
  • Sad 1
Matgen84
Matgen84
Posted
Posted
44 minutes ago, MifJpnAlphaPlus said:

Please let me know if I make a mistake.🙂

Thank you.

 

Thanks a lot 😊 I already use --recurse-sudmodules args, without success. Now, I create a new folder with your command line: all works.
Don't on an existing CloverBootloader folder. Strange.

  • Haha 1
Jief_Machak
Jief_Machak
Posted
Posted
1 hour ago, Matgen84 said:

@Jief_Machak

I re-clone. Unfortunately, can't build again:
  

enerating BootSectors
make: Nothing to be done for `all'.
Done!
In file included from /Users/mathieu/src/Cloverbootloader/rEFIt_UEFI/Platform/platformdata.cpp:7:
In file included from /Users/mathieu/src/Cloverbootloader/rEFIt_UEFI/Platform/smbios.h:15:
In file included from /Users/mathieu/src/Cloverbootloader/rEFIt_UEFI/Platform/../Platform/cpu.h:15:
In file included from /Users/mathieu/src/Cloverbootloader/rEFIt_UEFI/Platform/../include/OC.h:25:
/Users/mathieu/src/Cloverbootloader/OpenCorePkg/Include/Acidanthera/Library/OcMainLib.h:46:2: error: "Unknown target definition"
#error "Unknown target definition"
 ^
1 error generated.
note: Using new build system
note: Planning build
note: Constructing build description
** BUILD FAILED **

  

HEAD is now at c8e7ee0a Disable reading config.plist.
HEAD is now at 0bca61ad3 Handle multiple OpenRuntime version.

 

Found the same. It's the validator.

Fixed.

It's fixed.

2 hours ago, MifJpnAlphaPlus said:

I'm sorry to have rushed you into such an important idea.
I want to cooperate fully!
I'll ansered your lead and hold off on the build for now.
I made the following log from the Clover, BLT, and OpenRuntime-v12.efi I received.

2021-09-25_08-45_CloverX64-2021-09-23-22-55-36-8f3b2f0-jief.efi.log.zip 21.18 kB · 2 downloads

Cannot boot.😞

I will open everything.

EFI.2109251753.zip
I know it is hard for you to use your precious time, but please help me.

Thank you very much.

Have you checked USB/FixOwnership ?

  • Thanks 2
Slice
Slice
Posted
Posted
3 hours ago, Jief_Machak said:

I've re-assigned master, for both Clover and OpenCorePkg.

It means now that master is using 0.7.3 version of OpenCore : update your OpenRuntime.efi. And please, call it OpenRuntime-v12.efi. Reason for that is that, when we'll have a v13, the v12 will be automatically ignored and you'll be able to have OpenRuntime-v12.efi AND OpenRuntime-v13.efi in the same driver folder and Clover will pick the right one : no more panic when you'll switch version.

 

NOTE : please re-clone, or make sure that Clover AND OpenCorePkg pointing to the new master. I've tested with buildme and buildme XCODE8 from scratch, so if it doesn't compile, it's because you got a wrong version (old or deleted commit).

Maybe USB/FixOwnership is wrong ?

And old one can be renamed to -v11?

Slice
Slice
Posted
Posted
4 minutes ago, Matgen84 said:

@Jief_Machak Please, don't forget to reimplement the @Slice commit about Update to Monterey Beta 7.

Have a nice day.

Done.

10 minutes ago, Jief_Machak said:

@Slice Thing to have a look : in CommonPatches.c, importing KernelCPUIDPatch() if needed (maybe there is a kernel cpuid patch mechanism we can use instead ?).

 

I will study this moment

  • Thanks 2
Matgen84
Matgen84
Posted
Posted
2 hours ago, MifJpnAlphaPlus said:

I'm sorry to have rushed you into such an important idea.
I want to cooperate fully!
I'll ansered your lead and hold off on the build for now.
I made the following log from the Clover, BLT, and OpenRuntime-v12.efi I received.

2021-09-25_08-45_CloverX64-2021-09-23-22-55-36-8f3b2f0-jief.efi.log.zip 21.18 kB · 4 downloads

Cannot boot.😞

I will open everything.

EFI.2109251753.zip
I know it is hard for you to use your precious time, but please help me.

Thank you very much.

 

Hi. As @Jief_Machak says: have a look to FixOwnerShip in your config.plist ! For my Z390 config, I've the same trouble. All works fine when @Jief_Machak set FixOwnerShip to false.

  • Thanks 1
Slice
Slice
Posted
Posted
1 minute ago, Jief_Machak said:

Yes. But if you have v11 and v12 and try an old version, both will be tried to be loaded.

Because old Clover has no the method to not load other version...

3 hours ago, Sherlocks said:

hi jief, can you consider emulated nvram support? old clover support emulated nvram feature. but now latest clover is not supporting it.

Sent from my SM-N960N using Tapatalk
 

Why do you think it absents?

Jief_Machak
Jief_Machak
Posted
Posted
3 minutes ago, Slice said:

Because old Clover has no the method to not load other version...

Yes, exactly. So it'll be more handy when we'll have v13.

4 minutes ago, Slice said:

Why do you think it absents?

No real idea what that is. Isn't this an external efi to put in drivers, and not something internal to Clover ?

Matgen84
Matgen84
Posted
Posted (edited)

Hi @Slice

How to use 'Implement ExtendedFeatures' for Monterey in config-sample.plist ! Just uncommented the key, right 🙂 

For my Z390, I use SMBIOS Imac19,1. My FirmwareFeatures, FirmwareFeaturesMask values aren't the same as in the config-sample. I admit that I don't understand a thing.

Edited by Matgen84
Slice
Slice
Posted
Posted
14 minutes ago, Matgen84 said:

Hi @Slice

How to use 'Implement ExtendedFeatures' for Monterey in config-sample.plist ! Just uncommented the key, right 🙂

Right. For me default value is good.

  • Like 2
Slice
Slice
Posted
Posted
1 hour ago, Jief_Machak said:

 

No real idea what that is. Isn't this an external efi to put in drivers, and not something internal to Clover ?

For legacy BIOS there is a driver MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe/ which is included into boot6 and boot7 providing emulated NVRAM into RAM. So variables will be keeping in memory until reboot. In the case of shutdown or reboot the Clover provided shutdown script which save variables from emulated NVRAM into the file nvram.plist. Next start Clover will read the file nvram.plist and place its content into new RAM which will be assigned to emulated NVRAM again.

 For UEFI BIOS there are always hardware NVRAM but some years ago it was unaccessible from Clover so why Dmazar wrote new driver EmuVariableUefi.efi which also create emulated NVRAM into RAM but taking into account there is UEFI BIOS. vit9696 invented a method to force native NVRAM in new drivers AptioMemoryFix and OpenRuntime.  Since that EmuVariableUefi.efi is no more used by anybody although remains in sources.

 

So @Sherlocks what is your question?

Sherlocks
Sherlocks
Posted
Posted (edited)
8 minutes ago, Slice said:

For legacy BIOS there is a driver MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe/ which is included into boot6 and boot7 providing emulated NVRAM into RAM. So variables will be keeping in memory until reboot. In the case of shutdown or reboot the Clover provided shutdown script which save variables from emulated NVRAM into the file nvram.plist. Next start Clover will read the file nvram.plist and place its content into new RAM which will be assigned to emulated NVRAM again.

 For UEFI BIOS there are always hardware NVRAM but some years ago it was unaccessible from Clover so why Dmazar wrote new driver EmuVariableUefi.efi which also create emulated NVRAM into RAM but taking into account there is UEFI BIOS. vit9696 invented a method to force native NVRAM in new drivers AptioMemoryFix and OpenRuntime.  Since that EmuVariableUefi.efi is no more used by anybody although remains in sources.

 

So @Sherlocks what is your question?

 

About a month or so ago, I reported on this issue.
Before clover was mixed with open core, it worked fine.

 

 

Edited by Sherlocks
Slice
Slice
Posted
Posted
2 hours ago, Jief_Machak said:

@Slice Thing to have a look : in CommonPatches.c, importing KernelCPUIDPatch() if needed (maybe there is a kernel cpuid patch mechanism we can use instead ?).

 

Where is PatchKernelCpuId() implementation?

12 minutes ago, Sherlocks said:

 

About a month or so ago, I reported on this issue.
Before clover was mixed with open core, it worked fine.

 

 

If you have EmuVariableUefi.efi  then exclude it and test. OpenRuntime should make native NVRAM working.

Slice
Slice
Posted
Posted

You don't need to check AutoGenerated.c. The key feature is bit 35 in (Extended)FirmwareFeatures and in the mask. Thanks to vit9696 for the discovery.

I should note that old FirmwareFeatures is 32bit only. We have to set the bit in the ExtendedFirmwareFeatures.

Now Clover has the default values for some models. Other users may set it in config.plist.

  • Like 2
Jief_Machak
Jief_Machak
Posted
Posted
12 hours ago, Slice said:

I use Xcode as an IDE to find symbols in the whole project.

Yeah, I never understood why you don't use the CloverX64 project I made. So much quicker. Compiled the whole Clover (I mean Clover itself, the rEFIt_UEFI folder) and 10 seconds.

12 hours ago, Slice said:

Hmm, text editor size of 30Gb...

?

Can I help in any way ?

 Share
Go to topic listing
×
×
  • Create New...