Clover General discussion

[Jief_Machak]

3 hours ago, kushwavez said:

@Jief_Machak Just an idea. What if a new key or some new features added in Clover? Could the Validator notify us that there is such key, but not defined in config.plist?

For example: Key "IsCloverTheBest" is undefined, Type Boolean, using default value "True" or something like that.

That would also good for another, existing keys too to see that they're existing, but unused OR used with default values. 

 

 

I understand, but if I printed all default values, the new ones will be lost among the olds.

It's more of a problem of documentation, that we don't have anymore (although a lot from the old wiki is still valid).

We need some hands...

5 hours ago, Slice said:

There is also a small bug with line numeration: 122 instead of 123 and so on.

Fixed.

4 hours ago, Jief_Machak said:

If I compile without optimization, Release works fine...

Wondering how is that possible, considering it's simple with no "tricks" or anything that's supposed to generate optimization errors...

Obvious, in the end : a var not initialized. By luck, value was 0 for non-optimized.

[Jief_Machak]

To compile the validator, use "xcodebuild -target CloverConfigPlistValidator -configuration Release". That way, the name of the scheme doesn't matter...

4 hours ago, maclinuxG4 said:

hello i am still with R5133, i make each time compile ,and install .

 

https://github.com/CloverHackyColor/CloverBootloader/commit/f28e98fb3330990e357476dc6bf784453e3c67df

 

https://github.com/CloverHackyColor/CloverBootloader/commit/51d5d4a141e92dfa8337b82d06bd41be686b5082

 

@Jief_Machak could you generate a version to test ?

 

thanks

 

Done.

[kushwavez]

22 minutes ago, Jief_Machak said:

It's more of a problem of documentation, that we don't have anymore (although a lot from the old wiki is still valid).

We need some hands...

Yes I undestand that. 

 

I just saw this https://github.com/Drovosek01/CloverBootloader-documentation

and this

 

By @Drovosek

I think he did a good job.

 

The FULL documentation is autotranslated and a bit sketchy because of that, but I can understand.

On GitHub I found out that he started to summarize what are in the latest config.plist, and what the default value is. 

Maybe it is a good idea to mention his work on Clover github README or release page for people searching for documents? 

[Jief_Machak]

8 minutes ago, kushwavez said:

Yes I undestand that. 

 

I just saw this https://github.com/Drovosek01/CloverBootloader-documentation

and this

 

By @Drovosek

I think he did a good job.

 

The FULL documentation is autotranslated and a bit sketchy because of that, but I can understand.

On GitHub I found out that he started to summarize what are in the latest config.plist, and what the default value is. 

Maybe it is a good idea to mention his work on Clover github README or release page for people searching for documents? 

Yes, not bad.

He only did Boot and GUI section, but we should definitely collaborate to continue this, maintain a translation for example.

He mentioned https://clover-wiki.zetam.org/. I remember to like this wiki. Is it all lost ?

 

So there is some more people who can help. We should join efforts...

He definitely has a lot of information with when a parameter was added, what problem and when it was fixed !

[chris1111]

[maclinuxG4]

hello still broken.

 

i found what block.  (quirks are not guilty !!!!!!!)

 

i send report to slice

 

@jief_Machak , i lost time to select, to boot and finish ( boot take  previously 11 s and now  too slow 33 s...)

So last R5134 is too slow !!!!!!!!!!

Edited May 4, 2021 by maclinuxG4

[Jief_Machak]

4 hours ago, maclinuxG4 said:

@jief_Machak , i lost time to select, to boot and finish ( i was near 11 s to 33 s...)

Sorry, but I can't understand what you mean...

[Jief_Machak]

12 hours ago, maclinuxG4 said:

hello still broken.

 

i found what block.  (quirks are not guilty !!!!!!!)

 

i send report to slice

 

@jief_Machak , i lost time to select, to boot and finish ( boot take  previously 11 s and now  too slow 33 s...)

So last R5134 is too slow !!!!!!!!!!

"I lost time" : I think I understand now.

But you have to send at least some logs if you want us to look.

 

 

On 5/3/2021 at 3:26 PM, LAbyOne said:

@Slice and @Jief_Machak

there you go, works fine here, but i will just wait for this till will properly build under any Xcode.. otherwise can become "uncomfortable" for the build itself.

insertions.dmg 33.94 kB · 6 downloads

 

P.S.

Forgot to add,

- adding a Makefile inside the CloverConfigPlistValidator will make the build nicer ?

- I guess i forgot to mkdir when installing tool onto destination, sorry.

Wouldn't it be handy if you create a pull request ?

Edited May 5, 2021 by Jief_Machak

[Jief_Machak]

18 hours ago, Jief_Machak said:

Looks like a crash is DSDT pacthing... surprising. 

Please try this efi : CloverX64-2021-05-04-13-36-24-ee78cb9-dirty-jief.zip and send me the log.

@kushwavez Did you see that post ?

I'd like to debug your crash that seems to happen in ACPI patching.

Edited May 5, 2021 by Jief_Machak

[Matgen84]

Hi @Jief_Machak One question: I edited my personal Clover script, to build CloverConfigPlistValidator release to a specific destination: ~/src/tools (along side Cloverbootloader). When I update Clover, is the CloverConfigPlistValidator project also updated ? Because I don't use git pull for CloverConfigPlistValidator.

Thanks.

[Matgen84]

Hi @Jief_Machak @Slice

I don't understand why, there is a difference between commit number for OpencorePKG when I build this morning.

CloverHackycolor/CloverBootloader repo
 

Spoiler

CloverHackycolor/OpencorePKG
 

Spoiler

 

 

I can't build CloverConfigPlistValidator

 

note: Using new build system
note: Planning build
note: Constructing build description
error: unable to find sdk 'macosx10.11' (in target 'CloverConfigPlistValidator' from project 'CloverConfigPlistValidator')

But I can using: -sdk macosx (on Mojave, Xcode 11.3.1). 
 

Spoiler

 

Spoiler

 

Edited May 5, 2021 by Matgen84

[kushwavez]

1 hour ago, Jief_Machak said:

@kushwavez Did you see that post ?

I'd like to debug your crash that seems to happen in ACPI patching.

Yes I did, just needed to revert my config.plist to the old state where it won't boot (but could boot with v5133).

Now I woke up ealry so had time for that.

So here a new log with your efi:

 

I compared the new and the old config.plist
 

The only thing changed in new:

ACPI/DSDT/Fixes: FixAirport=False, FixHPET=True, FixIPIC= True, FixRTC=True, FixTMR=True

The above Fixes didn't cause the lockup.

 

Moving on to ACPI/DSDT/Patches:

• Deleted "Change _DSM to XDSM" rename patch
• Disabled HECI to IMEI rename patch
• Deleted HPET _CRS to XCRS, RTC IRQ8, TIMR IRQ8, TIMR IRQ 0 (enabled ACPI/DSDT/Fixes for them instead)

After that, it started (with release v5134 and your efi too). So something was in the ACPI/DSDT/Patches

 

EDIT: also with your new efi, iGPU HW acceleration failed to load (UHD 620 loaded with 7 MB VRAM). tried two times (once with NVRAM reset). On v5134 it's okay. Don't know why, will test more later.

2021-05-05_06-06_CloverX64-2021-05-04-13-36-24-ee78cb9-dirty-jief.efi.log

Edited May 5, 2021 by kushwavez

[maclinuxG4]

2 hours ago, Jief_Machak said:

@kushwavez Did you see that post ?

I'd like to debug your crash that seems to happen in ACPI patching.

 

i am block with ACPI/DSDT/Fixes i could find to find where.

i will send Three reports with:

1-boot too slowly and ACPI is totally wrong (value are different from previous r5133)? time to boot 33 s

2-boot complet too slowly and ACPI is totally wrong (all section  !!!!!!!!!) (values are different from previous r5133). time to boot 33 s

3-not boot, value are from previous with black screen.

 

[maclinuxG4]

2 hours ago, kushwavez said:

I compared the new and the old config.plist

 

The only thing changed in new:

ACPI/DSDT/Fixes: FixAirport=False, FixHPET=True, FixIPIC= True, FixRTC=True, FixTMR=True

The above Fixes didn't cause the lockup.

 

Moving on to ACPI/DSDT/Patches:

• Deleted "Change _DSM to XDSM" rename patch
• Disabled HECI to IMEI rename patch
• Deleted HPET _CRS to XCRS, RTC IRQ8, TIMR IRQ8, TIMR IRQ 0 (enabled ACPI/DSDT/Fixes for them instead)

 

Could developer clover confirm whole  modifications list to to do or not , because i am not sur that is compatible with clover configurator ?

 

thanks

 

i agree in this case, if options are set to TRUE, no boot

Edited May 5, 2021 by maclinuxG4

[Jief_Machak]

2 hours ago, Matgen84 said:

unable to find sdk 'macosx10.11'

I'm currently working on cleaning the validator project.

This problem is fixed, soon to be committed.

3 hours ago, Matgen84 said:

When I update Clover, is the CloverConfigPlistValidator project also updated ? Because I don't use git pull for CloverConfigPlistValidator.

Yes, you pull everything. It's not separate project, they are in the same tree.

[MacKonsti]

Hi @Jief_Machak thanks from me too for posting the CloverConfigPlistValidator officially in Clover's GitHub Releases page.

For us that don't know or don't have time to build binaries etc. now that you fixed both bugs, can we ask you to either share an updated r5134-1 or r5134.1 binary in the Releases Page or at least, kindly offer it here?

This way we know everyone is using the latest fixed one. Thank you in advance!

[Matgen84]

54 minutes ago, Jief_Machak said:

I'm currently working on cleaning the validator project.

This problem is fixed, soon to be committed.

 

@Jief_Machak Thanks. 
I can build the validator with macosx only ( in my script: -sdk macosx ) instead of 'macosx10.11' in the xcodeproject GitHub repo: the project find itself the macOS SDK installed on my system (Mojave, Xcode 11.3.1) and use it to build the tool.

Edited May 5, 2021 by Matgen84

[Jief_Machak]

@kushwavez Sorry, made a mistake and the log are not there.

Please keep that configuration that can reproduce this crash !

Try it with : CloverX64-2021-05-05-12-57-57-6266377-dirty-jief.zip

Thanks.

10 minutes ago, Matgen84 said:

 

@Jief_Machak Thanks. 
I can build the validator with macosx only ( in my script: -sdk macosx ) instead of 'macosx10.11' in the xcodeproject GitHub repo: the project find itself the macOS SDK installed on my system (Mojave, Xcode 11.3.1) and use it to build the tool.

yes, I already put back macosx instead of macosx10.11.

[Jief_Machak]

4 hours ago, Matgen84 said:

 

Fixed.

@Slice : remember that when you commit in OpenCorePkg, you have to commit in Clover that the sunmodule changed.

[kushwavez]

4 hours ago, Jief_Machak said:

@kushwavez Sorry, made a mistake and the log are not there.

Please keep that configuration that can reproduce this crash !

Try it with : CloverX64-2021-05-05-12-57-57-6266377-dirty-jief.zip

Thanks.

Here you go

 

EDIT: @Jief_Machak I saw in the log that it hangs after FixAirport. So I disabled it (only that, no other changes in the old cfg), and it booted.

Still no iGPU accel with this efi, gonna look into that in a half hour

EDIT2: tried 4 times with the same config:

- With your efi: No iGPU acceleration. Kexts are loaded. Maybe DeviceProperties aren't injected?

- With Clover v5134 release: Everything's OK

 

2021-05-05_14-41_CloverX64-2021-05-05-12-57-57-6266377-dirty-jief.efi.log

Edited May 5, 2021 by kushwavez

[Jief_Machak]

Ok, let's take them down one by one ! 

The reason I can't reproduce is because I don't have the same DSDT.

Execute this with FixAirport to true : CloverX64-2021-05-05-20-36-44-d52803e-dirty-jief.zip

After the crash, reboot and you'll find a file "DSDT_before_AIRPORT.bin" in misc folder. Send it to me. With this, I have the DSDT in the exact state it is when FixAirport is called.

I hope to reproduce with that, which will save you a loooot of reboot ! 

[kushwavez]

11 minutes ago, Jief_Machak said:

Ok, let's take them down one by one ! 

The reason I can't reproduce is because I don't have the same DSDT.

Execute this with FixAirport to true : CloverX64-2021-05-05-20-36-44-d52803e-dirty-jief.zip

After the crash, reboot and you'll find a file "DSDT_before_AIRPORT.bin" in misc folder. Send it to me. With this, I have the DSDT in the exact state it is when FixAirport is called.

I hope to reproduce with that, which will save you a loooot of reboot ! 

Thanks, man, if there were more devs like you... 

Here you are

DSDT_and_log.zip

[Slice]

7 hours ago, Jief_Machak said:

Fixed.

@Slice : remember that when you commit in OpenCorePkg, you have to commit in Clover that the sunmodule changed.

How shall I do this?

iMac2017:CloverBootloader sergey$ git commit -a -s -m "submodule changed"
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
	modified:   OpenCorePkg (untracked content)

 

7 hours ago, Jief_Machak said:

 

 

yes, I already put back macosx instead of macosx10.11.

My mistake.

Anyway my version of CloverConfigPlistValidator compiled with sdk10.11 works everywhere!

[Common_Sense]

Can we please have Scanpolicy in Config.plist, as seen in OpenCore? It is a very powerful and simple way to select what filesystems, drives etc. should be scanned for by the bootloader, and what gets to show up in the boot menu. Since we use OC runtime I think that option should be readily available? Nothing wrong with picking the good stuff that could benefit Clover users  Just my 2cents.

 

Excellent work with Clover, integrating XML validation at boot and having a command line tool for validating and making sure that the config.plist is properly formatted and uses the correct options and values. Makes it so much easier to find faults when you get stuck and just cannot find what is wrong with the file.

[chris1111]

New theme MacSteel available on Github  

5 background included

 

Background-1080p.png

Background-1366x768.png

Background-1024x768.png

Background-2560x1440.png

Background-1600x900.png

 

Included MacOS Icons from Tiger to macOS Big Sur