Jump to content

Customized OpenCore with additional features

n.d.k

By n.d.k,
in OpenCore

 Share
1335 posts in this topic

Recommended Posts

STLVNUB
STLVNUB
Posted
Posted (edited)

Trying to compile with GCC5 

build.py...
/Users/stlvnub/OpenCorePkg/edk2/OpenCorePkg/OpenCorePkg.dsc(...): error 4000: Instance of library class [FrameBufferBltLib] is not found
	in [/Users/stlvnub/OpenCorePkg/edk2/OcSupportPkg/Library/OcConsoleLib/OcConsoleLib.inf] [X64]
	consumed by module [/Users/stlvnub/OpenCorePkg/edk2/OpenCorePkg/Platform/OpenCore/OpenCore.inf]

This is from clean build

 

edit:

Give up trying to build with my modified script and GCC5/XCODE5, both error out.

Using stock standard builds fine, weird.

Edited by STLVNUB
bayard
bayard
Posted
Posted (edited)
1 hour ago, n.d.k said:

Ok, I just pushed out a new commit which address a couple issues:

 

- Fixed the Install MacOS not show up due to existing custom entry. ( no need to disable custom entry before update any more)

- Use custom font.png instead of HiiFont protocol which use system font. (So, please don't forget to copy font.png from Icons folder to EFI\OC\Icons).

  

I confirm this build 0.1.1 debug is working well on an iMac A1312. Just had to load NdkBootPicker.efi in config.plist and copy font.png to EFI\OC\Icons, no others changes needed. Great.

On Catalina 10.5.3 the compilation fails for me. I used your debug version.

opencore-2020-02-25-043845.txt

config.plist.zip

Compil_failed.txt

Edited by bayard
n.d.k
n.d.k
Posted
  • Author
Posted
48 minutes ago, bayard said:

I confirm this build 0.1.1 debug is working well on an iMac A1312. Just had to load NdkBootPicker.efi in config.plist and copy font.png to EFI\OC\Icons, no others changes needed. Great.

On Catalina 10.5.3 the compilation fails for me. I used your debug version.

opencore-2020-02-25-043845.txt

config.plist.zip

Compil_failed.txt

 

OC was updating some of the functions which required changes on this end as well, It should be Ok now...you can recompile.

n.d.k
n.d.k
Posted
  • Author
Posted
1 hour ago, TAGE said:

Hi there,

Trying to compile using Xcode 10.13.1
fresh install and I've compiled other xcode projects. Any ideas what's wrong?
  


/Volumes/Home/Desktop/OpenCorePkg-master/edk2/OpenCorePkg/Platform/OpenCore/OpenCoreUefi.c:435:26: error: too few arguments to function call, single argument 'Route' was not specified

    OcProvideConsoleGop ();

    ~~~~~~~~~~~~~~~~~~~  ^

/Volumes/Home/Desktop/OpenCorePkg-master/edk2/OcSupportPkg/Include/Library/OcConsoleLib.h:132:1: note: 'OcProvideConsoleGop' declared here

VOID

^

/Volumes/Home/Desktop/OpenCorePkg-master/edk2/MdePkg/Include/Base.h:278:19: note: expanded from macro 'VOID'

#define VOID      void

                  ^

1 error generated.

make: *** [/Volumes/Home/Desktop/OpenCorePkg-master/edk2/Build/OpenCorePkg/DEBUG_XCODE5/X64/OpenCorePkg/Platform/OpenCore/OpenCore/OUTPUT/OpenCoreUefi.obj] Error 1





build.py...

 : error 7000: Failed to execute command

make tbuild [/Volumes/Home/Desktop/OpenCorePkg-master/edk2/Build/OpenCorePkg/DEBUG_XCODE5/X64/OpenCorePkg/Platform/OpenCore/OpenCore]





build.py...

 : error F002: Failed to build module

/Volumes/Home/Desktop/OpenCorePkg-master/edk2/OpenCorePkg/Platform/OpenCore/OpenCore.inf [X64, XCODE5, DEBUG]



- Failed -

Build end time: 23:07:28, Feb.24 2020

Build total time: 00:00:04

 

 

You didn't update the OpenCorePkg itself... always do a git pull first then build

git pull

./nk-macbuild.tool

  • Like 1
Matgen84
Matgen84
Posted
Posted
1 hour ago, n.d.k said:

 

You didn't update the OpenCorePkg itself... always do a git pull first then build

git pull

./nk-macbuild.tool

 

It is possible to integrate git pull command at the beginning of ndk-macbuild.tool to avoid do it manually.

Matgen84
Matgen84
Posted
Posted

Hi @n.d.k

 

I follow yours instructions:

git pull

./ndk-macbuild.tool

 

But I've this issue at the moment:

  

/Users/mathieu/Desktop/NDK_OC_056-93723b7_16_02_2020/OpenCorePkg/edk2/OpenCorePkg/Platform/OpenCore/OpenCoreUefi.c:435:26: error: too few arguments to function call, single argument 'Route' was not specified
    OcProvideConsoleGop ();
    ~~~~~~~~~~~~~~~~~~~  ^
/Users/mathieu/Desktop/NDK_OC_056-93723b7_16_02_2020/OpenCorePkg/edk2/OcSupportPkg/Include/Library/OcConsoleLib.h:132:1: note: 'OcProvideConsoleGop' declared here
VOID
^
/Users/mathieu/Desktop/NDK_OC_056-93723b7_16_02_2020/OpenCorePkg/edk2/MdePkg/Include/Base.h:278:19: note: expanded from macro 'VOID'
#define VOID      void
                  ^
1 error generated.
make: *** [/Users/mathieu/Desktop/NDK_OC_056-93723b7_16_02_2020/OpenCorePkg/edk2/Build/OpenCorePkg/DEBUG_XCODE5/X64/OpenCorePkg/Platform/OpenCore/OpenCore/OUTPUT/OpenCoreUefi.obj] Error 1


build.py...
 : error 7000: Failed to execute command
	make tbuild [/Users/mathieu/Desktop/NDK_OC_056-93723b7_16_02_2020/OpenCorePkg/edk2/Build/OpenCorePkg/DEBUG_XCODE5/X64/OpenCorePkg/Platform/OpenCore/OpenCore]


build.py...
 : error F002: Failed to build module
	/Users/mathieu/Desktop/NDK_OC_056-93723b7_16_02_2020/OpenCorePkg/edk2/OpenCorePkg/Platform/OpenCore/OpenCore.inf [X64, XCODE5, DEBUG]

- Failed -
Build end time: 08:26:35, Feb.25 2020
Build total time: 00:00:03

 

btwise
btwise
Posted
Posted
2 hours ago, eng_redaesm said:

@n.d.k

Dear I think there is aproblem here with NDKbootbicker release 12  

 

the system requires password : before starting the graphical bootbicker 

The same is true with the latest fork, which is caused by the original OC adding some audio related code, but we don't know how to use it

  • Like 1
Awesome Donkey
Awesome Donkey
Posted
Posted (edited)
1 hour ago, btwise said:

@ndk

Update to the latest fork, boot requires password, what is this design?

 

Getting the same issue, OC is asking for a password now. Already tried adding Misc -> Security -> EnablePassword and setting it to false. Also tried setting Misc -> Security -> AuthRestart to true but nothing fixes it. Reverted to the previous working version.

Edited by Awesome Donkey
btwise
btwise
Posted
Posted
2 minutes ago, Awesome Donkey said:

He already responded hours ago here: https://github.com/acidanthera/bugtracker/issues/737

The answer does not solve the actual problem, and there is no EnablePassword option in our config file!

  • Sad 1
Awesome Donkey
Awesome Donkey
Posted
Posted (edited)
14 minutes ago, btwise said:

The answer does not solve the actual problem, and there is no EnablePassword option in our config file!

 

Yes, I'm aware of that. You can add that option if you want, but it setting it to false doesn't fix it. So we'll just have to wait and see if any developer encounters the issue and hopefully fixes it.

 

In the meantime, build this older version (pre-OpenCoreUefiAudio) and replace BOOTx64.efi and OpenCore.efi if you want a working system again: https://github.com/n-d-k/OpenCorePkg/tree/565f1d29072fe783066473365ef12a5f34bb0303

Edited by Awesome Donkey
  • Like 1
Matgen84
Matgen84
Posted
Posted
13 minutes ago, btwise said:

The answer does not solve the actual problem, and there is no EnablePassword option in our config file!

 

Right! There is no such key in sample.plist, sample-full.plist or Difference.pdf :cry:

Awesome Donkey
Awesome Donkey
Posted
Posted
24 minutes ago, Matgen84 said:

 

Right! There is no such key in sample.plist, sample-full.plist or Difference.pdf :cry:

 

Just add it to Misc -> Security in config.plist, like this...

  

        <key>Security</key>
        <dict>
            <key>AllowNvramReset</key>
            <true/>
            <key>AllowSetDefault</key>
            <true/>
            <key>AuthRestart</key>
            <false/>
            <key>EnablePassword</key>
            <false/>
            <key>ExposeSensitiveData</key>
            <integer>3</integer>
            <key>HaltLevel</key>
            <integer>2147483648</integer>
            <key>ScanPolicy</key>
            <integer>983299</integer>
            <key>Vault</key>
            <string>Optional</string>
        </dict>

 

But like I said, adding it and setting it to false doesn't make any difference. Just gotta wait and hope one of the developers either encounters the issue or can reproduce it.

pitrysha
pitrysha
Posted
Posted
29 minutes ago, Matgen84 said:

 

Right! There is no such key in sample.plist, sample-full.plist or Difference.pdf :cry:

0.5.6 still in development, there was no release, so some functions may not work. I think N-D-K needs to release their builds based on official releases not test ones that haven’t been finalized.

  • Like 1
btwise
btwise
Posted
Posted
20 minutes ago, pitrysha said:

0.5.6 still in development, there was no release, so some functions may not work. I think N-D-K needs to release their builds based on official releases not test ones that haven’t been finalized.

I think @n.d.k is capable of solving these problems!

27 minutes ago, Awesome Donkey said:

 

Just add it to Misc -> Security in config.plist, like this...

 

  


        <key>Security</key>
        <dict>
            <key>AllowNvramReset</key>
            <true/>
            <key>AllowSetDefault</key>
            <true/>
            <key>AuthRestart</key>
            <false/>
            <key>EnablePassword</key>
            <false/>
            <key>ExposeSensitiveData</key>
            <integer>3</integer>
            <key>HaltLevel</key>
            <integer>2147483648</integer>
            <key>ScanPolicy</key>
            <integer>983299</integer>
            <key>Vault</key>
            <string>Optional</string>
        </dict>

 

But like I said, adding it and setting it to false doesn't make any difference. Just gotta wait and hope one of the developers either encounters the issue or can reproduce it.

I tested the same problem with the original OC, but developers will admit it only if they encounter the same phenomenon. Let's hope @n.d.k is brilliant!

  • Like 2
Awesome Donkey
Awesome Donkey
Posted
Posted

Well, considering the issue exists in the original upstream OpenCore, it likely needs to be fixed there. That said, as a temporary workaround @n.d.k could revert and remove the OpenCoreUefiAudio stuff from the fork until it's fixed.

 

I can confirm the issue first occurs with the OpenCoreUefiAudio: Initial version commit and every commit after that.

  • Like 1
btwise
btwise
Posted
Posted
5 minutes ago, Awesome Donkey said:

Well, considering the issue exists in the original upstream OpenCore, it likely needs to be fixed there. That said, as a temporary workaround @n.d.k could revert and remove the OpenCoreUefiAudio stuff from the fork until it's fixed.

 

I can confirm the issue first occurs with the OpenCoreUefiAudio: Initial version commit and every commit after that.

Yes, the UefiAudio Support function doesn't know how to use it, so it adds to the bug!

  • Like 1
Matgen84
Matgen84
Posted
Posted (edited)

Hello guys

 

I don't know how you can build, but me I can't: the issues come from Opencoreuefi? both NDK and Official OC of course.

  

/Users/mathieu/Desktop/OpenCorePkg_056/OpenCorePkg/edk2/OpenCorePkg/Platform/OpenCore/OpenCoreUefi.c:408:26: error: too few arguments to function call, single argument 'Route' was not specified
    OcProvideConsoleGop ();
    ~~~~~~~~~~~~~~~~~~~  ^
/Users/mathieu/Desktop/OpenCorePkg_056/OpenCorePkg/edk2/OcSupportPkg/Include/Library/OcConsoleLib.h:132:1: note: 'OcProvideConsoleGop' declared here
VOID
^
/Users/mathieu/Desktop/OpenCorePkg_056/OpenCorePkg/edk2/MdePkg/Include/Base.h:278:19: note: expanded from macro 'VOID'
#define VOID      void
                  ^
1 error generated.
make: *** [/Users/mathieu/Desktop/OpenCorePkg_056/OpenCorePkg/edk2/Build/OpenCorePkg/DEBUG_XCODE5/X64/OpenCorePkg/Platform/OpenCore/OpenCore/OUTPUT/OpenCoreUefi.obj] Error 1


build.py...
 : error 7000: Failed to execute command
	make tbuild [/Users/mathieu/Desktop/OpenCorePkg_056/OpenCorePkg/edk2/Build/OpenCorePkg/DEBUG_XCODE5/X64/OpenCorePkg/Platform/OpenCore/OpenCore]


build.py...
 : error F002: Failed to build module
	/Users/mathieu/Desktop/OpenCorePkg_056/OpenCorePkg/edk2/OpenCorePkg/Platform/OpenCore/OpenCore.inf [X64, XCODE5, DEBUG]

- Failed -
Build end time: 13:28:57, Feb.25 2020
Build total time: 00:00:10

 

Edited by Matgen84
eng_redaesm
eng_redaesm
Posted
Posted

@btwise and @Awesome Donkey 

 

For your information  latest opencore upstream is working with NDKbootpicker release 11 (the problem with rel 12) except one issue custom entries is vanished so i revered back to older stream 

 

Awesome Donkey
Awesome Donkey
Posted
Posted
12 minutes ago, btwise said:

Yes, the UefiAudio Support function doesn't know how to use it, so it adds to the bug!

 

Don't think that's entirely accurate, if you look at the changes in Sample.plist on the repo when the OpenCoreUefiAudio stuff landed, you'll see new additions like the Audio section.

 

https://github.com/n-d-k/OpenCorePkg/commit/77dc10b9716faf8c2161c6e539cda704401f6617

 

That said, even though you can probably guess what they do, those new additions to config.plist haven't been documented yet so in that regard you're correct.

  • Like 1
 Share
Go to topic listing
×
×
  • Create New...