Clover General discussion

cankiulascmnfye · December 7, 2023

9 hours ago, Slice said:

May be there were different Sonoma versions?

Even if there were differences macOS versions, it doesn't change the fact that every Clover build after November 16th is not working if the BlockSkywalk Quirk is required while previous builds work even with the lates version of 14.2

I have an OpenCore EFI for this system as well and blocking Skywalk + injecting the wifi kexts + patching with OCLP to re-enable broadcom cards still works. So the patching principle as a whole still works.

Based on this, I think changes made to Clover after November 16th are the reason why BlockSkywalk is no longer working.

Maybe it would be a good ided to create a new branch based on commit bdb7a95 where BlockSkywalk still works and continue from there. @Jief_Machak

Edited December 7, 2023 by cankiulascmnfye

LAbyOne · December 7, 2023

4 hours ago, Slice said:

Sorry, I missed your message being in Spain.

Do you know some solution about cctools?

into buildmtoc.sh

line 186

add:

    # Replace deprecated DT_TOOLCHAIN_DIR as a workaround for building in Xcode 15
	xcodeapp=$(defaults read /Applications/Xcode.app/Contents/version.plist CFBundleShortVersionString)
	if [[ $xcodeapp == 15.* ]]; then
		sed -i '' 's/DT_TOOLCHAIN_DIR/TOOLCHAIN_DIR/g' "$CCTOOLS_DIR"/xcode/cctools.xcconfig
		sed -i '' 's/DT_TOOLCHAIN_DIR/TOOLCHAIN_DIR/g' "$CCTOOLS_DIR"/xcode/libstuff.xcconfig
		sed -i '' 's/DT_TOOLCHAIN_DIR/TOOLCHAIN_DIR/g' "$CCTOOLS_DIR"/xcode/strip.xcconfig
	fi

Edited December 7, 2023 by LAbyOne

Slice · December 7, 2023

22 hours ago, matxpa said:

@Slice @Jief_Machak

Hi

I've (re)built Clover from different commits (check out commit after commit on a local Repo)

r5157_a9b0654 (20231112-03h48) --> Wifi BCM 4360 works

r5157_1914496 (20231116-19h14) --> Wifi BCM 4360 works

r5157_bdb7a95 (20231116-22h10) --> Wifi BCM 4360 works

but with r5157_c5cb646 (20231119-18h16) boot crash

and with r5157_9e2bc77 (20231120-20h06) boot get stuck rapidly

Regards

Thus you say commit 32fbf76326ba45d6c06f6b3655877dbec21da2fd is the first wrong commit.

Slice · December 7, 2023

4 hours ago, LAbyOne said:

into buildmtoc.sh

line 186

add:

    # Replace deprecated DT_TOOLCHAIN_DIR as a workaround for building in Xcode 15
	xcodeapp=$(defaults read /Applications/Xcode.app/Contents/version.plist CFBundleShortVersionString)
	if [[ $xcodeapp == 15.* ]]; then
		sed -i '' 's/DT_TOOLCHAIN_DIR/TOOLCHAIN_DIR/g' "$CCTOOLS_DIR"/xcode/cctools.xcconfig
		sed -i '' 's/DT_TOOLCHAIN_DIR/TOOLCHAIN_DIR/g' "$CCTOOLS_DIR"/xcode/libstuff.xcconfig
		sed -i '' 's/DT_TOOLCHAIN_DIR/TOOLCHAIN_DIR/g' "$CCTOOLS_DIR"/xcode/strip.xcconfig
	fi

Thank you but

mtoc.make.log.txt.zip

LAbyOne · December 7, 2023

56 minutes ago, Slice said:

Thank you but

mtoc.make.log.txt.zip 1.71 kB · 2 downloads

your log shows the patches were not applied to the files.

Now the reason may be you'r using a beta version of Xcode

my patch checks for bundle version, maybe that is the reason why it fails.

I did not consider the beta version at that time

Don't know really what to say as now i do not have anymore a working machine to test

But the patches are ok.

Edited December 7, 2023 by LAbyOne

chris1111 · December 7, 2023

2 hours ago, Slice said:

Thank you but

mtoc.make.log.txt.zip 1.71 kB · 4 downloads

Same this is not working

Good trip

matxpa · December 7, 2023

2 hours ago, Slice said:

Thus you say commit 32fbf76326ba45d6c06f6b3655877dbec21da2fd is the first wrong commit.

@Slice

Hi.

All tests mad with Builds (Releases) done on a Laptop Ivy with Sonoma 14.1.2 and Xcode 15.0.1

To answer you : Clover build can't be done with commit 32fbf763, build aborted

And with r5157_c5cb646 (20231119-18h16) build done but with an immediate crash at boot

with r5157_9e2bc77 (20231120-20h06) build done but boot get stuck rapidly with BlockSkywalk = TRUE + IOSkywalkFamily.kext and IO80211FamilyLegacy.kext

and I can add the next (tested) commits (build done but boot get stuck rapidly with BlockSkywalk = TRUE + IOSkywalkFamily.kext and IO80211FamilyLegacy.kext)

with r5157_544d3ce (20231121-01h02), r5157_20e924f (20231126-17h10), r5157_09938d4 (20231126-17h24), r5157_153691a (20231202-12h14) and the last one r5157_e614deb (20231204-23h09)

Regards

miliuco · December 7, 2023

@cankiulascmnfye @MakAsus @Matgen84

Tried bdb7a95 "changes in OC", no luck. Every time BlockSkyWalk is enabled, I get early KP. Same with current build.

Silly question: how to disable SecureBoot in Clover?

LAbyOne · December 7, 2023

2 hours ago, LAbyOne said:

your log shows the patches were not applied to the files.

Now the reason may be you'r using a beta version of Xcode

my patch checks for bundle version, maybe that is the reason why it fails.

I did not consider the beta version at that time

Don't know really what to say as now i do not have anymore a working machine to test

But the patches are ok.

@Slice

i forgot to mention that the same changes must be made also into CloverBootloader/Patches/Mtoc/libstuff.xcconfig

line 13

HEADER_SEARCH_PATHS = ${inherited} ${DT_TOOLCHAIN_DIR}/usr/local/include
->
HEADER_SEARCH_PATHS = ${inherited} ${TOOLCHAIN_DIR}/usr/local/include

that totally just slipped my mind. Sorry

Edited December 7, 2023 by LAbyOne

cankiulascmnfye · December 7, 2023

17 minutes ago, miliuco said:

@cankiulascmnfye @MakAsus @Matgen84

Tried bdb7a95 "changes in OC", no luck. Every time BlockSkyWalk is enabled, I get early KP. Same with current build.

Silly question: how to disable SecureBoot in Clover?

Can't disable something that isn't there…

chris1111 · December 8, 2023

I am using the latest Acidanthera mtoc then build Clover without issue Xcode 15.0.1 Sonoma 14.2 (23C63)

So why not using an already binaries rather than trying to compile it

@Slice I made the change if you want I can commit then using Acidanthera mtoc simple as that.

Edited December 8, 2023 by chris1111
I can commit then using Acidanthera mtoc

miliuco · December 8, 2023

7 hours ago, chris1111 said:

I am using the latest Acidanthera mtoc then build Clover without issue Xcode 15.0.1 Sonoma 14.2 (23C63)

I also can compile doing as you say. Xcode 15.0.1 + Sonoma 14.1.2 (23B92). Latest Clover source code, today.

Spoiler

/Users/yo/Developer/CloverBootloader > ./buildme
...
- Building GCC 13.1.0 toolchain for x64
- to /Users/yo/Developer/CloverBootloader/toolchain/cross/bin/x86_64-clover-linux-gnu
  Running on Mac OS X 14.1, with x86_64 architecture.
  Using Xcode SDK: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk
...
* GCC toolchain Build process took 8m47s to complete...
...
Copy CloverEFI:
  -> boot6
  -> BOOTX64.efi
  -> CLOVERX64.efi
Copy Mandatory drivers:
  -> XhciDxe.efi
  -> EnglishDxe.efi
  -> ApfsDriverLoader.efi
  -> FSInject.efi
  -> EnglishDxe.efi
  -> GrubEXFAT.efi
  -> GrubISO9660.efi
  -> GrubNTFS.efi
  -> GrubUDF.efi
  -> CsmVideoDxe.efi
  -> EmuVariableUefi.efi
  -> NvmExpressDxe.efi
  -> OsxFatBinaryDrv.efi
  -> PartitionDxe.efi
  -> AudioDxe.efi
  -> Ps2MouseDxe.efi
  -> UsbKbDxe.efi
  -> UsbMouseDxe.efi
  -> AptioInputFix.efi
  -> ApfsDriverLoader.efi
  -> Fat.efi
  -> VBoxExt2.efi
  -> VBoxExt4.efi
  -> VBoxIso9600.efi
  -> VBoxHfs.efi
  -> AppleKeyFeeder.efi
  -> HashServiceFix.efi
  -> OpenRuntime.efi
Copy Applications:
  -> bdmesg.efi
  -> ControlMsrE2.efi
  -> Shell64U.efi
Done!

Slice · December 8, 2023

17 hours ago, LAbyOne said:
@Slice

i forgot to mention that the same changes must be made also into CloverBootloader/Patches/Mtoc/libstuff.xcconfig

line 13
HEADER_SEARCH_PATHS = ${inherited} ${DT_TOOLCHAIN_DIR}/usr/local/include
->
HEADER_SEARCH_PATHS = ${inherited} ${TOOLCHAIN_DIR}/usr/local/include
that totally just slipped my mind. Sorry

slice@iMac CloverBootloader % ./buildmtoc.sh  
WORKSPACE must be defined to Clover root path

- Creating new RAM disk

Initialized /dev/rdisk4 as a 300 MB case-insensitive HFS Plus volume
-  cctools-986 extract...
2023-12-08 19:06:53.285 defaults[97830:518856] 
The domain/default pair of (/Applications/Xcode.app/Contents/version.plist, CFBundleShortVersionString) does not exist
-  cctools-cctools-986 make mtoc...
-  cctools-cctools-986 installing mtoc...
-  cctools-cctools-986 mtoc installed in /Users/slice/src/opt/local

- Ejecting RAM disk
"disk4" ejected.
slice@iMac CloverBootloader %

18 hours ago, miliuco said:

@cankiulascmnfye @MakAsus @Matgen84

Tried bdb7a95 "changes in OC", no luck. Every time BlockSkyWalk is enabled, I get early KP. Same with current build.

Silly question: how to disable SecureBoot in Clover?

It is always disabled being nonsense.

Slice · December 8, 2023

18 hours ago, miliuco said:

@cankiulascmnfye @MakAsus @Matgen84

Tried bdb7a95 "changes in OC", no luck. Every time BlockSkyWalk is enabled, I get early KP. Same with current build.

Sorry, what toolset did you use, GCC131?

Matxpa used XCODE15 with success.

mariosun · December 8, 2023

On 12/7/2023 at 2:47 PM, cankiulascmnfye said:

it doesn't change the fact that every Clover build after November 16th is not working if the BlockSkywalk

it would also be helpful to understand why it works for a couple of people and doesn't work for others

Slice · December 8, 2023

On 12/6/2023 at 11:19 PM, matxpa said:

@Slice @Jief_Machak

Hi

I've (re)built Clover from different commits (check out commit after commit on a local Repo)

r5157_a9b0654 (20231112-03h48) --> Wifi BCM 4360 works

r5157_1914496 (20231116-19h14) --> Wifi BCM 4360 works

r5157_bdb7a95 (20231116-22h10) --> Wifi BCM 4360 works

but with r5157_c5cb646 (20231119-18h16) boot crash

and with r5157_9e2bc77 (20231120-20h06) boot get stuck rapidly

Regards

Can you upload here some of working build for our tests?

cankiulascmnfye · December 8, 2023

57 minutes ago, mariosun said:

it would also be helpful to understand why it works for a couple of people and doesn't work for others

Well, I've notice that recently manual updating required todelete the whole EFI forlder and rebuilding it (put back kexts, config)

So far I provided:

Issue report (incl. Bootlog) here: https://github.com/CloverHackyColor/CloverBootloader/issues/651
Last working Clover folder here: https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/?do=findComment&comment=2814338

Also: we've established that BlockSkywalk most definitely stopped working after November 16th.

>> I think it's time that those who can start having a look at the source code.

mariosun · December 8, 2023

10 minutes ago, cankiulascmnfye said:

Also: we've established that BlockSkywalk most definitely stopped working after November 16th.

for some of us never worked

i have used EFi you kindly posted some messages above and i have the same hang some of us have in early bootloader stage.

So problem is deeper to rule

I have no intel system so my problem could be different (clover doesnt work so well in AM5 system (audio crackling))

But curious and happy if wifi problem is solved for some people!

matxpa · December 8, 2023

1 hour ago, Slice said:

Can you upload here some of working build for our tests?

@Slice

Hi

Here's what you want and what you need (BOOTX64.efi (and CLOVERX64.efi) after renaming the below efi components) of :

r5157_a9b0654 (20231112-03h48) --> Wifi BCM 4360 works CloverX64_r5157_20231112-03h48_a9b0654_XCODE15_RELEASE_master_local.efi

r5157_1914496 (20231116-19h14) --> Wifi BCM 4360 works CloverX64_r5157_20231116-19h14_1914496 _XCODE15_RELEASE_master_local..efi

r5157_bdb7a95 (20231116-22h10) --> Wifi BCM 4360 works CloverX64_r5157_20231116-22h10_bdb7a95_XCODE15_RELEASE_master_local.efi

What else ...

ACPI/DSDT/Fixes : FixAirport=TRUE

Devices/FakeID : WIFI=0x43a014e4

KernelAndKextPatches : BlockSkywalk = TRUE

RtVariables : CsrActiveConfig=0x803 (just F.Y.I)

kexts/14 : AMFIPass.kext, IOSkywalkFamily.kext, IO80211FamilyLegacy.kext and RestrictEvents.kext) --> latest OC or OCLP releases

kexts/Other : (Std kexts) ALC LILU WEG SMC(Virtual and specifics Asus X75VB kexts for RJ45, WebCam, KBD & PAD) --> latest OC or others Dev. releases

NB in KernelAndKextPatches/KextsToPatch

I don't need (Disabled=YES) the patch from www.applelife.ru (Broadcom 94360 activation AirPort.BrcmNIC)

Regards

Edited December 8, 2023 by matxpa
latest kexts releases

Slice · December 8, 2023

20 minutes ago, cankiulascmnfye said:

Well, I've notice that recently manual updating required todelete the whole EFI forlder and rebuilding it (put back kexts, config)

So far I provided:

Issue report (incl. Bootlog) here: https://github.com/CloverHackyColor/CloverBootloader/issues/651

Last working Clover folder here: https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/?do=findComment&comment=2814338

Also: we've established that BlockSkywalk most definitely stopped working after November 16th.

>> I think it's time that those who can start having a look at the source code.

As well your Clover is not working for me too. Same hang after BootKernelExtensions.kc as with many other versions if BlockSkywalk = true.

So the problem is not with the Clover version.

Slice · December 8, 2023

31 minutes ago, matxpa said:

@Slice

Hi

Here's what you want and what you need (BOOTX64.efi (and CLOVERX64.efi) after renaming the below efi components) of :

r5157_a9b0654 (20231112-03h48) --> Wifi BCM 4360 works   CloverX64_r5157_20231112-03h48_a9b0654_XCODE15_RELEASE_master_local.efi

r5157_1914496 (20231116-19h14) --> Wifi BCM 4360 works   CloverX64_r5157_20231116-19h14_1914496 _XCODE15_RELEASE_master_local..efi

r5157_bdb7a95 (20231116-22h10) --> Wifi BCM 4360 works   CloverX64_r5157_20231116-22h10_bdb7a95_XCODE15_RELEASE_master_local.efi

What else ...

ACPI/DSDT/Fixes : FixAirport=TRUE

Devices/FakeID : WIFI=0x43a014e4

  KernelAndKextPatches : BlockSkywalk = TRUE

RtVariables : CsrActiveConfig=0x803 (just F.Y.I)

kexts/14 : AMFIPass.kext, IOSkywalkFamily.kext, IO80211FamilyLegacy.kext and RestrictEvents.kext) --> latest OC or OCLP releases

kexts/Other : (Std kexts) ALC LILU WEG SMC(Virtual and specifics Asus X75VB kexts for RJ45, WebCam, KBD & PAD) --> latest OC or others Dev. releases

NB in KernelAndKextPatches/KextsToPatch

I don't need (Disabled=YES) the patch from www.applelife.ru (Broadcom 94360 activation AirPort.BrcmNIC)

Regards

Same result. It never worked for my hardware.

36 minutes ago, matxpa said:

@Slice

Hi

Here's what you want and what you need (BOOTX64.efi (and CLOVERX64.efi) after renaming the below efi components) of :

r5157_a9b0654 (20231112-03h48) --> Wifi BCM 4360 works   CloverX64_r5157_20231112-03h48_a9b0654_XCODE15_RELEASE_master_local.efi

r5157_1914496 (20231116-19h14) --> Wifi BCM 4360 works   CloverX64_r5157_20231116-19h14_1914496 _XCODE15_RELEASE_master_local..efi

r5157_bdb7a95 (20231116-22h10) --> Wifi BCM 4360 works   CloverX64_r5157_20231116-22h10_bdb7a95_XCODE15_RELEASE_master_local.efi

What else ...

ACPI/DSDT/Fixes : FixAirport=TRUE

Devices/FakeID : WIFI=0x43a014e4

  KernelAndKextPatches : BlockSkywalk = TRUE

RtVariables : CsrActiveConfig=0x803 (just F.Y.I)

kexts/14 : AMFIPass.kext, IOSkywalkFamily.kext, IO80211FamilyLegacy.kext and RestrictEvents.kext) --> latest OC or OCLP releases

kexts/Other : (Std kexts) ALC LILU WEG SMC(Virtual and specifics Asus X75VB kexts for RJ45, WebCam, KBD & PAD) --> latest OC or others Dev. releases

NB in KernelAndKextPatches/KextsToPatch

I don't need (Disabled=YES) the patch from www.applelife.ru (Broadcom 94360 activation AirPort.BrcmNIC)

Regards

Did you test on other computer?

matxpa · December 8, 2023

1 hour ago, Slice said:

Same result. It never worked for my hardware.

Did you test on other computer?

No I didn't coz on my Laptops Tinkpad T550 and T450 Wifi card is an Intel (AirportItlwm.kext) and on my Desktop Z270 Wifi is an USB Stick with a Realtek chip and Chris1111's Wireless USB Adapter.

And with (your latest commit) r5157_0eac408 (20231208-19h20) XCODE15 RELEASE boot hang after BootKernelExtensions.kc as all the commits after r5157_bdb7a95 (20231116-22h10) do.

But it's not significant, the two last commits don't concern bootloader code

Edited December 8, 2023 by matxpa
comment after test with r5157_0eac408 new build

cankiulascmnfye · December 8, 2023

1 hour ago, Slice said:

So the problem is not with the Clover version.

Your "modus operandi" leaves me baffled. I don't know whose problem it is but it's definetly no longer mine…

jsl2000 · December 9, 2023

6 hours ago, matxpa said:

@Slice

Hi

Here's what you want and what you need (BOOTX64.efi (and CLOVERX64.efi) after renaming the below efi components) of :

r5157_a9b0654 (20231112-03h48) --> Wifi BCM 4360 works   CloverX64_r5157_20231112-03h48_a9b0654_XCODE15_RELEASE_master_local.efi

r5157_1914496 (20231116-19h14) --> Wifi BCM 4360 works   CloverX64_r5157_20231116-19h14_1914496 _XCODE15_RELEASE_master_local..efi

r5157_bdb7a95 (20231116-22h10) --> Wifi BCM 4360 works   CloverX64_r5157_20231116-22h10_bdb7a95_XCODE15_RELEASE_master_local.efi

What else ...

ACPI/DSDT/Fixes : FixAirport=TRUE

Devices/FakeID : WIFI=0x43a014e4

  KernelAndKextPatches : BlockSkywalk = TRUE

RtVariables : CsrActiveConfig=0x803 (just F.Y.I)

kexts/14 : AMFIPass.kext, IOSkywalkFamily.kext, IO80211FamilyLegacy.kext and RestrictEvents.kext) --> latest OC or OCLP releases

kexts/Other : (Std kexts) ALC LILU WEG SMC(Virtual and specifics Asus X75VB kexts for RJ45, WebCam, KBD & PAD) --> latest OC or others Dev. releases

NB in KernelAndKextPatches/KextsToPatch

I don't need (Disabled=YES) the patch from www.applelife.ru (Broadcom 94360 activation AirPort.BrcmNIC)

Regards

Thanks, but replaced with your BOOTX64.efi & CLOVERX64.efi as well as your settings my Z690 hackintosh still got the same hang in early boot of Clover 5157 as before.

One more question did your CPU in X75 have AVX2 instruction codes because ordinary Ivy Bridge's CPU need more to boot Ventura & Sonoma in my case ?

Edited December 9, 2023 by jsl2000

Slice · December 9, 2023

11 hours ago, cankiulascmnfye said:

Your "modus operandi" leaves me baffled. I don't know whose problem it is but it's definetly no longer mine…

You are right and thank you for the investigation. There are two questions:

1. Why Clover before 16 November works for you and later not? While opencore always work. There is definitely mistake in 32fbf76 commit.

2. Why your working Clover is not working for me and some other users? Hardware dependency?

I see no how these two questions are connected.

Clover General discussion

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites