Jief_Machak Posted August 16, 2020 Share Posted August 16, 2020 Oups oups. Any log file to get an idea where is the bug ? Or even better, the backtrace with gdb ? Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734392 Share on other sites More sharing options...
Slice Posted August 16, 2020 Share Posted August 16, 2020 18 minutes ago, Jief_Machak said: Or even better, the backtrace with gdb ? I don't know how to use gdb with real boot. About log one minute. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734396 Share on other sites More sharing options...
Jief_Machak Posted August 16, 2020 Share Posted August 16, 2020 6 minutes ago, Slice said: gdb with real boot Yes, sure. It may be technically possible, but I didn't go that far ! Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734397 Share on other sites More sharing options...
Slice Posted August 16, 2020 Share Posted August 16, 2020 Crash is happen somewhere in patching DSDT 20:899 0:001 === [ FixBiosDsdt ] ============================= 20:901 0:002 Patching DSDT: 20:903 0:001 - [Rename ECDV to EC__]: pattern 45434456, patched at: [ (857F) ] 20:917 0:014 0 replacements 0:100 0:100 MemLog inited, TSC freq: 2591585460 0:100 0:000 CPU was calibrated with ACPI PM Timer Full log debug.log.zip Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734398 Share on other sites More sharing options...
Jief_Machak Posted August 16, 2020 Share Posted August 16, 2020 I've just committed few correction (length() test before char access). Could you try while I'm looking your log ? On 8/16/2020 at 7:47 AM, Slice said: patching DSDT PatchACPI() is done before USB fixownership, right ? So the patching of ACPI went ok ? Looks like usb ownership fix is the last thing done in "OnExitBootServices()". Is not normal that the log stop here ? When you get that log, you got the panic i > length(), or just crash ? Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734399 Share on other sites More sharing options...
Slice Posted August 16, 2020 Share Posted August 16, 2020 12 minutes ago, Jief_Machak said: I've just committed few correction (length() test before char access). Could you try while I'm looking your log ? Same result debug.log.zip 1 minute ago, Jief_Machak said: PatchACPI() is done before USB fixownership, right ? So the patching of ACPI went ok ? Looks like usb ownership fix is the last thing done in "OnExitBootServices()". Is not normal that the log stop here ? When you get that log, you got the panic i > length(), or just crash ? No, the stop at the PatchACPI before OnExitBootServices. Before call to boot.efi. It is not panic or crash. It is CPU halt. See debug.log consists of two logs. First one is bad and the second with old Clover and it is successful. I shown you a place in the log when first one ended and second one began. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734401 Share on other sites More sharing options...
Jief_Machak Posted August 16, 2020 Share Posted August 16, 2020 I search for "Legacy USB Off Done" (almost last line of your log), which only appears in "EFI_STATUS FixOwnership(VOID)", which is only called at the end of "OnExitBootServices()". What did I miss ? 4 minutes ago, Slice said: It is not panic You don't have the panic message "i > length()" anymore ? Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734402 Share on other sites More sharing options...
Slice Posted August 16, 2020 Share Posted August 16, 2020 8 minutes ago, Jief_Machak said: I search for "Legacy USB Off Done" (almost last line of your log), which only appears in "EFI_STATUS FixOwnership(VOID)", which is only called at the end of "OnExitBootServices()". What did I miss ? You don't have the panic message "i > length()" anymore ? Yes, last line is here. It is line #1143. But look at the line #436 where old log finished and new log began. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734403 Share on other sites More sharing options...
Jief_Machak Posted August 16, 2020 Share Posted August 16, 2020 Oh, ok. I didn't get there was 2 boot in there. Ok, I'll look. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734404 Share on other sites More sharing options...
Slice Posted August 16, 2020 Share Posted August 16, 2020 I may propose that RenameDevices() finished successfully and crash at FixRegions() as we see no message from it like in second log. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734406 Share on other sites More sharing options...
Jief_Machak Posted August 16, 2020 Share Posted August 16, 2020 I'm looking at CmpAdr. I may have messed up with CmpAdr trying to make compatible with XString AND char* at the same time with template. At least, there is a length() test missing. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734407 Share on other sites More sharing options...
Slice Posted August 16, 2020 Share Posted August 16, 2020 I localized a problem: if I switched off FixAirport then I booted successfully. But new observation, I am booted into another computer with another desktop picture. Why? Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734408 Share on other sites More sharing options...
Jief_Machak Posted August 16, 2020 Share Posted August 16, 2020 (edited) Yes, make sense as FixAirport is calling the XString version of CmpDev. Do you have a AirportBridgeDeviceName in your config.plist that is not 4 chars long ? It it's 4 chars long, maybe I created a bug when reading the property. Well, I realize AirportBridgeDeviceName could be empty. That's the problem. Adding a test and commit in 20 sec. Edited August 16, 2020 by Jief_Machak Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734415 Share on other sites More sharing options...
Jief_Machak Posted August 16, 2020 Share Posted August 16, 2020 FIXAirport is now fixed, I think. Working smbios now. There is some difference with Clover before my modification. 1 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734417 Share on other sites More sharing options...
SavageAUS Posted August 16, 2020 Share Posted August 16, 2020 Good to see Clover getting some much needed love and attention. Can’t wait for it to be able to boot and install Big Sur. 8 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734423 Share on other sites More sharing options...
Jief_Machak Posted August 16, 2020 Share Posted August 16, 2020 2 hours ago, Jief_Machak said: Working smbios now. There is some difference with Clover before my modification. soon, very soon. A bug made smUUID not read. Problem also with release date. Almost all corrected now. 2 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734433 Share on other sites More sharing options...
Jief_Machak Posted August 16, 2020 Share Posted August 16, 2020 44 minutes ago, Jief_Machak said: Working smbios now You are absolutely right. I'm sorry. Should have said "Working on smbios now". 2 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734435 Share on other sites More sharing options...
Jief_Machak Posted August 16, 2020 Share Posted August 16, 2020 Ok. Committed. I've checked with a Clover from before I made all this refactoring and I have the exact same dmidecode output. So I think it's ok. 3 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734436 Share on other sites More sharing options...
Matgen84 Posted August 16, 2020 Share Posted August 16, 2020 35 minutes ago, Jief_Machak said: Ok. Committed. I've checked with a Clover from before I made all this refactoring and I have the exact same dmidecode output. So I think it's ok. It works fine (build latest commit): I can boot Catalina perfectly SMBIOS Imac19,1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734440 Share on other sites More sharing options...
Slice Posted August 16, 2020 Share Posted August 16, 2020 7 hours ago, Jief_Machak said: FIXAirport is now fixed, I think. Confirm success. But there is a new bug now. See, what is happen with the graphics card name??? Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734449 Share on other sites More sharing options...
Jief_Machak Posted August 16, 2020 Share Posted August 16, 2020 I think I happened to the graphic card name I'll have a look soon. I'll also check that the DSDT is still patched exactly the same as before (I use commit d42ba2602764206341e8f0b7ea5a2eccb443c1b5 as a reference). Please confirm that when I start macIASL (should I use the rehabman version ?), macIASL download the patched DSDT currently used by the computer. If I've understood well, I can save the DSDT, once with the latest Clover, once with Clover@d42ba2602764206341e8f0b7ea5a2eccb443c1b5. and just text compare the result. They should strictly identical, right ? Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734469 Share on other sites More sharing options...
iCanaro Posted August 16, 2020 Share Posted August 16, 2020 the properties section does not load correctly and there are several strange names 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734476 Share on other sites More sharing options...
Slice Posted August 17, 2020 Share Posted August 17, 2020 11 hours ago, Slice said: Confirm success. But there is a new bug now. See, what is happen with the graphics card name??? . 5 hours ago, iCanaro said: the properties section does not load correctly and there are several strange names Again AsciiSPrint() != snprintf() Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734494 Share on other sites More sharing options...
Jief_Machak Posted August 17, 2020 Share Posted August 17, 2020 4 hours ago, Slice said: . Again AsciiSPrint() != snprintf() I know. And I didn't replaced any. They were already replaced quite some time ago. Please confirm that when I start macIASL (should I use the rehabman version ?), macIASL download the patched DSDT currently used by the computer. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734502 Share on other sites More sharing options...
blackosx Posted August 17, 2020 Share Posted August 17, 2020 I would suggest the version from acidanthera https://github.com/acidanthera/MaciASL/releases 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/897/#findComment-2734512 Share on other sites More sharing options...
Recommended Posts