Clover General discussion

[chris1111]

2 hours ago, apianti said:

 

Because you need those entries to boot installers for PC but for some reason they were removed. They should be hidden by default, are they not? If so, I apparently messed up the code.

Same here after 4453

 

Post Edit***

 

Edited May 8, 2018 by chris1111

[apianti]

4 hours ago, Cyberdevs said:

Hi apianti,

 

I hope you get better with the new trial. You have nothing to be sorry about, we all understand the situation that you are in. You already gave so much to us and the hackintosh community and I'm personally thankful. I've learned a lot from you.

 

I hope that the new trial works out and you come back to us in good health.

 

Cheers!

 

(Sorry guys fo the off-topic comment I just needed to say this)

 

I wanted to have something working way before now though. I'm just hard on myself, hold myself to high standards and I just haven't been meeting them like I want. Also, I just found out that I'm not a candidate for the trial currently so I am unsure what is going to happen, my life is slowly spiraling out of control....  Thanks for your support though, and I'm going to try to continue to give until I'm physically or mentally unable to do so.

 

3 hours ago, chris1111 said:

Same here after 4453

 

Hmmm.... Ok, let me look at why it's not being hidden.

 

EDIT: Ok, I just realized that I didn't add the check to make sure they were hidden, lol. Revision 4456 4457 should now work correctly.

EDIT2: Stupidly copypasta'd and didn't fix, so 4456 does not build.... 4457 should be good.

Edited May 8, 2018 by apianti

[mrjayviper]

so I am using Clover Configurator to edit my config.plist

 

and one of the built-in selection is to change EHC1 to EH01. I selected this. and it is not disabled.

 

I rebooted the machine and loaded the system DSDT using maciASL and it's still EHC1. Is there something I'm doing wrong?

 

I am looking at the config.plist using nano and I can see this:

 

<key>Find</key>

<data>RuhDMQ==</data>

<key>Replace</key>

<data>RUgwMQ==</data>

 

thanks

 

ps. Maybe this will only work if I am supplying my own DSDT.aml. there's nothing in ACPI/patched at the moment.

[bronxteck]

why would it change a table if it is a dynamic patch? it is not a physical patch like what you are expecting. if you want clover to apply physical  patches to your DSDT then there is an option to dump your ACPI files after clover has applied your patch selections. hit F1 at clover for more info.

[apianti]

6 hours ago, mrjayviper said:

so I am using Clover Configurator to edit my config.plist

 

and one of the built-in selection is to change EHC1 to EH01. I selected this. and it is not disabled.

 

I rebooted the machine and loaded the system DSDT using maciASL and it's still EHC1. Is there something I'm doing wrong?

 

I am looking at the config.plist using nano and I can see this:

 

<key>Find</key>

<data>RuhDMQ==</data>

<key>Replace</key>

<data>RUgwMQ==</data>

 

thanks

 

ps. Maybe this will only work if I am supplying my own DSDT.aml. there's nothing in ACPI/patched at the moment.

 

Did you put the patch in the correct place? Also is there not an automatic fix for this in DSDT fixes?

 

3 hours ago, bronxteck said:

why would it change a table if it is a dynamic patch? it is not a physical patch like what you are expecting. if you want clover to apply physical  patches to your DSDT then there is an option to dump your ACPI files after clover has applied your patch selections. hit F1 at clover for more info.

 

He is talking about ACPI table patching, there is such a feature. But you can also patch them yourself, drop,  and inject them as well.

[mrjayviper]

As I said in my original post, I am not using my own DSDT.aml at the moment. Perhaps it is required to have a DSDT.aml inside /ACPI/patched?

[LockDown]

No. Acpi>dsdt>patches works even w/o dsdt.aml

[bronxteck]

api you must have miss interpreted his post

his quote "I rebooted the machine and loaded the system DSDT using maciASL and it's still EHC1"

he loaded his dsdt in maciasl. that means he expected the dynamic patch to be already configured in his dsdt. hence what I posted. I know your a jokester but please dont confuse the guy as he is looking for proper advice. not that you advice is not merited but it is not exactly the answer to his question at that moment.

Edited May 10, 2018 by bronxteck

[LockDown]

Only the acpi>dsdt>fixes gets merged in dsdt.aml if you gererate it in maciasl after booting. Not Patches last time i tried.

[LockDown]

If i have ssdt.aml, should i enable dropoem in config?

Edited May 10, 2018 by ellaosx

[apianti]

22 hours ago, mrjayviper said:

As I said in my original post, I am not using my own DSDT.aml at the moment. Perhaps it is required to have a DSDT.aml inside /ACPI/patched?

 

Yeah. I was referring to ACPI table patching on the fly, without re-injection.

 

20 hours ago, bronxteck said:

api you must have miss interpreted his post

his quote "I rebooted the machine and loaded the system DSDT using maciASL and it's still EHC1"

he loaded his dsdt in maciasl. that means he expected the dynamic patch to be already configured in his dsdt. hence what I posted. I know your a jokester but please dont confuse the guy as he is looking for proper advice. not that you advice is not merited but it is not exactly the answer to his question at that moment.

 

I was actually giving him the correct advice.  Clover has an on the fly ACPI patcher and an ACPI injector. He was talking about the patcher, not the injector.

 

20 hours ago, ellaosx said:

Only the acpi>dsdt>fixes gets merged in dsdt.aml if you gererate it in maciasl after booting. Not Patches last time i tried.

 

You are directly patching the tables if you use on the fly, and  all three methods should provide a correct XSDT/RSDT ACPI implementation for Apple.

 

7 hours ago, ellaosx said:

If i have ssdt.aml, should i enable dropoem in config?

 

Drop the specific tables you are patching, unless thats all off them, then dropoem as it drops all SSDTs, which you probably don't want.

[mrjayviper]

On 5/10/2018 at 7:22 AM, apianti said:

Did you put the patch in the correct place? Also is there not an automatic fix for this in DSDT fixes?

 

 

Can you please explain? From what I can see clover configurator put the patches inside config.plist. Am I doing it wrong?

 

Thanks

[bronxteck]

well it depends on what your expecting. all 3 methods work the same. you can manually edit the DSDT you can also just use clover ACPI config patching and you can also use clover config find replace method.  It is not mandatory to manually patch a DSDT anymore. it can mostly be done from clover config.

[apianti]

4 hours ago, mrjayviper said:

 

Can you please explain? From what I can see clover configurator put the patches inside config.plist. Am I doing it wrong?

 

Thanks

 

I'm asking you what you did. You didn't say if you were using clover configurator (which is a third party tool) or just editing the config.plist. Are the patches in the ACPI/DSDT/Patches section? I don't know if KernelAndKextPatches/Debug=true will give you anymore information about the DSDT patching. But you need to dump your tables from inside macOS to determine what the outcome is. You'll probably want to google how to dump/extract your tables in macOS.

[mrjayviper]

15 minutes ago, apianti said:

 

I'm asking you what you did. You didn't say if you were using clover configurator (which is a third party tool) or just editing the config.plist. Are the patches in the ACPI/DSDT/Patches section? I don't know if KernelAndKextPatches/Debug=true will give you anymore information about the DSDT patching. But you need to dump your tables from inside macOS to determine what the outcome is. You'll probably want to google how to dump/extract your tables in macOS.

 

I am using clover configuration which is clearly mentioned in my original post (1st statement). I also mentioned that Clover configurator has added this when I selected "change EHC1 to EH01" (I've attached a screenshot of the patch as shown in Clover configurator)

 

-----

<key>Find</key>

<data>RuhDMQ==</data>

<key>Replace</key>

<data>RUgwMQ==</data>

--------

There are no patches in ACPI/DSDT/Patches. From what I can see, Clover configurator added the patch inside config.plist. 

 

I know how to dump DSDT. In the past I've used a Linux USB installer to do this job.

 

Thanks a lot!

 

[apianti]

2 minutes ago, mrjayviper said:

 

I am using clover configuration which is clearly mentioned in my original post (1st statement). I also mentioned that Clover configurator has added this when I selected "change EHC1 to EH01" (I've attached a screenshot of the patch as shown in Clover configurator)

 

-----

<key>Find</key>

<data>RuhDMQ==</data>

<key>Replace</key>

<data>RUgwMQ==</data>

--------

There are no patches in ACPI/DSDT/Patches. From what I can see, Clover configurator added the patch inside config.plist. 

 

I know how to dump DSDT. In the past I've used a Linux USB installer to do this job.

 

Thanks a lot!

 

I don't care about clover configurator, if there's a problem with that then you'll have to go to the developer of that, that's not part of clover. I want to know what the config.plist has in it and you keep only posting the patch but it needs to be in ACPI/DSDT/Patches (which is the key path inside of config.plist). So what does your actual config.plist contain and you need to dump the tables IN macOS, not another OS or clover, otherwise they are not patched and you have no idea whether or not the patch worked. Did you turn on KernelAndKextPatches/Debug=true as I said to see if it gives you more information? I can't do it for you, I can only point you in a direction of what may be the issue and how to fix that.

[bronxteck]

you can press F4 at clover prompt if you want clover to dump your ACPI tables. or press F1 to see all other clover options like dumping the DSDT already patched i think thats the F5 option. both would reside in the origin folder. the patched folder is used after you manually add a patched ACPI table to it.

  what clover configurator did is fine if "change EHC1 to EH01" is what you want.

it does the same as manually making the change in DSDT if that is what you are concerned with. 

Edited May 11, 2018 by bronxteck

[mrjayviper]

7 hours ago, bronxteck said:

 

  what clover configurator did is fine if "change EHC1 to EH01" is what you want.

it does the same as manually making the change in DSDT if that is what you are concerned with. 

 

What I'm saying is that when my setup booted with that patch, I loaded system DSDT in MaciASL and I can still see EHC1. It hasn't chance EHC1 to EH01.

 

So I'm wondering if I'm doing it wrong. I've attached my cofig.plist.

 

Thanks a lot!

-------------------------------------------

According to this clover wiki (https://clover-wiki.zetam.org/Configuration/ACPI#DSDT-/-Patches - maybe unofficial), patches can be done inside config.plist?

config.plist.zip

[apianti]

11 hours ago, mrjayviper said:

 

What I'm saying is that when my setup booted with that patch, I loaded system DSDT in MaciASL and I can still see EHC1. It hasn't chance EHC1 to EH01.

 

So I'm wondering if I'm doing it wrong. I've attached my cofig.plist.

 

Thanks a lot!

-------------------------------------------

According to this clover wiki (https://clover-wiki.zetam.org/Configuration/ACPI#DSDT-/-Patches - maybe unofficial), patches can be done inside config.plist?

 

That is the official wiki but it is outdated and uneditable. Try a different method to extract the tables from inside macOS. I see no reason why it would not be working.

[vector sigma]

I wonder if is the same config.plist edited/loaded 

12 hours ago, mrjayviper said:

So I'm wondering if I'm doing it wrong

 

[D-an-W]

Does anyone use the kozlek HWMonitor and noticed it not fully working with the last few Clover releases (I usually get temps, speeds etc shown)? 

 

I just wondered if it is at all possible something has changed that might cause this?

Edited May 16, 2018 by D-an-W

[Slice]

2 hours ago, D-an-W said:

Does anyone use the kozlek HWMonitor and noticed it not fully working with the last few Clover releases (I usually get temps, speeds etc shown)? 

 

I just wondered if it is at all possible something has changed that might cause this?

No relation.

[D-an-W]

Cheers Slice, all sorted now I knew where to look (Or where not to!).

[RehabMan]

On 5/10/2018 at 4:06 PM, apianti said:

Drop the specific tables you are patching, unless thats all off them, then dropoem as it drops all SSDTs, which you probably don't want.

 

Dangerous advice there...

 

Using the drop/add method causes SSDTs to be re-ordered.

And SSDTs can be order dependent.

 

Better to set config.plist/ACPI/AutoMerge=true, then name SSDTs in ACPI/patched with the same name they had from ACPI/origin.  The AutoMerge feature will take care of replacing the SSDT in its original index, preserving the original order.

[HmO]

Clover 4496

Edited May 23, 2018 by Ukr55