chris1111 Posted February 5, 2018 Share Posted February 5, 2018 there is a small problem with the revision Clover r4399 it does not mount the EFI partition of a disk image of this format hdiutil create -size 5g -type SPARSE -fs HFS+J -volname Mac_OS_Installer -uid 0 -gid 80 -mode 1775 ~/Desktop/Mac-Image before 4399 it was not a problem Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585209 Share on other sites More sharing options...
vector sigma Posted February 5, 2018 Share Posted February 5, 2018 @chris1111 cool, tested: but here works good. Anyway we can make it also APFS? Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585252 Share on other sites More sharing options...
chris1111 Posted February 5, 2018 Share Posted February 5, 2018 @chris1111 cool, tested: tested.png but here works good. Anyway we can make it also APFS? Not working here 10.13.3 not test 10.13.4 Beta 1 Yes APFS hdiutil create -size 5g -type SPARSE -fs apfs -volname Mac_OS_Installer -uid 0 -gid 80 -mode 1775 ~/Desktop/Mac-Image Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585258 Share on other sites More sharing options...
vector sigma Posted February 5, 2018 Share Posted February 5, 2018 10.13.4 b1 here. Just updated Clover on the real esp disk. rebooted all normal Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585261 Share on other sites More sharing options...
chris1111 Posted February 5, 2018 Share Posted February 5, 2018 10.13.4 b1 here. Just updated Clover on the real esp disk. rebooted all normal Ok that's what I thought because here on 10.13.3 it does not work 4399 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585267 Share on other sites More sharing options...
vector sigma Posted February 5, 2018 Share Posted February 5, 2018 I have it on another hack, wait 2 minutes.. EDIT works here on 10.13.3, clover updated with the same package, I'm on it. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585270 Share on other sites More sharing options...
chris1111 Posted February 5, 2018 Share Posted February 5, 2018 I have it on another hack, wait 2 minutes.. EDIT works here on 10.13.3, clover updated with the same package, I'm on it. Test in 10.13.4 yes working Strange here not work in 10.13.3 don't know why ? Edit *** this kind of disk image converted with hdiutil create -size 5g -type SPARSE -fs HFS+J -volname Mac_OS_Installer -uid 0 -gid 80 -mode 1775 ~/Desktop/Mac-Image hdiutil convert ~/Desktop/Mac-Image.sparseimage -format UDTO -o ~/Desktop/Mac-Image.cdr mv ~/Desktop/mac-image.cdr ~/Desktop/macOS-High-Sierra.dmg this is a useful image for Restore with dd command making already bootable USB or Disk Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585284 Share on other sites More sharing options...
tluck Posted February 5, 2018 Share Posted February 5, 2018 MountESP seems broken for 10.13.4 beta1 - doesn't know how to mount the ESP (on an APFS)? Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585287 Share on other sites More sharing options...
Kynyo Posted February 5, 2018 Share Posted February 5, 2018 diskutil list diskutil mound diskXsX diskutil unmound diskXsX. (X) is your EFI partition Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585339 Share on other sites More sharing options...
llamafilm Posted February 5, 2018 Share Posted February 5, 2018 I have noticed that in recent versions of Clover, the Kext patches can be specified with full name, like com.apple.iokit.IOAHCIBlockStorage instead of just IOAHCIBlockStorage. What is the benefit to this? I suppose it's possible to have two different kexts with the same short name, but that seems unlikely to me. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585342 Share on other sites More sharing options...
PMheart Posted February 5, 2018 Share Posted February 5, 2018 I have noticed that in recent versions of Clover, the Kext patches can be specified with full name, like com.apple.iokit.IOAHCIBlockStorage instead of just IOAHCIBlockStorage. What is the benefit to this? I suppose it's possible to have two different kexts with the same short name, but that seems unlikely to me. When specifying a *rough* name, for instance, IOAHCIBlockStorage, Clover will also search for its dependencies and try to patch. (This should not be what you want, you are just willing to patch the kext itself, additionally in most cases there is no such occurrence in those dependent kexts, and you don't want to patch it/them either, furthermore, it's a waste of time, though, you can hardly ever feel it) 2 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585401 Share on other sites More sharing options...
llamafilm Posted February 5, 2018 Share Posted February 5, 2018 Thanks for that explanation, PMheart. So would you recommend updating all my older patches to include the full name, for a minuscule boot speed improvement? Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585405 Share on other sites More sharing options...
RehabMan Posted February 5, 2018 Share Posted February 5, 2018 When specifying a *rough* name, for instance, IOAHCIBlockStorage, Clover will also search for its dependencies and try to patch. No. Current Clover behavior: - look for a match within *only* the bundle-id if there are no '.' characters in the specified Name (eg. it is a strstr search). The old behavior (forget the specific version of Clover for this change) was that the entire Info.plist was searched. - look for an exact bundle-id match if there are '.' characters in the specified Name (eg. it is a strcmp comparison) 2 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585413 Share on other sites More sharing options...
PMheart Posted February 6, 2018 Share Posted February 6, 2018 No. Current Clover behavior: - look for a match within *only* the bundle-id if there are no '.' characters in the specified Name (eg. it is a strstr search). The old behavior (forget the specific version of Clover for this change) was that the entire Info.plist was searched. - look for an exact bundle-id match if there are '.' characters in the specified Name (eg. it is a strcmp comparison) Thanks for the clarification. Oh yes, remembered that there was a discussion on this probably in late 2016, perhaps since then the behavior has been changed. Thanks for that explanation, PMheart. So would you recommend updating all my older patches to include the full name, for a minuscule boot speed improvement? Sorry, I was wrong! (You can see @RehabMan's clarification above.) According to his sayings, you don't have to do it. Just keep your "dirty-but-effective" patch. By the way, you may remove some duplicated patches. (e.g. The ones applied to AppleUSBXHCIPCI) Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585452 Share on other sites More sharing options...
RehabMan Posted February 6, 2018 Share Posted February 6, 2018 there was a discussion on this probably in late 2016, perhaps since then the behavior has been changed. Yes, definitely new behavior since then. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585473 Share on other sites More sharing options...
chris1111 Posted February 6, 2018 Share Posted February 6, 2018 bad news the package does not work in Snow Leopard and Lion for UEFI and ESP 4399 and 4400 It installs the EFI folder on the root Disk instead of mounting the EFI partition 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585492 Share on other sites More sharing options...
bronxteck Posted February 6, 2018 Share Posted February 6, 2018 yeah thats the same issue I was having before I had to select and install clover to my first osx partition for it to install clover to EFI volume http://www.insanelymac.com/forum/topic/284656-clover-general-discussion/?p=2580721 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585504 Share on other sites More sharing options...
Smallersen Posted February 6, 2018 Share Posted February 6, 2018 Also on 10.13.3: Clover 4400 ends with installation error. Install Clover in the ESP does no longer work in 4400. Never had this issue before. Just possible to install EFI folder on the system partition. Updating EFI on EFI partition by hand is kind of risky. 4398 still worked. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585561 Share on other sites More sharing options...
Zenith432 Posted February 6, 2018 Share Posted February 6, 2018 So would you recommend updating all my older patches to include the full name, for a minuscule boot speed improvement?It's not about speed improvement. It's because some bundle ids are substrings of other bundle ids. This was discovered on AppleIntelKBLGraphics AppleIntelKBLGraphicsFramebuffer So if you want to patch AppleIntelKBLGraphics and use partial name, your patch is also applied to AppleIntelKBLGraphicsFramebuffer and puts you at risk of a spurious incorrect patch (this actually happened). If bundle-id is not a substring of another bundle-id - you can continue to use partial name. If it's a substring of another bundle-id use full bundle name for exact match. 4 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585789 Share on other sites More sharing options...
RehabMan Posted February 6, 2018 Share Posted February 6, 2018 It's not about speed improvement. It's because some bundle ids are substrings of other bundle ids. This was discovered on AppleIntelKBLGraphics AppleIntelKBLGraphicsFramebuffer So if you want to patch AppleIntelKBLGraphics and use partial name, your patch is also applied to AppleIntelKBLGraphicsFramebuffer and puts you at risk of a spurious incorrect patch (this actually happened). If bundle-id is not a substring of another bundle-id - you can continue to use partial name. If it's a substring of another bundle-id use full bundle name for exact match. Bottom line: it is safer (therefore, recommended) to use the complete bundle-id for Name specifications in KextsToPatch. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585810 Share on other sites More sharing options...
mhaeuser Posted February 6, 2018 Share Posted February 6, 2018 Bottom line: it is safer (therefore, recommended) to use the complete bundle-id for Name specifications in KextsToPatch.Why is StrStr used rather than StrCmp? Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585816 Share on other sites More sharing options...
apianti Posted February 6, 2018 Share Posted February 6, 2018 Why is StrStr used rather than StrCmp? For partial matches....? Why is it not StriStr or StriCmp? Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585819 Share on other sites More sharing options...
mhaeuser Posted February 6, 2018 Share Posted February 6, 2018 For partial matches....? Why is it not StriStr or StriCmp?I know what the functions do, I asked for the choice... Why support partial matches? Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585821 Share on other sites More sharing options...
apianti Posted February 6, 2018 Share Posted February 6, 2018 I know what the functions do, I asked for the choice... Why support partial matches? That was my point, I don't know. Why would it partially match exact case? No clue, I didn't write it.... I guess to make it easier, but I think it should be StriCmp, to match the full string case insensitive. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585824 Share on other sites More sharing options...
RehabMan Posted February 6, 2018 Share Posted February 6, 2018 Why is StrStr used rather than StrCmp? StrStr is used if the Name specified does not have any '.' characters. I would bet that was done to enhance backward compatibility. For partial matches....? Why is it not StriStr or StriCmp? Typically, we accept case sensitivity. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/656/#findComment-2585831 Share on other sites More sharing options...
Recommended Posts