Jump to content

Clover General discussion

ErmaC

By ErmaC,
in Clover

 Share
30960 posts in this topic

Recommended Posts

arsradu
arsradu
Posted
Posted

@arsradu - have you tried darkwake=0 boot arg? 

 

Well, that's the thing. I never used darkwake=0. Never messed with that. Still, I never got this issue before. So I doubt it's because of that.

 

I think the problem might be relying somewhere else. I disabled AppleRTC by mistake (in Kernel & Kexts patches). Though I honestly don't remember doing that.

 

So, right now I'm testing this with AppleRTC=enabled as well as default "sleep proxy client" settings (which I think is enabled, if I'm not mistaken). So far, I've noticed it's not just that it doesn't wake from sleep after an hour anymore, but also, when I decide to wake the computer from sleep (it's been about 15 minutes over an hour now), it wakes up a lot faster than with the disabled proxy client.

 

Will keep you guys posted if this issue reoccurs with the current setup.

 

As always, thank you very much for your feedback. :)

liujianwei
liujianwei
Posted
Posted

@cuthead thats known issues for some ppl.. Look here #1 / #2

 

I need to patch this line to refresh the screen after changing screen mode, do you think so Slice?

case SCAN_F9:
  SetNextScreenMode(1);
  MenuExit = MENU_EXIT_ESCAPE;
  break;

And something dangerous is coming, soon?

 

 

This could be not related to AppleTyMCEDriver. It seemed that AppleTyMCEDriver just caused KP on non-ECC memory. For further discussion, we may discuss at installation section?  :)

 

PMheart

FixDisplay

Slice
Slice
Posted
Posted

hello Slice good morning

 

clover rev 3977

 

long delay before boot .. reach gui normal .. then before start boot in verbose .. have a long delay

 

attachicon.gifboot.log.zip

 

thanks

Hello artur_pt,

Thanks you for the log but I see no problem here and I still can't reproduce the issue. All is fine in my case.

Philip Petev
Philip Petev
Posted
Posted

Many people have the same or similar problem, @Slice, including me. All Clover versions above 3974 I've tested fail to go beyond the GUI. Tested several Clover/edk2 combinations and every time I get this result. That happens on both my desktop (GB H77N-WiFi, AMI aptio) and my laptop (HP ProBook 4340s, HPQ EFI).

Here's the funny part: all the mentioned Clover versions work, compiled with older revision of edk2 (r23693 is the one I've tested).

Just like the case with @artur_pt, you won't find anything unusual in preboot.log.

Good thing I have Windows 10, installed in another partition, to restore the previous Clover version in such case.

 

Edit: attached my log (taken with r3977) and my usual Clover folder (r3974)

 

Edit2: just compared the two logs (taken with r3974/edk2 r23520 and r3977/edk2 r23704), besides the timestamps at the beginning of every line, they are almost identical.

Also, someone at AppleLife proposed the theory that the issue could be storage-related, no, it's not, because I have HDD on my desktop and SSD on my laptop and the same issue on both of them.

preboot.log.zip

CLOVER.zip

  • Like 1
Philip Petev
Philip Petev
Posted
Posted

Confirm, please, that Clover compiled with EDK2-23700 is good, with 23702 is bad.

 

Just tested with my ProBook. It doesn't boot with anything above r23702 including. r23700 and r23701 seem to be OK (the older versions too). That's for UEFI boot, haven't tested the legacy boot (don't even use it anymore). Also haven't tested those versions on my desktop, will do that later today (currently at work).

Commits 23700 - 23703 incl. contain changes to the following files:

 

/trunk/edk2/MdePkg/Include/Library/BaseLib.h

/trunk/edk2/MdePkg/Library/BaseLib/SafeString.c

/trunk/edk2/MdePkg/Library/BaseLib/BaseLibInternals.h

/trunk/edk2/MdePkg/Library/BaseLib/String.c

 

and obviously something has happened between commits r23701 and r23702.

 

Edit: Just tested the same builds on my desktop. Same scenario: works with all edk2 builds prior to r23702 and doesn't work with r23702 and higher.

 

 

Tested, Clover r3977 w/ edk2 r23704 works fine on UEFI boot. Not confirmed r23700/r23702...

 

 

Tested that too yesterday, but it doesn't work for me.

PMheart
PMheart
Posted
Posted

Just tested with my ProBook. It doesn't boot with anything above r23702 including. r23700 and r23701 seem to be OK. That's for UEFI boot, haven't tested the legacy boot (don't even use it anymore). Also haven't tested those versions on my desktop, will do that later today (currently at work).

Commits 23700 - 23703 incl. contain changes to the following files:

 

/trunk/edk2/MdePkg/Include/Library/BaseLib.h

/trunk/edk2/MdePkg/Library/BaseLib/SafeString.c

/trunk/edk2/MdePkg/Library/BaseLib/BaseLibInternals.h

/trunk/edk2/MdePkg/Library/BaseLib/String.c

 

and obviously something has happened between commits r23701 and r23702.

 

 

Tested that too yesterday, but it doesn't work for me.

Weird. I got a update of Micky's Build_Clover.command and he updated edk2 version to r23704. 23704 just works fine on my desktop... And seems nothing obvious changes with r23520.

  • Like 1
tluck
tluck
Posted
Posted

confirming issue with later versions of edk2

UEFI with EmuVariable on my ThinkPad T460

Clover 3977 + edk2 23700 or earlier -  OK - no delay on start up

Clover 3977 + edk2 23702 or later   - Broke - long delay (20-40 seconds)

Philip Petev
Philip Petev
Posted
Posted

UEFI with EmuVariable on my ThinkPad T460

 

Just a side note: the issue doesn't appear to be EFI driver-related. Tried to use one and the same EFI drivers (incl. this one) with all Clover build, mentioned by me in my previous post. Tested the different Clover builds, using the EFI drivers from r3974 and r3977 (though I suspect they are identical, haven't checked their checksums to be sure of that). The issue appears to be pure bootx64.efi (Clover) - related.

dgsga
dgsga
Posted
Posted

@Slice, I can confirm that Clover 3977 compiled with EDK 23701 works fine on my rig, any revision of EDK above this fails to boot, just stuck at the aptiofix initialisation line. Diff between 23701 and 23702 is as follows, I hope it helps:

--- a/trunk/edk2/MdePkg/Library/BaseLib/String.c
+++ b/trunk/edk2/MdePkg/Library/BaseLib/String.c
@@ -1,7 +1,7 @@
 /** @file
   Unicode and ASCII string primitives.
 
-  Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
   which accompanies this distribution.  The full text of the license may be found at
@@ -638,7 +638,7 @@
   If String has no pad spaces or valid decimal digits,
   then 0 is returned.
   If the number represented by String overflows according
-  to the range defined by UINTN, then ASSERT().
+  to the range defined by UINTN, then MAX_UINTN is returned.
 
   If PcdMaximumUnicodeStringLength is not zero, and String contains
   more than PcdMaximumUnicodeStringLength Unicode characters, not including
@@ -656,40 +656,8 @@
   )
 {
   UINTN     Result;
-  
-  //
-  // ASSERT String is less long than PcdMaximumUnicodeStringLength.
-  // Length tests are performed inside StrLen().
-  //
-  ASSERT (StrSize (String) != 0);
-
-  //
-  // Ignore the pad spaces (space or tab)
-  //
-  while ((*String == L' ') || (*String == L'\t')) {
-    String++;
-  }
-
-  //
-  // Ignore leading Zeros after the spaces
-  //
-  while (*String == L'0') {
-    String++;
-  }
-
-  Result = 0;
-
-  while (InternalIsDecimalDigitCharacter (*String)) {
-    //
-    // If the number represented by String overflows according 
-    // to the range defined by UINTN, then ASSERT().
-    //
-    ASSERT (Result <= ((((UINTN) ~0) - (*String - L'0')) / 10));
-
-    Result = Result * 10 + (*String - L'0');
-    String++;
-  }
-  
+
+  StrDecimalToUintnS (String, (CHAR16 **) NULL, &Result);
   return Result;
 }
 
@@ -717,7 +685,7 @@
   If String has no pad spaces or valid decimal digits,
   then 0 is returned.
   If the number represented by String overflows according
-  to the range defined by UINT64, then ASSERT().
+  to the range defined by UINT64, then MAX_UINT64 is returned.
 
   If PcdMaximumUnicodeStringLength is not zero, and String contains
   more than PcdMaximumUnicodeStringLength Unicode characters, not including
@@ -736,39 +704,7 @@
 {
   UINT64     Result;
   
-  //
-  // ASSERT String is less long than PcdMaximumUnicodeStringLength.
-  // Length tests are performed inside StrLen().
-  //
-  ASSERT (StrSize (String) != 0);
-
-  //
-  // Ignore the pad spaces (space or tab)
-  //
-  while ((*String == L' ') || (*String == L'\t')) {
-    String++;
-  }
-
-  //
-  // Ignore leading Zeros after the spaces
-  //
-  while (*String == L'0') {
-    String++;
-  }
-
-  Result = 0;
-
-  while (InternalIsDecimalDigitCharacter (*String)) {
-    //
-    // If the number represented by String overflows according 
-    // to the range defined by UINTN, then ASSERT().
-    //
-    ASSERT (Result <= DivU64x32 (((UINT64) ~0) - (*String - L'0') , 10));
-
-    Result = MultU64x32 (Result, 10) + (*String - L'0');
-    String++;
-  }
-  
+  StrDecimalToUint64S (String, (CHAR16 **) NULL, &Result);
   return Result;
 }
 
@@ -796,7 +732,7 @@
   If String has no leading pad spaces, leading zeros or valid hexadecimal digits,
   then zero is returned.
   If the number represented by String overflows according to the range defined by
-  UINTN, then ASSERT().
+  UINTN, then MAX_UINTN is returned.
 
   If PcdMaximumUnicodeStringLength is not zero, and String contains more than
   PcdMaximumUnicodeStringLength Unicode characters, not including the Null-terminator,
@@ -815,49 +751,7 @@
 {
   UINTN     Result;
 
-  //
-  // ASSERT String is less long than PcdMaximumUnicodeStringLength.
-  // Length tests are performed inside StrLen().
-  //
-  ASSERT (StrSize (String) != 0);
-  
-  //
-  // Ignore the pad spaces (space or tab) 
-  //
-  while ((*String == L' ') || (*String == L'\t')) {
-    String++;
-  }
-
-  //
-  // Ignore leading Zeros after the spaces
-  //
-  while (*String == L'0') {
-    String++;
-  }
-
-  if (InternalCharToUpper (*String) == L'X') {
-    if (*(String - 1) != L'0') {
-      return 0;
-    }
-    //
-    // Skip the 'X'
-    //
-    String++;
-  }
-
-  Result = 0;
-  
-  while (InternalIsHexaDecimalDigitCharacter (*String)) {
-    //
-    // If the Hex Number represented by String overflows according 
-    // to the range defined by UINTN, then ASSERT().
-    //
-    ASSERT (Result <= ((((UINTN) ~0) - InternalHexCharToUintn (*String)) >> 4));
-
-    Result = (Result << 4) + InternalHexCharToUintn (*String);
-    String++;
-  }
-
+  StrHexToUintnS (String, (CHAR16 **) NULL, &Result);
   return Result;
 }
 
@@ -886,7 +780,7 @@
   If String has no leading pad spaces, leading zeros or valid hexadecimal digits,
   then zero is returned.
   If the number represented by String overflows according to the range defined by
-  UINT64, then ASSERT().
+  UINT64, then MAX_UINT64 is returned.
 
   If PcdMaximumUnicodeStringLength is not zero, and String contains more than
   PcdMaximumUnicodeStringLength Unicode characters, not including the Null-terminator,
@@ -905,51 +799,7 @@
 {
   UINT64    Result;
 
-  //
-  // ASSERT String is less long than PcdMaximumUnicodeStringLength.
-  // Length tests are performed inside StrLen().
-  //
-  ASSERT (StrSize (String) != 0);
-  
-  //
-  // Ignore the pad spaces (space or tab) 
-  //
-  while ((*String == L' ') || (*String == L'\t')) {
-    String++;
-  }
-
-  //
-  // Ignore leading Zeros after the spaces
-  //
-  while (*String == L'0') {
-    String++;
-  }
-
-  if (InternalCharToUpper (*String) == L'X') {
-    ASSERT (*(String - 1) == L'0');
-    if (*(String - 1) != L'0') {
-      return 0;
-    }
-    //
-    // Skip the 'X'
-    //
-    String++;
-  }
-
-  Result = 0;
-  
-  while (InternalIsHexaDecimalDigitCharacter (*String)) {
-    //
-    // If the Hex Number represented by String overflows according 
-    // to the range defined by UINTN, then ASSERT().
-    //
-    ASSERT (Result <= RShiftU64 (((UINT64) ~0) - InternalHexCharToUintn (*String) , 4));
-
-    Result = LShiftU64 (Result, 4);
-    Result = Result + InternalHexCharToUintn (*String);
-    String++;
-  }
-
+  StrHexToUint64S (String, (CHAR16 **) NULL, &Result);
   return Result;
 }
 
@@ -1681,7 +1531,7 @@
   If String has only pad spaces, then 0 is returned.
   If String has no pad spaces or valid decimal digits, then 0 is returned.
   If the number represented by String overflows according to the range defined by
-  UINTN, then ASSERT().
+  UINTN, then MAX_UINTN is returned.
   If String is NULL, then ASSERT().
   If PcdMaximumAsciiStringLength is not zero, and String contains more than
   PcdMaximumAsciiStringLength ASCII characters not including the Null-terminator,
@@ -1700,38 +1550,7 @@
 {
   UINTN     Result;
   
-  //
-  // ASSERT Strings is less long than PcdMaximumAsciiStringLength
-  //
-  ASSERT (AsciiStrSize (String) != 0);
-
-  //
-  // Ignore the pad spaces (space or tab)
-  //
-  while ((*String == ' ') || (*String == '\t' )) {
-    String++;
-  }
-
-  //
-  // Ignore leading Zeros after the spaces
-  //
-  while (*String == '0') {
-    String++;
-  }
-
-  Result = 0;
-
-  while (InternalAsciiIsDecimalDigitCharacter (*String)) {
-    //
-    // If the number represented by String overflows according 
-    // to the range defined by UINTN, then ASSERT().
-    //
-    ASSERT (Result <= ((((UINTN) ~0) - (*String - L'0')) / 10));
-
-    Result = Result * 10 + (*String - '0');
-    String++;
-  }
-  
+  AsciiStrDecimalToUintnS (String, (CHAR8 **) NULL, &Result);
   return Result;
 }
 
@@ -1755,7 +1574,7 @@
   If String has only pad spaces, then 0 is returned.
   If String has no pad spaces or valid decimal digits, then 0 is returned.
   If the number represented by String overflows according to the range defined by
-  UINT64, then ASSERT().
+  UINT64, then MAX_UINT64 is returned.
   If String is NULL, then ASSERT().
   If PcdMaximumAsciiStringLength is not zero, and String contains more than
   PcdMaximumAsciiStringLength ASCII characters not including the Null-terminator,
@@ -1774,38 +1593,7 @@
 {
   UINT64     Result;
   
-  //
-  // ASSERT Strings is less long than PcdMaximumAsciiStringLength
-  //
-  ASSERT (AsciiStrSize (String) != 0);
-
-  //
-  // Ignore the pad spaces (space or tab)
-  //
-  while ((*String == ' ') || (*String == '\t' )) {
-    String++;
-  }
-
-  //
-  // Ignore leading Zeros after the spaces
-  //
-  while (*String == '0') {
-    String++;
-  }
-
-  Result = 0;
-
-  while (InternalAsciiIsDecimalDigitCharacter (*String)) {
-    //
-    // If the number represented by String overflows according 
-    // to the range defined by UINTN, then ASSERT().
-    //
-    ASSERT (Result <= DivU64x32 (((UINT64) ~0) - (*String - L'0') , 10));
-
-    Result = MultU64x32 (Result, 10) + (*String - '0');
-    String++;
-  }
-  
+  AsciiStrDecimalToUint64S (String, (CHAR8 **) NULL, &Result);
   return Result;
 }
 
@@ -1832,7 +1620,7 @@
   0 is returned.
 
   If the number represented by String overflows according to the range defined by UINTN,
-  then ASSERT().
+  then MAX_UINTN is returned.
   If String is NULL, then ASSERT().
   If PcdMaximumAsciiStringLength is not zero,
   and String contains more than PcdMaximumAsciiStringLength ASCII characters not including
@@ -1851,49 +1639,7 @@
 {
   UINTN     Result;
 
-  //
-  // ASSERT Strings is less long than PcdMaximumAsciiStringLength
-  //
-  ASSERT (AsciiStrSize (String) != 0);
-  
-  //
-  // Ignore the pad spaces (space or tab) 
-  //
-  while ((*String == ' ') || (*String == '\t' )) {
-    String++;
-  }
-
-  //
-  // Ignore leading Zeros after the spaces
-  //
-  while (*String == '0') {
-    String++;
-  }
-
-  if (InternalBaseLibAsciiToUpper (*String) == 'X') {
-    ASSERT (*(String - 1) == '0');
-    if (*(String - 1) != '0') {
-      return 0;
-    }
-    //
-    // Skip the 'X'
-    //
-    String++;
-  }
-
-  Result = 0;
-  
-  while (InternalAsciiIsHexaDecimalDigitCharacter (*String)) {
-    //
-    // If the Hex Number represented by String overflows according 
-    // to the range defined by UINTN, then ASSERT().
-    //
-    ASSERT (Result <= ((((UINTN) ~0) - InternalHexCharToUintn (*String)) >> 4));
-
-    Result = (Result << 4) + InternalAsciiHexCharToUintn (*String);
-    String++;
-  }
-
+  AsciiStrHexToUintnS (String, (CHAR8 **) NULL, &Result);
   return Result;
 }
 
@@ -1921,7 +1667,7 @@
   0 is returned.
 
   If the number represented by String overflows according to the range defined by UINT64,
-  then ASSERT().
+  then MAX_UINT64 is returned.
   If String is NULL, then ASSERT().
   If PcdMaximumAsciiStringLength is not zero,
   and String contains more than PcdMaximumAsciiStringLength ASCII characters not including
@@ -1940,53 +1686,7 @@
 {
   UINT64    Result;
 
-  //
-  // ASSERT Strings is less long than PcdMaximumAsciiStringLength
-  //
-  ASSERT (AsciiStrSize (String) != 0);
-  
-  //
-  // Ignore the pad spaces (space or tab) and leading Zeros
-  //
-  //
-  // Ignore the pad spaces (space or tab) 
-  //
-  while ((*String == ' ') || (*String == '\t' )) {
-    String++;
-  }
-
-  //
-  // Ignore leading Zeros after the spaces
-  //
-  while (*String == '0') {
-    String++;
-  }
-
-  if (InternalBaseLibAsciiToUpper (*String) == 'X') {
-    ASSERT (*(String - 1) == '0');
-    if (*(String - 1) != '0') {
-      return 0;
-    }
-    //
-    // Skip the 'X'
-    //
-    String++;
-  }
-
-  Result = 0;
-  
-  while (InternalAsciiIsHexaDecimalDigitCharacter (*String)) {
-    //
-    // If the Hex Number represented by String overflows according 
-    // to the range defined by UINTN, then ASSERT().
-    //
-    ASSERT (Result <= RShiftU64 (((UINT64) ~0) - InternalHexCharToUintn (*String) , 4));
-
-    Result = LShiftU64 (Result, 4);
-    Result = Result + InternalAsciiHexCharToUintn (*String);
-    String++;
-  }
-
+  AsciiStrHexToUint64S (String, (CHAR8 **) NULL, &Result);
   return Result;
 }

--- a/trunk/edk2/MdePkg/Include/Library/BaseLib.h
+++ b/trunk/edk2/MdePkg/Include/Library/BaseLib.h
@@ -1395,7 +1395,7 @@
   If String has no pad spaces or valid decimal digits,
   then 0 is returned.
   If the number represented by String overflows according
-  to the range defined by UINTN, then ASSERT().
+  to the range defined by UINTN, then MAX_UINTN is returned.
 
   If PcdMaximumUnicodeStringLength is not zero, and String contains
   more than PcdMaximumUnicodeStringLength Unicode characters not including
@@ -1435,7 +1435,7 @@
   If String has no pad spaces or valid decimal digits,
   then 0 is returned.
   If the number represented by String overflows according
-  to the range defined by UINT64, then ASSERT().
+  to the range defined by UINT64, then MAX_UINT64 is returned.
 
   If PcdMaximumUnicodeStringLength is not zero, and String contains
   more than PcdMaximumUnicodeStringLength Unicode characters not including
@@ -1477,7 +1477,7 @@
   If String has no leading pad spaces, leading zeros or valid hexadecimal digits,
   then zero is returned.
   If the number represented by String overflows according to the range defined by
-  UINTN, then ASSERT().
+  UINTN, then MAX_UINTN is returned.
 
   If PcdMaximumUnicodeStringLength is not zero, and String contains more than
   PcdMaximumUnicodeStringLength Unicode characters not including the Null-terminator,
@@ -1519,7 +1519,7 @@
   If String has no leading pad spaces, leading zeros or valid hexadecimal digits,
   then zero is returned.
   If the number represented by String overflows according to the range defined by
-  UINT64, then ASSERT().
+  UINT64, then MAX_UINT64 is returned.
 
   If PcdMaximumUnicodeStringLength is not zero, and String contains more than
   PcdMaximumUnicodeStringLength Unicode characters not including the Null-terminator,
@@ -1997,7 +1997,7 @@
   If String has only pad spaces, then 0 is returned.
   If String has no pad spaces or valid decimal digits, then 0 is returned.
   If the number represented by String overflows according to the range defined by
-  UINTN, then ASSERT().
+  UINTN, then MAX_UINTN is returned.
   If String is NULL, then ASSERT().
   If PcdMaximumAsciiStringLength is not zero, and String contains more than
   PcdMaximumAsciiStringLength ASCII characters not including the Null-terminator,
@@ -2034,7 +2034,7 @@
   If String has only pad spaces, then 0 is returned.
   If String has no pad spaces or valid decimal digits, then 0 is returned.
   If the number represented by String overflows according to the range defined by
-  UINT64, then ASSERT().
+  UINT64, then MAX_UINT64 is returned.
   If String is NULL, then ASSERT().
   If PcdMaximumAsciiStringLength is not zero, and String contains more than
   PcdMaximumAsciiStringLength ASCII characters not including the Null-terminator,
@@ -2075,7 +2075,7 @@
   0 is returned.
 
   If the number represented by String overflows according to the range defined by UINTN,
-  then ASSERT().
+  then MAX_UINTN is returned.
   If String is NULL, then ASSERT().
   If PcdMaximumAsciiStringLength is not zero,
   and String contains more than PcdMaximumAsciiStringLength ASCII characters not including
@@ -2116,7 +2116,7 @@
   0 is returned.
 
   If the number represented by String overflows according to the range defined by UINT64,
-  then ASSERT().
+  then MAX_UINT64 is returned.
   If String is NULL, then ASSERT().
   If PcdMaximumAsciiStringLength is not zero,
   and String contains more than PcdMaximumAsciiStringLength ASCII characters not including
  • Like 1
Micky1979
Micky1979
Posted
Posted (edited)

Weird. I got a update of Micky's Build_Clover.command and he updated edk2 version to r23704. 23704 just works fine on my desktop... And seems nothing obvious changes with r23520.

Starting from r23705 commits made regarding "ACPI Table Rev Options.. ". Later some fix on previous commits by them ( > 23705) . Later again other changes, but for me 23704 is ok.

23703 should be almost the same (refinement of debug messages in 23704). 23702, 23701, 23700 all the job is around "safe string" functions, Asserts etc.  May be ..culprit is around there...

Edited by Micky1979
  • Like 1
PMheart
PMheart
Posted
Posted

Starting from r23705 commits made regarding "ACPI Table Rev Options.. ". Later some fix on previous commits by them ( > 23705) . Later again other changes, but for me 23704 is ok.

23703 should be almost the same (refinement of debug messages in 23704). 23702, 23701, 23700 all the job is around "safe string" functions, Asserts etc.  May be ..culprit is around there...

Thanks for clarification. Typically I don't want to update edk2 unless necessary. TBH I don't care what's changed about edk2.  :P

  • Like 1
 Share
Go to topic listing
×
×
  • Create New...