FredWst Posted July 20, 2017 Share Posted July 20, 2017 @bronxteck so whats your temporary solution so far to allowed you too boot 10.13 with your current BGRT? - Manually edit BGRT header and place it into /Acpi/Patched - Or Drop BGRT table - Or by installing HackBGRT? ** Yes, dont let me dying alone Slice.. By watching apianti & DF conversations just gonna blow my brains out Drop and HackBGRT works both. Put a corrected BGRT in /Acpi/Patched does not work. Fred 1 Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2466167 Share on other sites More sharing options...
cecekpawon Posted July 20, 2017 Share Posted July 20, 2017 (edited) Test 4122 Kudos Slice, with your last commit it will scan whole length including empty string? With my aged eyes, I can see this table come with an empty "Oem Table ID", and evil chars in "Oem ID". Can I drink my coffee now, with peace? ** Edit: See below Edited July 20, 2017 by cecekpawon Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2466184 Share on other sites More sharing options...
FredWst Posted July 20, 2017 Share Posted July 20, 2017 Kudos Slice, with your last commit it will scan whole length including empty string? With my aged eyes, I can see this table come with an empty "Oem Table ID", and evil chars in "Oem ID". Can I drink my coffee now, with peace? Empty name doesn't matter I've some tables with empty name, HS boot. Fred 1 Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2466187 Share on other sites More sharing options...
Slice Posted July 20, 2017 Share Posted July 20, 2017 I don't know exactly. I see "AMI " success and "AMI" crash. Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2466274 Share on other sites More sharing options...
Philip Petev Posted July 20, 2017 Share Posted July 20, 2017 Another proposition, answering to this problem: CloverPackage/package/Scripts.templates/EFIFolder/postinstall The sample Clover config file config-sample.plist will be copied as config.plist only if config.plist doesn't exist or there are custom configs, present in the OEM folder (the script searches for custom configs in that folder and the sample SystemProductName folder is excluded from that search). postinstall.zip 4 Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2466335 Share on other sites More sharing options...
FredWst Posted July 20, 2017 Share Posted July 20, 2017 I don't know exactly. I see "AMI " success and "AMI" crash. I also see " my " for my BGRT but bad char are shown as space in MacIasl name, but real value in aml. Fred Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2466349 Share on other sites More sharing options...
Slice Posted July 20, 2017 Share Posted July 20, 2017 I also see " my " for my BGRT but bad char are shown as space in MacIasl name, but real value in aml. Fred Can you upload here your BGRT.aml to look? Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2466355 Share on other sites More sharing options...
FredWst Posted July 20, 2017 Share Posted July 20, 2017 Can you upload here your BGRT.aml to look? Archive.zip (I've not the last BGRT I've upgrade bios, this one if from previous bios) https://github.com/Metabolix/HackBGRT Works for me with HackBGRT. Fred 1 Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2466365 Share on other sites More sharing options...
cecekpawon Posted July 20, 2017 Share Posted July 20, 2017 Here from Fred panic: AcpiTbInstallTableWithOverride -> AcpiTbPrintTableHeader -> AcpiTbFixString (_isprint) 1 Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2466367 Share on other sites More sharing options...
TheRacerMaster Posted July 20, 2017 Share Posted July 20, 2017 Here from Fred panic: AcpiTbInstallTableWithOverride -> AcpiTbPrintTableHeader -> AcpiTbFixString (_isprint) Apple's _isprint isn't the same as ACPICA's, which is why the panic happens (it's a bug). The cast to an unsigned char seems to be missing (when using the char value as the index for _ctype), which causes char values greater than 0x7F to be used as a negative index. Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2466388 Share on other sites More sharing options...
cecekpawon Posted July 20, 2017 Share Posted July 20, 2017 Yes, I have read your post. Fred also confirm by patching the kext with Pikes patterns it does nothing. But look, seems Pike missed the red part: 554889E5 88D05E5770500F60407970F95C05DC3554889E5488D050F780500F60407970F95C05DC3 Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2466398 Share on other sites More sharing options...
Slice Posted July 20, 2017 Share Posted July 20, 2017 Archive.zip (I've not the last BGRT I've upgrade bios, this one if from previous bios) https://github.com/Metabolix/HackBGRT Works for me with HackBGRT. Fred BadBGRT contains bytes F3 EE in OemID field. Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2466413 Share on other sites More sharing options...
Slice Posted July 20, 2017 Share Posted July 20, 2017 Another proposition, answering to this problem: CloverPackage/package/Scripts.templates/EFIFolder/postinstall The sample Clover config file config-sample.plist will be copied as config.plist only if config.plist doesn't exist or there are custom configs, present in the OEM folder (the script searches for custom configs in that folder and the sample SystemProductName folder is excluded from that search). Accepted in 4123 Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2466425 Share on other sites More sharing options...
chris1111 Posted July 20, 2017 Share Posted July 20, 2017 R4123 probleme The Clover package replaces the config.plist with the default config included in the package Edit *** Sorry my English Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2466445 Share on other sites More sharing options...
Philip Petev Posted July 20, 2017 Share Posted July 20, 2017 Yeah, my bad, wrong logic, it should be AND, not OR... @Slice: line 22 (CloverPackage/package/Scripts.templates/EFIFolder/postinstall) should be: if [[ ! -f "${EFI_ROOT_DIR}/EFI/CLOVER/config.plist" && "${customPlists}" == "" ]]; then The template should be copied as main config only in case both the main config and the custom configs are not present. In any other case it should not be copied. 6 Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2466475 Share on other sites More sharing options...
bronxteck Posted July 20, 2017 Share Posted July 20, 2017 I tried r4123 with Philip's corrections above. I still got KP. I am attaching the origin folder incase the problem is also on another table. origin.zip preboot.log.zip Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2466512 Share on other sites More sharing options...
apianti Posted July 20, 2017 Share Posted July 20, 2017 I tried r4123 with Philip's corrections above. I still got KP. I am attaching the origin folder incase the problem is also on another table. Haha, two different fixes going on here. I don't think the table issue is fully fixed yet, Philip's fix has to do with the installer and installing default config.plist. Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2466541 Share on other sites More sharing options...
bronxteck Posted July 21, 2017 Share Posted July 21, 2017 yes I changed line 22 like Phil stated so I would not lose my config... recompiled and tested for slices changes in 4122 Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2466617 Share on other sites More sharing options...
Slice Posted July 21, 2017 Share Posted July 21, 2017 Yeah, my bad, wrong logic, it should be AND, not OR... @Slice: line 22 (CloverPackage/package/Scripts.templates/EFIFolder/postinstall) should be: if [[ ! -f "${EFI_ROOT_DIR}/EFI/CLOVER/config.plist" && "${customPlists}" == "" ]]; then The template should be copied as main config only in case both the main config and the custom configs are not present. In any other case it should not be copied. Committed I tried r4123 with Philip's corrections above. I still got KP. I am attaching the origin folder incase the problem is also on another table. If you dropped these tables then I see nothing in the preboot.log. I want to see preboot.log if BRGT is not dropped. 2 Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2466694 Share on other sites More sharing options...
bronxteck Posted July 21, 2017 Share Posted July 21, 2017 are you using a slide value? Slice here is Preboot log with KP BGRT and other tables preboot.log.zip Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2467015 Share on other sites More sharing options...
Slice Posted July 22, 2017 Share Posted July 22, 2017 Slice here is Preboot log with KP BGRT and other tables Your report 30:627 0:002 Apply DsdtFixMask=0x0908F0B1 Doesn't contain a fix for header <key>FixHeaders_20000000</key> <true/> 1 Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2467148 Share on other sites More sharing options...
bronxteck Posted July 22, 2017 Share Posted July 22, 2017 ok add fix header = true to config. now after selecting HS it is just black screen where usually optiofix driver loads. waited a bit but nothing happened. preboot.log.zip Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2467511 Share on other sites More sharing options...
Andrey1970 Posted July 22, 2017 Share Posted July 22, 2017 This fix does not work. Black screen too. preboot.log.zip Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2467595 Share on other sites More sharing options...
Slice Posted July 23, 2017 Share Posted July 23, 2017 Debugging needed. It's a pity I have no bad tables. Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2467694 Share on other sites More sharing options...
Andrey1970 Posted July 23, 2017 Share Posted July 23, 2017 This fix causes a bug, in not dependences on existence of bad tables. Link to comment https://www.insanelymac.com/forum/topic/306156-clover-problems-and-solutions/page/93/#findComment-2467820 Share on other sites More sharing options...
Recommended Posts