Matgen84 Posted March 6, 2020 Share Posted March 6, 2020 Hi @Slice @Jief_Machak This morning march,6 I compile and build package (latest r5104 commit bc45ded): quick message left top corner icons issues no pointer, no keyboard Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711349 Share on other sites More sharing options...
Jief_Machak Posted March 6, 2020 Share Posted March 6, 2020 Please, nobody panic or start to modify too much. It's working here so I'm struggling to find what's different. Could be the theme. Do you use QEMU ? Could you send me your QEMU clover folder (the whole thing, so I can have the same as you) ? 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711350 Share on other sites More sharing options...
Matgen84 Posted March 6, 2020 Share Posted March 6, 2020 6 minutes ago, Jief_Machak said: Please, nobody panic or start to modify too much. It's working here so I'm struggling to find what's different. Could be the theme. Do you use QEMU ? Could you send me your QEMU clover folder (the whole thing, so I can have the same as you) ? I don't use QEMU, don't know how to use it, so I do not have a QEMU clover folder. My EFI folder works well before. I don't think my Clover theme is the reason of the issue, just a opinion. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711353 Share on other sites More sharing options...
Jief_Machak Posted March 6, 2020 Share Posted March 6, 2020 I'm not saying your theme is wrong. I'm saying mine doesn't reveal the bugs. That's why your Clover folder would be helpful. If it's a real one, remove any serial number. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711355 Share on other sites More sharing options...
Matgen84 Posted March 6, 2020 Share Posted March 6, 2020 (edited) 23 minutes ago, Jief_Machak said: I'm not saying your theme is wrong. I'm saying mine doesn't reveal the bugs. That's why your Clover folder would be helpful. If it's a real one, remove any serial number. Thanks. Done. EDIT: What about pointer and keyboard! I just see the is something wrong in clover install file about Clover Version pkg. Clover EFI installer log - Fri Mar 6 05:59:51 CET 2020 Installer version: %CLOVERVERSION% r5104 EFI bootloader EFI 06.37.49.zip Edited March 6, 2020 by Matgen84 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711359 Share on other sites More sharing options...
Slice Posted March 6, 2020 Share Posted March 6, 2020 Yes, no mouse, no keyboard. Strange. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711362 Share on other sites More sharing options...
Jief_Machak Posted March 6, 2020 Share Posted March 6, 2020 Working on the mouse. Please wait a sec, I caught a random crash 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711363 Share on other sites More sharing options...
Slice Posted March 6, 2020 Share Posted March 6, 2020 No, bad diagnose. It is hang at starting menu. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711364 Share on other sites More sharing options...
Jief_Machak Posted March 6, 2020 Share Posted March 6, 2020 10 minutes ago, Slice said: No, bad diagnose. It is hang at starting menu. Bad diagnose ??? Really ? XPointer is writing on unallocated memory. I'm fixing that, which can cause a lot of other problem. So, keybaord is back. Mouse moves but is a black square. Icons still not there. Forgot to add the file REFIT_MENU_SCREEN.cpp to refit.inf. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711366 Share on other sites More sharing options...
Slice Posted March 6, 2020 Share Posted March 6, 2020 3 minutes ago, Jief_Machak said: Bad diagnose ??? Really ? XPointer is writing on unallocated memory. I'm fixing that, which can cause a lot of other problem. So, keybaord is back. Mouse moves but is a black square. Icons still not there. Sorry, I answered not to you. Black square I saw yesterday. Thinking Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711367 Share on other sites More sharing options...
Jief_Machak Posted March 6, 2020 Share Posted March 6, 2020 Oh, ok, sorry too. Answered too quickly. What's the name of this icon in the theme Mojave2 ? Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711368 Share on other sites More sharing options...
Matgen84 Posted March 6, 2020 Share Posted March 6, 2020 2 minutes ago, Jief_Machak said: Oh, ok, sorry too. Answered too quickly. What's the name of this icon in the theme Mojave2 ? The name is os_moja.icns The order from screenshot post before: usb installer--> os_mac EFI Windows--> os_win Mojave---------> os_moja.icns Recovery-------> os_moja ( I edit Volume_recovery because of swap badge) Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711369 Share on other sites More sharing options...
yuanpujie Posted March 6, 2020 Share Posted March 6, 2020 Show on startup 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711370 Share on other sites More sharing options...
Jief_Machak Posted March 6, 2020 Share Posted March 6, 2020 Looks good :-) For sure better than "Failed" :-) That'll be remove soon. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711372 Share on other sites More sharing options...
Jief_Machak Posted March 6, 2020 Share Posted March 6, 2020 Oh, I just found it : the icns format is wrong. I replaced os_sierra.icns and icons are back. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711375 Share on other sites More sharing options...
Matgen84 Posted March 6, 2020 Share Posted March 6, 2020 12 minutes ago, Jief_Machak said: Looks good :-) For sure better than "Failed" :-) That'll be remove soon. I see your comment in C+++ proposition about changing theme what I'm using: it's a BadruZeus theme that works before. He make a lot of great theme for Clover. How to know which theme is suitable in CloverThememanager list? I think it's better if you find a solution in the code. Thanks. 6 minutes ago, Jief_Machak said: Oh, I just found it : the icns format is wrong. I replaced os_sierra.icns and icons are back. Great I remove os_sierra.icns What is this bad format! 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711377 Share on other sites More sharing options...
Jief_Machak Posted March 6, 2020 Share Posted March 6, 2020 If it was working before, that means a regression and we'll fix it, for sure. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711378 Share on other sites More sharing options...
Jief_Machak Posted March 6, 2020 Share Posted March 6, 2020 "wrong" wasn't the right word. Can you test and tell me a not so old revision that was working with this theme (please double check if you can) ? It's easier to use 2 debugger sessions, one on the code that work and one on the non-working, so it's easy to compare. Won't do it before Monday. If someone else wants to do it : I have no more clue. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711379 Share on other sites More sharing options...
Matgen84 Posted March 6, 2020 Share Posted March 6, 2020 12 minutes ago, Jief_Machak said: "wrong" wasn't the right word. Can you test and tell me a not so old revision that was working with this theme (please double check if you can) ? It's easier to use 2 debugger sessions, one on the code that work and one on the non-working, so it's easy to compare. Won't do it before Monday. If someone else wants to do it : I have no more clue. This theme works fine with r5104 (8dbd938bf), don't works with r5104 (bc45ded34): perhaps, the problem comes from change between these two versions and in several commits. Unfortunately, I have no debug version because I only compile in release mode. So it is difficult to do tests to pinpoint the problem. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711380 Share on other sites More sharing options...
Jief_Machak Posted March 6, 2020 Share Posted March 6, 2020 Don't worry. Live debugging both session at the same time will make it easy... But next week ! 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711382 Share on other sites More sharing options...
LAbyOne Posted March 6, 2020 Share Posted March 6, 2020 buildme, Clover v2.5k r5104 (SHA: 797b5638d) TOOLCHAIN: GCC53 (override example: './buildme XCODE8') 1) build Clover 2) build Clover with HFSPlus 3) make pkg 4) make app 5) make iso 6) build all 7) test build (no autogen, no boot files) 8) status 9) update Clover 10) update Clover (reset changes) 11) show diff 12) open drivers directory 13) clean BaseTools 14) quit Please enter your choice: 9 [UPDATE CLOVER] Fetching origin From https://github.com/CloverHackyColor/CloverBootloader * branch master -> FETCH_HEAD Updating 797b5638d..564a3ca06 error: Your local changes to the following files would be overwritten by merge: CloverPackage/package/po/clover.pot Please commit your changes or stash them before you merge. Aborting logout Saving session... ...copying shared history... ...saving history...truncating history files... ...completed. [Process completed] Hmmm, Updating 797b5638d..564a3ca06 ? kinda strange the 'update' wouldn't work... I had to remove manually the .pot file in order to get it 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711387 Share on other sites More sharing options...
Matgen84 Posted March 6, 2020 Share Posted March 6, 2020 1 hour ago, LAbyOne said: buildme, Clover v2.5k r5104 (SHA: 797b5638d) TOOLCHAIN: GCC53 (override example: './buildme XCODE8') 1) build Clover 2) build Clover with HFSPlus 3) make pkg 4) make app 5) make iso 6) build all 7) test build (no autogen, no boot files) 8) status 9) update Clover 10) update Clover (reset changes) 11) show diff 12) open drivers directory 13) clean BaseTools 14) quit Please enter your choice: 9 [UPDATE CLOVER] Fetching origin From https://github.com/CloverHackyColor/CloverBootloader * branch master -> FETCH_HEAD Updating 797b5638d..564a3ca06 error: Your local changes to the following files would be overwritten by merge: CloverPackage/package/po/clover.pot Please commit your changes or stash them before you merge. Aborting logout Saving session... ...copying shared history... ...saving history...truncating history files... ...completed. [Process completed] Hmmm, Updating 797b5638d..564a3ca06 ? kinda strange the 'update' wouldn't work... I had to remove manually the .pot file in order to get it I can update local repo with toolchain Xcode8. Sorry, I don't use GCC53. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711392 Share on other sites More sharing options...
vector sigma Posted March 6, 2020 Share Posted March 6, 2020 3 hours ago, LAbyOne said: buildme, Clover v2.5k r5104 (SHA: 797b5638d) TOOLCHAIN: GCC53 (override example: './buildme XCODE8') 1) build Clover 2) build Clover with HFSPlus 3) make pkg 4) make app 5) make iso 6) build all 7) test build (no autogen, no boot files) 8) status 9) update Clover 10) update Clover (reset changes) 11) show diff 12) open drivers directory 13) clean BaseTools 14) quit Please enter your choice: 9 [UPDATE CLOVER] Fetching origin From https://github.com/CloverHackyColor/CloverBootloader * branch master -> FETCH_HEAD Updating 797b5638d..564a3ca06 error: Your local changes to the following files would be overwritten by merge: CloverPackage/package/po/clover.pot Please commit your changes or stash them before you merge. Aborting logout Saving session... ...copying shared history... ...saving history...truncating history files... ...completed. [Process completed] Hmmm, Updating 797b5638d..564a3ca06 ? kinda strange the 'update' wouldn't work... I had to remove manually the .pot file in order to get it time to use "10) update Clover (reset changes)"? 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711399 Share on other sites More sharing options...
vector sigma Posted March 6, 2020 Share Posted March 6, 2020 6 hours ago, Jief_Machak said: Oh, I just found it : the icns format is wrong. I replaced os_sierra.icns and icons are back. I read some where they are all png picts in all themes even if the extensions say 'icns'. @Slice I'm wrong? 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711403 Share on other sites More sharing options...
Matgen84 Posted March 6, 2020 Share Posted March 6, 2020 12 minutes ago, vector sigma said: I read some where they are all png picts in all themes even if the extensions say 'icns'. @Slice I'm wrong? Sorry, if I answer: right. The png icons is rename icns. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/842/#findComment-2711406 Share on other sites More sharing options...
Recommended Posts