Jump to content

Clover General discussion

ErmaC

By ErmaC,
in Clover

 Share
29,866 posts in this topic

Recommended Posts

Jief_Machak
Jief_Machak
Posted
Posted

 

10 minutes ago, Slice said:

No, bad diagnose. It is hang at starting menu.

Bad diagnose ??? Really ? XPointer is writing on unallocated memory. I'm fixing that, which can cause a lot of other problem.

So, keybaord is back. Mouse moves but is a black square. Icons still not there.

Forgot to add the file REFIT_MENU_SCREEN.cpp to refit.inf.

  • Like 1
Link to comment
Share on other sites
Slice
Slice
Posted
Posted
3 minutes ago, Jief_Machak said:

 

Bad diagnose ??? Really ? XPointer is writing on unallocated memory. I'm fixing that, which can cause a lot of other problem.

So, keybaord is back. Mouse moves but is a black square. Icons still not there.

Sorry, I answered not to you.

Black square I saw yesterday. Thinking

Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted
2 minutes ago, Jief_Machak said:

Oh, ok, sorry too. Answered too quickly.

 

What's the name of this icon in the theme Mojave2 ?

Screen Shot 2020-03-06 at 11.00.43.png

 

The name is os_moja.icns

 

The order from screenshot post before:

 

usb installer--> os_mac

EFI Windows--> os_win

Mojave---------> os_moja.icns

Recovery-------> os_moja ( I edit Volume_recovery because of swap badge)

Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted
12 minutes ago, Jief_Machak said:

Looks good :-)

For sure better than "Failed" :-)

That'll be remove soon.

 

I see your comment in C+++ proposition about changing theme what I'm using: it's a BadruZeus theme that works before. He make a lot of great theme for Clover. How to know which theme is suitable in CloverThememanager list? I think it's better if you find a solution in the code.

Thanks.

6 minutes ago, Jief_Machak said:

Oh, I just found it : the icns format is wrong. I replaced os_sierra.icns and icons are back.

 

Great :) I remove os_sierra.icns

 

What is this bad format!

 

 

  • Confused 1
Link to comment
Share on other sites
Jief_Machak
Jief_Machak
Posted
Posted

"wrong" wasn't the right word.

Can you test and tell me a not so old revision that was working with this theme (please double check if you can) ? It's easier to use 2 debugger sessions, one on the code that work and one on the non-working, so it's easy to compare.

Won't do it before Monday. If someone else wants to do it : I have no more clue.

  • Like 1
Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted
12 minutes ago, Jief_Machak said:

"wrong" wasn't the right word.

Can you test and tell me a not so old revision that was working with this theme (please double check if you can) ? It's easier to use 2 debugger sessions, one on the code that work and one on the non-working, so it's easy to compare.

Won't do it before Monday. If someone else wants to do it : I have no more clue.

 

This theme works fine with r5104 (8dbd938bf), don't works with r5104 (bc45ded34): perhaps, the problem comes from change between these two versions and in several commits.

Unfortunately, I have no debug version because I only compile in release mode. So it is difficult to do tests to pinpoint the problem.

Link to comment
Share on other sites
LAbyOne
LAbyOne
Posted
Posted 
buildme, Clover v2.5k r5104 (SHA: 797b5638d)
TOOLCHAIN: GCC53 (override example: './buildme XCODE8')

 1) build Clover
 2) build Clover with HFSPlus
 3) make pkg
 4) make app
 5) make iso
 6) build all
 7) test build (no autogen, no boot files)
 8) status
 9) update Clover
10) update Clover (reset changes)
11) show diff
12) open drivers directory
13) clean BaseTools
14) quit
Please enter your choice: 9
[UPDATE CLOVER]
Fetching origin
From https://github.com/CloverHackyColor/CloverBootloader
 * branch                master     -> FETCH_HEAD
Updating 797b5638d..564a3ca06
error: Your local changes to the following files would be overwritten by merge:
	CloverPackage/package/po/clover.pot
Please commit your changes or stash them before you merge.
Aborting
logout
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.

[Process completed]

Hmmm, Updating 797b5638d..564a3ca06  ? 

kinda strange the 'update' wouldn't work...

I had to remove manually the .pot file in order to get it

  • Sad 1
Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted
1 hour ago, LAbyOne said: 

buildme, Clover v2.5k r5104 (SHA: 797b5638d)
TOOLCHAIN: GCC53 (override example: './buildme XCODE8')

 1) build Clover
 2) build Clover with HFSPlus
 3) make pkg
 4) make app
 5) make iso
 6) build all
 7) test build (no autogen, no boot files)
 8) status
 9) update Clover
10) update Clover (reset changes)
11) show diff
12) open drivers directory
13) clean BaseTools
14) quit
Please enter your choice: 9
[UPDATE CLOVER]
Fetching origin
From https://github.com/CloverHackyColor/CloverBootloader
 * branch                master     -> FETCH_HEAD
Updating 797b5638d..564a3ca06
error: Your local changes to the following files would be overwritten by merge:
	CloverPackage/package/po/clover.pot
Please commit your changes or stash them before you merge.
Aborting
logout
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.

[Process completed]

Hmmm, Updating 797b5638d..564a3ca06  ? 

kinda strange the 'update' wouldn't work...

I had to remove manually the .pot file in order to get it

 

I can update local repo with toolchain Xcode8. Sorry, I don't use GCC53.

Link to comment
Share on other sites
vector sigma
vector sigma
Posted
Posted
3 hours ago, LAbyOne said: 

buildme, Clover v2.5k r5104 (SHA: 797b5638d)
TOOLCHAIN: GCC53 (override example: './buildme XCODE8')

 1) build Clover
 2) build Clover with HFSPlus
 3) make pkg
 4) make app
 5) make iso
 6) build all
 7) test build (no autogen, no boot files)
 8) status
 9) update Clover
10) update Clover (reset changes)
11) show diff
12) open drivers directory
13) clean BaseTools
14) quit
Please enter your choice: 9
[UPDATE CLOVER]
Fetching origin
From https://github.com/CloverHackyColor/CloverBootloader
 * branch                master     -> FETCH_HEAD
Updating 797b5638d..564a3ca06
error: Your local changes to the following files would be overwritten by merge:
	CloverPackage/package/po/clover.pot
Please commit your changes or stash them before you merge.
Aborting
logout
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.

[Process completed]

Hmmm, Updating 797b5638d..564a3ca06  ? 

kinda strange the 'update' wouldn't work...

I had to remove manually the .pot file in order to get it

time to use "10) update Clover (reset changes)"?

  • Like 1
Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted
12 minutes ago, vector sigma said:

I read some where they are all png picts in all themes even if the extensions say 'icns'. @Slice I'm wrong?

 

Sorry, if I answer: right. The png icons is rename icns.

  • Like 1
Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted

Hi @Slice

 

I can't build latest commit.

 

Spoiler

[CC] AutoGen
In file included from /Users/mathieu/src/CloverBootloader/rEFIt_UEFI/Platform/AcpiPatcher.cpp:20:
In file included from /Users/mathieu/src/CloverBootloader/rEFIt_UEFI/Platform/StateGenerator.h:9:
In file included from /Users/mathieu/src/CloverBootloader/rEFIt_UEFI/Platform/AmlGenerator.h:13:
In file included from /Users/mathieu/src/CloverBootloader/rEFIt_UEFI/Platform/Platform.h:99:
In file included from /Users/mathieu/src/CloverBootloader/rEFIt_UEFI/Platform/../refit/IO.h:28:
/Users/mathieu/src/CloverBootloader/rEFIt_UEFI/refit/../gui/menu_items/menu_items.h:427:39: error: field 'mItemID' will be initialized after field 'mPointer' [-Werror,-Wreorder]
                                                  Film(0), mAction(ActionNone), mItemID(0), mPointer() //, StyleFunc(&REFIT_MENU_SCREEN::TextMenuStyle)
                                                                                ^
/Users/mathieu/src/CloverBootloader/rEFIt_UEFI/refit/../gui/menu_items/menu_items.h:435:39: error: field 'mItemID' will be initialized after field 'mPointer' [-Werror,-Wreorder]
                                                  Film(0), mAction(ActionNone), mItemID(0), mPointer() //, StyleFunc(&REFIT_MENU_SCREEN::TextMenuStyle)
                                                                                ^
/Users/mathieu/src/CloverBootloader/rEFIt_UEFI/refit/../gui/menu_items/menu_items.h:442:39: error: field 'mItemID' will be initialized after field 'mPointer' [-Werror,-Wreorder]
                                                  Film(0), mAction(ActionNone), mItemID(0), mPointer() //, StyleFunc(&REFIT_MENU_SCREEN::TextMenuStyle)
                                                                                ^
3 errors generated.
make: *** [/Users/mathieu/src/CloverBootloader/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit/OUTPUT/Platform/AcpiPatcher.obj] Error 1


build.py...
 : error 7000: Failed to execute command
    make tbuild [/Users/mathieu/src/CloverBootloader/Build/Clover/RELEASE_XCODE8/X64/rEFIt_UEFI/refit]


build.py...
 : error F002: Failed to build module
    /Users/mathieu/src/CloverBootloader/rEFIt_UEFI/refit.inf [X64, XCODE8, RELEASE]

- Failed -
Build end time: 17:57:01, Mar.06 2020
Build total time: 00:00:17

 

Link to comment
Share on other sites
Matgen84
Matgen84
Posted
Posted (edited)

Hi @Slice

 

I just build and install latest r5104  (a00e14851). I've the same issues described yesterday: quick test message left top corner "all tests" + no icons. 

 

My knowledge is limited: It seems that the files with icns extension aren't display correctly.
 

screenshot0.png

Edited by Matgen84
Link to comment
Share on other sites
 Share
Go to topic listing
×
×
  • Create New...