bcc9, on Dec 6 2009, 08:34 PM, said:
...which in turn is lifted from osfmk/i386/cpuid.c in the OSX kernel source.
It should have been clear that I used the link as a reference to the
original source code because it reads: "Reuses code from the Mac OS X kernel." and since I know that oldnapalm is clever enough to Google for it. He checked it – after my little note. Most definitely.
bcc9, on Dec 6 2009, 08:34 PM, said:
With an OS that fails to make a good SDK to access the cpu state, it's understandable that you have to do a little cut&paste since there isn't a proper library to reference. No person to credit here since it's from the OS. I'd still reference Apple's OSF copyright if I was the one cutting&pasting. Amit should have done that instead of just writing "Reuses code from the Mac OS X kernel" I think.
He should have used the Apple Software License Header yes. Why else do they have a license?
bcc9, on Dec 6 2009, 08:34 PM, said:
Voodoohda, voodoobattery, are guilty of lifting a bunch of code from OSX as well without reference. If everyone provided references the code wouldn't seem like voodoo, huh? Seriously, it would be nice if people sighted the apple code they cribbed from, it'd make the code more maintainable. (People would know where you found out how to do things).
I couldn't agree more. Making it a perfect target for "learning by example".
And oldnapalm knows me, that I wasn't blaming him for the error, but merely pointing him into the right direction