Jump to content

Clover General discussion

ErmaC

By ErmaC,
in Clover

 Share
30960 posts in this topic

Recommended Posts

Trung_Nguyen
Trung_Nguyen
Posted
Posted

Hello, What is this in the code?:

  //dumping SETTING structure
  // if you change something in Platform.h, please uncomment and test that all offsets
  // are natural aligned i.e. pointers are 8 bytes aligned

Result:

0:100  0:000  Settings offsets:
0:100  0:000   OEMProduct:     218
0:100  0:000   DefaultVolume:  720
0:100  0:000   DefaultLoader:  728
0:100  0:000   ResetAddr:      748
0:100  0:000   FixDsdt:        7A4
0:100  0:000   FakeATI:        7B0
0:100  0:000   PatchVBiosBytes:7E0
0:100  0:000   VRAM:           830
0:100  0:000   SecureBootWhiteListCount: 860
0:100  0:000   LegacyBoot:     888
0:100  0:000   HVHideStrings:  8D0
0:100  0:000   PointerSpeed:   958
0:100  0:000   RtMLB:          980
0:100  0:000   ConfigName:     9A0
0:100  0:000   PointerSpeed:   958
0:100  0:000   PatchDsdtNum:   9E4
0:100  0:000   LenToReplace:   A00
0:100  0:000   ACPIDropTables: A10
0:100  0:000   CustomEntries:  A20
0:100  0:000   CustomTool:     A30
0:100  0:000   AddProperties:  A40
0:100  0:000   BlockKexts:     A48

Is that OK?

mhaeuser
mhaeuser
Posted
Posted

 

 

It was ironically meant. Not you in person, but you as insanely-team. Well, I find that blocking kindergarten like. Together you could reach much more , e.g. a proper wiki with always state of the art info.

Uhm... The only guy I know there not only doing useless stuff is RehabMan and he is here too... Who *is* there even to work with on a wiki? Lol

Trung_Nguyen
Trung_Nguyen
Posted
Posted

Because it also checks modifiers...?

Not really sure. when i turn on logscancodes with appleps2keyboard, it also sent modifier(except Fn) as seperate key :).

Just discovered: If you don't Locate the Apple Key State Protocol, boot.efi will able to handle Cmd+V :) 

Choice should be made here: Key process by clover or boot.efi ?

mhaeuser
mhaeuser
Posted
Posted

You. No, nobody. Yes, rehabman pretty much IS the forum.

If that was sarcastic: anything else I see there are the quadzillionth question or guide regarding "how to install on machine Y". Pretty damn original.

 

 

Not really sure. when i turn on logscancodes with appleps2keyboard, it also sent modifier(except Fn) as seperate key :).

 

Just discovered: If you don't Locate the Apple Key State Protocol, boot.efi will able to handle Cmd+V :)

Choice should be made here: Key process by clover or boot.efi ?

PS/2 is not USB.

Idk what mad black magic clover does again, however this should be non-exclusive.

Trung_Nguyen
Trung_Nguyen
Posted
Posted

If that was sarcastic: anything else I see there are the quadzillionth question or guide regarding "how to install on machine Y". Pretty damn original.

 

 

 

PS/2 is not USB.

Idk what mad black magic clover does again, however this should be non-exclusive.

 

I use all PS/2, I don't have even a single USB Keyboard in my house :)

Anyway, I don't understand what do you mean by non-exclusive here?

Trung_Nguyen
Trung_Nguyen
Posted
Posted

The Apple protocol is based on the USB HID design as that is precisely what Apple uses, and not PS/2

???? What do you mean. I use PS2 Keyboard and it recognized single modifier key too.

Did you mean that the APPLE_KEY_MAP_DATABASE_PROTOCOL was designed for USB HID?

chris1111
chris1111
Posted
Posted

humm, I thought Built-in Apple Keyboard on MacBook are connected by PS2? So It is by USB?

For PS2 mouse and Keyboard ?

Did you try old kext in Clover kext ?

AppleACPIPS2Nub.kext, ApplePS2Controller.kext

apianti
apianti
Posted
Posted

IIRC most (all?) MBPs are USB (don't remember 2016/2017), but the 12" MacBook (Core m) uses SPI.

 

Yes. There has never been a mac with PS/2 support, lol. Not one, ever. They had their own proprietary interface before, kinda the preface to firewire/usb/thunderbolt called apple desktop bus. It was created by steve wozniak and released in 1986 on one of the Apple II redesigns GS or GT or something. PS/2 wasn't released until the following year, with IBM's PS/2 model computer, that was almost positively to compete against the much better ADB over straight twisted pair serial ports.... So they made a serial bus that could only be used for specific purposes, in fact you used to have to specifically plug in the correct device or the protocol to recognize it was not even associated with the port. ADB works more like thunderbolt, only still a serial interface, but in 1986....... That guy is a {censored} genius.

 

EDIT: If you have a PS/2 controller, then you will need to modify the PS2 keyboard driver as well to populate the aggregator and database.

 

EDIT2: Also don't remove any keys from there, just inspect the protocol interfaces.

 

EDIT3: Oh just in case any one is wondering, SPI is Serial Peripheral Interface and is basically all of these put together, lol.

 

EDIT4: It looks like newer MacBookPros, especially with the touch bar probably use SPI too. Well, more specifically it's probably using Intel's proprietary eSPI. But there are evidence of SPI drivers needed for MacBookPro13,1+ in Ubuntu. As well as the afore mentioned newer MacBook.

  • Like 5
Trung_Nguyen
Trung_Nguyen
Posted
Posted (edited)

Yes. There has never been a mac with PS/2 support, lol. Not one, ever. They had their own proprietary interface before, kinda the preface to firewire/usb/thunderbolt called apple desktop bus. It was created by steve wozniak and released in 1986 on one of the Apple II redesigns GS or GT or something. PS/2 wasn't released until the following year, with IBM's PS/2 model computer, that was almost positively to compete against the much better ADB over straight twisted pair serial ports.... So they made a serial bus that could only be used for specific purposes, in fact you used to have to specifically plug in the correct device or the protocol to recognize it was not even associated with the port. ADB works more like thunderbolt, only still a serial interface, but in 1986....... That guy is a {censored} genius.

 

EDIT: If you have a PS/2 controller, then you will need to modify the PS2 keyboard driver as well to populate the aggregator and database.

 

EDIT2: Also don't remove any keys from there, just inspect the protocol interfaces.

I don't remove any keys from the buffer, just read it. Inspected with ReadKeyStroke Function, found out that if the protocol is define in CloverPkg.dec & not Located by Clover and then boot.efi will handle it and parse -v/-s but Shift not work, not even by Clover/boot.efi as it is the modifier. Any solutions here?

Edited by Trung_Nguyen
apianti
apianti
Posted
Posted

I don't remove any keys from the buffer, just read it. Inspected with ReadKeyStroke Function, found out that if the protocol is define in Platform.h & not Located by Clover and then boot.efi will handle it and parse -v/-s but Shift not work, not even by Clover/boot.efi as it is the modifier. Any solutions here?

 

I don't understand what you mean.

 

EDIT: Oh wait, I think I understand. You mean ReadKeyState from the aggregator. I don't know what you mean by define in Platform.h or whatever, but making assumptions, the problem is the protocol definition is hidden in the protocol implementation and needs to be separated out like the other protocols into the include folder. The protocol GUID is not defined outside the implementation of the protocol so search for the other protocol GUIDs and define the GUID in the same place, it is probably somewhere in the platform folder.....  :sick: ...... Anyway, I think it should be pretty clear that if you read the key state information that you got rid of it, so you either have to put it back or need to translate it into options directly to boot.efi (it does not appear to be removed at all, so maybe even using SearchKeyStroke may be a better idea first to determine if there are any relevant keystrokes). Remember the fact that none of this needs to be done if boot.efi is not being autolaunched with timeout=0.

 

EDIT2: After looking at the protocol implementation, I don't think it removes any information, so it should definitely still be there for boot.efi.

 

EDIT3: More clarity, if there are any keys at all and boot.efi is not being autolaunched with timeout=0, then the GUI must show.

 

EDIT4: Ah, this whole comment is non-sense, even I don't know what I meant anymore because I am so confused by what he said and it just gets worse each time I read it.

 

EDIT5:  :blowup:

TheRacerMaster
TheRacerMaster
Posted
Posted

EDIT4: It looks like newer MacBookPros, especially with the touch bar probably use SPI too. Well, more specifically it's probably using Intel's proprietary eSPI. But there are evidence of SPI drivers needed for MacBookPro13,1+ in Ubuntu. As well as the afore mentioned newer MacBook.

Yeah, I think you're right - 2016+ MBPs also use SPI for the keyboard/trackpad. I believe this out of tree driver is needed for Linux: https://github.com/cb22/macbook12-spi-driver

apianti
apianti
Posted
Posted

Yeah, I think you're right - 2016+ MBPs also use SPI for the keyboard/trackpad. I believe this out of tree driver is needed for Linux: https://github.com/cb22/macbook12-spi-driver

 

Yes, sir, I don't see how else they could program the touch bars. Some of the models don't have touch bars but why make two different types of main board when you could just not connect a connector? That's way cheaper in mass production.

 

EDIT: Also eSPI may be built into every intel platform chipset from now on. It's definitely in the 100 series chipsets (chapter 17).

EDIT2: It is also part of 200 series, and the Z370 (still chapter 17), so I imagine, that yes, it will be in every intel platform chipset from now on.

 Share
Go to topic listing
×
×
  • Create New...