itsmeciao Posted March 30, 2018 Share Posted March 30, 2018 24 minutes ago, FredWst said: https://www.insanelymac.com/forum/forums/topic/333560-macos-high-sierra-10134-is-out/?page=3 Fred This works, thank you very much Fred Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606513 Share on other sites More sharing options...
chris1111 Posted March 30, 2018 Share Posted March 30, 2018 (edited) Install macOS High Sierra.app (10.13.4) Create Install Media This installer paths "\\.IABootFiles\\boot.efi" is change by Apple See blue line for new path // OS X installer paths STATIC CHAR16 *OSXInstallerPaths[] = { L"\\Mac OS X Install Data\\boot.efi", L"\\macOS Install Data\\boot.efi", L"\\macOS Install Data\\Locked Files\\Boot Files\\boot.efi", L"\\OS X Install Data\\boot.efi", L"\\.IABootFiles\\boot.efi", L "\\System\\Library\\CoreServices\\boot.efi" ⬅︎ new Path }; Edited March 30, 2018 by chris1111 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606561 Share on other sites More sharing options...
ReddestDream Posted March 30, 2018 Share Posted March 30, 2018 (edited) 22 minutes ago, chris1111 said: Install macOS High Sierra.app (10.13.4) Create Install Media This installer paths "\\.IABootFiles\\boot.efi" is change by Apple See blue line for new path // OS X installer paths STATIC CHAR16 *OSXInstallerPaths[] = { L"\\Mac OS X Install Data\\boot.efi", L"\\macOS Install Data\\boot.efi", L"\\macOS Install Data\\Locked Files\\Boot Files\\boot.efi", L"\\OS X Install Data\\boot.efi", L"\\.IABootFiles\\boot.efi" L "\\System/Libray/CoreSevices\\boot.efi" ⬅︎ new Path }; Just FYI, UEFI uses backslashes like DOS/Windows, not Unix style: L"\\System\\Library\\CoreServices\\boot.efi" Is the correct formatting. Edited March 30, 2018 by ReddestDream Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606563 Share on other sites More sharing options...
chris1111 Posted March 30, 2018 Share Posted March 30, 2018 2 minutes ago, ReddestDream said: Just FYI, UEFI uses backslashes like DOS/Windows, not Unix style: L"\\System\\Library\\CoreServices\\boot.efi" Is the correct formatting. Yes typo Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606565 Share on other sites More sharing options...
ReddestDream Posted March 30, 2018 Share Posted March 30, 2018 (edited) 4 minutes ago, chris1111 said: Yes typo Not to nitpick again, but "Libray" and "CoreSevices" are also missing "r"s . . . "Library" and "CoreServices" Also the line above the new one needs a comma. Edited March 30, 2018 by ReddestDream Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606566 Share on other sites More sharing options...
chris1111 Posted March 30, 2018 Share Posted March 30, 2018 (edited) 5 minutes ago, ReddestDream said: Not to nitpick again, but "Libray" and "CoreSevices" are also missing "r"s . . . "Library" and "CoreServices" This is correct ? L "\\System\\Library\\CoreServices\\boot.efi" Edited March 30, 2018 by chris1111 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606567 Share on other sites More sharing options...
ReddestDream Posted March 30, 2018 Share Posted March 30, 2018 (edited) 5 minutes ago, chris1111 said: This is correct ? L "\\System\\Libray\\CoreSevices\\boot.efi" L"\\System\\Library\\CoreServices\\boot.efi" "Library" and "CoreServices" are misspelled in yours. Edited March 30, 2018 by ReddestDream Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606568 Share on other sites More sharing options...
chris1111 Posted March 30, 2018 Share Posted March 30, 2018 (edited) 2 minutes ago, ReddestDream said: L"\\System\\Library\\CoreServices\\boot.efi" "Library" and "CoreServices" are misspelled in yours. Sorry I am really tired This is good L "\\System\\Library\\CoreServices\\boot.efi" Edited March 30, 2018 by chris1111 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606569 Share on other sites More sharing options...
ReddestDream Posted March 30, 2018 Share Posted March 30, 2018 (edited) Whether it will work or not is a different question. The Clover devs need to find another way to distinguish between installers and installed OSes since they are using hardcoded paths and not bless like a real mac . . . https://bombich.com/kb/ccc4/what-makes-volume-bootable Edited March 30, 2018 by ReddestDream Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606571 Share on other sites More sharing options...
chris1111 Posted March 30, 2018 Share Posted March 30, 2018 2 minutes ago, ReddestDream said: Whether it will work or not is a different question. The Clover devs need to find another way to distinguish between installers and installed OSes since they are using hardcoded paths and not bless like a real mac . . . I think is good, see loader.c Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606572 Share on other sites More sharing options...
ReddestDream Posted March 30, 2018 Share Posted March 30, 2018 1 minute ago, chris1111 said: I think is good, see loader.c But that's the same path an "installed" macOS uses: L"\\System\\Library\\CoreServices\\boot.efi" Now you can't tell if it's an installer or an OS that has already been installed . . . Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606573 Share on other sites More sharing options...
chris1111 Posted March 31, 2018 Share Posted March 31, 2018 (edited) 3 minutes ago, ReddestDream said: But that's the same path an "installed" macOS uses: L"\\System\\Library\\CoreServices\\boot.efi" Now you can't tell if it's an installer or an OS that has already been installed . . . Yes your right Edit ** @Sherlock will find a solution Edited March 31, 2018 by chris1111 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606575 Share on other sites More sharing options...
ReddestDream Posted March 31, 2018 Share Posted March 31, 2018 Just now, chris1111 said: Yes your right Clover's probably going to have to start checking bless status to make this determination, which is how a real mac does it . . . In HFS+, this is done by checking the volume header for the inode of the Blessed System File and Folder. I'm not sure how it works on APFS . . . https://bombich.com/kb/ccc4/what-makes-volume-bootable 11 minutes ago, chris1111 said: Sorry I am really tired Should probably get sleep. This may end up being complex to fix . . . 4 minutes ago, chris1111 said: @Sherlock will find a solution Yay! 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606576 Share on other sites More sharing options...
apianti Posted March 31, 2018 Share Posted March 31, 2018 The path is the same as an already installed macOS, updating method doesn't matter how - just run the same entry that has always been detected to update. If anything their change makes it even easier to upgrade since it won't be creating extra entries, boot.efi can deal with whatever it needs to start the correct action.... This is along the behavior of how windows updates. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606593 Share on other sites More sharing options...
ReddestDream Posted March 31, 2018 Share Posted March 31, 2018 (edited) 6 minutes ago, apianti said: The path is the same as an already installed macOS, updating method doesn't matter how - just run the same entry that has always been detected to update. If anything their change makes it even easier to upgrade since it won't be creating extra entries, boot.efi can deal with whatever it needs to start the correct action.... This is along the behavior of how windows updates. This isn't about updating an already installed system. It's about new USB-based macOS installers based on 10.13.4. Clover isn't detecting the macOS installer on the USB correctly. See here: https://www.insanelymac.com/forum/forums/topic/333560-macos-high-sierra-10134-is-out/?page=2&tab=comments#comment-2606462 Edited March 31, 2018 by ReddestDream 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606595 Share on other sites More sharing options...
Slice Posted March 31, 2018 Share Posted March 31, 2018 5 hours ago, ReddestDream said: This isn't about updating an already installed system. It's about new USB-based macOS installers based on 10.13.4. Clover isn't detecting the macOS installer on the USB correctly. See here: https://www.insanelymac.com/forum/forums/topic/333560-macos-high-sierra-10134-is-out/?page=2&tab=comments#comment-2606462 What is happen at all? Clover detected the USB stick somehow? What is happen if click on it? I propose it works. Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606639 Share on other sites More sharing options...
chris1111 Posted March 31, 2018 Share Posted March 31, 2018 1 hour ago, Slice said: What is happen at all? Clover detected the USB stick somehow? What is happen if click on it? I propose it works. The entry is not visible on GUI Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606678 Share on other sites More sharing options...
Lucy183 Posted March 31, 2018 Share Posted March 31, 2018 (edited) Any success compiling r4419? Xcode 9.3 and Build_Clover.command Building ... /Users/LuCy/src/edk2/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf [X64] /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c:432:1: error: conflicting types for 'BmRepairAllControllers' BmRepairAllControllers ( ^ /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h:352:1: note: previous declaration is here BmRepairAllControllers ( ^ make: Nothing to be done for `tbuild'. Building ... /Users/LuCy/src/edk2/MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf [X64] make: Nothing to be done for `tbuild'. Building ... /Users/LuCy/src/edk2/ShellPkg/Library/UefiShellLib/UefiShellLib.inf [X64] /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c:580:32: error: use of undeclared identifier 'MAX_RECONNECT_REPAIR' if (ReconnectRepairCount < MAX_RECONNECT_REPAIR) { make: Nothing to be done for `tbuild'. ^ Building ... /Users/LuCy/src/edk2/MdePkg/Library/UefiMemoryLib/UefiMemoryLib.inf [X64] /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c:581:31: error: too many arguments to function call, expected 0, have 1 make: Nothing to be done for `tbuild'. BmRepairAllControllers (ReconnectRepairCount + 1); ~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~ /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h:351:1: note: 'BmRepairAllControllers' declared here VOID ^ /Users/LuCy/src/edk2/MdePkg/Include/Base.h:337:19: note: expanded from macro 'VOID' #define VOID void ^ Building ... /Users/LuCy/src/edk2/Clover/Library/OpensslLib/OpensslLibNull.inf [X64] 3 errors generated. make: *** [/Users/LuCy/src/edk2/Build/Clover/RELEASE_XCODE8/X64/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib/OUTPUT/BmDriverHealth.obj] Error 1 build.py... : error 7000: Failed to execute command make tbuild [/Users/LuCy/src/edk2/Build/Clover/RELEASE_XCODE8/X64/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib] build.py... : error F002: Failed to build module /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf [X64, XCODE8, RELEASE] - Failed - Build end time: 14:28:28, Mar.31 2018 Build total time: 00:00:16 o_Ops, ./ebuild.sh exited with error(s), aborting.. Edited March 31, 2018 by LuCyr04 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606679 Share on other sites More sharing options...
Zenith432 Posted March 31, 2018 Share Posted March 31, 2018 (edited) @LuCyr04: update to latest edk2 and reapply Patches_for_edk2 Edited March 31, 2018 by Zenith432 1 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606688 Share on other sites More sharing options...
Matgen84 Posted March 31, 2018 Share Posted March 31, 2018 (edited) 56 minutes ago, LuCyr04 said: Any success compiling r4419? Xcode 9.3 and Build_Clover.command Reveal hidden contents Building ... /Users/LuCy/src/edk2/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf [X64] /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c:432:1: error: conflicting types for 'BmRepairAllControllers' BmRepairAllControllers ( ^ /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h:352:1: note: previous declaration is here BmRepairAllControllers ( ^ make: Nothing to be done for `tbuild'. Building ... /Users/LuCy/src/edk2/MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf [X64] make: Nothing to be done for `tbuild'. Building ... /Users/LuCy/src/edk2/ShellPkg/Library/UefiShellLib/UefiShellLib.inf [X64] /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c:580:32: error: use of undeclared identifier 'MAX_RECONNECT_REPAIR' if (ReconnectRepairCount < MAX_RECONNECT_REPAIR) { make: Nothing to be done for `tbuild'. ^ Building ... /Users/LuCy/src/edk2/MdePkg/Library/UefiMemoryLib/UefiMemoryLib.inf [X64] /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c:581:31: error: too many arguments to function call, expected 0, have 1 make: Nothing to be done for `tbuild'. BmRepairAllControllers (ReconnectRepairCount + 1); ~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~ /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h:351:1: note: 'BmRepairAllControllers' declared here VOID ^ /Users/LuCy/src/edk2/MdePkg/Include/Base.h:337:19: note: expanded from macro 'VOID' #define VOID void ^ Building ... /Users/LuCy/src/edk2/Clover/Library/OpensslLib/OpensslLibNull.inf [X64] 3 errors generated. make: *** [/Users/LuCy/src/edk2/Build/Clover/RELEASE_XCODE8/X64/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib/OUTPUT/BmDriverHealth.obj] Error 1 build.py... : error 7000: Failed to execute command make tbuild [/Users/LuCy/src/edk2/Build/Clover/RELEASE_XCODE8/X64/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib] build.py... : error F002: Failed to build module /Users/LuCy/src/edk2/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf [X64, XCODE8, RELEASE] - Failed - Build end time: 14:28:28, Mar.31 2018 Build total time: 00:00:16 o_Ops, ./ebuild.sh exited with error(s), aborting.. All work fine here with Xcode 9.3: I just replace EDK2 26300--->26764 in Build_Clover.command. Of cause, select Update EDK2 in, the script. Edited March 31, 2018 by Matgen84 1 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606694 Share on other sites More sharing options...
Zenith432 Posted March 31, 2018 Share Posted March 31, 2018 You can update to EDK2 svn r26767 or githib commit 9c7d0d4. I put 26764 in the commit msg because it's the last one that contained a change impacting the patches. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606695 Share on other sites More sharing options...
Lucy183 Posted March 31, 2018 Share Posted March 31, 2018 17 minutes ago, Zenith432 said: @LuCyr04: update to latest edk2 and reapply Patches_for_edk2 6 minutes ago, Matgen84 said: All work fine here with Xcode 9.3: I just replace EDK2 26300--->26764 in Build_Clover.command. Of cause, select Update EDK2 in, the script. 1 minute ago, Zenith432 said: You can update to EDK2 svn r26767 or githib commit 9c7d0d4. I put 26764 in the commit msg because it's the last one that contained a change impacting the patches. Thanks, compiled fine now. 3 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606696 Share on other sites More sharing options...
apianti Posted March 31, 2018 Share Posted March 31, 2018 9 hours ago, ReddestDream said: This isn't about updating an already installed system. It's about new USB-based macOS installers based on 10.13.4. Clover isn't detecting the macOS installer on the USB correctly. See here: https://www.insanelymac.com/forum/forums/topic/333560-macos-high-sierra-10134-is-out/?page=2&tab=comments#comment-2606462 I still see no reason why it would not find the default path of every macOS install. It probably just says something different like Boot macOS from macOS or whatever. Also if someone gives a listing of the media, maybe there is new installer path...? Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606709 Share on other sites More sharing options...
chris1111 Posted March 31, 2018 Share Posted March 31, 2018 2 minutes ago, apianti said: I still see no reason why it would not find the default path of every macOS install. It probably just says something different like Boot macOS from macOS or whatever. Also if someone gives a listing of the media, maybe there is new installer path...? Install macOS High Sierra.app (10.13.4) Create Install Media This installer paths "\\.IABootFiles\\boot.efi" is change by Apple Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606710 Share on other sites More sharing options...
apianti Posted March 31, 2018 Share Posted March 31, 2018 Just now, chris1111 said: Install macOS High Sierra.app (10.13.4) Create Install Media This installer paths "\\.IABootFiles\\boot.efi" is change by Apple You proposed adding the default boot path as the installer path...? I can understand that the path changed, if you look in the other thread can you please provide me with that information? I imagine that the installer just moved the file to a new place and a new boot.efi path needs to be added. 1 Link to comment https://www.insanelymac.com/forum/topic/284656-clover-general-discussion/page/673/#findComment-2606711 Share on other sites More sharing options...
Recommended Posts