Clover General discussion

[Zenith432]

Why support partial matches?

What difference does it make anymore? It's needed for backward compatibility now. Removing it will break almost all existing config.plist.

 

The case sensitivity I think is dictated because Apple bundle-ids are case-sensitive.

 

Reference for build-ids.

Edited February 6, 2018 by Zenith432

[apianti]

StrStr is used if the Name specified does not have any '.' characters.

I would bet that was done to enhance backward compatibility.

Typically, we accept case sensitivity.

 

I understand, but that doesn't solve the issue. Because as brought up before there are some that don't have '.' characters and are sub-strings of other bundle-ids. I have no problem with backwards compatibility, but this should be deprecated, spit out a warning, and eventually removed. It's not really beneficial to remain backwards compatible at risk of bugs.

 

What difference does it make anymore? It's needed for backward compatibility now. Removing it will break almost all existing config.plist.

 

The case sensitivity I think is dictated because Apple bundle-ids are case-sensitive. Haven't verified this, just guessing.

 

I am not sure if you notice but config.plist is broken by changes constantly. I think it's best to just match the whole bundle-id. I doubt very much they are case sensitive, why would they want two drivers with the same but different cased bundle-id? That would be really confusing.

 

EDIT:

 

Reference for build-ids.

 

So they are case sensitive. Then we should just use StrCmp for all, and deprecate and eventually remove the previous partial matching.

[Sherlocks]

@Slice

in latest clover package, always force to check. because package always remove this file

 

this driver must be use to boot snow leopard and lion. its important.

rehabman also revert this driver in package. no need this before(check) in old package.

 

i always checked before after fresh install

 

can we consider again?

https://github.com/RehabMan/Clover/commit/541fa44f4de26b75e32a33d282e90d826288481c

 

my driver list

0:149  0:002  Loading apfs.efi  status=Success

0:152  0:003   - driver needs connecting

0:152  0:000  Loading AppleImageCodec-64.efi  status=Success

0:152  0:000  Loading AppleKeyAggregator-64.efi  status=Success

0:152  0:000  Loading AppleUITheme-64.efi  status=Success

0:152  0:000  Loading DataHubDxe-64.efi  status=Success

0:153  0:000  Loading EmuVariableUefi-64.efi  status=Success

0:155  0:001  EmuVariableUefi Initialize: VariableCommonInitialize = Success, orig services stored, install gEmuVariableControlProtocolGuid = Success

0:155  0:000  Loading Fat-64.efi  status=Success

0:155  0:000   - driver needs connecting

0:155  0:000  Loading FirmwareVolume-64.efi  status=Success

0:155  0:000  Loading FSInject-64.efi  status=Success

0:155  0:000  Loading HFSPlus.efi  status=Success

0:155  0:000   - driver needs connecting

0:155  0:000  Loading HPFanReset.efi  status=Success

0:246  0:091  HPFanReset: successfully set fan control to BIOS mode.

0:246  0:000  Loading OsxFatBinaryDrv-64.efi  status=Success

0:246  0:000  Loading SMCHelper-64.efi  status=Success

0:248  0:001  Loading AptioMemoryFix.efi  status=Success

0:248  0:000  3 drivers needs connecting ...

0:248  0:000  PlatformDriverOverrideProtocol not found. Installing ... Success

0:248  0:000  HFS+ driver loaded

0:248  0:000  APFS driver loaded

 

package now touch only OsxFatBinaryDrv-64 when install clover.

[RehabMan]

@Slice

in latest clover package, always force to check. because package always remove this file

스크린샷 2018-02-07 오전 12.48.49.png

 

this driver must be use to boot snow leopard and lion. its important.

rehabman also revert this driver in package. no need this before(check) in old package.

Yeah, I wasted at least a few hours of my life determining why SL 10.6.8 failed to boot after installing the latest Clover.

I didn't see any reason to remove this efi driver as it is needed by Lion/SL (due to kexts being 32-bit/64-bit), so I reverted the change in my Clover build (I don't like breaking things that used to work for no good reason).

[Sherlocks]

Yeah, I wasted at least a few hours of my life determining why SL 10.6.8 failed to boot after installing the latest Clover.

I didn't see any reason to remove this efi driver as it is needed by Lion/SL (due to kexts being 32-bit/64-bit), so I reverted the change in my Clover build (I don't like breaking things that used to work for no good reason).

Right. Me too. I spent some times to find reason.

Hope revert this file back. Thank you for reason with commit.

 

나의 LG-F800S 의 Tapatalk에서 보냄

[apianti]

Yeah, that driver should not have been modified/removed from installer, unless we are saying that there is no longer support below ML? I don't think that's the case quite yet.

 

@Sherlocks or Philip,

 

Can one of you two please revert that change and put the driver back in the installer? Also is there any way to further group the drivers together under more types, like grouping all the AptioFixes and only allowing one to be picked, or drivers needed for SL/Lion, Graphics, Input, etc.

[RehabMan]

Right. Me too. I spent some times to find reason.

Hope revert this file back. Thank you for reason with commit.

 

나의 LG-F800S 의 Tapatalk에서 보냄

And that particular change was especially hard to find due to it being buried in an unrelated commit: "Book may have desktop CPU".

I *might* have used some four letter words when I found that!

[apianti]

And that particular change was especially hard to find due to it being buried in an unrelated commit: "Book may have desktop CPU".

I *might* have used some four letter words when I found that!

 

Are you serious???? Jesus. That's a terrible message for any commit, like what on Earth does that mean? There is no commit review feature on sourceforge without implementing very complex hooks methods, at least I don't think. Maybe it may be time to go over to github so commits can be reviewed.... I don't know though, that's a lot of work...

 

EDIT: You can go to a file and click history in the upper right on sourceforge and it will tell you every time the file was changed. That can make it easier to trace a change you know where it is.

[Philip Petev]

Yeah, that driver should not have been modified/removed from installer, unless we are saying that there is no longer support below ML? I don't think that's the case quite yet.

 

@Sherlocks or Philip,

 

Can one of you two please revert that change and put the driver back in the installer? Also is there any way to further group the drivers together under more types, like grouping all the AptioFixes and only allowing one to be picked, or drivers needed for SL/Lion, Graphics, Input, etc.

Done in r4402.

 

EDIT: sorry, my bad, it's r4403. Forgot that two packages with the same name (identifier) can't exist in the distribution.

 

EDIT2: can't believe I made such stupid mistake... r4404 on the way.

[smolderas]

Three commits just for one line in a script!? Are you kidding?

[Slice]

 

@Slice

in latest clover package, always force to check. because package always remove this file

 

 

And now I force to uncheck this driver because I install for 10.11+ systems.

It must be optional!

We should check it by default but not mandatory.

[Sherlocks]

And now I force to uncheck this driver because I install for 10.11+ systems.

It must be optional!

We should check it by default but not mandatory.

So, if user has this driver in folder, can clover package check whether exist? Then if there is file, skip remove.

This process shown case "fat-64.efi".

I tested this file with package.

 

I have this file and install clover. Still i have fat-64.efi. I didnt touch any uefi64 entry when install clover.

 

Can you consider like fat-64, aptiomemoryfix, aptiofix series process?

 

나의 LG-F800S 의 Tapatalk에서 보냄

Done in r4402.

 

EDIT: sorry, my bad, it's r4403. Forgot that two packages with the same name (identifier) can't exist in the distribution.

 

EDIT2: can't believe I made such stupid mistake... r4404 on the way.

@Philip Petev

I have a question. If i select some uefi64 driver in clover package when install clover and installed clover. Next time, clover package again, clover package remember i selected uefi64 driver. If i want to cleanup option like after install fresh macos. Where is store that i selected option in MacOS partition?

 

Thanks in advance

 

나의 LG-F800S 의 Tapatalk에서 보냄

[apianti]

I'm confused, why is it just not checked by default if there was no previous installation? There is some sort of previous installation information somewhere isn't there? As I recall there is a record of the options selected for the installer in the OS somewhere. If not, would be fairly easy to create one. Then, if there is previous install, check the driver exists, if exists then check the box, and remove the driver if then unchecked.

Done in r4402.

 

EDIT: sorry, my bad, it's r4403. Forgot that two packages with the same name (identifier) can't exist in the distribution.

 

EDIT2: can't believe I made such stupid mistake... r4404 on the way.

 

Need that git commit --amend! Haha!

 

Three commits just for one line in a script!? Are you kidding?

 

It happens, I do this all the time.

[Philip Petev]

@Philip Petev

I have a question. If i select some uefi64 driver in clover package when install clover and installed clover. Next time, clover package again, clover package remember i selected uefi64 driver. If i want to cleanup option like after install fresh macos. Where is store that i selected option in MacOS partition?

 

Thanks in advance

 

나의 LG-F800S 의 Tapatalk에서 보냄

 

It's /Library/Preferences/com.projectosx.clover.installer.plist.

[Sherlocks]

I'm confused, why is it just not checked by default if there was no previous installation? There is some sort of previous installation information somewhere isn't there? As I recall there is a record of the options selected for the installer in the OS somewhere. If not, would be fairly easy to create one. Then, if there is previous install, check the driver exists, if exists then check the box, and remove the driver if then unchecked.

Yes. I also confused. I have some driver. Ex. Fat-64.efi. Since i install MacOS, i never touch UEFI64 entry in clover package when install clover.

 

Process is not clean. It causes confusion. There are some driver after install clover like fat-64. But like slice said, some driver were automatically removed after install clover.

 

나의 LG-F800S 의 Tapatalk에서 보냄

[apianti]

It's /Library/Preferences/com.projectosx.clover.installer.plist.

 

Yeah I thought that there was a file record of what is installed. So everything should stay checked or unchecked....... But....

 

Yes. I also confused. I have some driver. Ex. Fat-64.efi. Since i install MacOS, i never touch UEFI64 entry in clover package when install clover.

 

Process is not clean. It causes confusion. There are some driver after install clover like fat-64. But like slice said, some driver were automatically removed after install clover.

 

나의 LG-F800S 의 Tapatalk에서 보냄

 

....Is there something in the package that is overwriting these stored options and always setting some to be checked, instead of only doing this when not already installed?

[Philip Petev]

Yeah, I wasted at least a few hours of my life determining why SL 10.6.8 failed to boot after installing the latest Clover.

I didn't see any reason to remove this efi driver as it is needed by Lion/SL (due to kexts being 32-bit/64-bit), so I reverted the change in my Clover build (I don't like breaking things that used to work for no good reason).

According to Slice, that driver has been made  optional and it exists in the Drivers64UEFI group menu. If you need it, you may select it for installation and the choice will be remembered in the Clover installer plist for the next install.

[Sherlocks]

Yeah I thought that there was a file record of what is installed. So everything should stay checked or unchecked....... But....

 

 

....Is there something in the package that is overwriting these stored options and always setting some to be checked, instead of only doing this when not already installed?

According to Slice, that driver has been made optional and it exists in the Drivers64UEFI group menu. If you need it, you may select it for installation and the choice will be remembered in the Clover installer plist for the next install.

0:147 0:000 === [ LoadDrivers ] =======================================

0:151 0:004 Loading apfs.efi status=Success

0:155 0:004 - driver needs connecting

0:155 0:000 Loading AppleImageCodec-64.efi status=Success

0:155 0:000 Loading AppleKeyAggregator-64.efi status=Success

0:155 0:000 Loading AppleUITheme-64.efi status=Success

0:155 0:000 Loading DataHubDxe-64.efi status=Success

0:156 0:000 Loading EmuVariableUefi-64.efi status=Success

0:158 0:001 EmuVariableUefi Initialize: VariableCommonInitialize = Success, orig services stored, install gEmuVariableControlProtocolGuid = Success

0:158 0:000 Loading Fat-64.efi status=Success

0:158 0:000 - driver needs connecting

0:158 0:000 Loading FirmwareVolume-64.efi status=Success

0:158 0:000 Loading FSInject-64.efi status=Success

0:158 0:000 Loading HFSPlus.efi status=Success

0:158 0:000 - driver needs connecting

0:158 0:000 Loading HPFanReset.efi status=Success

0:250 0:091 HPFanReset: successfully set fan control to BIOS mode.

0:250 0:000 Loading OsxFatBinaryDrv-64.efi status=Success

0:251 0:001 Loading SMCHelper-64.efi status=Success

0:253 0:001 Loading OsxAptioFixDrv-64.efi status=Success

0:254 0:001 3 drivers needs connecting ...

0:254 0:000 PlatformDriverOverrideProtocol not found. Installing ... Success

0:254 0:000 HFS+ driver loaded

0:254 0:000 APFS driver loaded

 

 

after install clover, there are fat-64, EmuVariableUefi-64.efi, etc. these files were unchecked in clover package default. i said that i never touch driver64uefi entry

why i still have these files exist in folder? why OsxFatBinaryDrv is not include this case? I don't understand clover package automatically remove only OsxFatBinaryDrv.

These files that i mentioned also optional efi files.

[apianti]

According to Slice, that driver has been made  optional and it exists in the Drivers64UEFI group menu. If you need it, you may select it for installation and the choice will be remembered in the Clover installer plist for the next install.

 

Not all the drivers are being removed if they are not checked, should they not be?

[chris1111]

latest Package Clover 4405 not mount EFI partition in Mac OS X  Snow Leopard

bellow 4398 is ok 

[Philip Petev]

Not all the drivers are being removed if they are not checked, should they not be?

From CloverPackage/package/Scripts.templates/EFIFolder/preinstall:

 

# Remove files of old revision.

pkgs=$(/usr/sbin/pkgutil --volume "$DEST_VOL" --pkgs | /usr/bin/grep -iE '@CLOVER_PACKAGE_IDENTITY@.' | /usr/bin/grep -Ev 'ntfs|apfs|hfsplus')

for pkg in $pkgs; do

    # Get where the files where installed from volume destination

    location=$(/usr/sbin/pkgutil --volume "$DEST_VOL" --pkg-info $pkg 2>/dev/null | sed -n 's/^location: *//p')

    pkgutil --volume "$DEST_VOL" --files $pkg 2>/dev/null  | \

     xargs -I @@ echo "$DEST_VOL/$location/@@"             | \

     /usr/bin/grep -iE 'EFI/CLOVER/(drivers\w+)/'   | \

     xargs -I @@ rm -rf '@@'

    rm -f "$DEST_VOL"/Library/Receipts/"$pkg".{plist,bom}

done

This part reads the receipts that contain Clover in its name, determines the files from each of them and deletes the files. That means all files, mentioned in those receipts, are going to be deleted, along with the receipts. After that, the package payload is being deployed and a new receipts are being created. The files that have been added manually like the filesystem drivers won't be removed and that's the only case of non-removed files. If you however uncheck any driver that have been checked before (and there is previous receipt for it), the current install will remove it.

[chris1111]

I have a question. If i select some uefi64 driver in clover package when install clover and installed clover. Next time, clover package again, clover package remember i selected uefi64 driver. If i want to cleanup option like after install fresh macos. Where is store that i selected option in MacOS partition?

 

Thanks in advance

 

나의 LG-F800S 의 Tapatalk에서 보냄

its store in Library /Preferances/com.projectosx.clover.installer.plist

[Philip Petev]

latest Package Clover 4405 not mount EFI partition in Mac OS X  Snow Leopard

bellow 4398 is ok

 

According to Micky1979 the partutil tool is 64 bit only and you should probably change the build settings for it and generate 32 bit binary.

[chris1111]

According to Micky1979 the partutil tool is 64 bit only and you should probably change the build settings for it and generate 32 bit binary.

OK Thanks

[apianti]

From CloverPackage/package/Scripts.templates/EFIFolder/preinstall:

This part reads the receipts that contain Clover in its name, determines the files from each of them and deletes the files. That means all files, mentioned in those receipts, are going to be deleted, along with the receipts. After that, the package payload is being deployed and a new receipts are being created. The files that have been added manually like the filesystem drivers won't be removed and that's the only case of non-removed files. If you however uncheck any driver that have been checked before (and there is previous receipt for it), the current install will remove it.

 

I'm not sure that works 100%. I looked at that, I wonder what the output of each of those commands is, and if it truly removes everything installed before.