Clover General discussion

Micky1979 · February 18, 2017

Is this open source?

Even if could be, this app use a payed developer id certificate (valid until 2025) to do some privileged tasks and building it will break Clover compilation or anyway a long long and complicate setup to be done, but even after this the Helper Tools that the app installs can have a different code signature if builted by another person, causing it to not be usable. So let other peoples doing that is dangerous and useless, and for most w/o nvram because not saved.

smolderas · February 18, 2017

Even if could be, this app use a payed developer id certificate (valid until 2025) to do some privileged tasks and building it will break Clover compilation or anyway a long long and complicate setup to be done, but even after this the Helper Tools that the app installs can have a different code signature if builted by another person, causing it to not be usable. So let other peoples doing that is dangerous and useless, and for most w/o nvram because not saved.

Why are you assuming that others don't have a payed developer ID. I just don't want to run a closed source software on my system and therefore my question, hence I'm interested in what you(r software) promise...

A simple "no" would have been enough

Micky1979 · February 18, 2017

Good luck than using opensource softwares in OSX

Slice · February 20, 2017

You can : NVRAM Dumper Pro.app_v1.0_(beta).zip

It's a top-bar app that cost 0 resources to the System , and is configurable.

By default, the first time you use it, detect if you have real NVRAM support and deactivate the dump on disk, otherwise marked as active (you can rearm it). Under its settings you can set also a different file name and if you want to save to a subdirectory:

nvram.png

By default, if fields are empty, save nvram.plist to the root of the boot partition;

if for some reason the boot partition is no longer available (a USB stick ejected?) dump nvram to the ESP and if the current OS is running on a logical volume open the ESP on the physical disk and save it there. If no ESPs are available it save to "/".

I think can be an alternative to 80.save_nvram_plist.local.

Yep, you can dump nvram also when the System goes to sleep (is an option in the settings) and as I said you can try by specifying another file name.

P.S. support 10.7+ and in yosemite + follow the dark theme of the system, if set, automatically. Retina display support.

Tested in El Capitan and Sierra, not in old ones, but I will do it shortly (is beta)

P.S.2 obviously shows you the contents of the NVRAM

Test in 10.7.5

Slice · February 21, 2017

You can : NVRAM Dumper Pro.app_v1.0_(beta).zip

Hi, Micky1979

It works in Sierra without problem but my new computer can't sleep and I can't test the main function.

Tell me, please, can it save variables with other GUID? For example

8BE4DF61-93CA-11D2-AA0D-00E098032B8C:Boot0082

It is produces by macOS only when going to hibernatesleep and used to perform hibernation.

Micky1979 · February 21, 2017

Hi, Micky1979

It works in Sierra without problem but my new computer can't sleep and I can't test the main function.

Tell me, please, can it save variables with other GUID? For example

8BE4DF61-93CA-11D2-AA0D-00E098032B8C:Boot0082

It is produces by macOS only when going to hibernatesleep and used to perform hibernation.

Fixed the error in my PC where I have Mac OS 10.7.5, but now I have to see if the file is correctly saved.. after a wake from sleep I'll tell you, otherwise some minutes.

The app can add all GUIDs you want, and I can make this conditional if the booter is Clover and if we are shoutting down/restaring or sleeping. Also I can add/remove stuff if the pc is waking up.. just tell me.

See you after my testing

EDIT

What is 'BootNext', and what the value for 'Boot0082' ? they appear to be hex data..

Slice · February 21, 2017

Fixed the error in my PC where I have Mac OS 10.7.5, but now I have to see if the file is correctly saved.. after a wake from sleep I'll tell you, otherwise some minutes.

The app can add all GUIDs you want, and I can make this conditional if the booter is Clover and if we are shoutting down/restaring or sleeping. Also I can add/remove stuff if the pc is waking up.. just tell me.

See you after my testing

EDIT

What is 'BootNext', and what the value for 'Boot0082' ? they appear to be hex data..

From Clover investigations

/*
    Variable NV+RT+BS '7C436110-AB2A-4BBB-A880-FE41995C9F82:boot-image' DataSize = 0x3A
    00000000: 02 01 0C 00 D0 41 03 0A-00 00 00 00 01 01 06 00  *.....A..........*
    00000010: 02 1F 03 12 0A 00 00 00-00 00 00 00 04 04 1A 00  *................*
    00000020: 33 00 36 00 63 00 34 00-64 00 64 00 63 00 30 00  *3.6.c.4.d.d.c.0.*
    00000030: 30 00 30 00 00 00 7F FF-04 00                    *0.0.......*
     02 - ACPI_DEVICE_PATH
     01 - ACPI_DP
     0C - 4 bytes
     00 D0 41 03 - PNP0A03
     
 // FileVault2
  4:609  0:000      Boot0082 points to Volume with UUID:BA92975E-E2FB-48E6-95CC-8138B286F646
  4:609  0:000      boot-image before: PciRoot(0x0)\Pci(0x1F,0x2)\Sata(0x5,0x0,0x0)\25593c7000:A82E84C6-9DD6-49D6-960A-0F4C2FE4851C
*/

Micky1979 · February 22, 2017

From Clover investigations

/*
    Variable NV+RT+BS '7C436110-AB2A-4BBB-A880-FE41995C9F82:boot-image' DataSize = 0x3A
    00000000: 02 01 0C 00 D0 41 03 0A-00 00 00 00 01 01 06 00  *.....A..........*
    00000010: 02 1F 03 12 0A 00 00 00-00 00 00 00 04 04 1A 00  *................*
    00000020: 33 00 36 00 63 00 34 00-64 00 64 00 63 00 30 00  *3.6.c.4.d.d.c.0.*
    00000030: 30 00 30 00 00 00 7F FF-04 00                    *0.0.......*
     02 - ACPI_DEVICE_PATH
     01 - ACPI_DP
     0C - 4 bytes
     00 D0 41 03 - PNP0A03
     
 // FileVault2
  4:609  0:000      Boot0082 points to Volume with UUID:BA92975E-E2FB-48E6-95CC-8138B286F646
  4:609  0:000      boot-image before: PciRoot(0x0)\Pci(0x1F,0x2)\Sata(0x5,0x0,0x0)\25593c7000:A82E84C6-9DD6-49D6-960A-0F4C2FE4851C
*/

Ok, fixed and tested in 10.7.5, plus I've added the possibility of adding custom keys while dumping the nvram:

You can add what you like with Data, String and Number tags. Like a plist Data tag must contains a valid hex datas, Number means integers (floats/double are converted to max 32 bit int). String can be what you like. If you type invalid characters for Data/Numbers, the app will continue beebing until you fix it. Keys with lenght 0 will not be saved.

Actually there's no check for duplicate keys, so in the case, the higer index is what will finish to nvram.plist.

This is a new version and the first time will require to reinstall the helper tool, and you have to restart the app manually (later will be sutomatic). Before try this new one uncheck "run at login" from the old one, otherwise you will have two apps loaded..

NVRAM Dumper Pro.app_v1.1_(beta1).zip

Zenith432 · February 22, 2017

FYI this EDK2 commit breaks the Clover build

Below is a patch to edk2 tree to revert it

diff --git a/BaseTools/Source/Python/Workspace/MetaFileParser.py b/BaseTools/Source/Python/Workspace/MetaFileParser.py
index 37a7f5d..da525bb 100644
--- a/BaseTools/Source/Python/Workspace/MetaFileParser.py
+++ b/BaseTools/Source/Python/Workspace/MetaFileParser.py
@@ -351,13 +351,6 @@ class MetaFileParser(object):
 
         self._ValueList = [ReplaceMacro(Value, self._Macros) for Value in self._ValueList]
         Name, Value = self._ValueList[1], self._ValueList[2]
-        MacroUsed = GlobalData.gMacroRefPattern.findall(Value)
-        if len(MacroUsed) != 0:
-            for Macro in MacroUsed:
-                if Macro in GlobalData.gGlobalDefines:
-                    EdkLogger.error("Parser", FORMAT_INVALID, "Global macro %s is not permitted." % (Macro), ExtraData=self._CurrentLine, File=self.MetaFile, Line=self._LineIndex + 1)
-            else:
-                EdkLogger.error("Parser", FORMAT_INVALID, "%s not defined" % (Macro), ExtraData=self._CurrentLine, File=self.MetaFile, Line=self._LineIndex + 1)
         # Sometimes, we need to make differences between EDK and EDK2 modules 
         if Name == 'INF_VERSION':
             if re.match(r'0[xX][\da-f-A-F]{5,8}', Value):
diff --git a/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py b/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py
index 0686721..dbe2986 100644
--- a/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py
+++ b/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py
@@ -1830,8 +1830,6 @@ class InfBuildData(ModuleBuildClassObject):
             if self.AutoGenVersion < 0x00010005:
                 self.__Macros.update(GlobalData.gEdkGlobal)
                 self.__Macros.update(GlobalData.gGlobalDefines)
-            else:
-                self.__Macros.update(self.Defines)
         return self.__Macros
 
     ## Get architecture

Slice · February 22, 2017

FYI this EDK2 commit breaks the Clover build

Below is a patch to edk2 tree to revert it

diff --git a/BaseTools/Source/Python/Workspace/MetaFileParser.py b/BaseTools/Source/Python/Workspace/MetaFileParser.py
index 37a7f5d..da525bb 100644
--- a/BaseTools/Source/Python/Workspace/MetaFileParser.py
+++ b/BaseTools/Source/Python/Workspace/MetaFileParser.py
@@ -351,13 +351,6 @@ class MetaFileParser(object):
 
         self._ValueList = [ReplaceMacro(Value, self._Macros) for Value in self._ValueList]
         Name, Value = self._ValueList[1], self._ValueList[2]
-        MacroUsed = GlobalData.gMacroRefPattern.findall(Value)
-        if len(MacroUsed) != 0:
-            for Macro in MacroUsed:
-                if Macro in GlobalData.gGlobalDefines:
-                    EdkLogger.error("Parser", FORMAT_INVALID, "Global macro %s is not permitted." % (Macro), ExtraData=self._CurrentLine, File=self.MetaFile, Line=self._LineIndex + 1)
-            else:
-                EdkLogger.error("Parser", FORMAT_INVALID, "%s not defined" % (Macro), ExtraData=self._CurrentLine, File=self.MetaFile, Line=self._LineIndex + 1)
         # Sometimes, we need to make differences between EDK and EDK2 modules 
         if Name == 'INF_VERSION':
             if re.match(r'0[xX][\da-f-A-F]{5,8}', Value):
diff --git a/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py b/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py
index 0686721..dbe2986 100644
--- a/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py
+++ b/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py
@@ -1830,8 +1830,6 @@ class InfBuildData(ModuleBuildClassObject):
             if self.AutoGenVersion < 0x00010005:
                 self.__Macros.update(GlobalData.gEdkGlobal)
                 self.__Macros.update(GlobalData.gGlobalDefines)
-            else:
-                self.__Macros.update(self.Defines)
         return self.__Macros
 
     ## Get architecture

Include it into patches_for_EDK2?

mhaeuser · February 22, 2017

Include it into patches_for_EDK2?

You could also fix your code base...

Zenith432 · February 22, 2017

Good luck figuring out how... I tried and gave up - reverted the EDK2 change instead.

You could also fix your code base...

Philip Petev · February 22, 2017

@Slice @syscl, there is still problem with the latest 80.save_nvram_plist.local 1.15. On my desktop, except touching the .metadata_never_index file in EFI, it creates one at the root folder as well.

Sherlocks · February 22, 2017

@Slice @syscl, there is still problem with the latest 80.save_nvram_plist.local 1.15. On my desktop, except touching the .metadata_never_index file in EFI, it creates one at the root folder as well.

Good report. I also reported other issue.

1.5 still has issues. Spin wait and metadata never index can't help failure case in my case and your case.

I will report it to syscl.

Now, he is busy. Because he has exams.

Thank you

나의 LG-F410S 의 Tapatalk에서 보냄

Slice · February 23, 2017

Ok, fixed and tested in 10.7.5, plus I've added the possibility of adding custom keys while dumping the nvram:

beta1.png

You can add what you like with Data, String and Number tags. Like a plist Data tag must contains a valid hex datas, Number means integers (floats/double are converted to max 32 bit int). String can be what you like. If you type invalid characters for Data/Numbers, the app will continue beebing until you fix it. Keys with lenght 0 will not be saved.

Actually there's no check for duplicate keys, so in the case, the higer index is what will finish to nvram.plist.

This is a new version and the first time will require to reinstall the helper tool, and you have to restart the app manually (later will be sutomatic). Before try this new one uncheck "run at login" from the old one, otherwise you will have two apps loaded..

Tested with sleep to hibernatemode 25.

Yes, there is boot0082 saved!

	<key>8BE4DF61-93CA-11D2-AA0D-00E098032B8C:Boot0082</key>
	<string></string>

This is the great application in this case!

Micky1979 · February 23, 2017

Thanks , small bugs typing strings, but I'll fix it soon.

Slice · February 23, 2017

But why I see no decryption key? The application works before it set?

And boot0082 is fake

42:436  0:003  DeleteBootOption: Boot0082
42:440  0:003   Error del. variable: Boot0082 = Not Found
42:451  0:010  Options 0082 was not deleted: Not Found

Micky1979 · February 23, 2017

Hi Slice. Sorry really short time now, but with a quick look at the source I've lost where Clover handles the separator ':', can be this the problem?

Zenith432 · February 23, 2017

The part that couldn't be adapted to in WorkspaceDatabase.py was a regression. It's now been fixed in this commit.

Good luck figuring out how... I tried and gave up - reverted the EDK2 change instead.

randombrain · February 23, 2017

I have poor references about that sorry, except some from xnu/macosxbootloader/chameleon/revoboot which still counfusing. You may want to read what people talk earlier in this thread. Clover appear to have new settings under "BootGraphics". Have you tried it? They store "UIScale" value into nvram like described in this blog.

Thank you—

I tried compiling that person's EFI script (ended up having to install an Ubuntu VM, because I could not get it to work in OS X). Unfortunately the script does not work for me; I tried adding some "debug" printout lines but I don't see an easy fix. (A simple "Hello, world" EFI script does work.)

Do you know how I can manipulate Clover BootGraphics settings instead? Would I have to edit Settings.c and build the entire Clover package locally?

gujiangjiang · February 23, 2017

My xps 15 9550 have suffered from OSXAptioFixDrv2 and i tried many ways but no use.

Type       Start            End              # Pages          AttributesRT_Data    0000000000000000-0000000000000FFF 0000000000000001 800000000000000FAvailable  0000000000001000-0000000000057FFF 0000000000000057 000000000000000FReserved   0000000000058000-0000000000058FFF 0000000000000001 000000000000000F Available  0000000000059000-000000000009CFFF 0000000000000044 000000000000000FReserved   000000000009D000-000000000009EFFF 0000000000000002 000000000000000FRT_Data    000000000009F000-000000000009FFFF 0000000000000001 800000000000000FAvailable  0000000000100000-000000000421BFFF 000000000000411C 000000000000000F BS_Data    000000000421C000-000000000425BFFF 0000000000000040 000000000000000FAvailable  000000000425C000-0000000021D53FFF 000000000001DAF8 000000000000000F 32 270LoaderCode 0000000021D54000-0000000021EEAFFF 0000000000000197 000000000000000FACPI_Recl  0000000021EEB000-0000000021F1CFFF 0000000000000032 000000000000000FBS_Data    0000000021F1D000-0000000023970FFF 0000000000001A54 000000000000000FACPI_NVS   0000000023971000-0000000023971FFF 0000000000000001 000000000000000FRT_Data    0000000023972000-00000000239BBFFF 000000000000004A 800000000000000FBS_Data    00000000239BC000-0000000023A12FFF 0000000000000057 000000000000000FRT_Data    0000000023A13000-0000000024203FFF 00000000000007F1 800000000000000FBS_Data    0000000024204000-000000002420BFFF 0000000000000008 000000000000000FAvailable  000000002420C000-000000003128AFFF 000000000000D07F 000000000000000F 288 392BS_Data    000000003128B000-0000000036A89FFF 00000000000057FF 000000000000000FAvailable  0000000036A8A000-0000000036C2FFFF 00000000000001A6 000000000000000F 436 437BS_Code    0000000036C30000-0000000037298FFF 0000000000000669 000000000000000FReserved   0000000037299000-0000000037645FFF 00000000000003AD 000000000000000FACPI_Recl  0000000037646000-0000000037667FFF 0000000000000022 000000000000000FAvailable  0000000037668000-0000000037CB9FFF 0000000000000652 000000000000000F 442 445ACPI_NVS   0000000037CBA000-000000003800EFFF 0000000000000355 000000000000000FRT_Data    000000003800F000-000000003A48BFFF 000000000000247D 800000000000000FRT_Code    000000003A48C000-000000003A4FEFFF 0000000000000073 800000000000000FBS_Data    000000003A4FF000-000000003A4FFFFF 0000000000000001 000000000000000FAvailable  0000000100000000-00000004BDFFFFFF 00000000003BE000 000000000000000F 2047 9711Reserved   000000003A500000-000000003A5FFFFF 0000000000000100 0000000000000000MMIO       00000000E0000000-00000000EFFFFFFF 0000000000010000 8000000000000001MMIO       00000000FE000000-00000000FE010FFF 0000000000000011 8000000000000001MMIO       00000000FEC00000-00000000FEC00FFF 0000000000000001 8000000000000001MMIO       00000000FEE00000-00000000FEE00FFF 0000000000000001 8000000000000001MMIO       00000000FF000000-00000000FFFFFFFF 0000000000001000 8000000000000001   Reserved  :          1,200 Pages (4,915,200 Bytes)  LoaderCode:            407 Pages (1,667,072 Bytes)  LoaderData:              0 Pages (0 Bytes)  BS_Code   :          1,641 Pages (6,721,536 Bytes)  BS_Data   :         29,427 Pages (120,532,992 Bytes)  RT_Code   :            115 Pages (471,040 Bytes)  RT_Data   :         11,450 Pages (46,899,200 Bytes)  ACPI_Recl :             84 Pages (344,064 Bytes)  ACPI_NVS  :            854 Pages (3,497,984 Bytes)  MMIO      :         69,651 Pages (285,290,496 Bytes)  MMIO_Port :              0 Pages (0 Bytes)  PalCode   :              0 Pages (0 Bytes)  Available :      4,117,798 Pages (16,866,500,608 Bytes)  Persistent:              0 Pages (0 Bytes)              -------------- Total Memory:         16,256 MB (17,046,634,496 Bytes)

Here is my memmap from uefishell command "memmap > mem.txt" and i have get all the Available slide data such as 32,270 and so on,

I have tried all this data "32 270 288 392 436 437 442 445 2047 9711"but still can't boot into the osx and saying "Error allocating xxxx pages at xxxxx".

I have also tried to delete all the kext expect fakesmc.kext but still same error.

Then i tried to delete the addtional efi drivers such as DataHub.efi but still same error.

I want to know does any other problem can cause this allocating error happen?

Edit1:I have tried this files with slide=0 and can boot into the osx fine.

https://sourceforge.net/p/cloverefiboot/tickets/125/#fd2c/6d91/539a

I noticed the h4x said "I merged test2.efi into OsxAptioFix2Drv.efi. You can delete ALL aptio fixes, test2.efi, and even LowMemFix and place this binary in your driverUEFI64 folder and have a try."

So does this problem can be sloved by this way?

Edit2:I found a solution here with edited OsxLowMemFixDrv-64.efi together with OSXAptioFixDrv2 and add "slide=32"and boot fine with no error.

https://nickwoodhams.com/x99-hackintosh-solving-osxaptiofixdrv-allocaterelocblock-can-not-allocate-relocation-block/

What I needed to do was recompile Clover from source with an edited OsxLowMemFixDrv-64.efi memory allocation file. I then included that file along with the regular OsxAptioFixDrv2-64.efi file in the /EFI/ClOVER/drivers64UEFIfolder.

Changes to OsxLowMemFixDrv-64.efi were simply editing 0x10000000 to 0x20000000.

The way it works is that it loads the edited OsxLowMemFixDrv-64.efi file first and wipes out the entire memory allocation table up to 0x20000000. I renamed the recompiled version to Test2.efi to avoid the confusion.

So i use OsxAptioFixDrv2-64.efi from clover4012 and modified Test2.efi together and use "slide=32"and boot fine with no error.

But i use OsxAptioFixDrv2-64.efi and OsxLowMemFixDrv-64.efi together from clover4012 and use "slide=32" and boot with error.

I think this can be commit to clover or just commit to OsxLowMemFixDrv-64.efi with 0x40000000 or higher instead of 0x10000000 just like the Test2.efi because the 0x10000000 or 0x20000000 is small with the latest macOS.

Thanks slice.

JahStories · February 23, 2017

Hi there folks, just wanted to report a problem with patching on Clover, while some patches works right away, some others don't....

Here the description of the issue happening for me on two kexts on two different systems:

The AGDP Patch that "don't disable GFX0" when using MacPro Smbios, this one:

AppleGraphicsDevicePolicy Find: 626F6172642D6964 Replace:626F6172642D6978

Does not apply, but after editing the binary manually and installing the kexts doing a reboot and reinstalling the original, the patch works!

The same thing happens when using the Disable minStolenSize less or equal fStolenMemorySize assertion 10.12 patch:

AppleIntelSKLGraphicsFramebuffer Find: 8945C839C67651 Replace: 8945C839C6EB51

Why is this happening?

I understand is a cache problem but is there a solution?

Hoping to be helpful somehow!

THX

cecekpawon · February 23, 2017

@Zenith Did you get any other error like: 'error 3000: Global macro ARCH is not permitted' since that commit?

@randombrain You can try this wrapper & discuss there, or by following this steps?

Zenith432 · February 23, 2017

@Zenith Did you get any other error like: 'error 3000: Global macro ARCH is not permitted' since that commit

Yes. There were 2 problems with edk2 commit dc4c77

Get error "global macro arch is not permitted' in refit.inf. This is result of change in MetaFileParser.py. Can fix this by either using reversion checked in by Slice, or as Fritz suggested - edit refit.inf and change CLOVER$(ARCH) to just CLOVER.
The change in WorkspaceDatabase.py caused unfixable breakdown - a regression in edk2 build process. It was fixed by edk2 commit 1d8ceb. So after 1d8ceb, it is possible to use WorkspaceDatabase.py from edk2 tree or the reversion checked in by Slice.

Hope this clarifies.

frankiee · February 23, 2017

My xps 15 9550 have suffered from OSXAptioFixDrv2 and i tried many ways but no use.

Reminds me of a similar problem I had. I always had KPs after wake and reboot (with type 14 page fault errors). At first I thought it was bad RAM, but that wasn't the case. My solution back then was to use a recompiled AptioFixDrv (not "2") with increased memory allocation. Curiously, with my current clover version (3961) the problem has apparently vanished - but I also changed my GPU in the meantime so I am not 100% sure what exactly fixed that problem. But it seems that maybe PCI configuration (i.e. how many and which cards you have installed and maybe also in which slots they reside) might play a role here.

Clover General discussion

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites