Jump to content
2189 posts in this topic

Recommended Posts

3 minutes ago, Sherlocks said:

 

thanks. can you cleanup platformdata for future with maintenance?

for example

https://sourceforge.net/p/cloverefiboot/code/HEAD/tree/rEFIt_UEFI/Platform/platformdata.c#l223

{ 0x02, 0x45, 0x0f, 0, 0, 0x00 }, "2018mbp", "j680", 0xf0a009 }, // there are no BIOS REV rBR EPCI

to

NULL, NULL, "j680", NULL },

 

if has smc3, don't add it blow

https://sourceforge.net/p/cloverefiboot/code/HEAD/tree/rEFIt_UEFI/Platform/DataHubCpu.c#l458

https://sourceforge.net/p/cloverefiboot/code/HEAD/tree/rEFIt_UEFI/Platform/DataHubCpu.c#l467

Do you mean in Clover or somewhere in the IO registry?

Do you mean in Clover or somewhere in the IO registry?
probably both or not.
mbp15,1 and 15,2 and etc of smc3 model in clover have dummy key now(rev, epci, pbr).
we need to cleaup these values.
if there is no key, dont add or override this key(anyway you already done but seems now clover always attempt to override key)

나의 SM-N960N 의 Tapatalk에서 보냄

11 minutes ago, Sherlocks said:

i just mentioned platformdata.c and datahubcpu.c

May be I don't understand. Do you need a code to know when Clover should not inject these keys? Because I have questions as well:

  1. Will older OSes run without these keys in involved models?
  2. If yes, why just don't remove them completely?
  3. If not, what's the problem? No OS version when DataHub runs?

?

Edited by vector sigma
  • Like 1
May be I don't understand. Do you need a code to know when Clover should not inject these keys? Because I have questions as well:
  1. Will older OSes run without these keys?
  2. If yes, why just don't remove them completely?
  3. If not, what's the problem? No OS version when DataHub runs?
?
ofc old models(except smc3 models) need rev and pbr and epci.

we just consider smc3 models.
look here
https://sourceforge.net/p/cloverefiboot/code/HEAD/tree/rEFIt_UEFI/Platform/platformdata.c#l279

macbookair8,1 of clover platformdata has dummy rev from other old macbookair model. no need it on macbookair8,1.
we change dummy key to NULL or Blank or etc that you want to cleanup source and data.

then, rev has NULL and or Blank or etc, no need add or override rev values in Datahubcpu.c. in this cases, only smc3.


나의 SM-N960N 의 Tapatalk에서 보냄

29 minutes ago, Sherlocks said:

macbookair8,1 of clover platformdata has dummy rev from other old macbookair model. no need it on macbookair8,1.

Real sorry, don't think I'm completely stupid :blush:, but, unless you are unable to reach the repository for unknown reasons to me, and  just put nr 5 NULL in platformdata.c ...... are you asking me to change them and do a commit?

... I need to checkout Clover as I don't have it right now....:blush:

 

Edited by vector sigma
  • Like 1
Real sorry, don't think I'm completely stupid :blush:, but, unless you are unable to reach the repository for unknown reasons to me, and  just put nr 5 NULL in platformdata.c ...... are you asking me to change them and do a commit?
... I need to checkout Clover as I don't have it right now....:blush:
 
okay. i just asked you who completed smc3 patch in FakeSMC to cleanup source.

나의 SM-N960N 의 Tapatalk에서 보냄

10 hours ago, vector sigma said:

May be I don't understand. Do you need a code to know when Clover should not inject these keys? Because I have questions as well:

  1. Will older OSes run without these keys in involved models?
  2. If yes, why just don't remove them completely?
  3. If not, what's the problem? No OS version when DataHub runs?

?

1.2. Older OS with older models need these keys.

3. No problem at all. Cosmetic changes.

  • Like 4

Suppose you have this controller with an input pin where you expected to see an ambient temperature value.

To do this you have to be sure there is an thermodiod which actually measures the temperature of environment and is connected to this input pin. I am not sure if the thermodiod exists.

  • Like 1
40 minutes ago, Slice said:

Suppose you have this controller with an input pin where you expected to see an ambient temperature value.

To do this you have to be sure there is an thermodiod which actually measures the temperature of environment and is connected to this input pin. I am not sure if the thermodiod exists.

Existence before sleep, loss after awakening.

 

There were no problems in earlier versions.

Edited by jinbingmao
×
×
  • Create New...