Clover General discussion

chris1111 · May 1, 2022

20 minutes ago, Matgen84 said:
Hi @Slice

Maybe I find the issue: when I build Clover, at the same time I build CloverConfigPlistValidator before make the PKG.

Strangely, I can't build CloverConfigPlistValidator :
[XCODE]
- Building ccpv and archive
** BUILD FAILED **


The following build commands failed:
	CompileC /Users/mathieu/src/Cloverbootloader/Xcode/CloverConfigPlistValidator/build/CloverConfigPlistValidator.build/Release/CloverConfigPlistValidator.build/Objects-normal/x86_64/Config_GUI.o /Users/mathieu/src/Cloverbootloader/rEFIt_UEFI/Settings/ConfigPlist/Config_GUI.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
I mistaken somewhere ? Before all work fine.

EDIT
Same issue with Buildme script: can't build CloverConfigPlistValidator.

CCPV OutPut 7.5 kB · 0 downloads

Same here Build failled

MifJpnAlphaPlus · May 1, 2022

Hello.

After booting, I was told that there was a problem with my computer, I entered the setting Apple ID again and noticed the following.

Part of the interpretation of System-ID is as if it were little-endian.

Please help me.

Thank you.

Matgen84 · May 1, 2022

34 minutes ago, MifJpnAlphaPlus said:

Hello.

After booting, I was told that there was a problem with my computer, I entered the setting Apple ID again and noticed the following.

Part of the interpretation of System-ID is as if it were little-endian.

Please help me.

Thank you.

Which r5146 commit to use !

Just a opinion. Maybe it's related to commit 1ea4700b or I mistake, so I'm sorry. 😪

Edited May 1, 2022 by Matgen84

Slice · May 1, 2022

2 hours ago, MifJpnAlphaPlus said:

Hello.

After booting, I was told that there was a problem with my computer, I entered the setting Apple ID again and noticed the following.

Part of the interpretation of System-ID is as if it were little-endian.

Please help me.

Thank you.

Please remember if it was otherwise with Clover-5146 release.

MifJpnAlphaPlus · May 1, 2022

1 hour ago, Slice said:

Please remember if it was otherwise with Clover-5146 release.

Thank you very much for your prompt reply.

I am very sorry for the inconvenience.

To tell you the truth
I don't know what you mean, and I am a little emotionally unstable mentally.

Apparently, others are not... If so, it is a very strange phenomenon.

I don't know about the cause, but I do know that it can be set up to be the same as before.

Anyway, I will get over my anxiety and move on.

Thank you so much for your help.

chris1111 · May 1, 2022

@Slice the workflows here https://github.com/CloverHackyColor/OpenCorePkg/tree/master/.github/workflows is not use by Clover

It is completetly useless I think, thats why we have a X on every commits; the workflow always faiiled !

I don't know if this has any effect on opencore not being embed correctly?

Edited May 1, 2022 by chris1111
I don't know

tluck · May 2, 2022

13 hours ago, MifJpnAlphaPlus said:

Hello.

After booting, I was told that there was a problem with my computer, I entered the setting Apple ID again and noticed the following.

Part of the interpretation of System-ID is as if it were little-endian.

Please help me.

Thank you.

i had the same thing happen - using the most recent 5146 (after fixing the OC integration)

Slice · May 2, 2022

1 hour ago, tluck said:

i had the same thing happen - using the most recent 5146 (after fixing the OC integration)

Tell me something more. Is there system-id changed after changing the Clover version?

MifJpnAlphaPlus · May 2, 2022

On 5/1/2022 at 10:25 PM, Matgen84 said:
Hi @Slice

Maybe I find the issue: when I build Clover, at the same time I build CloverConfigPlistValidator before make the PKG.

Strangely, I can't build CloverConfigPlistValidator :
[XCODE]
- Building ccpv and archive
** BUILD FAILED **


The following build commands failed:
	CompileC /Users/mathieu/src/Cloverbootloader/Xcode/CloverConfigPlistValidator/build/CloverConfigPlistValidator.build/Release/CloverConfigPlistValidator.build/Objects-normal/x86_64/Config_GUI.o /Users/mathieu/src/Cloverbootloader/rEFIt_UEFI/Settings/ConfigPlist/Config_GUI.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
I mistaken somewhere ? Before all work fine.

EDIT
Same issue with Buildme script: can't build CloverConfigPlistValidator.

CCPV OutPut 7.5 kB · 1 download

Me too

Spoiler

alpha@iMac CloverBootloader % ./buildme

 ------------------------------------------------------------------------------
                          🍀 Clover r5146 (SHA: b8c935a64)
              TOOLCHAIN: GCC53 (override example: './buildme XCODE8')
 ------------------------------------------------------------------------------









1) build Clover				 9) test Clover
2) update Clover			10) check status
3) build Clover with HFSPlus		11) show diff
4) make pkg				12) open CloverV2/EFI/CLOVER directory
5) make iso				13) update Clover (reset changes)
6) make app				14) clean BaseTools
7) build all				15) Utilities
8) make Release				16) quit

Please enter your choice: 15

 ------------------------------------------------------------------------------
                          🍀 Clover r5146 (SHA: b8c935a64)
                                  External Utilities 
 ------------------------------------------------------------------------------









1) Get CloverConfigPlistValidator	   	 9) Get SSDTTime
2) Get PlistEDPlus				10) Get USBMap
3) Get Hackintool				11) Get QtiASL
4) Get BitmaskDecode				12) Get CsrDecode
5) Get MaciASL					13) Get gibMacOS
6) Get dmidecode				14) Get mountR/W
7) Get IOReg-Devices				15) back to buildme
8) Get NativeDisplayBrightness			16) quit

Files will be put on Desktop/ClovUtils: 1
[CHECK XCODE]
In file included from /Users/alpha/CloverBootloader/rEFIt_UEFI/Platform/Utils.cpp:24:
In file included from /Users/alpha/CloverBootloader/rEFIT_UEFI/include/Efi.h:13:
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:16:7: error: 
      definition of type 'GUID' conflicts with typedef of the same name
class GUID;
      ^
In file included from <built-in>:1:
In file included from /Users/alpha/CloverBootloader/rEFIT_UEFI/PlatformPOSIX/include/Platform.h:42:
In file included from /Users/alpha/CloverBootloader/MdePkg/Include/Uefi.h:26:
In file included from /Users/alpha/CloverBootloader/MdePkg/Include/Uefi/UefiBaseType.h:20:
/Users/alpha/CloverBootloader/PosixCompilation/UefiMock/Base.h:228:3: note: 
      'GUID' declared here
} GUID;
  ^
In file included from /Users/alpha/CloverBootloader/rEFIt_UEFI/Platform/Utils.cpp:24:
In file included from /Users/alpha/CloverBootloader/rEFIT_UEFI/include/Efi.h:13:
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:18:9: warning: 
      'CONST_EFI_GUID_PTR_T' macro redefined [-Wmacro-redefined]
#define CONST_EFI_GUID_PTR_T  const EFI_GUID&
        ^
In file included from <built-in>:1:
In file included from /Users/alpha/CloverBootloader/rEFIT_UEFI/PlatformPOSIX/include/Platform.h:42:
In file included from /Users/alpha/CloverBootloader/MdePkg/Include/Uefi.h:26:
In file included from /Users/alpha/CloverBootloader/MdePkg/Include/Uefi/UefiBaseType.h:20:
/Users/alpha/CloverBootloader/PosixCompilation/UefiMock/Base.h:230:9: note: 
      previous definition is here
#define CONST_EFI_GUID_PTR_T  IN CONST EFI_GUID*
        ^
In file included from /Users/alpha/CloverBootloader/rEFIt_UEFI/Platform/Utils.cpp:24:
In file included from /Users/alpha/CloverBootloader/rEFIT_UEFI/include/Efi.h:13:
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:19:9: warning: 
      'JCONST_EFI_GUID_PTR_T' macro redefined [-Wmacro-redefined]
#define JCONST_EFI_GUID_PTR_T  const EFI_GUID&
        ^
In file included from <built-in>:1:
In file included from /Users/alpha/CloverBootloader/rEFIT_UEFI/PlatformPOSIX/include/Platform.h:42:
In file included from /Users/alpha/CloverBootloader/MdePkg/Include/Uefi.h:26:
In file included from /Users/alpha/CloverBootloader/MdePkg/Include/Uefi/UefiBaseType.h:20:
/Users/alpha/CloverBootloader/PosixCompilation/UefiMock/Base.h:231:9: note: 
      previous definition is here
#define JCONST_EFI_GUID_PTR_T  IN JCONST EFI_GUID*
        ^
In file included from /Users/alpha/CloverBootloader/rEFIt_UEFI/Platform/Utils.cpp:24:
In file included from /Users/alpha/CloverBootloader/rEFIT_UEFI/include/Efi.h:13:
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:51:7: error: 
      definition of type 'GUID' conflicts with typedef of the same name
class GUID
      ^
In file included from <built-in>:1:
In file included from /Users/alpha/CloverBootloader/rEFIT_UEFI/PlatformPOSIX/include/Platform.h:42:
In file included from /Users/alpha/CloverBootloader/MdePkg/Include/Uefi.h:26:
In file included from /Users/alpha/CloverBootloader/MdePkg/Include/Uefi/UefiBaseType.h:20:
/Users/alpha/CloverBootloader/PosixCompilation/UefiMock/Base.h:228:3: note: 
      'GUID' declared here
} GUID;
  ^
In file included from /Users/alpha/CloverBootloader/rEFIt_UEFI/Platform/Utils.cpp:24:
In file included from /Users/alpha/CloverBootloader/rEFIT_UEFI/include/Efi.h:13:
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:393:72: error: 
      no member named 'long_guid_form_length' in 'GUID'
  ...== GUID::long_guid_form_length && (str[0] != '{' || str[GUID::long_guid_...
                                                             ~~~~~~^
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:393:19: error: 
      no member named 'long_guid_form_length' in 'GUID'
    : (N == GUID::long_guid_form_length && (str[0] != '{' || str[GUID::l...
            ~~~~~~^
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:394:13: error: 
      no member named 'parse_guid_error2' in 'GUID'
    ? GUID::parse_guid_error2()
      ~~~~~~^
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:395:13: error: 
      no member named 'parse_guid' in 'GUID'
    : GUID::parse_guid(str + (N == GUID::long_guid_form_length ? 1 : 0));
      ~~~~~~^
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:395:42: error: 
      no member named 'long_guid_form_length' in 'GUID'
    : GUID::parse_guid(str + (N == GUID::long_guid_form_length ? 1 : 0));
                                   ~~~~~~^
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:391:24: error: 
      no member named 'long_guid_form_length' in 'GUID'
  return (!(N == GUID::long_guid_form_length || N == GUID::short_guid_fo...
                 ~~~~~~^
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:391:60: error: 
      no member named 'short_guid_form_length' in 'GUID'
  return (!(N == GUID::long_guid_form_length || N == GUID::short_guid_fo...
                                                     ~~~~~~^
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:392:13: error: 
      no member named 'parse_guid_error2' in 'GUID'
    ? GUID::parse_guid_error2()
      ~~~~~~^
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:389:16: error: 
      no return statement in constexpr function
constexpr GUID operator "" _guid(const char *str, size_t N)
               ^
/Users/alpha/CloverBootloader/rEFIT_UEFI/include/Guid++.h:398:22: error: 
      default initialization of an object of const type 'const GUID' without a
      user-provided default constructor
constexpr const GUID nullGuid;
                     ^
                             {}
2 warnings and 12 errors generated.
note: Using new build system
note: Planning
note: Build preparation complete
warning: Building targets in manual order is deprecated - check "Parallelize build for command-line builds" in the project editor, or set DISABLE_MANUAL_TARGET_ORDER_BUILD_WARNING in any of the targets in the current build to suppress this warning
** BUILD FAILED **

tluck · May 2, 2022

11 hours ago, Slice said:

Tell me something more. Is there system-id changed after changing the Clover version?

yes.

System-ID: old vs new - seems there is some swapping going on. not good!

3 variables changed actually. i printed out key items with iMessageDebug...
before if I boot the system with OC or Clover - identical. but now clover is different.

Note: i would take system_ID after booting with clover and provide it for my OC config. so i presume the other variables shown here have a dependency on system-ID

$ diff im_old.txt im_new.txt

8c8

< Hardware UUID: 32A12892-FA65-5EF5-9623-C62A7F2CDABD

---

> Hardware UUID: 3759A000-6E97-545E-BBBC-E88DB235CB34

10c10

< System-ID: ADC4A801-5149-11CB-94D0-CE1B8C4C5D31

---

> System-ID: 01A8C4AD-4951-CB11-94D0-CE1B8C4C5D31

15c15

< Fyp98tpgj: 736fe3ae7cd2d031bc44bd2701aa733715

---

> Fyp98tpgj: 8c280c999254e1e95a419c2aea6fb89182

Edited May 2, 2022 by tluck

May 2, 2022

On 5/1/2022 at 5:22 PM, MifJpnAlphaPlus said:

Hello.

After booting, I was told that there was a problem with my computer, I entered the setting Apple ID again and noticed the following.

Part of the interpretation of System-ID is as if it were little-endian.

Please help me.

Thank you.

I have battled with this issue most of the weekend. I had to enter and verify my Password time and time again after switching back and forth from Clover to OC and vice versa even though the data in both configs was Identical. I've used them for over a year before that without issues.

Here's how I fixed it: https://github.com/5T33Z0/Clover-Crate/tree/main/OC2Clover#troubleshooting

Edited May 2, 2022 by 5T33Z0

MifJpnAlphaPlus · May 2, 2022

58 minutes ago, 5T33Z0 said:

I have battled with this issue most of the weekend. I had to enter and verify my Password time and time again after switching back and forth from Clover to OC and vice versa even though the data in both configs was Identical. I've used them for over a year before that without issues.

Here's how I fixed it: https://github.com/5T33Z0/Clover-Crate/tree/main/OC2Clover#troubleshooting

Thank you for always being so kind and creating a page of summaries.
I actually noticed this first because of the differences with OpenCore.
Now that I know where Endian has changed, I was able to put it back together anyway.
It's good to know that I didn't have to use a new number since TimeMachiene will no longer be available.
Thank you so much.

May 2, 2022

@MifJpnAlphaPlus The big question is: what caused the change of Endianness. Was it Clover or OpenCore? And why does it only happen to the System-ID and only parts of it and not the whole string? Weird.

Slice · May 2, 2022

19 minutes ago, 5T33Z0 said:

@MifJpnAlphaPlus The big question is: what caused the change of Endianness. Was it Clover or OpenCore? And why does it only happen to the System-ID and only parts of it and not the whole string? Weird.

Obviously the cause of the change is the commit by Jief_Machak.

I think I will fix the endianness so do not account current Clover as a final.

MifJpnAlphaPlus · May 2, 2022

25 minutes ago, Slice said:

Obviously the cause of the change is the commit by Jief_Machak.

I think I will fix the endianness so do not account current Clover as a final.

Thanks for the quick reply.
Maybe here he is generalizing smUUID as XString8 class to EFI_GUID class.

https://github.com/CloverHackyColor/CloverBootloader/commit/1ea4700bd6eb4252555537adb4204339903ad7c0

So I feel that there might have been something that could not be generalized as smUUID.
It will be fixed soon, I think.
Thanks again.

May 2, 2022

@MifJpnAlphaPlus From the timeframe, I think this could be the commit that started the problems on my systems as well.

Edited May 2, 2022 by 5T33Z0

MifJpnAlphaPlus · May 2, 2022

Spoiler

rEFIt_UEFI/Platform/smbios.cpp

518:	////  XString8 g = GuidBeToXString8(SmbiosTable.Type1->Uuid); // should we use the "variant" field to know if it's LE or BE
519:	//  XString8 g = GuidLEToXString8(SmbiosTable.Type1->Uuid); // 2021-04 : this is a bug, the UUID will be swapped (read as a LE, sent as a BE). I leave for now because it doesn't really matter.
520:	  return SmbiosTable.Type1->Uuid;

Sorry if I am wrong.
From what I can see here, he has turned LittleEndian into a generalized EFI_GUID class as is, so I think this change is correct.
What I think is happening here, as others have said, is that it happened when we changed OpenCore.
I am very sorry because I am guessing, but it says in the code that the sm-UUID is passed in BE=BigEidian later. Could it be that it is OpenCore that is passing it?
I feel like maybe it is not being passed in BigEndian when it is passed.
If I can do it, I will try reading it some more.

Thank you so much.

MifJpnAlphaPlus · May 2, 2022

I'm a bit curious about something.

”// macOs treats all guids as BE guids, regardless of variant.”
It says.

However, it eliminates the conversion to BigEndian.
Sorry, I am not sure what it means.
How to define smUUID is not clear to me.
Please help me.

https://github.com/CloverHackyColor/CloverBootloader/commit/1ea4700bd6eb4252555537adb4204339903ad7c0#diff-4a0d88485435414cd08a60877d8d85a22d6a18c8d96cf19ae7fbecb43a77cc33L546-R549

Stefanalmare · May 2, 2022

6 hours ago, 5T33Z0 said:

I have battled with this issue most of the weekend. I had to enter and verify my Password time and time again after switching back and forth from Clover to OC and vice versa even though the data in both configs was Identical. I've used them for over a year before that without issues.

Here's how I fixed it: https://github.com/5T33Z0/Clover-Crate/tree/main/OC2Clover#troubleshooting

ROM îs not necessary, UseMacAddr0 it works just fin. Also I never used Update Firmware Only. Rest is like in your tutorial and is what I did from some time with 7 hacks I play around, different tipes, always latest OS, OC, Clover commits.

Slice · May 3, 2022

I restored old smUUID behavior and returned to old AppleID.

commit 04e42c09e

May 3, 2022

@Slice @Jief_Machak There's still something wrong with commit 04e42c09e.

This is the data that is entered in the Clover Config. It's the same as in my OpenCore config:

SmUUID.png.0ddac0585ac824c928658183793f2f18.png

HardwareUUID.png.d31342e26f9f318ae8d40a933a31bf8d.png

After rebooting with CLover, I am being asked for AppleID Password again. Hackintool Shows Data, that I didn't enter. It looks like Clover is using the Custom UUID as System ID and not as Hardware ID and also reverses the Endianness of the first 2 groups. The original System ID isn't used at all:

Hackintool.png.e3c34b9ae652aef7e62b8a023afeebd7.png

On my 2nd test, I left the Custom UUID empty. Then the System ID is used, but the first 3 pairs of digits are reversed:

1331356015_Bildschirmfoto2022-05-03um08_02_44.png.ab660d8b752ffc3500f36c43eb78535d.png

After reverting to the release version of r5146 everything is working as expected.

Edited May 4, 2022 by 5T33Z0

MacKonsti · May 3, 2022

Hi everyone! Sorry @5T33Z0 and @Slice so is r5146 buggy then, or the subsequent commits to this official release?

Just to avoid confusion for the rest of us users that do not compile Clover via Builder but rely on official GitHub releases of yours.

Thank you for your confirmation.

May 3, 2022

@MacKonsti This issue only affects beta releases you find in the "Action" Section of the github repo, specifically the ones since Replace EFI_GUID by a class EFI_GUID.

Edited May 3, 2022 by 5T33Z0

chris1111 · May 3, 2022

@Slice thanks latest commit seems to have fixed the Fletch OpenCorePkg

y010204025 · May 3, 2022

@Slice,Hi, Slice, I noticed that CLOVER uses rEFIt_uefi. Whether the clover switches from rEFIt to rEFInd again, I noticed that rEFIt has stopped updating for a period of time, and the maintenance of rEFInd is more active, and it has added a lot of modern characteristics.

In addition, there is a rEFIndPlus, which seems to have some repair for MacOS, adding some additional functions, which may have some good ideas as a reference.https://github.com/dakanji/refindplus

Clover General discussion

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites