Clover General discussion

[polyzargone]

Please send the file '/Volumes/Macintosh HD/Users/polyzargone/Desktop/Portables/HP Spectre x360/Rapport_MacBidouille/CLOVER/config.plist' as is to me. DO NOT modify the file please, or I won't catch that bug in my new parser. Thanks.

config.plist.zip

[yapan4]

Version 6c and Version 7

No parsing bug detected. Great. Let me know

[Jief_Machak]

56 minutes ago, polyzargone said:

Please send the file '/Volumes/Macintosh HD/Users/polyzargone/Desktop/Portables/HP Spectre x360/Rapport_MacBidouille/CLOVER/config.plist' as is to me. DO NOT modify the file please, or I won't catch that bug in my new parser. Thanks.

config.plist.zip 3 kB · 1 download

Version 8...

This inconsistency was about ig-platform-id which can prevent to boot. Good to catch these before.

Thanks for your patience.

Hum, before, my insanelymac title was something like "teh 11443(*". Now it became "InsanelyMac Deity". Not sure what I prefer... 

[yapan4]

@Jief_Machak

Version 8 

No parsing bug detected. Great. Let me know

[Slice]

iMac2017:Test_Config sergey$ ./CloverX64TestNewParser 
Version 8
file:/Users/sergey/Desktop/config2.plist
Please send the file '/Users/sergey/Desktop/config2.plist' as is to me. DO NOT modify the file please, or I won't catch that bug in my new parser. Thanks.

 

config2.plist

[polyzargone]

polyzargone@MacBook-Optimus Clover_test % ./CloverX64TestNewParser       
Version 8
Please send the file '/Volumes/MacDATA/OEM/Aspire V3-772G/config.plist' as is to me. DO NOT modify the file please, or I won't catch that bug in my new parser. Thanks.

config.plist.zip

Edited April 12, 2021 by polyzargone

[Jief_Machak]

5 hours ago, Slice said:

iMac2017:Test_Config sergey$ ./CloverX64TestNewParser 
Version 8
file:/Users/sergey/Desktop/config2.plist
Please send the file '/Users/sergey/Desktop/config2.plist' as is to me. DO NOT modify the file please, or I won't catch that bug in my new parser. Thanks.

 

config2.plist 42.05 kB · 3 downloads

New version 9 on github.

You're the only one, so far, to have the value of CsrActiveConfig in a data tag ! Case now handled. Thanks.

[Slice]

Next test will be at the evening only.

23 minutes ago, Jief_Machak said:

New version 9 on github.

You're the only one, so far, to have the value of CsrActiveConfig in a data tag ! Case now handled. Thanks.

data tag? Strange. I don't remember why it was happened.

[Matgen84]

23 minutes ago, Slice said:

Next test will be at the evening only.

data tag? Strange. I don't remember why it was happened.

Hi @Slice
I remember the discussion in this thread December, 15 about commit d68d53a. Sorry if I misunderstood, my English is bad.
 

https://github.com/CloverHackyColor/CloverBootloader/commit/d68d53a4165dc634ffc770072c7f055e8fa2e6e6

[Jief_Machak]

1 minute ago, Matgen84 said:

Hi @Slice
I remember the discussion in this thread December, 15 about commit d68d53a. Sorry if I misunderstood, my English is bad.
 

https://github.com/CloverHackyColor/CloverBootloader/commit/d68d53a4165dc634ffc770072c7f055e8fa2e6e6

Ah ok, this "data" possibility was added not so long ago, after I made my first version of my new parser. That is explaining why. That's confirming that "mass testing" is good :-)

[Jief_Machak]

5 hours ago, polyzargone said:

polyzargone@MacBook-Optimus Clover_test % ./CloverX64TestNewParser       
Version 8
Please send the file '/Volumes/MacDATA/OEM/Aspire V3-772G/config.plist' as is to me. DO NOT modify the file please, or I won't catch that bug in my new parser. Thanks.

config.plist.zip 6.05 kB · 1 download

 

1 hour ago, MifJpn said:

Thank you always!

@Jief_Machak

Version 9

Please send the file '/Volumes/MacData/1.EFI-Backup/1.CatalinaEFI(Clover)/old/EFI.2007261135/CLOVER/config.plist' as is to me. DO NOT modify the file please, or I won't catch that bug in my new parser. Thanks.

config.plist 8.55 kB · 1 download

Fixed in version 11 ?

[Jief_Machak]

In platformdata.cpp, there is 

snprintf(RBr, 8, "%s", "j95j95am");

but the last char won't be copied and will be replaced by 0 (was already the case before my snprintf function. AsciiStrCpyS do the same).

Is it the intended behaviour ?

[Slice]

6 minutes ago, Jief_Machak said:

In platformdata.cpp, there is 

snprintf(RBr, 8, "%s", "j95j95am");

but the last char won't be copied and will be replaced by 0 (was already the case before my snprintf function. AsciiStrCpyS do the same).

Is it the intended behaviour ?

As far as I remember the result should be "j95j95a\0" or may be "j95j95am\0" .  I will check when I will be at home.

We are still supporting these SMC keys while they are no more used. Last use I saw in 10.7.5.

[Jief_Machak]

40 minutes ago, Slice said:

the result should be "j95j95a\0"

Yes, the result is "j95j95a\0".

It can't be "j95j95am\0" because RBr is only 8 char long. But maybe the result should be "j95j95am" as it looks like the final \0 is not needed.

It is used like this : 

LogDataHub(&gEfiMiscSubClassGuid, L"RBr",  &RBr,    8);

So no \0 looks fine.

3 minutes ago, MifJpn said:

Excuse me.

Where is Version 11?

I downloaded it from the same git-hub (twice). But it's version 9.

Maybe I'm misunderstanding?

 

Sorry, forgotten git push. Done now.

[Matgen84]

Hi @Jief_Machak

Version 11: no parsing bug (Z390 config.plist). Only strange lines:

 

ProductName SETTINGS_DATA=
ProductName setting=iMac19,1
ProductName new SETTINGS_DATA=iMac19,1

And 
 

void ParseSMBIOSSettings(SETTINGS_DATA&, const TagDict*) : BoardVersion: Imac19,1

 

Result version Z390 04-11 15-30.rtf

[Slice]

2 hours ago, Jief_Machak said:

Yes, the result is "j95j95a\0".

It can't be "j95j95am\0" because RBr is only 8 char long. But maybe the result should be "j95j95am" as it looks like the final \0 is not needed.

It is used like this : 

LogDataHub(&gEfiMiscSubClassGuid, L"RBr",  &RBr,    8);

So no \0 looks fine.

Sorry, forgotten git push. Done now.

Yes, real iMac17,1 has these values

RBr   [ch8*]  (bytes 6a 39 35 6a 39 35 61 6d)

RPlt  [ch8*]  (bytes 6a 39 35 00 00 00 00 00)

While currently Clover makes me

  RPlt  [ch8*]  (bytes 6a 39 35 00 00 00 00 00)
  RBr   [ch8*]  (bytes 6a 39 35 6a 39 35 61 00)

 

[Slice]

New one

Quote

Please send the file '/Users/sergey/Documents/Hacks/DellE6430/config 3.plist' as is to me. DO NOT modify the file please, or I won't catch that bug in my new parser. Thanks.

config 3.plist

Should be

snprintf(RBr, 9, "%s", "j95j95am");

?

And

char RBr[9];

 

[polyzargone]

4 hours ago, Jief_Machak said:

 

Fixed in version 11 ?

 

Seems like :

 

polyzargone@MacBook-Optimus Clover_test % ./CloverX64TestNewParser       
Version 11
No parsing bug detected. Great. Let me know

 

[yapan4]

Version 11

No parsing bug detected. Great. Let me know

Saving session...

...copying shared history...

...saving history...truncating history files...

...completed.

Deleting expired sessions...none found.

 

[Process completed]

 

[matxpa]

On 4/11/2021 at 12:33 PM, Jief_Machak said:

Did we have the opposite problem few days ago ? 

Good we support 2 compilers !

I'll have a look.

Nice diagnostic, thanks.

 

@Jief_Machak

 

Slice's r5133 Release (master commit fd3b09cf1) is a GCC53 build

 

I've made a r5133 Release (master commit fd3b09cf1) XCODE8 build.

That r5133 XCODE8 Release work fine I can boot on a Laptop Asus X75VB (MBP11,3 IvyBridge I5-3340M) Big Sur 11.2.3 (20D91)

 

Yesturday i've built three XCODE8 r5133 Releases based on the three master commits (fe26ba9, 4269083 and the last c07c154)

The three r5133 XCODE8 built Releases are OK but none of them can BOOT (black screen, no REFIT_MAINMENU_SCREEN displayed)

I didn't try with others commits

Those three r5133 GCC53 built Releases work fine 

 

Result of your parser CloverX64TestNewParser

./CloverX64TestNewParser /Users/meunier/Desktop/"EFI X75 MBP1x,x"/Clover

Version 11

Look for config.plist in folder '/Users/meunier/Desktop/EFI X75 MBP1x,x/Clover'

file:/Users/meunier/Desktop/EFI X75 MBP1x,x/Clover/r5101_EFI_Clover_Mojave_10.14.6_20191220/EFI/CLOVER/config.plist

... (57 ".plist" files)

file:/Users/meunier/Desktop/EFI X75 MBP1x,x/Clover/r5133-EFI 3 20210412 c07c154 GCC53 OK/CLOVER/config.plist

No parsing bug detected. Great. Let me know

 

greetings

[Jief_Machak]

2 hours ago, Slice said:

New one

config 3.plist 19.87 kB · 2 downloads

Should be

snprintf(RBr, 9, "%s", "j95j95am");

?

And

char RBr[9];

 

We can define as 9 bytes long, or just do a memcpy instead of a snprintf.

 

@matxpa All your plist are in the folder "/Users/meunier/Desktop/"EFI X75 MBP1x,x"/Clover" ? If you have old, almost forgotten archive, I'm interested toparse them too.

You can do /CloverX64TestNewParser / ! (take a small break, it'll take some time).

 

Version 12 pushed...

[Slice]

Version 12

1 file(s) ignored because of xml structural problem (missing closing tag or like).

No parsing bug detected. Great. Let me know

 

(there was ~300 files config-like. It's a pity there is no counter)

[yapan4]

Version 12

~200 .plist files

No parsing bug detected. Great. Let me know

Saving session...

...copying shared history...

...saving history...truncating history files...

...completed.

 

[Process completed]

[Slice]

57 minutes ago, Jief_Machak said:

We can define as 9 bytes long, or just do a memcpy instead of a snprintf.

 

We can't use memcpy because in other cases it will copy extra bytes while snprintf copy until zero.

[Jief_Machak]

1 hour ago, Slice said:

We can't use memcpy because in other cases

We use memcpy only for the case where Rbr is 8 bytes long.

 

But 9 bytes definition is probably the more intuitive...

2 hours ago, Slice said:

It's a pity there is no counter

I can do a version 13 with a counter 

A lot of plist tested. That's great.

 

I'll asked few other people to do some more.