Clover General discussion

[Slice]

Currently we have working state.

32ec9183d57997668f547d89337dfa88823555e1

[LockDown]

OS: High Siera

Xcode: 10.1

Commit: 328

Toolchain XCODE8

 

Getting this error:

Building CloverPrefpane preference...
[XCODE]
================= Making all in boot1-install =================
	[XCODE] boot1-install
================= Making all in partutil =================
	[XCODE] partutil
================= Making all in bdmesg =================
	[XCODE] bdmesg
================= Making all in clover-genconfig =================
	[XCODE] clover-genconfig
** INSTALL FAILED **


The following build commands failed:
	CompileC /Users/ella/src/CloverBootloader/CloverPackage/sym/build/clover-genconfig/clover-genconfig.build/Release/clover-genconfig.build/Objects-normal/x86_64/clover-genconfig.o /Users/ella/src/CloverBootloader/CloverPackage/utils/clover-genconfig/clover-genconfig.c normal x86_64 c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
make[2]: *** [/Users/ella/src/CloverBootloader/CloverPackage/sym/utils/clover-genconfig] Error 65
make[1]: *** [all-recursive] Error 1
make: *** [pkg] Error 2
iMac:~ ella$ 

 

[Jief_Machak]

Probably an include order, like before.

[Slice]

Platform.h should be

#ifdef _cplusplus

#include "../cpp_foundation/XStringW.h"
#include "../cpp_foundation/XArray.h"
#include "../cpp_foundation/XObjArray.h"
#endif

[Jief_Machak]

53 minutes ago, Slice said:

Platform.h should be

#ifdef _cplusplus

#include "../cpp_foundation/XStringW.h"
#include "../cpp_foundation/XArray.h"
#include "../cpp_foundation/XObjArray.h"
#endif

Yes, of course. Why did I forgot that ???

[Slice]

I have to exclude clover-genconfig from compilation up to new times.

Hope @vector sigma will make it unnecessary.

[Slice]

As well we can no more compile CloverUpdater and Preference pane in the wake of Clover.app.

[Jief_Machak]

Does CloverUpdater and Clover use "Volumes". If no, the #ifdef __cplusplus should have them compiling again ?

[Slice]

28 minutes ago, Jief_Machak said:

Does CloverUpdater and Clover use "Volumes". If no, the #ifdef __cplusplus should have them compiling again ?

Not using. Platform.h needed for <Uefi...> and for SETTINGS_DATA

[Jief_Machak]

Ok, solving that right now.

[Jief_Machak]

Just commited about the .h includes and gen-config.

 

I've started some includes files. The rules is :

  - each .cpp should have it's own .h

  - each .cpp should include it's own .h (to catch declaration mismatch problem)

 

So, basically, lib.h must not defines anything that are not in lib.cpp.

Platform.h could exist, but just as a convenience that includes other .h.

 

If a circular dependancy happens, it's because a module is too big...

 

 

[Jief_Machak]

Also :

Ideally, a .h can include other .h, but the absolute minimum to get the type definition needed (like UINTN).

That said, Platform.h could be a candidate for this, but we have to check that Platform.h does not reference other Clover modules, especially C++ modules.

Then, gen-config should probably include Platform, and not lib.h

 

PS : I said I've started because I only moved the offending definition for gen-config. I didn't include it's own .h in every .cpp. It's a quick fix but NOT dirty. It's the right direction.

PS2 : didn't check CloverUpdater and Preference pane, but I guess it was the same problem as gen-config ?

[vector sigma]

5 hours ago, Slice said:

I have to exclude clover-genconfig from compilation up to new times.

Hope @vector sigma will make it unnecessary.

I translated it to swift, but I'm still linking to Platform.h with no problems:

#ifdef DEBUG
#undef DEBUG
#endif

#include "../../rEFIt_UEFI/Platform/Platform.h"

#import "NSWindowFix.h"
#import "gfxutil.h"
#import "efidevp.h"

ok, not finished, but SETTINGS_DATA are ok here since last few days and the only problem until now is that I have to undefine DEBUG

[Jief_Machak]

I guess that gen-config will have to switch to C++ compiler too, because on day, SETTINGS_DATA will become an object...

[vector sigma]

41 minutes ago, Jief_Machak said:

I guess that gen-config will have to switch to C++ compiler too, because on day, SETTINGS_DATA will become an object...

How you will encode/serialize that object in the IO?

Edited February 29, 2020 by vector sigma

[Jief_Machak]

Sorry, I don't really know what gen-config does.

But in my C++ classes (foundation), I've removed the serialization method, but I have them !

 

It's base on an object XBuffer, which is almost an XArray<UINT8> in wich I've added serialize methods. Can take care of that when the moment will come... It's not that soon :-)

[vector sigma]

let see

[vector sigma]

By the way, all Clover Settings are basically a big tuple saved in  IODeviceTree->efi->platform->Settings 

which can be copied to a new copy of SETTINGS_DATA structure.

[ameenjuz]

anyone provide me clovergit v1.2 for building downloading

[vector sigma]

52 minutes ago, anmool said:

anyone provide me clovergit v1.2 for building downloading

 

 

cd $HOME && git clone https://github.com/CloverHackyColor/CloverBootloader.git

 

[ameenjuz]

28 minutes ago, vector sigma said:

 

 

cd $HOME && git clone https://github.com/CloverHackyColor/CloverBootloader.git

 

thank vector sigma I got it

 

I have another issue with Quicktime player
When i play video 1920x1080 60fps with quicktime player the screen flickering black
When i play video 1920x1080 30fps or 25fps video worked fine no flickering
What is this issue 

i think this issue is related shiki or quicktime player

I m running kabylake i5-7200u IntelHDGraphic 620

 

pr file attached

debug_21366.zip

[chris1111]

latest build some issue but package build

 

 

[Slice]

4 hours ago, chris1111 said:

latest build some issue but package build

 

 

 

 

Yes, I excluded genconfig compilation but not excluded a link to binary.

Will be resolved later.

[vector sigma]

Clover.app is now able to generate the config.plist and it's retro compatible with very old revisions of Clover. Anyway I set r3250 as minimum requirement as I haven't the time to go back researching even older commits. What I have to do is to add new settings that will comes in newer revisions. Old settings, if no longer present in SETTINGS_DATA, will be simply skipped because before accessing a variable in the struct the code check for its existence. So it will not crash... or at least is designed for... (ok excluding possible bugs to be fixed Lol).

 

 

Clover.app_v1.16_r5104.pkg.zip

 

let me know!

 

P.S. now Clover.app has an installer that automatically remove attributes to prevent messages by the OS that the app is damaged due to the missing code signature of a paid certificate from Apple. Installs in /Applications, but then you can move it where you like.

10 hours ago, Slice said:

Yes, I excluded genconfig compilation but not excluded a link to binary.

Will be resolved later.

Is back. In both Clover.app and clover-genconfig now there is this definition:

#ifndef CLOVERAPPLICATION
#define CLOVERAPPLICATION 1
#endif

#include "../../rEFIt_UEFI/Platform/Platform.h"

 

in Platform.h now there's this:

#ifndef CLOVERAPPLICATION
#include "../refit/IO.h"
#endif

..should be used to exclude unneeded things.

Edited March 1, 2020 by vector sigma

[vector sigma]

23 hours ago, anmool said:

thank vector sigma I got it

 

I have another issue with Quicktime player
When i play video 1920x1080 60fps with quicktime player the screen flickering black
When i play video 1920x1080 30fps or 25fps video worked fine no flickering
What is this issue 

i think this issue is related shiki or quicktime player

I m running kabylake i5-7200u IntelHDGraphic 620

 

pr file attached

debug_21366.zip

Sorry, I have the same IntelHDGraphic 620 in a tiny pc in my living room, ..and it flicker as well using Windows 10.