Jump to content
About Just Joined group Read more... ×

455 posts in this topic

Recommended Posts

19 hours ago, blackosx said:

That looks good. 

My file has frame 1 -> frame 39

So frame 0 -> frame 38 is fine.

This is the first issue. It was not found frame_0 and then

      if (Screen->Film[0] != NULL) {

:)

 

Looking more...

Share this post


Link to post
Share on other sites
Advertisement

And second issue is initializing values

  Anime->FilmX = INITVALUE;
  Anime->FilmY = INITVALUE;
  Anime->NudgeX = INITVALUE;
  Anime->NudgeY = INITVALUE;

As well time should be reduced

FrameTime="50"

And Voila!

Screen Shot 2018-12-03 at 20.44.37.png 

Committed to 4789

Share this post


Link to post
Share on other sites

Just tested and I see animation works! :D

 

But it's not right. :(

It should look like Anim_1_Logo animation from BGM.

 

Each frame has size boundingrect set to 800x100, for example:

<rect visibility="hidden" id="BoundingRect_74_" y="0" class="NoFill" width="800" height="100"/>

 

Should look like this (here's frame 7 and 36).

frame7and36.jpg.9cc17c94afc3b09e7134a10e3f1f9c90.jpg

 

But all whitespace/empty space is cropped, leaving each image centred.

 

Can you retain the full bounding rect and not crop on empty space?

 

Share this post


Link to post
Share on other sites

Understand. It looks like in VectorGraphics.c line 204

  if ((Id != BUILTIN_ICON_BACKGROUND) && (strcmp(IconName, "Banner") != 0)) {

    float realWidth = (bounds[2] - bounds[0]) * Scale;

    float realHeight = (bounds[3] - bounds[1]) * Scale;

    tx = (Width - realWidth) * 0.5f;

    ty = (Height - realHeight) * 0.5f;

  }

should add condition 

&& (Id != BUILTIN_ICON_ANIME)

 

Can you check?

Share this post


Link to post
Share on other sites

It's better, but still not completely correct as all images are now ranged left. This is good.

 

But left side of image is still cropped (has whitespace removed) resulting in all image content being aligned to same X position.

 

anim_grabs.thumb.jpg.d7fcffdf9fbed2612323661858a87e2e.jpg

 

Where in post above I show the content in frame 7 (the fragments) is further left that the CLOVER word/icons

 

Share this post


Link to post
Share on other sites

Okay. I'll take a look at animation again soon.

 

Moving away from animation for now, can you check 2 things for me when you get time?

1 - I cannot figure out why Banner_night does not show. Am I missing something obvious?

2 - Background does not scale?, even though I have set BackgroundScale="scale"

 

EDIT: Attachment removed

 

Edited by blackosx

Share this post


Link to post
Share on other sites

Something wrong here

17:196  0:009  Use anime=<null string> frames=65535
17:208  0:012  icon 'frame_1' not loaded, status=Not Found
17:220  0:011  icon 'frame_2' not loaded, status=Not Found
17:231  0:010  icon 'frame_3' not loaded, status=Not Found
...
72:301  0:011  icon 'frame_4545' not loaded, status=Not Found
72:315  0:014  icon 'frame_4546' not loaded, status=Not Found
72:327  0:011  icon 'frame_4547' not loaded, status=Not Found
72:338  0:010  icon 'frame_4548' not loaded, status=Not Found
...

 

Share this post


Link to post
Share on other sites

Thank you for taking the time to check my theme slice.

 

EDIT: Making suggested changes:

- 1 - Fix AnimeFrames=“"

- 2 - Remove class=""

- 3 - Change background size to 1920x1080.

- 4 - Remove transform scale=1

 

Banner_night still not showing.

Background not being scaled horizontally.

 

I'll try to run a debug and see what's going on.

 

 

 

Edited by blackosx
Removed images of work-in-progress theme

Share this post


Link to post
Share on other sites
22 minutes ago, blackosx said:

You mean ?

(strstr(IconName, "Banner") != NULL)

:)

 

EDIT: Works

There is another place several lines below

  if ((Id != BUILTIN_ICON_BACKGROUND) &&
      (Id != BUILTIN_ICON_ANIME) &&
      (strstr(IconName, "Banner") == NULL)) {
    float realWidth = (bounds[2] - bounds[0]) * Scale;
    float realHeight = (bounds[3] - bounds[1]) * Scale;
    tx = (Width - realWidth) * 0.5f;
    ty = (Height - realHeight) * 0.5f;
  }

 

Share this post


Link to post
Share on other sites

To do this we should implement SelectionColorNight="..." and insert parsing into nanosvg.c here

    } else if (strcmp(dict, "SelectionColor") == 0) {

      GlobalConfig.SelectionColor = getIntegerDict(dict[i + 1]);

with checking time of day.

For example

 

    } else if (strcmp(dict, "SelectionColor") == 0) {

      if (DayLight)

      GlobalConfig.SelectionColor = getIntegerDict(dict[i + 1]);

    } else if (strcmp(dict, "SelectionColorNight") == 0) {

      if (!DayLight)

      GlobalConfig.SelectionColor = getIntegerDict(dict[i + 1]);

 

But typefaces is more complex.

Share this post


Link to post
Share on other sites

I think it is better to implement night menu 

Daylight as usual

<g id="MenuRows" class="st0"><text class="st1">Menu</text></g>
<g id="HelpRows" class="st0"><text class="st2">Help</text></g>
<g id="MessageRow" class="st0"><text class="st3">Boot macOS from HDD</text></g>

and for night

<g id="MenuRows_night" class="st0"><text class="st1n">Menu</text></g>
<g id="HelpRows_night" class="st0"><text class="st2n">Help</text></g>
<g id="MessageRow_night" class="st0"><text class="st3n">Boot macOS from HDD</text></g>

 

Share this post


Link to post
Share on other sites

Thanks for the SelectionColorNight instructions.

And yes, a separate night menu would be cleaner to visualise and handle.

 

I will try later when I get time.

Share this post


Link to post
Share on other sites
1 hour ago, blackosx said:

Thanks for the SelectionColorNight instructions.

And yes, a separate night menu would be cleaner to visualise and handle.

 

I will try later when I get time.

I committed these advances for you to draw and test when you will have a time and wish.

Share this post


Link to post
Share on other sites

Not sure if here is appropriate but I just downloaded the 10.14.2 combo update and rebooted, I am using the Clovy theme but when I chose the install macOS drive file on the GUI it just froze. I tried this three times with no success until I changed to a standard theme then I could boot the install macOS from xxxx drive.


Sent from my iPhone using Tapatalk

Share this post


Link to post
Share on other sites

@Slice

I'm testing using symbols for OSBadge but not having success getting Clover to load it. Can you help?

 

Here are two files which I've created to test the elements.

test_basic_badge_offset_in_finder_good_in_ai.svg

Test_os_cap_not_bad_in_finder_wrong_in_ai.svg

 

However, when I put this in to theme.svg for Clover I'm not seeing the Badge. Debug shows:

2:893  0:003  search for os_mac
2:905  0:002  load os_mac status=Not Found
2:907  0:002  OSicon os_mac not parsed

Here's are 2 slightly different theme.svg files I'm using.

Theme.svg

Theme2.svg

 

Gives me the following result.

1622146691_Screenshot2018-12-07at21_50_03.thumb.png.0d9be761e4895dd644286365a556748b.png

 

Can you identify what's wrong and why the os_mac badge is not showing?

 

Thanks

 

 

Share this post


Link to post
Share on other sites

  • Recently Browsing   0 members

    No registered users viewing this page.

Announcements

  • Similar Content

    • By BALDY_MAN
      Hi All.
      Im Happy to share my new EFI file that I put together  18/10/2020. which got me up and running 11.0  Beta(20A5395g) on my hack
      a thanks you to everyone who's work I have use to assemble this EFI File. and the help I have received from this site
      I have used openCore 0.6.3, sound work for me (HDMI) and onboard Ethernet. map the usb ports as you wish.
      the definition to iMac20,2
      hope it helps all who need it
      PS. Please leave a comment if the EFI File is helpful to you
      (No Kexts were Harmed in the making of this EFI)
                                                                                                                     regards
                                                                                                                                         Baldy_man
      GigabyteZ40Master.EFI.(20A539g) .zip
    • By qmgoqwe
      I have installed MacOS and Windows on the following hardware:
       
      AMD Ryzen 7 3700X MSI B450M Mortar Max Sapphire Radeon Pulse RX 5600 XT 6G Samsung 860 QVO, 1 TB SSD (PciRoot(0x0)/Pci(0x1,0x3)/Pci(0x0,0x1)/Sata(0x5,0xFFFF,0x0)) - MacOS on this disk Kingston A2000 SSD 1TB M.2 2280 NVMe (PciRoot(0x0)/Pci(0x1,0x1)/Pci(0x0,0x0)/NVMe(0x1,15-AD-CD-26-28-B7-26-00)) - Windows on this disk  
      OpenCore 0.6.1 MacOS 10.15.7 both disks GPT UEFI  
      Both OSs boot nicely and work as a charm when selecting either of the disks as boot disks in the BIOS.
       
      However, trying to boot Windows 10 from the Opencore Bootmanager (no matter whether PickerMode=internal or OpenCanopy) causes a Windows Blue Screen ("SYSTEM THREAD EXCEPTION NOT HANDLED").
      To be on the safe side, I have added an appropriate entry to Misc->Entries:
      <key>Arguments</key> <string></string> <key>Auxiliary</key> <false/> <key>Comment</key> <string>Not signed for security reasons</string> <key>Enabled</key> <true/> <key>Name</key> <string>Windows 10</string> <key>Path</key> <string>PciRoot(0x0)/Pci(0x1,0x1)/Pci(0x0,0x0)/NVMe(0x1,15-AD-CD-26-28-B7-26-00)/HD(1,GPT,2E9695CB-0F9A-4005-AADB-2FF9C96AD02C,0x800,0x32000)/\EFI\Microsoft\Boot\bootmgfw.efi</string> It points to the Windows 10 bootmanager on the Windows disk's EFI partition.
       
      What's wrong with that? Why does this cause a BSOD? It is not clear to me why it works when booting from BIOS but not here.
       
      config.plist attached (but maybe it has no relevance for the problem).
      config.plist
    • By le332313
      Can someone share the dell 5593/5493 EFI ? I try to fit the graphics driver, but it not working please help me thanks
       
    • By MaLd0n
      -OpenCore Vanilla TUTORIAL-
       
       
      -USB Port Mapping TUTORIAL-
       
        1 -Create a USB bootable
       
      Create your usb installer, use this tool and download Catalina or Big Sur from Apple servers
       
      Catalina
      installScript_allfullapp.zip
       
      Big Sur
      installScript_1016fullapp.zip
       
      Credits: crazybirdy
       
      Copy Catalina / Big Sur installer to Applications folder, open terminal and run
       
      Catalina
       
       
      Big Sur
       
       
      If you want check one step by step, check here
       
      -Opencore Vanilla Tutorial
      https://tinyurl.com/ycvcnp8h
       
      2- EFI folder USB installation
       
      -EFI OpenCore Folder Desktop 10th Intel Processors
      Paste this EFI folder in EFI partition in your USB STICK
      https://tinyurl.com/ybwr9kq3
       
      -EFI Clover Folder Desktop 10th Intel Processors
      Paste this EFI folder in EFI partition in your USB STICK
      https://tinyurl.com/yxsw7d3t
       
      3- EFI folder SSD
       
      -EFI OpenCore Folder Desktop 10th Intel Processors
      Paste this EFI folder in EFI partition SSD 
      https://tinyurl.com/ybwr9kq3
       
      -EFI Clover Folder Desktop 10th Intel Processors
      Paste this EFI folder in EFI partition SSD
      https://tinyurl.com/yxsw7d3t
       
      4- Start Fine Tune
       
      Run this app and post full dump here for full ACPI solution
       
      RunMe.app
      https://tinyurl.com/y9562hz7
       
       
      If you like a SSDT way, here we go
      SSDT-OLARILA.aml.zip
       
      5- USB Solution
       
      Use these kexts, enable XHCI port limit patch
       
      USB INTEL SERIE 400.zip
       
      and follow this tutorial for remap USB ports
       
       
      --DSDT PATCHES--
       
      -FIX ERRORS AND WARNINGS -FIX ACPI ERRORS -REMOVE UNUSED SCOPES / DEVICES -HIGH PRECISION EVENT TIMER -SATA SERIE ID -DMAC -REMOVE LINES, PROBLEMATIC and UNUSED -FIX K.P in REBOOT -NVRAM -REAL TIME CLOCK -SLPB -DARWIN / WINDOWS -XHCI -PLUGIN TYPE -HDEF -ARTC -IPIC -TIMR -SBUS -BUS1 -MCHC -ALS0 -SHUTDOWN -UAR1 -LAN -FWHD -USBX -PMCR -PPMC -XSPI -kUSBCompanionIndex -io-device-location -IMEI -EC -PNLF -ARPT -GFX0 -NVME -ACPI-WAKE-GPE -DTGP -HDMI / HDAU  
      --SCREENSHOTS--































      -If you want to buy me a beer - Donations with PayPal
      https://tinyurl.com/r2bvzm7
       
      Big Thanks to XLR and your Badass Motherboard, Ultrafast CPU, Coolest Heatsink, Huge Graphics Card, Tonnes of RAM,
      Gigantic Hard Drive, Lightspeed Disk Burner, Professional Sound Card, Massive LCD Display.
       
       
      -Credits and thanks to the old and new people in the community who developed patches, kexts and bootloaders!
      Slice, Kabyl, usr-sse2, jadran, Blackosx, dmazar, STLVNUB, pcj, apianti, JrCs, pene, FrodoKenny, skoczy, ycr.ru, Oscar09, xsmile, SoThOr, RehabMan, Download-Fritz, Zenit432, cecekpawon, Intel, Apple, Oracle, Chameleon Team, crazybirdy, Mieze, Mirone, Oldnapalm, netkas, Elconiglio, artut-pt, ErmaC, Pavo, Toleda, Master Chief and family, bcc9, The King, PMheart, Sherlocks, Micky1979, vit9696, vandroiy2013, Voodoo Team, Pike R. Alpha, lvs1974, Austere.J, CVad and many, many, many others!

      We're all here to have fun and learn from each other!
    • By Nomade
      Hello All,
       
      It's been a while that I am trying to update my system to 10.15.16.
      The install seem to start, then at reboot time I only see the Normal boot and the Recovery option from the Clover boot menu.
      None of those 2 allow to complete the update.
       
      Is there any ways to force it to install and/or show the "Update" option on the Clover boot screen?
       
      PS: I'm using Z97-Gaming-3
×