Jump to content
About Just Joined group Read more... ×
Slice

Clover Themes

1,656 posts in this topic

Recommended Posts

12 hours ago, Badruzeus said:

About scrollbar currently: Yes. Even if I fill layer with non-transparent color, but drawn on top transparent background; it'll show weird black color over it.

 

I remember have reported this issue before (on vector theme thread): If Vector theme is used by default, then switched to Raster theme; Raster's Banner positioning would follow vector has. No issue if Raster theme is the default (till it changed to vector, then switched back).

 

Scrollbar fix is to change this line

https://sourceforge.net/p/cloverefiboot/code/4822/tree/rEFIt_UEFI/refit/menu.c#l3310

 

from:

    Total = egCreateFilledImage(ScrollTotal.Width, ScrollTotal.Height, FALSE, &MenuBackgroundPixel);

to:

    Total = egCreateFilledImage(ScrollTotal.Width, ScrollTotal.Height, TRUE, &MenuBackgroundPixel);

 

Share this post


Link to post
Share on other sites
Advertisement
2 minutes ago, blackosx said:

Absolutely. That works great for themes with 128px icons.

 

Settings.c has
GlobalConfig.MainEntriesSize          = 128;

 

But other themes use different sizes, for example DarkBootX icon sizes are 160px wide and BGM256 icon sizes are 256px wide.

 

I was thinking maybe the easiest solution is to allow designer to define icon width in theme.plist, but there is already a Theme->Layout->MainEntriesSize setting which I'd forgotten about, though it gives different result.

 

https://clover-wiki.zetam.org/Design

 

MainEntriesSize - The size of the main device icons is set internally in the code to 128. Changing this value will instruct Clover to scale the device icons. For example, using a value of 256 on a theme with 128px icons will show the device icons scaled up to 256px. Note: badges will not be affected and will more than likely need repositioning.
 

So needs more attention.. To be looked at after Christmas

 

Thanks for r4820 commit, could be temporary solution but it just worked.

Merry Christmas to you and your family.

VirtualBox_Clover Bootloader_24_12_2018_16_58_38.png

Share this post


Link to post
Share on other sites
22 minutes ago, blackosx said:

 

Scrollbar fix is to change this line

https://sourceforge.net/p/cloverefiboot/code/4822/tree/rEFIt_UEFI/refit/menu.c#l3310

 

from:


    Total = egCreateFilledImage(ScrollTotal.Width, ScrollTotal.Height, FALSE, &MenuBackgroundPixel);

to:


    Total = egCreateFilledImage(ScrollTotal.Width, ScrollTotal.Height, TRUE, &MenuBackgroundPixel);

 

Thanks again, it solves transparent scrollbar issue (right ss) :thumbsup_anim:

VirtualBox_Clover-Bootloader_25_12_2018_04_54_19.png

Share this post


Link to post
Share on other sites
4 hours ago, Ingwar77 said:

r4822 se ve bien

screenshot0.thumb.png.8e709851d34a61ab1a6abf6e4ed89441.png

 

a pesar de la pérdida inesperada del tema de la noche en Clovy 8 PM (GMT + 3)

1956949049_2018-12-2420_14_01.png.86dd8247c3ad57740ae555bb2928d4af.png

 

Friend great topic, I would like for my asus x540 Mojave, you can share it. Thank you

Share this post


Link to post
Share on other sites
29 minutes ago, blackosx said:

Great job! emoji3.png

My test version is terrible, and I forgot applying Bevel & Emboss on it (which I believe ur design using it hah haa)

Are you sure wanna touch your PC on Xmas moment? Can't believe that is raining on a whole day here since this morning (now is evening IDN Time), unable going to anywhere then. 

os_moja.icns_bevel.zip

Edited by Badruzeus

Share this post


Link to post
Share on other sites

1395974808_ScreenShot.png.3c03136615e7447b412b2604f44e32bb.png

 

Hello there, just wondering are these 2 parameters still working as such or there's been some modification to the way its done?

 

Asking this because made a few themes for my machines and those doesn't seem to apply no matter what... or did i missed something in the way?

 

pls some hints

thx.

Share this post


Link to post
Share on other sites

to follow up on 

I've conducted some initial testing for icon placement.

 

Notes for sanity:
=============
Default, in Settings.c
GlobalConfig.MainEntriesSize = 128;   <--- Overridden by theme.plist entry MainEntriesSize
row0TileSize = 144;                   <--- Overridden by theme.plist entry SelectionBigWidth
GlobalConfig.TileXSpace = 8;          <--- Overridden by theme.plist entry TileXSpace

 

Default in menu.c
#define ROW0_SCROLLSIZE (100)

 

=============

To start, I added some debug statements to current clover and also to r4875

DBG("UGAWidth =%d\n", UGAWidth);
DBG("GlobalConfig.MainEntriesSize =%d\n", GlobalConfig.MainEntriesSize);
DBG("row0TileSize =%d\n", row0TileSize);
DBG("GlobalConfig.Scale =%d\n", GlobalConfig.Scale);
DBG("EntriesGap =%d\n", EntriesGap);
DBG("EntriesWidth =%d\n", EntriesWidth);
DBG("MaxItemOnScreen =%d\n", MaxItemOnScreen);
DBG("row0Count =%d\n", row0Count);
DBG("row0PosX (Before) =%d\n", row0PosX);
DBG("row0PosY (Before) =%d\n", row0PosY);
DBG("row1PosX (Before) =%d\n", row1PosX);

      row0PosX = (UGAWidth + (GlobalConfig.TypeSVG ? EntriesGap : 8) - (EntriesWidth + EntriesGap)
                  * ((MaxItemOnScreen < row0Count)?MaxItemOnScreen:row0Count)) >> 1;
      row0PosY = (int)(((float)UGAHeight - LayoutMainMenuHeight * GlobalConfig.Scale) * 0.5f +
                  LayoutBannerOffset * GlobalConfig.Scale);
      row1PosX = (UGAWidth + 8 - (row1TileSize + (INTN)(8.0f * GlobalConfig.Scale)) * row1Count) >> 1;

DBG("row0PosX (After) =%d\n", row0PosX);
DBG("row0PosY (After) =%d\n", row0PosY);
DBG("row1PosX (After) =%d\n", row1PosX);


Then saved screenshots of DarkBootX and BGM raster themes and overlaid debug and measurements for comparison.

 

BGM has Selection_big at 144px and icons as 128px and works fine before and after commit 4785. This is how rEFIt was designed to work.

 

1520275931_3_4785_BGM_Screenshot2018-12-26at08_01_163.thumb.jpg.ad6d763b3da687dcfdd3bacd51743fed.jpg

 

DarkBootX, however, has Selection_big at 180px and icons as 160px and fails to be centered with commit 4785. This goes against rEFIt's original design intention but plays with layout options introduced in to Clover which allowed BGM256 to work.


1870523027_1_4785_Darkboot_Screenshot2018-12-26at07_53.08_3.thumb.jpg.6e489da1651744693169039556ca757a.jpg

 

 

Even though DarkbootX did render centred before commit 4785 or after r4820 the code was still incorrect as EntriesWidth was incorrect and and EntriesGap was not being seen on the screen.

 

EntriesWidth
=============
The current calculation of EntriesWidth is strange as Slice pointed out.

EntriesWidth = GlobalConfig.MainEntriesSize + (16 * row0TileSize) / 144;

BGM
EntriesWidth = 128 + (16 * 144) / 144;        = 144  <-- Ends up being same as Selection_big width

 

DarkBootX
EntriesWidth = 128 + (16 * 180) / 144;        = 148  <-- Ends up being neither Selection_big or icon width


Proposed Change 1
============

I suggest to just use row0TileSize (also SelectionBigWidth from theme.plist) for EntriesWidth.

      //EntriesWidth = GlobalConfig.MainEntriesSize + (16 * row0TileSize) / 144;
      EntriesWidth = row0TileSize;

Then centre the icons as per Slice's simple drawing above, otherwise themes such as DarkBootX will not be centered.

      //row0PosX = (UGAWidth + (GlobalConfig.TypeSVG ? EntriesGap : 8) - (EntriesWidth + EntriesGap)
      //            * ((MaxItemOnScreen < row0Count)?MaxItemOnScreen:row0Count)) >> 1;
      row0PosX = row0TileSize + EntriesGap;
      row0PosX = row0PosX * MaxItemOnScreen;
      row0PosX = row0PosX - EntriesGap;
      row0PosX = UGAWidth - row0PosX;
      row0PosX = row0PosX / 2;

Proposed Change 2 (Not done)
============

Also.. menu.c has

#define ROW0_SCROLLSIZE (100)

However, Clover does not use a scroll at either side of the icons, so why not have this setting user definable in the theme.plist? Setting this to a lower value can allow more larger icons to fit on a smaller screen for example.


Moving forward
============

One caveat is that as TileXSpace is now used properly, any themes based on BGM256 or for example DarkBootX which uses the layout options

            <key>TileXSpace</key>
            <integer>nn</integer>

will now properly have nn Gap between icons. This will need to be reduced in most instances. Here's an image showing BGM256 with three different TileXSpace values.

 

screenshot_BGM256_TileXSpace_diffs.thumb.jpg.57c5c7fea62802da8dfeaa88d7287a7b.jpg

 

Also, for now with Clovy theme only when SelectionOnTop="0", the selector draws the selected icon in a different position. This needs to be addressed next..

 

Here's a test build for testing:

CLOVERX64.efi.zip

 

Edited by blackosx

Share this post


Link to post
Share on other sites
On 12/26/2018 at 10:18 AM, SavageAUS said:

What's up with the line down the middle?



screenshot1.thumb.png.f23275ecfee7e8ba3a3c22c86d64459c.png

 

What can I say, "InsanelyLook" (and also "Carbon") theme use:

		<key>Background</key>
		<dict>
			...
			<key>Type</key>
			<string>Tile</string>
		</dict>

.. and provided *.png is 1080p (why I limited into this size on Theme's Description), while your display is 1440p.

You could change it to "Type=Scale" though I'm not sure about Layout potitioning related to "background".

The easier is using another background image, not should be 1440p or larger but whatever it fits the Display with "Type=Scale". Yeah, these themes are bad on this part, I could provide an alternate bkg later but honestly.. I lost my interest using fixed background since Vector theme arrived hah haa.

 

No idea with your 2nd screenshot, are you using vector theme then switched to Raster? About Banner positioning is just previous posts back on this thread, I guess. 

Share this post


Link to post
Share on other sites
8 hours ago, blackosx said:

Here's a test build for testing:

CLOVERX64.efi.zip

Here's my report;

Using your r4824 (test); both Raster & Vector theme with 128px icons as MainEntries would be alligned to the left side. Tested using Clovy and Mojave theme (No Layout customized, standard):

 

Clovy
VirtualBox_Clover Bootloader_27_12_2018_20_10_34.png

Mojave
VirtualBox_Clover Bootloader_27_12_2018_20_17_13.png
 

 

 

Any themes with bigger than 128px icons size however; are well alligned, but "TileXSpace" becomes too large: (Using Lightness256 here)

 

 

Lightness256
VirtualBox_Clover Bootloader_27_12_2018_20_22_54.png

 

Edited by Badruzeus

Share this post


Link to post
Share on other sites

This is very old bug/absent feature in DrawMainMenuEntries->BltImageCompositeBadge()

Quote

  //to simplify suppose square images

Clovy theme has non-square images so we see shifting when selected.

 

Share this post


Link to post
Share on other sites
1 hour ago, Badruzeus said:

Here's my report;

Using your r4824 (test); both Raster & Vector theme with 128px icons as MainEntries would be alligned to the left side. Tested using Clovy and Mojave theme (No Layout customized, standard):

  Reveal hidden contents

Clovy
VirtualBox_Clover Bootloader_27_12_2018_20_10_34.png

Mojave
VirtualBox_Clover Bootloader_27_12_2018_20_17_13.png
 

 

 

Any themes with bigger than 128px icons size however; are well alligned, but "TileXSpace" becomes too large: (Using Lightness256 here)

 

  Reveal hidden contents

Lightness256
VirtualBox_Clover Bootloader_27_12_2018_20_22_54.png

 

 

Thanks for testing and thanks for the report.

 

Can you try this version with added debug statements to show me what's happening? I'm sure you know, but add the following to your config.plist

    <key>Boot</key>
    <dict>
      <key>Debug</key>
      <true/>
    </dict>

debug.log will be written to /EFI/Clover/misc

 

CLOVERX64_DEBUG.zip

Share this post


Link to post
Share on other sites
49 minutes ago, blackosx said:

Can you try this version with added debug statements to show me what's happening? I'm sure you know, but add the following to your config.plist


    <key>Boot</key>
    <dict>
      <key>Debug</key>
      <true/>
    </dict>

 

debug.log attached

debug.log_gt520_r4824.zip

Share this post


Link to post
Share on other sites
[mention=331032]blackosx[/mention]
long time no see.
seems to update christmas theme and newyear theme
there is no mojave icon and apfs icon.
screenshot0.thumb.png.f7a0bd770376004b936a7fc0f0520071.png
 
thanks in advance

Hi Sherlock’s
I’ll fix it soon. Thanks for the reminder.
debug.log attached
debug.log_gt520_r4824.zip

Thanks Badruzeus.
I’ll take a look soon when I get home.

Share this post


Link to post
Share on other sites

  • Recently Browsing   0 members

    No registered users viewing this page.

Announcements

  • Similar Content

    • By MaLd0n
      -OpenCore Vanilla TUTORIAL-
       
       
      -USB Port Mapping TUTORIAL-
       
        1 -Create a USB bootable
       
      Create your usb installer, use this tool and download Catalina or Big Sur from Apple servers
       
      Catalina
      installScript_allfullapp.zip
       
      Big Sur
      installScript_1016fullapp.zip
       
      Credits: crazybirdy
       
      Copy Catalina / Big Sur installer to Applications folder, open terminal and run
       
      Catalina
       
       
      Big Sur
       
       
      If you want check one step by step, check here
       
      -Opencore Vanilla Tutorial
      https://tinyurl.com/ycvcnp8h
       
      2- EFI folder USB installation
       
      -EFI OpenCore Folder Desktop 10th Intel Processors
      Paste this EFI folder in EFI partition in your USB STICK
      https://tinyurl.com/ybwr9kq3
       
      -EFI Clover Folder Desktop 10th Intel Processors
      Paste this EFI folder in EFI partition in your USB STICK
      https://tinyurl.com/y6avuxsv
       
       
      3- EFI folder SSD
       
      -EFI OpenCore Folder Desktop 10th Intel Processors
      Paste this EFI folder in EFI partition SSD 
      https://tinyurl.com/ybwr9kq3
       
      -EFI Clover Folder Desktop 10th Intel Processors
      Paste this EFI folder in EFI partition SSD
      https://tinyurl.com/y6avuxsv
       
      4- Start Fine Tune
       
      Run this app and post full dump here for full ACPI solution
       
      RunMe.app
      https://tinyurl.com/y9562hz7
       
       
      If you like a SSDT way, here we go
      SSDT-OLARILA.aml.zip
       
      5- USB Solution
      USB INTEL SERIE 400.zip
       
      Use these kexts, enable XHCI port limit patch and follow this tutorial for remap USB ports
       
       
       
      --DSDT PATCHES--
       
      -FIX ERRORS AND WARNINGS -FIX ACPI ERRORS -REMOVE UNUSED SCOPES / DEVICES -HIGH PRECISION EVENT TIMER -SATA SERIE ID -DMAC -REMOVE LINES, PROBLEMATIC and UNUSED -FIX K.P in REBOOT -NVRAM -REAL TIME CLOCK -SLPB -DARWIN / WINDOWS -XHCI -PLUGIN TYPE -HDEF -ARTC -IPIC -TIMR -SBUS -BUS1 -MCHC -ALS0 -SHUTDOWN -UAR1 -LAN -FWHD -USBX -PMCR -PPMC -XSPI -kUSBCompanionIndex -io-device-location -IMEI -EC -PNLF -ARPT -GFX0 -NVME -ACPI-WAKE-GPE -DTGP -HDMI / HDAU  
      --SCREENSHOTS--































      -If you want to buy me a beer - Donations with PayPal
      https://tinyurl.com/r2bvzm7
       
      Big Thanks to XLR and your Badass Motherboard, Ultrafast CPU, Coolest Heatsink, Huge Graphics Card, Tonnes of RAM,
      Gigantic Hard Drive, Lightspeed Disk Burner, Professional Sound Card, Massive LCD Display.
       
       
      -Credits and thanks to the old and new people in the community who developed patches, kexts and bootloaders!
      Slice, Kabyl, usr-sse2, jadran, Blackosx, dmazar, STLVNUB, pcj, apianti, JrCs, pene, FrodoKenny, skoczy, ycr.ru, Oscar09, xsmile, SoThOr, RehabMan, Download-Fritz, Zenit432, cecekpawon, Intel, Apple, Oracle, Chameleon Team, crazybirdy, Mieze, Mirone, Oldnapalm, netkas, Elconiglio, artut-pt, ErmaC, Pavo, Toleda, Master Chief and family, bcc9, The King, PMheart, Sherlocks, Micky1979, vit9696, vandroiy2013, Voodoo Team, Pike R. Alpha, lvs1974, Austere.J, CVad and many, many, many others!

      We're all here to have fun and learn from each other!
    • By y010204025
      Update: On October 24, 2020, using clover to solve the macOS11 beta10 boot problem, you can now enjoy macOS11beta10, and the compatibility of subsequent versions is not guaranteed.
      HIDPI uses a modified version. You can directly execute the hidpi script to get a better experience. If you lose the repair, it is not within the scope of my support.
      Support upgrades without destroying the integrity of the original image.
      There seems to be a problem with the shortcut keys. If you can help solve it, thank you for your contribution.
       
      Perhaps it was the first NEC (Lenovo) Lavie Z HZ550 to install hackintosh. I hope more people who like Lavie Z series can experience Hackintosh at HZ550. She is really great.
       
      I found HZ550 & HZ750 on the Chinese website, which is amazing. It weighs only 790g, 13.3 inches, and the standard 2k screen, which is too attractive to me. I am a Hackintosh enthusiast. I think HZ550 or HZ750 with MacOS is the best Unfortunately, the Lavie Z series is not listed in China, only exists in the Japanese and American markets, and in the Japanese market is the NEC brand, while the American market uses the Lenovo logo.
       
      Fortunately, I got an HZ550 from Taobao. Yes, not HZ750. In comparison, HZ750 has more touch screens and 360 ° flip. These are hard to attract me. More importantly, HZ750 is about 200g heavier than HZ550 That's why I chose HZ550. Well, because he is only 2,000 RMB.
       
      The specific introduction can refer to NEC Japan official website:http://nec-lavie.jp/products/hz13b/
       
      The HZ550 hardware list I obtained:
                                    
                       -/+:.          ningnan@ningnandeMacBook-Air
                      :++++.          OS: 64bit Mac OS X 10.15.5 19F96
                     /+++/.           Kernel: x86_64 Darwin 19.5.0
             .:-::- .+/:-``.::-       Uptime: 19m
          .:/++++++/::::/++++++/:`    Packages: 1
        .:///////////////////////:`   Shell: zsh 5.7.1
        ////////////////////////`     Resolution: 3840x2160
       -+++++++++++++++++++++++`      DE: Aqua
       /++++++++++++++++++++++/       WM: Quartz Compositor
       /sssssssssssssssssssssss.      WM Theme: Blue (Dark)
       :ssssssssssssssssssssssss-     Disk: 11G / 108G (12%)
        osssssssssssssssssssssssso/`  CPU: Intel Core i7-5500U @ 2.40GHz
        `syyyyyyyyyyyyyyyyyyyyyyyy+`  GPU: Intel Iris Graphics 6100
         `ossssssssssssssssssssss/    RAM: 4376MiB / 8192MiB
           :ooooooooooooooooooo+.    
            `:+oo+/:-..-:/+o+/-     
       
       
      Advantages: small size, light weight, 2K screen, 8G memory, 512g SSD, keyboard feels good, and wireless network card can be replaced, which is unimaginable in today's thin and light books.
      Disadvantages: The sound is small, almost the same as the mosquitoes.
       
      Ok, bragging is over!
      In order to use the wireless network, I changed the wireless network card from inter 7265 to BCM94352ZAE. Some people called it DW1560. It is uncomfortable that in China, this card and his elder brother DW1830 were hyped to a high price of 480RMB. of. Fortunately, I bought it early, and this card is also very stable under win10, and there is no high delay and outage. The hard disk should be PM951 of Samsung, not PM981, which is lucky.   Before installing Hackintosh: You need to prepare a 16G U disk, SanDisk is not a rough choice for making MacOS installation disk, I used the latest MacOS Catalina 10.15.5, got config.plist from Rehabman, and put together an EFI, the latest version of clover and kext drivers. Thanks to Rehabman and the developers of the Black Apple community. I do n’t like that OC team very much.
      Make an installation disk: If you have a computer running MacOS, you can use the command line to make it, if you do n’t have a computer running MacOS, you can try VMware, I know that the insanelymac forum allows discussion, or use ether to write the image to U disk, use the EFI I provided to boot into the installation process.   BIOS setting: Press F12 at boot to enter the BIOS settings, Tab switches to "Security-Secure boot", set to "DISable", this is what we need, and switch to "Boot -Boot devices", set the U disk as the first boot item You can directly enter the clover guide interface, please follow it for google it.
      It is worth noting that the remaining space of your EFI partition needs to be greater than 200M, otherwise, the disk format will be wrong. In addition, the format partition format is APFS, do not choose to encrypt, your data is not valuable, at least you must have this awareness of Hackintosh, the file safe is also the same, do not enable, do not use to find your mac, otherwise, change the machine, OK .   Fortunately, no additional ssdt patch is required. All the patch functions are implemented through clover. The flat Apple is turned on. This is to solve the problem of the flower screen. You can find a solution yourself.
      Experience your black apple, this will bring a better experience than MacBook Pro.  
       
    • By BALDY_MAN
      Hi All.
      Im Happy to share my new EFI file that I put together  18/10/2020. which got me up and running 11.0  Beta(20A5395g) on my hack
      a thanks you to everyone who's work I have use to assemble this EFI File. and the help I have received from this site
      I have used openCore 0.6.3, sound work for me (HDMI) and onboard Ethernet. map the usb ports as you wish.
      the definition to iMac20,2
      hope it helps all who need it
      PS. Please leave a comment if the EFI File is helpful to you
      (No Kexts were Harmed in the making of this EFI)
      THIS EFI. WAS MADE ON A Z490 GIGABYTE MASTER For the Z490 Gigabyte Master ONLY
                                                                                                                     regards
                                                                                                                                         Baldy_man
      GigabyteZ40Master.EFI.(20A539g) .zip
    • By qmgoqwe
      I have installed MacOS and Windows on the following hardware:
       
      AMD Ryzen 7 3700X MSI B450M Mortar Max Sapphire Radeon Pulse RX 5600 XT 6G Samsung 860 QVO, 1 TB SSD (PciRoot(0x0)/Pci(0x1,0x3)/Pci(0x0,0x1)/Sata(0x5,0xFFFF,0x0)) - MacOS on this disk Kingston A2000 SSD 1TB M.2 2280 NVMe (PciRoot(0x0)/Pci(0x1,0x1)/Pci(0x0,0x0)/NVMe(0x1,15-AD-CD-26-28-B7-26-00)) - Windows on this disk  
      OpenCore 0.6.1 MacOS 10.15.7 both disks GPT UEFI  
      Both OSs boot nicely and work as a charm when selecting either of the disks as boot disks in the BIOS.
       
      However, trying to boot Windows 10 from the Opencore Bootmanager (no matter whether PickerMode=internal or OpenCanopy) causes a Windows Blue Screen ("SYSTEM THREAD EXCEPTION NOT HANDLED").
      To be on the safe side, I have added an appropriate entry to Misc->Entries:
      <key>Arguments</key> <string></string> <key>Auxiliary</key> <false/> <key>Comment</key> <string>Not signed for security reasons</string> <key>Enabled</key> <true/> <key>Name</key> <string>Windows 10</string> <key>Path</key> <string>PciRoot(0x0)/Pci(0x1,0x1)/Pci(0x0,0x0)/NVMe(0x1,15-AD-CD-26-28-B7-26-00)/HD(1,GPT,2E9695CB-0F9A-4005-AADB-2FF9C96AD02C,0x800,0x32000)/\EFI\Microsoft\Boot\bootmgfw.efi</string> It points to the Windows 10 bootmanager on the Windows disk's EFI partition.
       
      What's wrong with that? Why does this cause a BSOD? It is not clear to me why it works when booting from BIOS but not here.
       
      config.plist attached (but maybe it has no relevance for the problem).
      config.plist
    • By le332313
      Can someone share the dell 5593/5493 EFI ? I try to fit the graphics driver, but it not working please help me thanks
       
×