Jump to content
Slice

Clover Themes

1,656 posts in this topic

Recommended Posts

The problem is that because of vector themes, slice changed the way all themes are drawn. He proposed a solution but I believe that there is a better one probably where the value is calculated automatically from the size of the icons. Not sure though as I haven't looked at it closely enough, the GUI seriously gives me nightmares....

Share this post


Link to post
Share on other sites
Advertisement
1 hour ago, blackosx said:

@Badruzeus

Can you try your themes with this test version of Clover?

CLOVER.efi.zip

Thank you, 256px MainEntries are well alligned with your r4817 (test).. only Buttons & Text are off position if using "BootCampStyle=true". Weird is Vector theme, compared to r4713 (with r4785 unCommitted) both have 8px Offset to the left (Orange box). Does this how latest Clovy.svg look like? This is what I meant on prev. post actually.

VirtualBox_Clover-GUI-001.png

 

r4813 (unCommitting r4785):

VirtualBox_Clover-GUI-002.png

Edited by Badruzeus

Share this post


Link to post
Share on other sites

Morning. Just woke up to see your test results. Thanks for testing. :)

 

This is a good start then.

 

Well that test just reverted one change in commit #4785 where rox0PosX was changed to have the value of EntriesGap, instead of 8 (where did this 8 come from?) added to the calculation. In my 256px theme.plist, EntriesGap was 128 as this comes from Theme->Layout->TileXSpace.

-      row0PosX = (UGAWidth + 8 - (EntriesWidth + EntriesGap) *
-                  ((MaxItemOnScreen < row0Count)?MaxItemOnScreen:row0Count)) >> 1;
+      row0PosX = (UGAWidth + EntriesGap - (EntriesWidth + EntriesGap)
+                  * ((MaxItemOnScreen < row0Count)?MaxItemOnScreen:row0Count)) >> 1;

So it's now back to 8 (in my local source) as it used to be and may go on to explain why vector themes are off by 8 as you've discovered.

 

I've not used BootCampStyle but where you say 'only Buttons & Text are off position if using "BootCampStyle=true"' then I would hazard a guess that I will need to look at how Theme->Layout->TileYSpace from the theme.plist is taken in to account.

 

I'm out for most of today so won't be able to spend too much time on in.. but I'll see what I can come up with to help.

 

Keep up your hard work with your excellent themes.

Share this post


Link to post
Share on other sites

After a quick test, setting BootCampStyle to BGM256 seems okay. Buttons and text are vertically placed okay so TileYSpace is being taken in to account with the current setting of 128 works. Have you got TileYSpace set in your theme.plist?

 

I'm outta time for now. Gotta go.

 

Edit. Need more testing with layout settings in theme.plist

Share this post


Link to post
Share on other sites

@Slice Sorry for another report.

We have weird scrollbar appearance since r4811, only bar_fill & scroll_fill are shown properly (especially if they contain Alpha). Thanks.

 

scrollbar_r4811.png

Edited by Badruzeus

Share this post


Link to post
Share on other sites
5 hours ago, blackosx said:

After a quick test, setting BootCampStyle to BGM256 seems okay. Buttons and text are vertically placed okay so TileYSpace is being taken in to account with the current setting of 128 works. Have you got TileYSpace set in your theme.plist?

 

I'm outta time for now. Gotta go.

 

Edit. Need more testing with layout settings in theme.plist

Oops, I just realized that you replied twice.
OK, added "TileYSpace=N" under Layout, now Buttons & Text are shown properly for 256px theme with "BootCampStyle=true" (using your r4817 test). Many thanks.

BCS_TileYSpace.png

Edited by Badruzeus

Share this post


Link to post
Share on other sites
1 hour ago, Badruzeus said:

@Slice Sorry for another report.

We have weird scrollbar appearance since r4811, only bar_fill & scroll_fill are shown properly (especially if they contain Alpha). Thanks.

 

Oh, because the scrollbar was reduced to only those two parts instead of the six(?) it was previously.

 

EDIT: From here: 

 

Edited by apianti

Share this post


Link to post
Share on other sites
8 hours ago, blackosx said:

Morning. Just woke up to see your test results. Thanks for testing. :)

 

This is a good start then.

 

Well that test just reverted one change in commit #4785 where rox0PosX was changed to have the value of EntriesGap, instead of 8 (where did this 8 come from?) added to the calculation. In my 256px theme.plist, EntriesGap was 128 as this comes from Theme->Layout->TileXSpace.


-      row0PosX = (UGAWidth + 8 - (EntriesWidth + EntriesGap) *
-                  ((MaxItemOnScreen < row0Count)?MaxItemOnScreen:row0Count)) >> 1;
+      row0PosX = (UGAWidth + EntriesGap - (EntriesWidth + EntriesGap)
+                  * ((MaxItemOnScreen < row0Count)?MaxItemOnScreen:row0Count)) >> 1;

So it's now back to 8 (in my local source) as it used to be and may go on to explain why vector themes are off by 8 as you've discovered.

 

I've not used BootCampStyle but where you say 'only Buttons & Text are off position if using "BootCampStyle=true"' then I would hazard a guess that I will need to look at how Theme->Layout->TileYSpace from the theme.plist is taken in to account.

 

I'm out for most of today so won't be able to spend too much time on in.. but I'll see what I can come up with to help.

 

Keep up your hard work with your excellent themes.

 

Guessing that the line should instead be something like this instead:

      row0PosX = (UGAWidth + (GlobalConfig.TypeSVG ? 8 : EntriesGap) - (EntriesWidth + EntriesGap)
                  * ((MaxItemOnScreen < row0Count)?MaxItemOnScreen:row0Count)) >> 1;

 

Share this post


Link to post
Share on other sites
5 hours ago, Badruzeus said:

Oops, I just realized that you replied twice.
OK, added "TileYSpace=N" under Layout, now Buttons & Text are shown properly for 256px theme with "BootCampStyle=true" (using your r4817 test). Many thanks.

BCS_TileYSpace.png

That's great! Thanks for letting me know.

20 hours ago, Badruzeus said:

Weird is Vector theme, compared to r4713 (with r4785 unCommitted) both have 8px Offset to the left (Orange box). Does this how latest Clovy.svg look like? 

 

I also see clovy's icons offset to the left, but what's strange is BGM_SVG's icons are not.

 

1098292965_Screenshot2018-12-22at19_16_30.thumb.png.4ba36a1d2b35cc361e89f505bc91bff1.png

 

Share this post


Link to post
Share on other sites
3 hours ago, Awesome Donkey said:

Great to see the alignment issue with raster themes being looked into - hopefully the fix works for 128px raster themes too.

AFAICT, 128px raster themes look fine.

 

raster.thumb.jpg.b86eb077c6053045b06c9c8a2e73ed5a.jpg

2 hours ago, apianti said:

 

Guessing that the line should instead be something like this instead:


      row0PosX = (UGAWidth + (GlobalConfig.TypeSVG ? 8 : EntriesGap) - (EntriesWidth + EntriesGap)
                  * ((MaxItemOnScreen < row0Count)?MaxItemOnScreen:row0Count)) >> 1;

 

 

or actually, 

      row0PosX = (UGAWidth + (GlobalConfig.TypeSVG ? EntriesGap : 8) - (EntriesWidth + EntriesGap)
                  * ((MaxItemOnScreen < row0Count)?MaxItemOnScreen:row0Count)) >> 1;

as the 8 would not be used if SVG theme is true.

1 hour ago, Ingwar77 said:

"TileYSpace=N" under Layout

Do you mean "NO" Boolean,
or "N" string neutral,
or what? :huh:

in the above example, N would be an integer value to represent a number of pixels.

Share this post


Link to post
Share on other sites
1 hour ago, blackosx said:

I also see clovy's icons offset to the left, but what's strange is BGM_SVG's icons are not.

 

1098292965_Screenshot2018-12-22at19_16_30.thumb.png.4ba36a1d2b35cc361e89f505bc91bff1.png

 

This is down to the following section in VectorGraphics.c 

        if ((strstr(IconName, "selection_big") != NULL) && (!GlobalConfig.SelectionOnTop)) {
          GlobalConfig.MainEntriesSize = (int)(IconImage->width * Scale); //xxx
          row0TileSize = GlobalConfig.MainEntriesSize; // + (int)(16.f * Scale);
          DBG("main entry size = %d\n", GlobalConfig.MainEntriesSize);
        }

So the GlobalConfig.MainEntriesSize is only scaled if GlobalConfig.SelectionOnTop is not true.

 

Clovy has the selection set to be below:

SelectionOnTop="0"

 

Where as BGM_SCV has selection set to be above

SelectionOnTop="1"

 

Clovy:

9:139  0:004  GlobalConfig.MainEntriesSize =144

 

BGM_SVG:

9:898  0:048  GlobalConfig.MainEntriesSize =128

 

Changing Clovy theme to have SelectionOnTop="1" correctly centres the icons.

 

So I would say the above code needs to be changed to remove the condition regarding the state of GlobalConfig.SelectionOnTop ?

EDIT: no..needs more checks..

 

Edited by blackosx

Share this post


Link to post
Share on other sites

Thanks for letting me know. I'll test with the DarkBootX theme and see.

 

Looks OK here on my current build, but then I'm currently working on changes. Did you try with the build I posted yesterday (above)?

 

 

screenshot.thumb.jpg.78fb08cf23b7cdd68a227cdce1690e4b.jpg

Edited by blackosx

Share this post


Link to post
Share on other sites

Err, yeah, I wrote it backwards in haste but you knew what I was getting at. Have you looked at multiple rows to see if they are correct (and a bunch of custom entries)? Because it looks like they might have the same issue...

 

EDIT: Misspelled a word.

Edited by apianti

Share this post


Link to post
Share on other sites
1 hour ago, Awesome Donkey said:

 

Odd, I use the DarkBootX theme (latest version of the theme + latest Clover) and the MainEntries are off center.

Well, MainEntries are using 160px instead of 128px, duno why I got some difficulties when applying graphics fx with smaller layer; they're pixelated on some parts. If you take a look a theme like "Outlines"; I did layer crop to the OS logo.. I could get outline (stroke) no more than 1px if using small layer so.. they'll be pixelated: things that honestly I hate with Raster graphics if not using a proper image resampling method and or good properties when exporting 8-bit png (especially, if they contain transparency). They'll be better if built from vector but FYi, not all my Raster themes came from vector.

 

Anyway, I'm currently filtering my themes collection and see which of them will be converted (or rebuilt) to vector / svg. So, themes with 256px could be merged into one on the future (with 128px as standard for MainEntries) and Theme's repo will be slimmer (I hope, and not confusing ppl why there're more than one theme with a same look but just diff. size LoL).

Share this post


Link to post
Share on other sites
1 hour ago, blackosx said:

Multiple rows? Sorry, not sure I understand. Do you mean multiple entries?

Edit: yeah I’m sure you do as you said add a bunch of custom entries

 

Ugh, I'm out of it. I mean like if there are more entries than appear on the screen, do they work right? And is there a difference between the rows between themes? Because it looks like the second row of icons is lower on raster themes now then vector themes, I think the same issue just vertically.

 

EDIT: I think I mean the reverse but whatever, I have no idea what I'm saying anymore, there just appears to be a difference.

Edited by apianti

Share this post


Link to post
Share on other sites
5 hours ago, Badruzeus said:

Well, MainEntries are using 160px instead of 128px, duno why I got some difficulties when applying graphics fx with smaller layer; they're pixelated on some parts. If you take a look a theme like "Outlines"; I did layer crop to the OS logo.. I could get outline (stroke) no more than 1px if using small layer so.. they'll be pixelated: things that honestly I hate with Raster graphics if not using a proper image resampling method and or good properties when exporting 8-bit png (especially, if they contain transparency). They'll be better if built from vector but FYi, not all my Raster themes came from vector.

 

Anyway, I'm currently filtering my themes collection and see which of them will be converted (or rebuilt) to vector / svg. So, themes with 256px could be merged into one on the future (with 128px as standard for MainEntries) and Theme's repo will be slimmer (I hope, and not confusing ppl why there're more than one theme with a same look but just diff. size LoL).

I assume that your vector themes will be 128px very nice, I can not wait to try it.

Great luck in making vector themes 128 px.
 

Share this post


Link to post
Share on other sites
11 hours ago, blackosx said:
13 hours ago, Ingwar77 said:

"TileYSpace=N" under Layout

Do you mean "NO" Boolean,
or "N" string neutral,
or what? :huh:

in the above example, N would be an integer value to represent a number of pixels.

Now the value is 32, which one do you suggest?

Share this post


Link to post
Share on other sites
35 minutes ago, Ingwar77 said:

Now the value is 32, which one do you suggest?

Are you referring to blackosx's r4817 (test version)..?

It depends on which theme used and MainEntries size.

Example below is using "FlatCamp" theme with "BootCampStyle=true", it has 160px for MainEntries BTW.

 

Spoiler

		<key>Layout</key>
		<dict>
			...
			<key>ButtonOffset</key>
			<integer>32</integer>
			<key>TileXSpace</key>
			<integer>40</integer>
			<key>Vertical</key>
			<false/>
			...
		</dict>

 

"TileYSpace" is not used under Layout; it looks fine. But for theme with 256px MainEntries, it' s needed on this case.

This could be temporary solution anyway.

FlatCamp-Test-BCS-r4817.png

Edited by Badruzeus

Share this post


Link to post
Share on other sites
17 hours ago, blackosx said:

Thanks for letting me know. I'll test with the DarkBootX theme and see.

 

Looks OK here on my current build, but then I'm currently working on changes. Did you try with the build I posted yesterday (above)?

 

Yes I am using the build you posted yesterday (but I did have to rename CLOVER.efi to CLOVERX64.efi if that makes any difference) along with the current DarkBootX theme (v1.7) with a custom icon for macOS Mojave (doesn't make a difference if I use the original one). Random thought; would forcing screen resolution in Clover cause it to happen? If so, I have mine forced to display at 2560x1440. But yeah, MainEntries are still off-center for me. Second random thought; I also use only custom entries too, perhaps that's why it happens?

 

EDIT: I removed the 2560x1440 screen resolution, and it didn't make a difference so it isn't that.

 

EDIT 2: Switched from custom entries to auto and that doesn't make a difference either, MainEntries are still off-center for me. I'm stumped now.

 

screenshot2.thumb.png.9688543b90f755e2cf39970e9d9df94a.png

Edited by Awesome Donkey

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

Announcements

  • Similar Content

    • By le332313
      Can someone share the dell 5593/5493 EFI ? I try to fit the graphics driver, but it not working please help me thanks
       
    • By MaLd0n
      -OpenCore Vanilla TUTORIAL-
       
       
      -USB Port Mapping TUTORIAL-
       
        1 -Create a USB bootable
       
      Create your usb installer, use this tool and download Catalina or Big Sur from Apple servers
       
      Catalina
      installScript_allfullapp.zip
       
      Big Sur
      installScript_1016fullapp.zip
       
      Credits: crazybirdy
       
      Copy Catalina / Big Sur installer to Applications folder, open terminal and run
       
      Catalina
       
       
      Big Sur
       
       
      If you want check one step by step, check here
       
      -Opencore Vanilla Tutorial
      https://tinyurl.com/ycvcnp8h
       
      2- EFI folder USB installation
       
      -EFI OpenCore Folder Desktop 10th Intel Processors
      Paste this EFI folder in EFI partition in your USB STICK
      https://tinyurl.com/ybwr9kq3
       
      -EFI Clover Folder Desktop 10th Intel Processors
      Paste this EFI folder in EFI partition in your USB STICK
      https://tinyurl.com/yxsw7d3t
       
      3- EFI folder SSD
       
      -EFI OpenCore Folder Desktop 10th Intel Processors
      Paste this EFI folder in EFI partition SSD 
      https://tinyurl.com/ybwr9kq3
       
      -EFI Clover Folder Desktop 10th Intel Processors
      Paste this EFI folder in EFI partition SSD
      https://tinyurl.com/yxsw7d3t
       
      4- Start Fine Tune
       
      Run this app and post full dump here for full ACPI solution
       
      RunMe.app
      https://tinyurl.com/y9562hz7
       
       
      If you like a SSDT way, here we go
      SSDT-OLARILA.aml.zip
       
      5- USB Solution
       
      Use these kexts, enable XHCI port limit patch
       
      USB INTEL SERIE 400.zip
       
      and follow this tutorial for remap USB ports
       
       
      --DSDT PATCHES--
       
      -FIX ERRORS AND WARNINGS -FIX ACPI ERRORS -REMOVE UNUSED SCOPES / DEVICES -HIGH PRECISION EVENT TIMER -SATA SERIE ID -DMAC -REMOVE LINES, PROBLEMATIC and UNUSED -FIX K.P in REBOOT -NVRAM -REAL TIME CLOCK -SLPB -DARWIN / WINDOWS -XHCI -PLUGIN TYPE -HDEF -ARTC -IPIC -TIMR -SBUS -BUS1 -MCHC -ALS0 -SHUTDOWN -UAR1 -LAN -FWHD -USBX -PMCR -PPMC -XSPI -kUSBCompanionIndex -io-device-location -IMEI -EC -PNLF -ARPT -GFX0 -NVME -ACPI-WAKE-GPE -DTGP -HDMI / HDAU  
      --SCREENSHOTS--































      -If you want to buy me a beer - Donations with PayPal
      https://tinyurl.com/r2bvzm7
       
      Big Thanks to XLR and your Badass Motherboard, Ultrafast CPU, Coolest Heatsink, Huge Graphics Card, Tonnes of RAM,
      Gigantic Hard Drive, Lightspeed Disk Burner, Professional Sound Card, Massive LCD Display.
       
       
      -Credits and thanks to the old and new people in the community who developed patches, kexts and bootloaders!
      Slice, Kabyl, usr-sse2, jadran, Blackosx, dmazar, STLVNUB, pcj, apianti, JrCs, pene, FrodoKenny, skoczy, ycr.ru, Oscar09, xsmile, SoThOr, RehabMan, Download-Fritz, Zenit432, cecekpawon, Intel, Apple, Oracle, Chameleon Team, crazybirdy, Mieze, Mirone, Oldnapalm, netkas, Elconiglio, artut-pt, ErmaC, Pavo, Toleda, Master Chief and family, bcc9, The King, PMheart, Sherlocks, Micky1979, vit9696, vandroiy2013, Voodoo Team, Pike R. Alpha, lvs1974, Austere.J, CVad and many, many, many others!

      We're all here to have fun and learn from each other!
    • By Nomade
      Hello All,
       
      It's been a while that I am trying to update my system to 10.15.16.
      The install seem to start, then at reboot time I only see the Normal boot and the Recovery option from the Clover boot menu.
      None of those 2 allow to complete the update.
       
      Is there any ways to force it to install and/or show the "Update" option on the Clover boot screen?
       
      PS: I'm using Z97-Gaming-3
    • By Damx
      The specs CPU: Intel® Core™ i3 Processor 8130U, 2.20 GHz (Kaby Lake Refresh) Chipset: Intel® 300 Series Graphics: Intel® UHD Graphics 620 Display: 21.5'' 1920x1200 RAM: DDR4 PC2400 4GB SSD1: M.2 PLEXTOR (with original Windows 10) SSD2: SATA SAMSUNG 850 EVO (for macOS) Sound: Realtek ALC269 WiFi / BT: Intel 3168 NGW Realtek Card-reader  
       
      Not working
      WiFi: Intel 3168 NGW Realtek Card-reader  
       
      Pre-Installation
       
      I will not go through the basics since it is explained in details here on this site. Briefly, the process is to:
      Get Clover Get Catalina macOS installer Create USB with 2 MBR partitions (FAT32 for Clover and HFS+J for the installer)  
       
      Required kexts
      AppleALC.kext Lilu.kext RealtekRTL8111.kext VirtualSMC.kext WhateverGreen.kext  
       
      Config.plist
      I used the one provided by RehabMan called config_HD615_620_630_640_650.plist. Download it from GitHub. It has almost everything you will need with only few edits for audio.
      Edits:
      [CPU] Make sure there is lilcpu=9 setting in boot arguments needed for Kaby Lake R CPU to be recognised correctly. [GPU] Make sure there is a patch GFX0 to IGPU under ACPI->DSDT [GPU] Under Devices->Properties->PciRoot(0)/Pci(0x02,0) make sure that the AAPL,ig-platform-id value is 00001B59, and the device-id value is 16590000 [AUDIO] Under Devices->Properties->PciRoot(0)/Pci(0x1f,3) set the layout-id to 40 and the device-id to 70A10000 [SMBIOS] Set Mac model ID is iMac19,2  

       

       
      Notes
      For some reason with latest version of Clover the install partition was not visible. If you run into the same issue you can downgrade Clover to r5103, which worked perfectly. WiFi / BT Intel 3168 NGW needs to be replaced if one needs WiFi. Someone mentioned that to get HDMI work properly you may need to change AAPL,ig-platform-id value to 00001659 for PciRoot(0)/Pci(0x02,0) - not my case but may be considered if you get this issue. Don't forget to generate your serial and other SMBUS values before signing in with iCloud services.  
       
    • By MaLd0n
      A very custom DSDT for best experience under macOS. Removed all unused devices, injected all Apple devices, essentials, cosmetics, real improvements. 
       
      -OpenCore Vanilla TUTORIAL-
       
       
      -USB Port Mapping TUTORIAL-
       
          -Original DSDT have 167,880 lines and 762kb
       
      DSDT ORIGINAL.aml.zip138.01 kB · 8 downloads
       
      -Patched DSDT have 30,912 lines and 111kb
       
      DSDT PATCHED.aml.zip27.01 kB · 17 downloads
       
      --Hardware--
      Asus ROG RAMPAGE VI EXTREME OMEGA

      Processor  Intel i9-10980XE

      GPU Radeon RX 5700 XT

      --DSDT Patches--
      -FIX ERRORS AND WARNINGS -FIX ACPI ERRORS -REMOVE UNUSED SCOPES / DEVICES -HIGH PRECISION EVENT TIMER -SATA SERIE ID -DMAC -REMOVE LINES, PROBLEMATIC and UNUSED -REAL TIME CLOCK -SLPB -DARWIN / WINDOWS -XHCI -PLUGIN TYPE -HDEF -ARTC -IPIC -TIMR -SBUS -BUS1 -MCHC -ALS0 -SHUTDOWN -UAR1 -LAN -FWHD -USBX -XSPI -EC -PNLF -ARPT -GFX0 -NVME  
      --Screenshots-



















       
      -Credits and thanks to the old and new people in the community who developed patches, kexts and bootloaders!
      Slice, Kabyl, usr-sse2, jadran, Blackosx, dmazar, STLVNUB, pcj, apianti, JrCs, pene, FrodoKenny, skoczy, ycr.ru, Oscar09, xsmile, SoThOr, RehabMan, Download-Fritz, Zenit432, cecekpawon, Intel, Apple, Oracle, Chameleon Team, crazybirdy, Mieze, Mirone, Oldnapalm, netkas, Elconiglio, artut-pt, ErmaC, Pavo, Toleda, Master Chief and family, bcc9, The King, PMheart, Sherlocks, Micky1979, vit9696, vandroiy2013, Voodoo Team, Pike R. Alpha, lvs1974, Austere.J, CVad and many, many, many others!

      We're all here to have fun and learn from each other!
×