Jump to content
Slice

Clover Themes

1,610 posts in this topic

Recommended Posts

The problem is that because of vector themes, slice changed the way all themes are drawn. He proposed a solution but I believe that there is a better one probably where the value is calculated automatically from the size of the icons. Not sure though as I haven't looked at it closely enough, the GUI seriously gives me nightmares....

Share this post


Link to post
Share on other sites
Advertisement
1 hour ago, blackosx said:

@Badruzeus

Can you try your themes with this test version of Clover?

CLOVER.efi.zip

Thank you, 256px MainEntries are well alligned with your r4817 (test).. only Buttons & Text are off position if using "BootCampStyle=true". Weird is Vector theme, compared to r4713 (with r4785 unCommitted) both have 8px Offset to the left (Orange box). Does this how latest Clovy.svg look like? This is what I meant on prev. post actually.

VirtualBox_Clover-GUI-001.png

 

r4813 (unCommitting r4785):

VirtualBox_Clover-GUI-002.png

Edited by Badruzeus

Share this post


Link to post
Share on other sites

Morning. Just woke up to see your test results. Thanks for testing. :)

 

This is a good start then.

 

Well that test just reverted one change in commit #4785 where rox0PosX was changed to have the value of EntriesGap, instead of 8 (where did this 8 come from?) added to the calculation. In my 256px theme.plist, EntriesGap was 128 as this comes from Theme->Layout->TileXSpace.

-      row0PosX = (UGAWidth + 8 - (EntriesWidth + EntriesGap) *
-                  ((MaxItemOnScreen < row0Count)?MaxItemOnScreen:row0Count)) >> 1;
+      row0PosX = (UGAWidth + EntriesGap - (EntriesWidth + EntriesGap)
+                  * ((MaxItemOnScreen < row0Count)?MaxItemOnScreen:row0Count)) >> 1;

So it's now back to 8 (in my local source) as it used to be and may go on to explain why vector themes are off by 8 as you've discovered.

 

I've not used BootCampStyle but where you say 'only Buttons & Text are off position if using "BootCampStyle=true"' then I would hazard a guess that I will need to look at how Theme->Layout->TileYSpace from the theme.plist is taken in to account.

 

I'm out for most of today so won't be able to spend too much time on in.. but I'll see what I can come up with to help.

 

Keep up your hard work with your excellent themes.

Share this post


Link to post
Share on other sites

After a quick test, setting BootCampStyle to BGM256 seems okay. Buttons and text are vertically placed okay so TileYSpace is being taken in to account with the current setting of 128 works. Have you got TileYSpace set in your theme.plist?

 

I'm outta time for now. Gotta go.

 

Edit. Need more testing with layout settings in theme.plist

Share this post


Link to post
Share on other sites

@Slice Sorry for another report.

We have weird scrollbar appearance since r4811, only bar_fill & scroll_fill are shown properly (especially if they contain Alpha). Thanks.

 

scrollbar_r4811.png

Edited by Badruzeus

Share this post


Link to post
Share on other sites
5 hours ago, blackosx said:

After a quick test, setting BootCampStyle to BGM256 seems okay. Buttons and text are vertically placed okay so TileYSpace is being taken in to account with the current setting of 128 works. Have you got TileYSpace set in your theme.plist?

 

I'm outta time for now. Gotta go.

 

Edit. Need more testing with layout settings in theme.plist

Oops, I just realized that you replied twice.
OK, added "TileYSpace=N" under Layout, now Buttons & Text are shown properly for 256px theme with "BootCampStyle=true" (using your r4817 test). Many thanks.

BCS_TileYSpace.png

Edited by Badruzeus

Share this post


Link to post
Share on other sites
1 hour ago, Badruzeus said:

@Slice Sorry for another report.

We have weird scrollbar appearance since r4811, only bar_fill & scroll_fill are shown properly (especially if they contain Alpha). Thanks.

 

Oh, because the scrollbar was reduced to only those two parts instead of the six(?) it was previously.

 

EDIT: From here: 

 

Edited by apianti

Share this post


Link to post
Share on other sites
8 hours ago, blackosx said:

Morning. Just woke up to see your test results. Thanks for testing. :)

 

This is a good start then.

 

Well that test just reverted one change in commit #4785 where rox0PosX was changed to have the value of EntriesGap, instead of 8 (where did this 8 come from?) added to the calculation. In my 256px theme.plist, EntriesGap was 128 as this comes from Theme->Layout->TileXSpace.


-      row0PosX = (UGAWidth + 8 - (EntriesWidth + EntriesGap) *
-                  ((MaxItemOnScreen < row0Count)?MaxItemOnScreen:row0Count)) >> 1;
+      row0PosX = (UGAWidth + EntriesGap - (EntriesWidth + EntriesGap)
+                  * ((MaxItemOnScreen < row0Count)?MaxItemOnScreen:row0Count)) >> 1;

So it's now back to 8 (in my local source) as it used to be and may go on to explain why vector themes are off by 8 as you've discovered.

 

I've not used BootCampStyle but where you say 'only Buttons & Text are off position if using "BootCampStyle=true"' then I would hazard a guess that I will need to look at how Theme->Layout->TileYSpace from the theme.plist is taken in to account.

 

I'm out for most of today so won't be able to spend too much time on in.. but I'll see what I can come up with to help.

 

Keep up your hard work with your excellent themes.

 

Guessing that the line should instead be something like this instead:

      row0PosX = (UGAWidth + (GlobalConfig.TypeSVG ? 8 : EntriesGap) - (EntriesWidth + EntriesGap)
                  * ((MaxItemOnScreen < row0Count)?MaxItemOnScreen:row0Count)) >> 1;

 

Share this post


Link to post
Share on other sites
5 hours ago, Badruzeus said:

Oops, I just realized that you replied twice.
OK, added "TileYSpace=N" under Layout, now Buttons & Text are shown properly for 256px theme with "BootCampStyle=true" (using your r4817 test). Many thanks.

BCS_TileYSpace.png

That's great! Thanks for letting me know.

20 hours ago, Badruzeus said:

Weird is Vector theme, compared to r4713 (with r4785 unCommitted) both have 8px Offset to the left (Orange box). Does this how latest Clovy.svg look like? 

 

I also see clovy's icons offset to the left, but what's strange is BGM_SVG's icons are not.

 

1098292965_Screenshot2018-12-22at19_16_30.thumb.png.4ba36a1d2b35cc361e89f505bc91bff1.png

 

Share this post


Link to post
Share on other sites
3 hours ago, Awesome Donkey said:

Great to see the alignment issue with raster themes being looked into - hopefully the fix works for 128px raster themes too.

AFAICT, 128px raster themes look fine.

 

raster.thumb.jpg.b86eb077c6053045b06c9c8a2e73ed5a.jpg

2 hours ago, apianti said:

 

Guessing that the line should instead be something like this instead:


      row0PosX = (UGAWidth + (GlobalConfig.TypeSVG ? 8 : EntriesGap) - (EntriesWidth + EntriesGap)
                  * ((MaxItemOnScreen < row0Count)?MaxItemOnScreen:row0Count)) >> 1;

 

 

or actually, 

      row0PosX = (UGAWidth + (GlobalConfig.TypeSVG ? EntriesGap : 8) - (EntriesWidth + EntriesGap)
                  * ((MaxItemOnScreen < row0Count)?MaxItemOnScreen:row0Count)) >> 1;

as the 8 would not be used if SVG theme is true.

1 hour ago, Ingwar77 said:

"TileYSpace=N" under Layout

Do you mean "NO" Boolean,
or "N" string neutral,
or what? :huh:

in the above example, N would be an integer value to represent a number of pixels.

Share this post


Link to post
Share on other sites
1 hour ago, blackosx said:

I also see clovy's icons offset to the left, but what's strange is BGM_SVG's icons are not.

 

1098292965_Screenshot2018-12-22at19_16_30.thumb.png.4ba36a1d2b35cc361e89f505bc91bff1.png

 

This is down to the following section in VectorGraphics.c 

        if ((strstr(IconName, "selection_big") != NULL) && (!GlobalConfig.SelectionOnTop)) {
          GlobalConfig.MainEntriesSize = (int)(IconImage->width * Scale); //xxx
          row0TileSize = GlobalConfig.MainEntriesSize; // + (int)(16.f * Scale);
          DBG("main entry size = %d\n", GlobalConfig.MainEntriesSize);
        }

So the GlobalConfig.MainEntriesSize is only scaled if GlobalConfig.SelectionOnTop is not true.

 

Clovy has the selection set to be below:

SelectionOnTop="0"

 

Where as BGM_SCV has selection set to be above

SelectionOnTop="1"

 

Clovy:

9:139  0:004  GlobalConfig.MainEntriesSize =144

 

BGM_SVG:

9:898  0:048  GlobalConfig.MainEntriesSize =128

 

Changing Clovy theme to have SelectionOnTop="1" correctly centres the icons.

 

So I would say the above code needs to be changed to remove the condition regarding the state of GlobalConfig.SelectionOnTop ?

EDIT: no..needs more checks..

 

Edited by blackosx

Share this post


Link to post
Share on other sites

Thanks for letting me know. I'll test with the DarkBootX theme and see.

 

Looks OK here on my current build, but then I'm currently working on changes. Did you try with the build I posted yesterday (above)?

 

 

screenshot.thumb.jpg.78fb08cf23b7cdd68a227cdce1690e4b.jpg

Edited by blackosx

Share this post


Link to post
Share on other sites

Err, yeah, I wrote it backwards in haste but you knew what I was getting at. Have you looked at multiple rows to see if they are correct (and a bunch of custom entries)? Because it looks like they might have the same issue...

 

EDIT: Misspelled a word.

Edited by apianti

Share this post


Link to post
Share on other sites
1 hour ago, Awesome Donkey said:

 

Odd, I use the DarkBootX theme (latest version of the theme + latest Clover) and the MainEntries are off center.

Well, MainEntries are using 160px instead of 128px, duno why I got some difficulties when applying graphics fx with smaller layer; they're pixelated on some parts. If you take a look a theme like "Outlines"; I did layer crop to the OS logo.. I could get outline (stroke) no more than 1px if using small layer so.. they'll be pixelated: things that honestly I hate with Raster graphics if not using a proper image resampling method and or good properties when exporting 8-bit png (especially, if they contain transparency). They'll be better if built from vector but FYi, not all my Raster themes came from vector.

 

Anyway, I'm currently filtering my themes collection and see which of them will be converted (or rebuilt) to vector / svg. So, themes with 256px could be merged into one on the future (with 128px as standard for MainEntries) and Theme's repo will be slimmer (I hope, and not confusing ppl why there're more than one theme with a same look but just diff. size LoL).

Share this post


Link to post
Share on other sites
1 hour ago, blackosx said:

Multiple rows? Sorry, not sure I understand. Do you mean multiple entries?

Edit: yeah I’m sure you do as you said add a bunch of custom entries

 

Ugh, I'm out of it. I mean like if there are more entries than appear on the screen, do they work right? And is there a difference between the rows between themes? Because it looks like the second row of icons is lower on raster themes now then vector themes, I think the same issue just vertically.

 

EDIT: I think I mean the reverse but whatever, I have no idea what I'm saying anymore, there just appears to be a difference.

Edited by apianti

Share this post


Link to post
Share on other sites
5 hours ago, Badruzeus said:

Well, MainEntries are using 160px instead of 128px, duno why I got some difficulties when applying graphics fx with smaller layer; they're pixelated on some parts. If you take a look a theme like "Outlines"; I did layer crop to the OS logo.. I could get outline (stroke) no more than 1px if using small layer so.. they'll be pixelated: things that honestly I hate with Raster graphics if not using a proper image resampling method and or good properties when exporting 8-bit png (especially, if they contain transparency). They'll be better if built from vector but FYi, not all my Raster themes came from vector.

 

Anyway, I'm currently filtering my themes collection and see which of them will be converted (or rebuilt) to vector / svg. So, themes with 256px could be merged into one on the future (with 128px as standard for MainEntries) and Theme's repo will be slimmer (I hope, and not confusing ppl why there're more than one theme with a same look but just diff. size LoL).

I assume that your vector themes will be 128px very nice, I can not wait to try it.

Great luck in making vector themes 128 px.
 

Share this post


Link to post
Share on other sites
11 hours ago, blackosx said:
13 hours ago, Ingwar77 said:

"TileYSpace=N" under Layout

Do you mean "NO" Boolean,
or "N" string neutral,
or what? :huh:

in the above example, N would be an integer value to represent a number of pixels.

Now the value is 32, which one do you suggest?

Share this post


Link to post
Share on other sites
35 minutes ago, Ingwar77 said:

Now the value is 32, which one do you suggest?

Are you referring to blackosx's r4817 (test version)..?

It depends on which theme used and MainEntries size.

Example below is using "FlatCamp" theme with "BootCampStyle=true", it has 160px for MainEntries BTW.

 

Spoiler

		<key>Layout</key>
		<dict>
			...
			<key>ButtonOffset</key>
			<integer>32</integer>
			<key>TileXSpace</key>
			<integer>40</integer>
			<key>Vertical</key>
			<false/>
			...
		</dict>

 

"TileYSpace" is not used under Layout; it looks fine. But for theme with 256px MainEntries, it' s needed on this case.

This could be temporary solution anyway.

FlatCamp-Test-BCS-r4817.png

Edited by Badruzeus

Share this post


Link to post
Share on other sites
17 hours ago, blackosx said:

Thanks for letting me know. I'll test with the DarkBootX theme and see.

 

Looks OK here on my current build, but then I'm currently working on changes. Did you try with the build I posted yesterday (above)?

 

Yes I am using the build you posted yesterday (but I did have to rename CLOVER.efi to CLOVERX64.efi if that makes any difference) along with the current DarkBootX theme (v1.7) with a custom icon for macOS Mojave (doesn't make a difference if I use the original one). Random thought; would forcing screen resolution in Clover cause it to happen? If so, I have mine forced to display at 2560x1440. But yeah, MainEntries are still off-center for me. Second random thought; I also use only custom entries too, perhaps that's why it happens?

 

EDIT: I removed the 2560x1440 screen resolution, and it didn't make a difference so it isn't that.

 

EDIT 2: Switched from custom entries to auto and that doesn't make a difference either, MainEntries are still off-center for me. I'm stumped now.

 

screenshot2.thumb.png.9688543b90f755e2cf39970e9d9df94a.png

Edited by Awesome Donkey

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By gengstapo
      @Hervé
       
      Im having similar issue with my HS setup, dell latitute 3480, i5-7200U
      Once the hdmi plugged in, the laptop display went blank, only could see the external tv
      But, when i put my laptop to sleep & wake up again, both screen got display (hdmi still connected)
      Even the hdmi could be plugged off & in (after sleep), the laptop display is fine
       
      What could be the culprit?
      Dell’s MacBook Pro IORegistry.zip
      config.plist.zip
    • By TomZanna
      Hi, I'm trying to install Mac Os Catalina on a HP 550-132NL.
      The system has:
      i7-6700
      RAM 12 GB
      GT 730
      LAN Realtek RTL8161
      ALC3863
       
      It passes the verbose phase but after the Apple logo goes away, it gets stuck on a grey screen and I can only move the pointer.
      Can I try to boot with the iGPU?
       
      origin.zip
      CLOVER_dGPU_USB_3.zip
    • By MaLd0n
      ---TUTORIAL---
      https://www.olarila.com/topic/5794-guide-install-macos-with-olarila-image-step-by-step-install-and-post-install-windows-or-mac/
       
      --Original Post--
      https://www.olarila.com/topic/6531-olarila-hackbeast-z390-designare-thunderbolt-full-dsdt-patches-clover-opencore/
       
      --Bios/UEFI Settings--
       
      *Update bios/uefi to F7+*
      1- Go to M.I.T./Advanced Frequency Settings tab
       
      Extreme Memory Profile (X.M.P.) - Profile 1
       
      2- Go to BIOS tab
       
      CSM Support - Disabled
       
      3- Go to Peripherals/Thunderbolt(TM) Configuration tab
       
      Security Level - No Security
      Thunderbolt USB Support - Enabled
      GPIO3 Force Pwr - Enabled
       
      4- Go to Chipset tab
       
      Internal Graphics - Enable
       
      ---CLOVER FOLDER---
      https://olarila.com/files/Clover.Folder/EFI CLOVER Z390 DESIGNARE.zip
      *Use this folder with FULL DSDT PATCHED
       
      ---OPENCORE FOLDER---
      https://www.olarila.com/topic/6364-mojave-catalina-on-mobos-series-100200300-with-opencore-bootloader/
      *Use this folder with FULL DSDT PATCHED
       
       
      ---Extract one Full dump for DSDT edits, post files---
       
      RunMe.app
       
       
       
      ---HARDWARE---
       
      --MOBO

      GIGABYTE Z390 DESIGNARE
      -Link
      https://www.amazon.com/Z390-DESIGNARE-Gigabyte-Thunderbolt-Motherboard/dp/B07K8RJZRG/ref=sr_1_1?keywords=Z390+DESIGNARE&qid=1565492390&s=electronics&sr=1-1

      --PROCESSOR

      Intel Core i9-9900K
      -Link
      https://www.amazon.com/Intel-i9-9900K-Desktop-Processor-Unlocked/dp/B005404P9I/ref=sr_1_1_sspa?keywords=Intel+Core+i9-9900K&qid=1553358099&s=gateway&sr=8-1-spons&psc=1

      --COOLER

      CORSAIR H100i RGB PLATINUM AIO Liquid CPU Cooler
      -Link
      https://www.amazon.com/CORSAIR-H100i-PLATINUM-Liquid-Cooler/dp/B07JWB5BSN/ref=sr_1_4?keywords=WATER+COOLER+CPU&qid=1565492509&s=gateway&sr=8-4

      --MEMORY

      Corsair CMW32GX4M2C3200C16 Vengeance RGB PRO 32GB (2x16GB) DDR4 3200 (PC4-25600)
      -Link
      https://www.amazon.com/Corsair-CMW32GX4M2C3200C16-Vengeance-PC4-25600-Desktop/dp/B07GTG2T7L/ref=sr_1_15?keywords=memory+ddr4+32&qid=1553358238&s=gateway&sr=8-15

      --GPU

      MSI RX Vega 64 AIR Boost 8G OC
      -Link
      https://www.amazon.com/MSI-RX-64-AIR-8G/dp/B07DH7S1X1/ref=sr_1_2?keywords=vega+64+gigabyte&qid=1565492819&s=electronics&sr=1-2

      --SSD

      Samsung 970 EVO 1TB SSD (MZ-V7E1T0BW) NVMe M.2 V-NAND
      -Link
      https://www.amazon.com/Samsung-970-EVO-1TB-MZ-V7E1T0BW/dp/B07BN217QG/ref=sr_1_1?keywords=s+samsung+970+evo+1tb&qid=1565493002&s=electronics&sr=1-1

      --POWER SUPPLY

      EVGA Supernova 1000 P2 80+ Platinum, 1000W ECO Mode Fully Modular 
      -Link
      https://www.amazon.com/EVGA-Supernova-Platinum-Crossfire-220-P2-1000-XR/dp/B00EKJQM5E/ref=sr_1_3?keywords=power+supply+1000w&qid=1565493196&s=gateway&sr=8-3

      --WIRELESS

      TP-Link Archer T9E
      -Link
      https://www.amazon.com/TP-Link-Archer-T9E-Beamforming-Technology/dp/B00TQEX7AQ/ref=sr_1_1?keywords=TP-Link+Archer+T9E&qid=1553358397&s=gateway&sr=8-1

      --CASE

      Thermaltake Core P5 Tempered Glass Black Edition ATX Open Frame Panoramic Viewing
      -Link
      https://www.amazon.com/Thermaltake-Tempered-Panoramic-Certified-CA-1E7-00M1WN-03/dp/B01N4IGVSC/ref=sr_1_2?keywords=Thermaltake+Core+P5&qid=1565493567&s=gateway&sr=8-2

      --DSDT Patches--
      -FIX ACPI ERRORS -FIX OEM SSDTs to AVOID ERRORS AND WARNINGS -REMOVE UNUSED SCOPES / DEVICES -HIGH PRECISION EVENT TIMER -SATA -DMAC -REMOVE PROBLEMATIC AND UNUSED DEVICES -FIX K.P in REBOOT -SLPB -DARWIN / WINDOWS 2015 -XHCI -PLUGIN TYPE -HDAS to HDEF -HDEF -REAL TIME CLOCK -ARTC -IRQs -SBUS -BUS1 -MCHC -ALS0 -SHUTDOWN -LAN -FWHD -USBX -PMCR -PPMC -XSPI -CNVW -GMM -IMEI -EC -PNLF -ARPT -GFX0 -NVME -DTGP -ACQUIRE MUT0 0XFFFF -MUTEX MUT0 0x00 -EXTERNAL REFERENCES -UNKNOWNOBJ -HDMI / HDAU -FULL RENAMED DEVICES ---SCREENSHOTs---




















      -Credits and thanks to the old and new people in the community who developed patches, kexts and bootloaders!
      Thanks to KGP for SSDT Thunderbolt
      Slice, Kabyl, usr-sse2, jadran, Blackosx, dmazar, STLVNUB, pcj, apianti, JrCs, pene, FrodoKenny, skoczy, ycr.ru, Oscar09, xsmile, SoThOr, RehabMan, Download-Fritz, Zenit432, cecekpawon, Intel, Apple, Oracle, Chameleon Team, crazybirdy, Mieze, Mirone, Oldnapalm, netkas, Elconiglio, artut-pt, ErmaC, Pavo, Toleda, Master Chief and family, bcc9, The King, PMheart, Sherlocks, Micky1979, vit9696, vandroiy2013, Voodoo Team, Pike R. Alpha, lvs1974, Austere.J, CVad, Sampath007, onemanosx, erroruser, Jenny David, Olarila Facebook Community, Hackintosh Facebook Community and many others!
      We're all here to have fun and learn from each other!
    • By dgsga
      Can I propose a new subforum be created for the new OpenCorePkg OpenCore front end being created by vit9696 and others, it is a fantastic piece of work:
      https://github.com/acidanthera/OpenCorePkg
      Even at version 0.1 it runs my Mojave 10.14.4 setup very nearly flawlessly. It consists of a 10KB bootstrap BootX64.efi and a 200KB OpenCore.efi OS loader. All configuration is done using a very well documented config.plist 
       
       
    • By kingoffright
      Dear all,
       
      I have a external harddisk about 500GB, I installed the clover into it and the harddisk is GPT format, below is the 3 partitions details:
      FS01: EFI - disk0s1 - fat32
      FS02: install mac  image - disk0s2 -  hfs+
      FS03: install windows 10 - disk0s3 - fat32
       
      I can use this external harddisk to install Mac without issue, I use below steps to install windows 10
      enter the FS03:
      cd to efi/boot/ and excuete bootx64.efi
      after pop up the windows install screen, i click next and it shows error 'A media driver your computer needs is missing...' and the installation can not go any further.
      Firstly I use ultraiso to write the windows 10 image to a flash disk and no issue to start install window 10 so the image is working fine. Since I dont know how to write
      a wiindow installation image into harddisk partition, I used winrar extra all the files into disk0s3, am I missing some steps or actually clover not support to install windows
      by partitions, apprecating any helps.
       
×