Jump to content
ErmaC

Clover General discussion

19,695 posts in this topic

Recommended Posts

Posted (edited)
10 hours ago, vector sigma said:

Tadan: Clover_v2.4k_r4974.pkg

 

after one year, as soon I understood that you wanted a dark background image and not the logo Lol, here is it:

aqua.png.6b2c36684c89538f56496fc1b1aae65c.pngdark.png.54c0e0c718818dd66b22436f3e0a1dbd.png

 

To all,

before committing changes I want to know if the package can work in old OSes, e.g. 10.10 or maybe 10.7? Please report!

 

Thanks a lot :) I look forward to the new commit. It's possible that Clover Logo keeps Green color (in Dark Mode) instead of Gray. I've a dream...

 

I hope this new background would be compatible with old OSes e.g. 10.10 or 10.10.7

 

Edited by Matgen84

Share this post


Link to post
Share on other sites
Advertisement

Hi,

 

Sorry, I was too hurried yesterday, better to polish logging as follows:

Index: rEFIt_UEFI/Platform/kernel_patcher.c
===================================================================
--- rEFIt_UEFI/Platform/kernel_patcher.c	(revision 4974)
+++ rEFIt_UEFI/Platform/kernel_patcher.c	(working copy)
@@ -1048,7 +1048,7 @@
 
   // check OS version suit for patches
   if (!IsXCPMOSVersionCompat(os_version)) {
-    DBG("Unsupported macOS.\n");
+    DBG("HaswellLowEndXCPM(): Unsupported macOS.\n");
     DBG("HaswellLowEndXCPM() <===FALSE\n");
     return FALSE;
   }
@@ -1121,7 +1121,7 @@
 
   // check whether Ivy Bridge
   if (gCPUStructure.Model != CPU_MODEL_IVY_BRIDGE) {
-    DBG("Unsupported platform.\nRequires Ivy Bridge, aborted\n");
+    DBG("KernelIvyBridgeXCPM(): Unsupported platform.\nRequires Ivy Bridge, aborted\n");
     DBG("KernelIvyBridgeXCPM() <===FALSE\n");
     return FALSE;
   }
@@ -1129,7 +1129,7 @@
   // check OS version suit for patches
   // PMheart: attempt to add 10.14 compatibility
   if (!IsXCPMOSVersionCompat(os_version)) {
-    DBG("Unsupported macOS.\n");
+    DBG("KernelIvyBridgeXCPM(): Unsupported macOS.\n");
     DBG("KernelIvyBridgeXCPM() <===FALSE\n");
     return FALSE;
   } else if (os_version >= AsciiOSVersionToUint64("10.8.5") && os_version < AsciiOSVersionToUint64("10.12")) {
@@ -1205,7 +1205,7 @@
   
   // check whether Ivy Bridge-E5
   if (gCPUStructure.Model != CPU_MODEL_IVY_BRIDGE_E5) {
-    DBG("Unsupported platform.\nRequires Ivy Bridge-E, aborted\n");
+    DBG("KernelIvyE5XCPM(): Unsupported platform.\nRequires Ivy Bridge-E, aborted\n");
     DBG("KernelIvyE5XCPM() <===FALSE\n");
     return FALSE;
   }
@@ -1213,7 +1213,7 @@
   // check OS version suit for patches
   // PMheart: attempt to add 10.15 compatibility
   if (!IsXCPMOSVersionCompat(os_version)) {
-    DBG("Unsupported macOS.\n");
+    DBG("KernelIvyE5XCPM(): Unsupported macOS.\n");
     DBG("KernelIvyE5XCPM() <===FALSE\n");
     return FALSE;
   }

Thanks a lot!

Share this post


Link to post
Share on other sites
3 hours ago, PMheart said:

Hi,

 

Sorry, I was too hurried yesterday, better to polish logging as follows:


Index: rEFIt_UEFI/Platform/kernel_patcher.c
===================================================================
--- rEFIt_UEFI/Platform/kernel_patcher.c	(revision 4974)
+++ rEFIt_UEFI/Platform/kernel_patcher.c	(working copy)
@@ -1048,7 +1048,7 @@
 
   // check OS version suit for patches
   if (!IsXCPMOSVersionCompat(os_version)) {
-    DBG("Unsupported macOS.\n");
+    DBG("HaswellLowEndXCPM(): Unsupported macOS.\n");
     DBG("HaswellLowEndXCPM() <===FALSE\n");
     return FALSE;
   }
@@ -1121,7 +1121,7 @@
 
   // check whether Ivy Bridge
   if (gCPUStructure.Model != CPU_MODEL_IVY_BRIDGE) {
-    DBG("Unsupported platform.\nRequires Ivy Bridge, aborted\n");
+    DBG("KernelIvyBridgeXCPM(): Unsupported platform.\nRequires Ivy Bridge, aborted\n");
     DBG("KernelIvyBridgeXCPM() <===FALSE\n");
     return FALSE;
   }
@@ -1129,7 +1129,7 @@
   // check OS version suit for patches
   // PMheart: attempt to add 10.14 compatibility
   if (!IsXCPMOSVersionCompat(os_version)) {
-    DBG("Unsupported macOS.\n");
+    DBG("KernelIvyBridgeXCPM(): Unsupported macOS.\n");
     DBG("KernelIvyBridgeXCPM() <===FALSE\n");
     return FALSE;
   } else if (os_version >= AsciiOSVersionToUint64("10.8.5") && os_version < AsciiOSVersionToUint64("10.12")) {
@@ -1205,7 +1205,7 @@
   
   // check whether Ivy Bridge-E5
   if (gCPUStructure.Model != CPU_MODEL_IVY_BRIDGE_E5) {
-    DBG("Unsupported platform.\nRequires Ivy Bridge-E, aborted\n");
+    DBG("KernelIvyE5XCPM(): Unsupported platform.\nRequires Ivy Bridge-E, aborted\n");
     DBG("KernelIvyE5XCPM() <===FALSE\n");
     return FALSE;
   }
@@ -1213,7 +1213,7 @@
   // check OS version suit for patches
   // PMheart: attempt to add 10.15 compatibility
   if (!IsXCPMOSVersionCompat(os_version)) {
-    DBG("Unsupported macOS.\n");
+    DBG("KernelIvyE5XCPM(): Unsupported macOS.\n");
     DBG("KernelIvyE5XCPM() <===FALSE\n");
     return FALSE;
   }

Thanks a lot!

Not a big deal! Committed.

Share this post


Link to post
Share on other sites
16 hours ago, vector sigma said:

Tadan: Clover_v2.4k_r4974.pkg

 

after one year, as soon I understood that you wanted a dark background image and not the logo Lol, here is it:

aqua.png.6b2c36684c89538f56496fc1b1aae65c.pngdark.png.54c0e0c718818dd66b22436f3e0a1dbd.png

 

To all,

before committing changes I want to know if the package can work in old OSes, e.g. 10.10 or maybe 10.7? Please report!

 

Install also succeeds in Lion and boots it as well :)...

 

Spoiler

1379580078_VectorSigmar4974inLion.thumb.png.cf1638b805d4bbad16604f0e132dbb52.png

 

Share this post


Link to post
Share on other sites
Posted (edited)
13 hours ago, Matgen84 said:

Thanks a lot :) I look forward to the new commit. It's possible that Clover Logo keeps Green color (in Dark Mode) instead of Gray. I've a dream.

I made it dark with Photoshop Lol, but ok will be green ;)

6 hours ago, fusion71au said:

Install also succeeds in Lion and boots it as well :)...

Thanks you so much! I'll commit this as soon as possible.

Edited by vector sigma
typo

Share this post


Link to post
Share on other sites
16 minutes ago, vector sigma said:

I made it dark with Photoshop Lol, but ok will be green ;)

Thanks you so mutch! I'll commit this as soon as possible.

I think gray is also cool, so Clover logo is also transformed into another color when UI goes Dark lol B)

Share this post


Link to post
Share on other sites
21 minutes ago, vector sigma said:

Why not automatic if "Reboot On Panic" is turned off?

In this case it will be good.

On 6/25/2019 at 5:56 PM, cecekpawon said:

@Slice Please ignore if you already have similar results like imac dump below.

 

https://sourceforge.net/p/cloverefiboot/code/HEAD/tree/rEFIt_UEFI/Platform/smbios.c#l1083

 

rom.thumb.png.61e59cf6d94a28757a415b2a30ccd0a8.png

 

 

My result with Clover

Снимок экрана 2019-06-26 в 20.42.24.png

 

Снимок экрана 2019-06-26 в 20.04.55.png

Share this post


Link to post
Share on other sites
Posted (edited)
2 hours ago, Badruzeus said:

I think gray is also cool, so Clover logo is also transformed into another color when UI goes Dark lol B)

Yes,  I've only followed a popular policy lately in Apple, but green is default for a clover lol, so I think it's ok for most.. 

Anway I need to test it to ensure this method isn't applied in dark mode, that usually require an image to be greyscaled... otherwise the result will be unpleasant.

 

EDIT

committed

Edited by vector sigma

Share this post


Link to post
Share on other sites

Quick question, do you still have to format the EFI partition as FAT32? I am about to update to Mojave and want o be sure I get it right,

 

I apologize if this has been asked before but I can’t find a definitive answer.

Share this post


Link to post
Share on other sites
9 hours ago, Slice said:

In this case it will be good.

My result with Clover

Снимок экрана 2019-06-26 в 20.42.24.png

 

Снимок экрана 2019-06-26 в 20.04.55.png

 

can we turn off cosmetic of apple rom info in system profiler from config.plist?

 

also what is better name for disabled kernel panic logging?

 

can i determine name?

Share this post


Link to post
Share on other sites

Regarding "disabled kernel panic logging", should you mean something like this in OpenCore?

 

12 hours ago, Sherlocks said:

@Slice

the most of people uses disable kernel panic patch to get exact panic kext part.

https://github.com/RehabMan/OS-X-Clover-Laptop-Config/pull/60

 

like this. can we include this patch default like SIP and EXT? if we need, i will consider

By the way, this is not the best approach, a better one can be found at https://github.com/acidanthera/OcSupportPkg/blob/master/Library/OcAppleKernelLib/CommonPatches.c#L948-L958, where the bytes are kind of stabler.

 

As for the name itself, not so bad to copy/paste it from OC I guess. =)

Share this post


Link to post
Share on other sites
1 hour ago, Sherlocks said:

 

can we turn off cosmetic of apple rom info in system profiler from config.plist?

 

also what is better name for disabled kernel panic logging?

 

can i determine name?

Apple ROM Info depends on macModel or FeatureMask. I don't know exactly.

As well we set smbis version as 2.4 while in newest Mac it is 3.0. May be it also should be adustable.

Share this post


Link to post
Share on other sites

Hmmb, I just realized that "Boot ROM Version" and "EFI Version" give a same result. (256.0.0.0.0 on my case)

Can EFI version replaced with Clover revision, or.. BiosReleaseDate? Thanks.

Share this post


Link to post
Share on other sites
17 minutes ago, Badruzeus said:

Hmmb, I just realized that "Boot ROM Version" and "EFI Version" give a same result. (256.0.0.0.0 on my case)

Can EFI version replaced with Clover revision, or.. BiosReleaseDate? Thanks.

We may include different information. Discussable. Do you really want to see BiosReleaseDate? Is it influence on something?

Share this post


Link to post
Share on other sites
Posted (edited)
1 hour ago, Slice said:

Do you really want to see BiosReleaseDate? Is it influence on something

It doesn't, but I usually bdmesg grep it to compare my custom PlatformData on SMBios with Clover provided to see whether BiosReleaseDate is current or not, or you could consider another one like Board-id maybe..

Edited by Badruzeus

Share this post


Link to post
Share on other sites
4 hours ago, Slice said:

We may include different information. Discussable. Do you really want to see BiosReleaseDate? Is it influence on something?

 

i want to keep vanilla system profiler like realmac without cosmetic. so i ask you to turn off cosmetics option

Share this post


Link to post
Share on other sites
Posted (edited)

@Slice Or EFI Version could be unified with BiosReleaseDate in single line like screenshot below, probably..

plus Board-ID as addition.

Windows-OC.png

 

15 minutes ago, Sherlocks said:

i want to keep vanilla system profiler like realmac without cosmetic. so i ask you to turn off cosmetics option

Uhmmb, if there's such option on config.plist I think it'll be better for user to choose.

 

Edited by Badruzeus

Share this post


Link to post
Share on other sites
1 hour ago, Sherlocks said:

 

i want to keep vanilla system profiler like realmac without cosmetic. so i ask you to turn off cosmetics option

I just added SMBIOS table 11. It does present in real Macs.

There is a question why System Profiler not always shows the information. May be because of FeatureMask? Or because of MacModel? Or because of SMBIOS version?

Share this post


Link to post
Share on other sites

Hi Clover Team

 

I don't know if I'm Off-Topic

 

Under catalina Developer Beta 2, Clover stuck at prepare stage so I can't update

 

 

 

Capture d’écran 2019-06-28 à 08.29.09.png

Share this post


Link to post
Share on other sites
Posted (edited)
1 hour ago, Matgen84 said:

Hi Clover Team

 

I don't know if I'm Off-Topic

 

Under catalina Developer Beta 2, Clover stuck at prepare stage so I can't update

 

 

 

Capture d’écran 2019-06-28 à 08.29.09.png

 

Hi Matt,

 

Uhm...no such issues on my side.

1379918933_Screenshot2019-06-28at10_21_56.png.f2d9ad139e8e3d4ae5efbe6fb43dfed8.png

 

However, I'm still getting this weird warning. Maybe because Clover was built on Mojave...? No idea. Clicking Install Anyway does seem to install it properly though.

 

1955136247_Screenshot2019-06-28at10_20_45.png.7e05700f5163c952b76c2a71ea419dc0.png

 

How are you building Clover? Maybe you're selecting something else in Drivers....? I only chose the mandatory (automatically checked) drivers + OSXAptioFix3Drv. That's all.

 

Also, we were previously talking about the post install script, which should prevent user from getting AptioMemoryFix and OSxAptioFix drivers, both at the same time.

There seems to be a case where this does not happen.

 

Because this is what I'm getting after installing Clover, while previously I had AptioMemoryFix in drivers64UEFI.

 

1408977674_Screenshot2019-06-28at10_28_47.png.d24c23f15a8ad8ebc19eb5f04d88c1e5.png

 

My guess is that since the previous Clover installer did have AptioMemoryFix (and it was checked for installation) and this one doesn't (since I've switched to the default OsXAptioFix3Drv instead, and did not include AptioMemoryFix in the build anymore), the installer doesn't know AptioMemoryFix is already present, and it doesn't do anything based on that. Doesn't skip the installation of OsXAptioFix3Drv, and it doesn't remove AptioMemoryFix either to avoid conflicts.

 

I'm looking forward to your opinions though. In my opinion this could be a real life scenario. If one day we ship Clover with AptioMemoryFix, and the other day we don't or we use something else instead, I see this as a potential problem on the long run, if people will end up with two (or more) Aptio fixes. And I've actually seen people with all 3 OsXAptioFixes in their drivers folders. Probably added manually, not through the installer. In which case there's not much we can do. But if that was through the installer...maybe we should think of a better solution to this other than relying on the post-install script to fix everything in the background.

 

I think a bit more transparency wouldn't hurt anyone. Meaning let the user know in the UI that what they're trying to do is not ok. I don't know, it's just my opinion. If we just allow the user to choose whatever he wants and then "fix it" in the background, it will create confusion, they'll think it's a bug the fact that they didn't get their drivers installed as they selected, and they will never learn anything from that. They'll think it's Clover's fault for not installing everything they wanted, not their fault, for selecting (stupid) incompatible things in the installer UI.

Edited by arsradu

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Pentothal.Z
      Hello all,
      I have a working hackintosh....ok.....but it takes a lot to boot and according to the boot.log there are a few problems.
      One of them is a black screen that stays on for a long time.
      I would like to ask anyone in this community some help to fine tune my machine.
      Boot.log and config.plist attached


      Any help would be appreciated.
      bootlog.txt
      config.plist
    • By metaphysician
      hi folks! i'm just checking for opinions here on a Clover based install of High Sierra. currently i can't boot directly from the internal drive on my hackbook, an ASUS ROG GL502-VS laptop (with the replaced WiFi card), though i can boot from the USB bootloader/installer

      i installed 10.13.6 fine using a prepared vanilla installer on HFS+ (not APFS), but my configuration is somewhat unusual. i have two drives. the first SSD has the Windows system, the second has two partitions with the 2nd partition holding the macOS system. when i ran Clover installer i could not use the UEFI option to copy to the EFI partition because it couldn't find one on that drive. so it installed the EFI folder on the root of the macOS partition instead.
       
      however, after a bit of tinkering around, i found out that there is an existing EFI partition on the primary drive called SYSTEM. it has a EFI folder and underneath that is a Windows folder, a Boot folder, and one called APPLE. i can mount this partition with Clover Configurator and copy files to it, but i don't know if this is a good or risky solution. i was thinking i would manually copy the CLOVER folder and the uefi64.boot file to this partition , making sure not to overwrite anything existing. using the UEFI setup, i can create a boot path from the SYSTEM partition to the Clover boot file, but i'm just curious if this is a useful solution or not, and i don't want to ruin the existing Windows 10 installation for sure. any advice appreciated!
    • By Slice
      OK, 4988 released.
      Now, @vector sigma, what have we do to update translations?
×