Jump to content
ErmaC

Clover General discussion

20,705 posts in this topic

Recommended Posts

On 1/18/2019 at 4:00 PM, Dr. Hurt said:

The only annoyance for me is that Clover takes 3 extra seconds to start. Hopefully that will be slightly optimized in the future.

Weird with VM, I don't use AudioDxe* BootChime *.efi related on ..\drivers* ..\tools folder, neither any *.wav file for theme.. but still, it took some secs loading the GUI. What do you think?

Edited by Badruzeus

Share this post


Link to post
Share on other sites
Advertisement

 

32 minutes ago, cecekpawon said:

@arsradu @MakAsus The sound on after selecting boot device must be come from BootChimeDxe. While on before Clover GUI / theme changes / within GUI are from Clover internal player. Agreed, AudioDxe will took sometimes to load, you may check it with BUILD_TARGETS=DEBUG while compiling.

 

You are correct. That's indeed the source of the sound, just like MakAsus mentioned above. Removing that will also remove the sound after selecting the boot drive. :) I'm sure things will improve over time. And whatever is causing it not to work right now, I'm sure will be fixed. 

 

To be honest, I never thought I'd see the day a hackintosh will play that legendary Mac chime. :)) This is amazing, in my opinion. And I'd like to congratulate everyone involved in this little project for their amazing work.

Share this post


Link to post
Share on other sites
3 hours ago, arsradu said:

 

 

You are correct. That's indeed the source of the sound, just like MakAsus mentioned above. Removing that will also remove the sound after selecting the boot drive. :) I'm sure things will improve over time. And whatever is causing it not to work right now, I'm sure will be fixed. 

 

To be honest, I never thought I'd see the day a hackintosh will play that legendary Mac chime. :)) This is amazing, in my opinion. And I'd like to congratulate everyone involved in this little project for their amazing work.

compile ➢  the source your self and its work

Works for EFI and Lagacy

Edited by chris1111

Share this post


Link to post
Share on other sites
14 minutes ago, chris1111 said:

compile ➢  the source your self and its work

Works for EFI and Lagacy

 

Thanks. I already did that. And it does work, indeed. But I was talking about Clover's attempt on this, with the sound included in the theme folder. That one doesn't work yet, at least for me.

Share this post


Link to post
Share on other sites

@Slice when you have a bit of time, here's the updated ro.po file for Romanian translation. I took a look at the current one from SourceForge, and there were some strings that were not translated at all (newer ones, especially driver descriptions, themes descriptions, including the new SVG ones). Now they should be all translated. Also, corrected/updated some of the existing ones, as well. Poedit was also showing some warnings, due to slight differences between the original text and the translated one. So those should be gone now.

 

Let's just say I kept myself busy for the past few hours. And this version should fix a lot of those issue (if not all). :)

 

So, if you want, here's the RO translation for adding/merging into the source.

 

I also built Clover locally using this ro.po file, and I had no issues whatsoever. So I don't think you will encounter any issues either. But if you do, please, let me know.

 

Cheers!

ro.po.zip

Edited by arsradu

Share this post


Link to post
Share on other sites
9 hours ago, arsradu said:

 

Thanks, man. :) Yeah, if you read the update on my previous post, you'll see I did the exact same thing. :)) And it does work. As I said, it works in a different way though. Meaning the sound is played back after selecting the boot drive, not before, as I saw in one of the earlier posts, and as I think Clover is trying to achieve with its AudioDxe driver (when loading the theme). But it does work, if you're using all the files from the same source and you have them correctly placed in their locations.

 

By the way, your English is quite good actually. :)) And I'm pretty sure very few people on this forum are actually native speakers. So don't worry about it. :) 

Thanks! You are right that "Clover tries to do this with the AudioDxe driver (when loading a theme)." This worked in revisions up to 4850 (revision 4850 caused in my case a frequent panic). Edition 4850 caused a frequent panic, and in revision 4851, the sound with the built-in AudioDxe stopped working, even if all the files are from the same source, even if they are located in their places. :( it just hangs if I press the F7 key, or it doesn’t play back anything either before loading the theme or when the progress bar appears. Although the outputs and level are selected correctly.

Share this post


Link to post
Share on other sites
42 minutes ago, MakAsus said:

Thanks! You are right that "Clover tries to do this with the AudioDxe driver (when loading a theme)." This worked in revisions up to 4850 (revision 4850 caused in my case a frequent panic). Edition 4850 caused a frequent panic, and in revision 4851, the sound with the built-in AudioDxe stopped working, even if all the files are from the same source, even if they are located in their places. :( it just hangs if I press the F7 key, or it doesn’t play back anything either before loading the theme or when the progress bar appears. Although the outputs and level are selected correctly.

 

Yep, I think I also mentioned in my previous posts that F7 freezes the UI in 4851. Looks like I'm not the only one. I'll try some of the older builds, before 4851 but after the official 4844. See how they perform...

 

Update: Well, what do you know? Version 4848 works perfectly fine, with the same files in the same places. Well, the AudioDxe driver was actually the one built into version 4848, so most likely different from the one in version 4851. But yeah, it works. :D 

 

The UI in Options -> Startup Sound still needs some tweaking. But I was able to configure everything from Shell.

Edited by arsradu

Share this post


Link to post
Share on other sites
57 minutes ago, arsradu said:

 

Yep, I think I also mentioned in my previous posts that F7 freezes the UI in 4851. Looks like I'm not the only one. I'll try some of the older builds, before 4851 but after the official 4844. See how they perform...

 

Update: Well, what do you know? Version 4848 works perfectly fine, with the same files in the same places. Well, the AudioDxe driver was actually the one built into version 4848, so most likely different from the one in version 4851. But yeah, it works. :D 

 

The UI in Options -> Startup Sound still needs some tweaking. But I was able to configure everything from Shell.

For me, version 4848 works fine with files from version 4851. Most of the changes were in the StartupSound.c file. Unfortunately, I am not a good programmer. I would fix the problem, but I do not know how!

Share this post


Link to post
Share on other sites

odd - i'm on 4852 

i put sound.wav from Clovy in the ThinkPad folder...

but says File not found using embedded sound -  which sounds really lowFI - more like a guitar strum than mac chime?

wonder why it doesn't find the sound.wav file?

 

update: added 2nd sound file and it sounds normal vs embedded 

ah it needed sound_night.wav too. for some reason clover thinks its nighttime ?!

 

5:234  0:001  === [ InitTheme ] =========================================

5:255  0:020  use night theme

5:258  0:002  Using theme 'ThinkPad' (EFI\CLOVER\themes\ThinkPad)

5:258  0:000  OS main and drive as badge

5:259  0:000  Warning! Character width 9 should be even!

5:259  0:000  file sound read: Not Found

5:260  0:000  got embedded sound

5:260  0:000    Channels: 2  Sample rate: 8000 Hz  Bits: 16

5:261  0:000  output to channel 1 with volume 80, len=25600

5:262  0:000   sound channels=2 bits=16 freq=8000

5:262  0:000  sound converted to 48kHz

6:511  1:248  Loading font from ThemeDir: Success

6:512  0:000  theme inited

6:512  0:000  Chosen theme ThinkPad

Edited by tluck

Share this post


Link to post
Share on other sites
29 minutes ago, MakAsus said:
For me, version 4848 works fine with files from version 4851. Most of the changes were in the StartupSound.c file. Unfortunately, I am not a good programmer. I would fix the problem, but I do not know how!

I see...i haven't tried to use 4848 with files from 4851. I assumed the issue was with the AudioDxe driver itself , so I replaced that upon installation of 4848.

Also I'm not a programmer. So can't really help with that either.

 

Edited by arsradu

Share this post


Link to post
Share on other sites
25 minutes ago, tluck said:

odd - i'm on 4852 

i put sound.wav from Clovy in the ThinkPad folder...

but says File not found using embedded sound -  which sounds really lowFI - more like a guitar strum than mac chime?

wonder why it doesn't find the sound.wav file?

 

5:234  0:001  === [ InitTheme ] =========================================

5:255  0:020  use night theme

5:258  0:002  Using theme 'ThinkPad' (EFI\CLOVER\themes\ThinkPad)

5:258  0:000  OS main and drive as badge

5:259  0:000  Warning! Character width 9 should be even!

5:259  0:000  file sound read: Not Found

5:260  0:000  got embedded sound

5:260  0:000    Channels: 2  Sample rate: 8000 Hz  Bits: 16

5:261  0:000  output to channel 1 with volume 80, len=25600

5:262  0:000   sound channels=2 bits=16 freq=8000

5:262  0:000  sound converted to 48kHz

6:511  1:248  Loading font from ThemeDir: Success

6:512  0:000  theme inited

6:512  0:000  Chosen theme ThinkPad

 

Not sure...but sound file should be 44100 Hz (44.1 KHz). At least these are the instructions provided here.

 

You can try the attached one, if you want.

sound.wav

 

EDIT: nevermind. Now I saw the 8 Khz embedded sound from commit 4852. My bad. :) You can still try the attached file, if you want.

Edited by arsradu

Share this post


Link to post
Share on other sites

made me LOL when i heard it work (after adding sound_night.wav) ! now i need to figure out timezone thing.

Edited by tluck

Share this post


Link to post
Share on other sites
1 hour ago, tluck said:

made me LOL when i heard it work (after adding sound_night.wav) ! now i need to figure out timezone thing.

 

I installed 4852 as well, and I've got two issues:

 

1. the sound is really weird. Just like you said.

2. F7 while it doesn't freeze the UI anymore, it also doesn't seem to play back the sound... Not sure what's going on with that.

 

Did you manage to make it play the actual file you set up in the theme folder? Cause I don't think the embedded one has anything to do with that.

Edited by arsradu

Share this post


Link to post
Share on other sites

4852: there is a logic issue in Clover/rEFIt_UEFI/Platform/Settings.c 

 

problems is it wont try to open sound.wav if !Daylight is false (i.e DayLight is true)

(DayLight is true when timezone corrected time is between 8:00 and 20:00)

 

the other logic issue was it would alway play embedded sound instead of sound.wav since it would never come back with failed status.

 

also NowHour needs to adjusted if < 0

i.e if NowHour < 0 ; then NowHour = NowHour +24

 

 

original:

    if (!DayLight) {

      Status = StartupSoundPlay(ThemeDir, L"sound_night.wav", OldChosenAudio);

    }

    if (EFI_ERROR(Status)) {

      Status = StartupSoundPlay(ThemeDir, L"sound.wav", OldChosenAudio);

    }

 

NEW

 

  if (!ThemeDict) {  // No theme could be loaded, use embedded

    DBG (" using embedded theme\n");

...

      Status = StartupSoundPlay(ThemeDir, L"embedded", OldChosenAudio);

  } else { // theme loaded successfully

...

    if (!DayLight) {

      Status = StartupSoundPlay(ThemeDir, L"sound_night.wav", OldChosenAudio);

      if (EFI_ERROR(Status)) { Status = StartupSoundPlay(ThemeDir, L"sound.wav", OldChosenAudio); }

    else {

      Status = StartupSoundPlay(ThemeDir, L"sound.wav", OldChosenAudio);

    }

 

  }

 

fixed using this logic:

if there is a real theme with 1 or 2 sound files (sound.wav and sound_night.wav)

 

check for nightime 

       and try to use sound_night.wav

if no sound_night.wav

    use sound.wav

 

 

i chose to use embedded sound ONLY when using embedded theme rather than fall back. but this is just an opinion.

 

--------------

$ diff /Extra/Clover_Install/CloverGrowerPro/edk2/Clover/rEFIt_UEFI/Platform/Settings.c /Temp/Settings.c 

2719c2719

<           } else if (AsciiStriCmp (Prop->string, "Daytime") == 0) {

---

>           } else if (AsciiStriCmp (Prop->string, "DayTime") == 0) {

4195a4196

>       Status = StartupSoundPlay(ThemeDir, L"embedded", OldChosenAudio);

4211,4212c4212,4213

<     }

<     if (EFI_ERROR(Status)) {

---

>       if (EFI_ERROR(Status)) { Status = StartupSoundPlay(ThemeDir, L"sound.wav", OldChosenAudio); }    

>     } else {

 

$ diff /Extra/Clover_Install/CloverGrowerPro/edk2/Clover/rEFIt_UEFI/Platform/StartupSound.c  /Temp/StartupSound.c 

71c71

<   if (SoundFile) {

---

>   if ( StriCmp(SoundFile, L"embedded") != 0 ) {

74c74,75

<       DBG("file sound read: %r\n", Status);

---

>       DBG("file sound read: %s %r\n", SoundFile, Status);

>       return Status;

76,77c77

<   }

<   if (EFI_ERROR(Status)) {

---

>   } else {

 

 

4852_fixes.zip

Edited by tluck
added sample fixes + update on NowHour bug

Share this post


Link to post
Share on other sites

@arsradu

Accepted

 

@tluck

I accepted your code with some deviations.

1. About letter case Daytime or DayTime. config-sample uses lowcase but it doesn't matter Clover checks case-independent AsciiStriCmp().

2. About name embedded. I uses NULL as many other settings for embedded theme. Why not?

 

@all

There is still an issue with PlayAsync=YES. Clover hangs after play. Use NO until the issue will be resolved.

 

Share this post


Link to post
Share on other sites

In version 4852 when I press F7 to any output, no longer hangs, but there is no sound, and most importantly, the sound does not appear at the start. If you configure the output and volume by BootChimeCfg.efi, then the sound appear at the start fine. :) I using the built-in version 4852 drivers now.

log fragment:

8:426  0:000  Using vector theme 'Clovy' (EFI\CLOVER\themes\Clovy)
8:443  0:016    Channels: 2  Sample rate: 44100 Hz  Bits: 16
8:443  0:000  output to channel 2 with volume 90, len=421120
8:443  0:000   sound channels=2 bits=16 freq=44100
11:239  2:795  theme inited

Here is a complete dump of the case when there is no sound:

nvramdump.txt

Edited by MakAsus

Share this post


Link to post
Share on other sites
2 hours ago, MakAsus said:
In version 4852 when I press F7 to any output, no longer hangs, but there is no sound, and most importantly, the sound does not appear at the start. If you configure the output and volume by BootChimeCfg.efi, then the sound appear at the start fine.  I using the built-in version 4852 drivers now.

log fragment:


8:426  0:000  Using vector theme 'Clovy' (EFI\CLOVER\themes\Clovy)8:443  0:016    Channels: 2  Sample rate: 44100 Hz  Bits: 168:443  0:000  output to channel 2 with volume 90, len=4211208:443  0:000   sound channels=2 bits=16 freq=4410011:239  2:795  theme inited
 

Here is a complete dump of the case when there is no sound:

nvramdump.txt

 

Have you tried 4853?

 

F7 is still a little buggy. But you shouldn't need BootChimeCfg.efi anymore, aaand...as Steve Jobs loved to say: it just works. I mean, the UI might still need some tweaking. But it does pretty much what I wanted it to do by default.

 

Give this one a try (attached). See if it works for you.

Clover_v2.4k_r4853.zip

 

Update: although BootChimeCfg.efi is not necessary with this build in order to get the boot sound, and the bug with the guitar distorted kind of sound was fixed with this build, the configuration UI doesn't seem to work as of right now, so, the only way I could find to configure the volume, for example, is from Shell, using BootChimeCfg.efi.

 

So, you probably shouldn't remove it just yet.

 

In the UI, if you try to change the volume (from already set 60 to 70 for example), it will reset itself to 0000.

Also, not sure if this is intended, but, no matter which output device you select, when you enter this section, it will always default to the first one, although that is not the one used for sound.

And, as I mentioned in my previous messages, F7 doesn't play back the sound for testing.

 

 

Screenshot1.thumb.png.c062bae00bdae9332fba6fe0296f193f.png

Edited by arsradu

Share this post


Link to post
Share on other sites
1 hour ago, arsradu said:

In the UI, if you try to change the volume (from already set 60 to 70 for example), it will reset itself to 0000.

Also, not sure if this is intended, but, no matter which output device you select, when you enter this section, it will always default to the first one, although that is not the one used for sound.

And, as I mentioned in my previous messages, F7 doesn't play back the sound for testing.

 

Same for me on my ASRock Z370 Prof. Gaming i7 running Clover 4853 rev.

Also rev. 4853 seems to hang before it enters CLOVER Menu. I have NO BootChimexxx in my EFI folder (no BootChime.efi, either NO BootChimeCFG). Just AudioDXE.efi in DriversX64 folder.

Share this post


Link to post
Share on other sites
2 minutes ago, Mork vom Ork said:

 

Same for me on my ASRock Z370 Prof. Gaming i7 running Clover 4853 rev.

Also rev. 4853 seems to hang before it enters CLOVER Menu. I have NO BootChimexxx in my EFI folder (no BootChime.efi, either NO BootChimeCFG). Just AudioDXE.efi in DriversX64 folder.

 

Yep, there's also that. Though Clover might reserve some space...to make sure the sound is played? I don't know. I'm probably wrong.

 

Yeah, you don't need BootChimeCfg...technically. But, since the UI doesn't work yet, it might be a good idea to keep it around if you wanna tweak the volume, for example.

Share this post


Link to post
Share on other sites

It seems that in my case, everything remained unchanged. Changed only the display menu. So far - BootChimeCfg still need to restore the settings. :(

Share this post


Link to post
Share on other sites
9 minutes ago, Download-Fritz said:

@Slice The sound files from the cesium theme make me want to put up a donation towards the health of whatever living thing made that noise, can you forward it?

 

I heard it before when he posted the changes for 4833 here. And I was like: wth is that? :)) Is that yawning...or what?

 

I guess they are just test files. :) And probably royalty free.

Share this post


Link to post
Share on other sites

LoL.. You know what, I thought that my audio device was broken when hearing sound.wav from r4833 provided by @Slice till I realized it hah haa..my bad I didn't preview the file b4 placing to theme dir when install clover via ubuntu linux :D

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By ajmcello
      The following files exist on the github:
       
      a) Clover.app-v1.11-5100.zip
      b) Clover_v2.5k_r5100.pkg
      c) CloverISO-5100.tar.lzma
      d) CloverV2-5100.zip
      e) CLOVERX64.efi.zip
       
       
      Is (a) for installing as an app on OSX? What is it for?
       
      What is (b) for, the .pkg? Not exactly familiar with .pkg. I've seen it used in UNIX, but I believe it's also a PKG format for installing packages on OSX. So, what is the difference between this (b), and (a)? (a) is labeled v1.11-5100, while (b) is labeled v2.5k_r5100.
      (c) contains only this file, Clover-v2.5k-5100-X64.iso, which I assume is a pre-bootloader.
      (d) looks like the NON ISO version, to build an ISO?
      (e) Contains CLOVERX64.efi, which is the same CloverX64.efi for Clover.app-v1.11-5100 and CloverV2-5100.zip
       
      Thanks for any explanations. 
       

       
       
       
       
    • By Dolamarv
      Hi all, I have been using an x240 thinkpad for more than 2 months as hackintosh and it is very stable. As of now I am in Catalina 10.15.1 and it’s running great until I updated it to the new clover build r5100. My laptop won’t automatically sleep when I close the lid down now. I reverted back to 5099 and close-lid automatic sleep works. I don’t know what caused the problem but I think 5100 fixed a dsdt patching of some sort that that conflicted with my config plist? Thanks in advance!
    • By Aldaro
      Gigabyte, in their infinite wisdom, decided to remove the option to disable serial ports, and not being able to do so has been causing me some problems. I know that I have to either use a patch in clover, or create a custom SSDT to disable super I/O, but I honestly do not know how to go about doing this. One of the weirder problems I'm experiencing is the inability to connect to Apple Music (error 11556) unless I go into my network settings, and delete my serial connection. If anyone could help me out with this, that'd be greatly appreciated; anyway, thank you for taking the time to read this.
       
      SPECS:
      Mobo GIGABYTE Z390 M GAMING (UEFI F8)
      CPU: i5 9600k
      RAM: 32GB DDR4 @ 2666 Mhz
      GPU: AMD Radeon RX 580 w/ 8GB of VRAM (MSI armor oc edition)
      Storage Samsung 970 evo 500GB
    • By cvad
      View File Bootdisk Utility
      Make bootable USB Flash Disk for MAC OS X with Latest Clover bootloader revision fast and easy by one click! under OS Windows.
      Special utility from cvad & russian MAC community for new hackintosh users.
       
      Enjoy...
       
      For more information and complete instructions please see this topic.
       
       
       
       
      Feel free to "Rate File"
      Submitter cvad Submitted 04/28/2013 Category Bootloaders  
×