Jump to content

shawnanastasio

Members
  • Content Count

    20
  • Joined

  • Last visited


Reputation Activity

  1. Like
    shawnanastasio reacted to jalavoui in [RELEASE] Open-source Clover fork with Ryzen support   
    I've checked current clover sources at
    - https://sourceforge.net/p/cloverefiboot/code/HEAD/tree/rEFIt_UEFI/Platform/cpu.c
     
    and by checking other distros like
     
    - https://github.com/torvalds/linux/blob/master/arch/x86/kernel/cpu/amd.c
    - https://github.com/freebsd/freebsd/blob/master/sys/amd64/amd64/initcpu.c
     
    maybe u guys wanna review / add some updates from above
     
    i do hope not to see this code again in clover
    MACHINE_TYPES GetDefaultModel() { MACHINE_TYPES DefaultType = iMac132; if (gCPUStructure.Vendor != CPU_VENDOR_INTEL) { return MacPro31;
     
    btw Bronya, are u also updating the kernel ?
     
    shawnanastasio its a great idea to keep a github 4 this topic - maybe finally we can have a few developers discussing source code.
     
    once all this changes are tested we can port all this to clover since we have them here to help us.
     
     
    is this the AsmReadMsr64 from http://www.bluestop.org/edk2/docs/trunk/_mde_pkg_2_library_2_base_lib_2_ia32_2_read_msr64_8c_source.html ?
     
     
    found this inside https://github.com/freebsd/freebsd/blob/master/sys/amd64/include/cpufunc.h(code seems very clean - maybe useful if we need to fix any 64 bits function):
    static __inline uint64_t rdmsr(u_int msr) { uint32_t low, high; __asm __volatile("rdmsr" : "=a" (low), "=d" (high) : "c" (msr)); return (low | ((uint64_t)high << 32)); } static __inline uint32_t rdmsr32(u_int msr) { uint32_t low; __asm __volatile("rdmsr" : "=a" (low) : "c" (msr) : "rdx"); return (low); } this code is from init_amd (and fu@#! i wonder if this is why i get random crashes)  - not ryzen but applyes to f16. this is just a piece of code found in https://github.com/freebsd/freebsd/blob/master/sys/amd64/amd64/initcpu.c
    guess its easy to browse those sources and decide if they will help us or not. and ofc we need to post a binary and ask ppl to test it b4 thinking on porting this to clover.
    if ((cpu_feature2 & CPUID2_HV) == 0) is a check for virtualization (off) - guess is safe to implement this code unless using a virtual machine
    /* * Work around Erratum 793: Specific Combination of Writes to Write * Combined Memory Types and Locked Instructions May Cause Core Hang. * See Revision Guide for AMD Family 16h Models 00h-0Fh Processors, * revision 3.04 or later, publication 51810. */ if (CPUID_TO_FAMILY(cpu_id) == 0x16 && CPUID_TO_MODEL(cpu_id) <= 0xf) { if ((cpu_feature2 & CPUID2_HV) == 0) { msr = rdmsr(0xc0011020); msr |= (uint64_t)1 << 15; wrmsr(0xc0011020, msr); } }
  2. Like
    shawnanastasio got a reaction from nms in [RELEASE] Open-source Clover fork with Ryzen support   
    Noted. I wasn't sure if you guys would be okay with accepting a potentially broken/untested patch. If you'd like I can PM you a diff containing all the changes I made for Ryzen support, or explain why the changes needed to be made.
  3. Like
    shawnanastasio got a reaction from nms in [RELEASE] Open-source Clover fork with Ryzen support   
    Noted. I wasn't sure if you guys would be okay with accepting a potentially broken/untested patch. If you'd like I can PM you a diff containing all the changes I made for Ryzen support, or explain why the changes needed to be made.
  4. Like
    shawnanastasio got a reaction from nms in [RELEASE] Open-source Clover fork with Ryzen support   
    Noted. I wasn't sure if you guys would be okay with accepting a potentially broken/untested patch. If you'd like I can PM you a diff containing all the changes I made for Ryzen support, or explain why the changes needed to be made.
  5. Like
    shawnanastasio got a reaction from Gigamaxx in [RELEASE] Open-source Clover fork with Ryzen support   
    All of my changes are completely open source. I was waiting for more testers to confirm that it works fine to submit it upstream to Clover.
  6. Like
    shawnanastasio got a reaction from Gigamaxx in [RELEASE] Open-source Clover fork with Ryzen support   
    All of my changes are completely open source. I was waiting for more testers to confirm that it works fine to submit it upstream to Clover.
  7. Like
    shawnanastasio got a reaction from Gigamaxx in [RELEASE] Open-source Clover fork with Ryzen support   
    All of my changes are completely open source. I was waiting for more testers to confirm that it works fine to submit it upstream to Clover.
  8. Like
    shawnanastasio got a reaction from Gigamaxx in [RELEASE] Open-source Clover fork with Ryzen support   
    All of my changes are completely open source. I was waiting for more testers to confirm that it works fine to submit it upstream to Clover.
  9. Like
    shawnanastasio reacted to Tetonne in [RELEASE] Open-source Clover fork with Ryzen support   
    shawnanastasio it's up to you thanks a lot for this contribution
  10. Like
    shawnanastasio reacted to Shaneee in [RELEASE] Open-source Clover fork with Ryzen support   
    Github link to source is on the first post, https://github.com/shawnanastasio/Clover-Ryzen
  11. Like
    shawnanastasio got a reaction from Rocky12 in [RELEASE] Open-source Clover fork with Ryzen support   
    Hi all,
     
    After realizing that Clover doesn't work on AMD Ryzen systems and the only solution is to use a closed-source fork, I set out to implement Ryzen support in Clover myself and share the results.
    The source can be found at https://github.com/shawnanastasio/Clover-Ryzen and I've attached a build to this post.
     
    I have confirmed that it boots on my Ryzen 7 1800X system, but I have not tried booting macOS yet. If anybody has a Ryzen hackintosh set up, I'd love to hear if it works for you. To try it out, just replace your current BOOT/BOOTX64.efi and CLOVER/CLOVERX64.efi with the attached build.
     
    Feedback is welcome!
     
    ============
    Update 7/1/17: Add support for fractional multipliers (like 39.5). Link to download.
    ============
     
    Old Downloads:
    Update 6/30/17: Fix max/min ratio detection as well as FSB detection. Link to download.
    Update 6/29/17: Add automatic CPU max/min ratio detection. Should resolve clock speed issues. Link to download.
    CLOVERX64.efi
  12. Like
    shawnanastasio got a reaction from Tetonne in Ryzen Clover Installation Guide macOS Sierra   
    Hi all,
     
    I've created an open-source Clover fork with Ryzen support but don't have a hackintosh set up to test booting macOS yet. If someone wants to try it out, feedback would be greatly appreciated!
     
    I've created a thread for it here http://www.insanelymac.com/forum/topic/324831-release-open-source-clover-fork-with-ryzen-support/
  13. Like
  14. Like
  15. Like
    shawnanastasio got a reaction from gills83 in [RELEASE] Open-source Clover fork with Ryzen support   
    Update:
     
    I've added support for fractional ratios (like 39.5). Please give it a try and let me know how it works.
     
     
    CLOVERX64.efi
  16. Like
    shawnanastasio reacted to TheRacerMaster in [RELEASE] Open-source Clover fork with Ryzen support   
    Can we stop with this petty beef? This has absolutely nothing to do with Clover development for Ryzen, which is the purpose of this thread.
  17. Like
    shawnanastasio got a reaction from spakk in [RELEASE] Open-source Clover fork with Ryzen support   
    I'm not sure it's at a stage where its ready to be upstreamed but once it is ill definitely contact the clover guys.  
    Sent from my Nexus 5X using Tapatalk
  18. Like
    shawnanastasio got a reaction from Rocky12 in [RELEASE] Open-source Clover fork with Ryzen support   
    Hi all,
     
    After realizing that Clover doesn't work on AMD Ryzen systems and the only solution is to use a closed-source fork, I set out to implement Ryzen support in Clover myself and share the results.
    The source can be found at https://github.com/shawnanastasio/Clover-Ryzen and I've attached a build to this post.
     
    I have confirmed that it boots on my Ryzen 7 1800X system, but I have not tried booting macOS yet. If anybody has a Ryzen hackintosh set up, I'd love to hear if it works for you. To try it out, just replace your current BOOT/BOOTX64.efi and CLOVER/CLOVERX64.efi with the attached build.
     
    Feedback is welcome!
     
    ============
    Update 7/1/17: Add support for fractional multipliers (like 39.5). Link to download.
    ============
     
    Old Downloads:
    Update 6/30/17: Fix max/min ratio detection as well as FSB detection. Link to download.
    Update 6/29/17: Add automatic CPU max/min ratio detection. Should resolve clock speed issues. Link to download.
    CLOVERX64.efi
  19. Like
    shawnanastasio got a reaction from Bronya in [RELEASE] Open-source Clover fork with Ryzen support   
    Update:
     
    I've fixed FSB calculation as well as Max/Min Ratio calculation (thanks, Bronya!).
    All performance issues with the bootloader should hopefully be resolved now.
     
    Please let me know how it works if you try it.
     
     
    CLOVERX64.efi
  20. Like
    shawnanastasio got a reaction from spakk in [RELEASE] Open-source Clover fork with Ryzen support   
    I do plan on creating an Open Source Ryzen kernel eventually.
     
    As for the second question, feedback from any ryzen hackintosh install would be helpful. Doesn't have necessarily be a fresh install.
     
  21. Like
    shawnanastasio got a reaction from sea_man in [RELEASE] Open-source Clover fork with Ryzen support   
    I have added Min/Max Ratio to my Open Source fork as well. I've uploaded it here as well as the original post. This should resolve all clock speed issues.
    CLOVERX64.efi
  22. Like
    shawnanastasio got a reaction from Bronya in [RELEASE] Open-source Clover fork with Ryzen support   
    Update:
     
    I've fixed FSB calculation as well as Max/Min Ratio calculation (thanks, Bronya!).
    All performance issues with the bootloader should hopefully be resolved now.
     
    Please let me know how it works if you try it.
     
     
    CLOVERX64.efi
  23. Like
    shawnanastasio got a reaction from spakk in [RELEASE] Open-source Clover fork with Ryzen support   
    I do plan on creating an Open Source Ryzen kernel eventually.
     
    As for the second question, feedback from any ryzen hackintosh install would be helpful. Doesn't have necessarily be a fresh install.
     
  24. Like
    shawnanastasio got a reaction from spakk in [RELEASE] Open-source Clover fork with Ryzen support   
    I'm not sure it's at a stage where its ready to be upstreamed but once it is ill definitely contact the clover guys.  
    Sent from my Nexus 5X using Tapatalk
  25. Like
×